238170 2022-03-21 17:03:43 -0700 Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header 2022-03-24 10:21:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble darin eric.carlson jean-yves.avenard pete.jungwirth supersonicandtails webkit-bug-importer oldest_to_newest 1853422 0 jer.noble 2022-03-21 17:03:43 -0700 Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header 1853424 1 455304 jer.noble 2022-03-21 17:15:09 -0700 Created attachment 455304 Patch 1853548 2 455304 jean-yves.avenard 2022-03-21 23:54:21 -0700 Comment on attachment 455304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455304&action=review > Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp:279 > + } seems to be a lot of duplicated code around here. 1853674 3 ews-feeder 2022-03-22 08:47:16 -0700 Committed r291622 (248715@main): <https://commits.webkit.org/248715@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455304. 1853675 4 webkit-bug-importer 2022-03-22 08:48:15 -0700 <rdar://problem/90637966> 1853718 5 455304 darin 2022-03-22 09:42:01 -0700 Comment on attachment 455304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455304&action=review > Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp:276 > + rangeEnd = m_totalSize - 1; Why is -1 correct? 1853974 6 jer.noble 2022-03-22 16:11:30 -0700 (In reply to Darin Adler from comment #5) > Comment on attachment 455304 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=455304&action=review > > > Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp:276 > > + rangeEnd = m_totalSize - 1; > > Why is -1 correct? Because a Content-Range header's "range end" is inclusive. (Which I agree is weird from a C++ POV.) 1854732 7 jer.noble 2022-03-24 10:21:23 -0700 *** Bug 238113 has been marked as a duplicate of this bug. *** 455304 2022-03-21 17:15:09 -0700 2022-03-22 10:39:22 -0700 Patch bug-238170-20220321171508.patch text/plain 7116 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ2OTU4NTc1YjQ5MDk3 ZjFjZTJhZjM3NjMyZDEyNGNmMTU5YjM3OS4uZjlhZjkyYTFlYTM1ZTUyYTg5YzllNmIyYTIwNjZj YWU5YTNlNGI3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTIxICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEZldGNoaW5nIGEgQmxvYiBV Ukwgd2l0aCBhbiB1bmJvdW5kZWQgUmFuZ2UgaGVhZGVyIGRvIG5vdCBnZW5lcmF0ZSBhIENvbnRl bnQtUmFuZ2UgcmVzcG9uc2UgaGVhZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMzgxNzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUZXN0OiBmZXRjaC9mZXRjaC1ibG9iLXVuYm91bmRlZC1yYW5nZS5o dG1sCisKKyAgICAgICAgSGFuZGxlIHRoZSBjYXNlIHdoZXJlIHRoZSByZXF1ZXN0IGNvbnRhaW5z IGFuIHVuYm91bmRlZCByYW5nZSwgYW5kIHByb3BlcnR5IGNhbGN1bGF0ZSB0aGUgcmFuZ2VFbmQK KyAgICAgICAgdG8gcGFzcyBpbnRvIFBhcnNlZENvbnRlbnRSYW5nZS4KKworICAgICAgICAqIHBs YXRmb3JtL25ldHdvcmsvQmxvYlJlc291cmNlSGFuZGxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkJsb2JSZXNvdXJjZUhhbmRsZTo6bm90aWZ5UmVzcG9uc2VPblN1Y2Nlc3MpOgorCiAyMDIyLTAz LTIxICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFlvdVR1YmUu Y29tIC0gQ2xpY2tpbmcgYW55d2hlcmUgb24gdGhlIHByb2dyZXNzIGJhciBwYXVzZXMgdGhlIHZp ZGVvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nCmluZGV4IDEwNTVkOWI1MTc3Yzg2YmZiMTllNDA5NDNjZTJlNjI1NzFhMmQyNzUu LjdmM2Q1ZGIyMGU2Mjg2YzNiNTRlMWVkZWVjNmQ5ZTdmZGY3YzdmOTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMjItMDMtMjEgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgRmV0Y2hpbmcgYSBCbG9iIFVSTCB3aXRoIGFuIHVuYm91bmRlZCBSYW5nZSBo ZWFkZXIgZG8gbm90IGdlbmVyYXRlIGEgQ29udGVudC1SYW5nZSByZXNwb25zZSBoZWFkZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODE3MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhbmRsZSB0aGUg Y2FzZSB3aGVyZSB0aGUgcmVxdWVzdCBjb250YWlucyBhbiB1bmJvdW5kZWQgcmFuZ2UsIGFuZCBw cm9wZXJ0eSBjYWxjdWxhdGUgdGhlIHJhbmdlRW5kCisgICAgICAgIHRvIHBhc3MgaW50byBQYXJz ZWRDb250ZW50UmFuZ2UuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrRGF0YVRh c2tCbG9iLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0RhdGFUYXNrQmxvYjo6ZGlzcGF0 Y2hEaWRSZWNlaXZlUmVzcG9uc2UpOgorCiAyMDIyLTAzLTE5ICBUaW0gSG9ydG9uICA8dGltb3Ro eV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgYnVpbGQgKGhvcGVmdWxseSkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvQmxvYlJlc291cmNl SGFuZGxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvQmxvYlJlc291cmNl SGFuZGxlLmNwcAppbmRleCBmMjNiZWVkNTgyOTQ5ZmMwYWQzMmMzMDkyMzNhM2RjZmMxYWFkMDA3 Li4wOThhNzQyZTc1ZTVlOGUxMDc2MTdlN2Q4MTE0YmRmZWZmN2U5YTE3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Jsb2JSZXNvdXJjZUhhbmRsZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9CbG9iUmVzb3VyY2VIYW5kbGUuY3Bw CkBAIC01NzksOCArNTc5LDEzIEBAIHZvaWQgQmxvYlJlc291cmNlSGFuZGxlOjpub3RpZnlSZXNw b25zZU9uU3VjY2VzcygpCiAgICAgYWRkQ3Jvc3NPcmlnaW5PcGVuZXJQb2xpY3lIZWFkZXJzKHJl c3BvbnNlLCBtX2Jsb2JEYXRhLT5wb2xpY3lDb250YWluZXIoKS5jcm9zc09yaWdpbk9wZW5lclBv bGljeSk7CiAgICAgYWRkQ3Jvc3NPcmlnaW5FbWJlZGRlclBvbGljeUhlYWRlcnMocmVzcG9uc2Us IG1fYmxvYkRhdGEtPnBvbGljeUNvbnRhaW5lcigpLmNyb3NzT3JpZ2luRW1iZWRkZXJQb2xpY3kp OwogCi0gICAgaWYgKGlzUmFuZ2VSZXF1ZXN0KQotICAgICAgICByZXNwb25zZS5zZXRIVFRQSGVh ZGVyRmllbGQoSFRUUEhlYWRlck5hbWU6OkNvbnRlbnRSYW5nZSwgUGFyc2VkQ29udGVudFJhbmdl KG1fcmFuZ2VPZmZzZXQsIG1fcmFuZ2VFbmQsIG1fdG90YWxTaXplKS5oZWFkZXJWYWx1ZSgpKTsK KyAgICBpZiAoaXNSYW5nZVJlcXVlc3QpIHsKKyAgICAgICAgYXV0byByYW5nZUVuZCA9IG1fcmFu Z2VFbmQ7CisgICAgICAgIGlmIChyYW5nZUVuZCA9PSBrUG9zaXRpb25Ob3RTcGVjaWZpZWQpCisg ICAgICAgICAgICByYW5nZUVuZCA9IG1fdG90YWxTaXplIC0gMTsKKworICAgICAgICByZXNwb25z ZS5zZXRIVFRQSGVhZGVyRmllbGQoSFRUUEhlYWRlck5hbWU6OkNvbnRlbnRSYW5nZSwgUGFyc2Vk Q29udGVudFJhbmdlKG1fcmFuZ2VPZmZzZXQsIHJhbmdlRW5kLCBtX3RvdGFsU2l6ZSkuaGVhZGVy VmFsdWUoKSk7CisgICAgfQogICAgIC8vIEZJWE1FOiBJZiBhIHJlc291cmNlIGlkZW50aWZpZWQg d2l0aCBhIGJsb2I6IFVSTCBpcyBhIEZpbGUgb2JqZWN0LCB1c2VyIGFnZW50cyBtdXN0IHVzZSB0 aGF0IGZpbGUncyBuYW1lIGF0dHJpYnV0ZSwKICAgICAvLyBhcyBpZiB0aGUgcmVzcG9uc2UgaGFk IGEgQ29udGVudC1EaXNwb3NpdGlvbiBoZWFkZXIgd2l0aCB0aGUgZmlsZW5hbWUgcGFyYW1ldGVy IHNldCB0byB0aGUgRmlsZSdzIG5hbWUgYXR0cmlidXRlLgogICAgIC8vIE5vdGFibHksIHRoaXMg d2lsbCBhZmZlY3QgYSBuYW1lIHN1Z2dlc3RlZCBpbiAiRmlsZSBTYXZlIEFzIi4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0RhdGFUYXNrQmxvYi5jcHAg Yi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtEYXRhVGFza0Jsb2IuY3BwCmlu ZGV4IDA0MjhiMGU4NDAzMzA3YWViNTdjNTYwZDVkM2EwMmU4MTVjMDQ2NjQuLmE4ZTc0OTk3ZDZj NDA1MGZiMjBlODBiZDRhZGJiNzJkODE4NDZmNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvTmV0d29ya0RhdGFUYXNrQmxvYi5jcHAKKysrIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrRGF0YVRhc2tCbG9iLmNwcApAQCAtMjcwLDggKzI3MCwx MyBAQCB2b2lkIE5ldHdvcmtEYXRhVGFza0Jsb2I6OmRpc3BhdGNoRGlkUmVjZWl2ZVJlc3BvbnNl KEVycm9yIGVycm9yQ29kZSkKICAgICAgICAgYWRkQ3Jvc3NPcmlnaW5PcGVuZXJQb2xpY3lIZWFk ZXJzKHJlc3BvbnNlLCBtX2Jsb2JEYXRhLT5wb2xpY3lDb250YWluZXIoKS5jcm9zc09yaWdpbk9w ZW5lclBvbGljeSk7CiAgICAgICAgIGFkZENyb3NzT3JpZ2luRW1iZWRkZXJQb2xpY3lIZWFkZXJz KHJlc3BvbnNlLCBtX2Jsb2JEYXRhLT5wb2xpY3lDb250YWluZXIoKS5jcm9zc09yaWdpbkVtYmVk ZGVyUG9saWN5KTsKIAotICAgICAgICBpZiAoaXNSYW5nZVJlcXVlc3QpCi0gICAgICAgICAgICBy ZXNwb25zZS5zZXRIVFRQSGVhZGVyRmllbGQoSFRUUEhlYWRlck5hbWU6OkNvbnRlbnRSYW5nZSwg UGFyc2VkQ29udGVudFJhbmdlKG1fcmFuZ2VPZmZzZXQsIG1fcmFuZ2VFbmQsIG1fdG90YWxTaXpl KS5oZWFkZXJWYWx1ZSgpKTsKKyAgICAgICAgaWYgKGlzUmFuZ2VSZXF1ZXN0KSB7CisgICAgICAg ICAgICBhdXRvIHJhbmdlRW5kID0gbV9yYW5nZUVuZDsKKyAgICAgICAgICAgIGlmIChyYW5nZUVu ZCA9PSBrUG9zaXRpb25Ob3RTcGVjaWZpZWQpCisgICAgICAgICAgICAgICAgcmFuZ2VFbmQgPSBt X3RvdGFsU2l6ZSAtIDE7CisKKyAgICAgICAgICAgIHJlc3BvbnNlLnNldEhUVFBIZWFkZXJGaWVs ZChIVFRQSGVhZGVyTmFtZTo6Q29udGVudFJhbmdlLCBQYXJzZWRDb250ZW50UmFuZ2UobV9yYW5n ZU9mZnNldCwgcmFuZ2VFbmQsIG1fdG90YWxTaXplKS5oZWFkZXJWYWx1ZSgpKTsKKyAgICAgICAg fQogICAgICAgICAvLyBGSVhNRTogSWYgYSByZXNvdXJjZSBpZGVudGlmaWVkIHdpdGggYSBibG9i OiBVUkwgaXMgYSBGaWxlIG9iamVjdCwgdXNlciBhZ2VudHMgbXVzdCB1c2UgdGhhdCBmaWxlJ3Mg bmFtZSBhdHRyaWJ1dGUsCiAgICAgICAgIC8vIGFzIGlmIHRoZSByZXNwb25zZSBoYWQgYSBDb250 ZW50LURpc3Bvc2l0aW9uIGhlYWRlciB3aXRoIHRoZSBmaWxlbmFtZSBwYXJhbWV0ZXIgc2V0IHRv IHRoZSBGaWxlJ3MgbmFtZSBhdHRyaWJ1dGUuCiAgICAgICAgIC8vIE5vdGFibHksIHRoaXMgd2ls bCBhZmZlY3QgYSBuYW1lIHN1Z2dlc3RlZCBpbiAiRmlsZSBTYXZlIEFzIi4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlZTQx ZGE5MDQ4YjdiZjg4Njc3YzY0Y2M1MzZjOTY3ZmM2NDdkNTc3Li4zMzA1NTI5YzQyMjEzMTg1YjJl MWUyOWI1MGFiNDljZWU5ZDEyMGZhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjItMDMtMjEg IEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgRmV0Y2hpbmcgYSBC bG9iIFVSTCB3aXRoIGFuIHVuYm91bmRlZCBSYW5nZSBoZWFkZXIgZG8gbm90IGdlbmVyYXRlIGEg Q29udGVudC1SYW5nZSByZXNwb25zZSBoZWFkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODE3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogZmV0Y2gvZmV0Y2gtYmxvYi11bmJvdW5kZWQtcmFuZ2Ut ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmZXRjaC9mZXRjaC1ibG9iLXVuYm91bmRl ZC1yYW5nZS5odG1sOiBBZGRlZC4KKwogMjAyMi0wMy0yMSAgSmVyIE5vYmxlICA8amVyLm5vYmxl QGFwcGxlLmNvbT4KIAogICAgICAgICBZb3VUdWJlLmNvbSAtIENsaWNraW5nIGFueXdoZXJlIG9u IHRoZSBwcm9ncmVzcyBiYXIgcGF1c2VzIHRoZSB2aWRlbwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmV0Y2gvZmV0Y2gtYmxvYi11bmJvdW5kZWQtcmFuZ2UtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvZmV0Y2gvZmV0Y2gtYmxvYi11bmJvdW5kZWQtcmFuZ2UtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLmQ4N2ZiMjJmMmRhMjQ2Yzg3YzdkZmJlNWIwMTJmZmZkMGQxMTI1MjYKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mZXRjaC9mZXRjaC1ibG9iLXVuYm91bmRlZC1yYW5nZS1l eHBlY3RlZC50eHQKQEAgLTAsMCArMSw0IEBACisKK1BBU1MgQm91bmRlZCByYW5nZSByZXF1ZXN0 CitQQVNTIFVuYm91bmRlZCByYW5nZSByZXF1ZXN0CisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2ZldGNoL2ZldGNoLWJsb2ItdW5ib3VuZGVkLXJhbmdlLmh0bWwgYi9MYXlvdXRUZXN0cy9mZXRj aC9mZXRjaC1ibG9iLXVuYm91bmRlZC1yYW5nZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZkYWE1YjA0OGEx Mjg3NWRkNmUyZGEyYzE2YTZhNDI2MTUzNWMxY2IKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mZXRjaC9mZXRjaC1ibG9iLXVuYm91bmRlZC1yYW5nZS5odG1sCkBAIC0wLDAgKzEsMjQg QEAKKzwhRE9DVFlQRSBodG1sPgorPHNjcmlwdCBzcmM9Jy4uL3Jlc291cmNlcy90ZXN0aGFybmVz cy5qcyc+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0nLi4vcmVzb3VyY2VzL3Rlc3RoYXJuZXNzcmVw b3J0LmpzJz48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2xldCBidWZmZXIgPSBVaW50OEFycmF5LmZy b20oWzEsIDIsIDMsIDQsIDUsIDYsIDcsIDgsIDksIDEwXSk7CitsZXQgYmxvYiA9IG5ldyBCbG9i KFtidWZmZXJdKTsKK2xldCBibG9iVVJMID0gVVJMLmNyZWF0ZU9iamVjdFVSTChibG9iKTsKKwor cHJvbWlzZV90ZXN0KGFzeW5jICgpID0+IHsKKyAgICBsZXQgcmVzcG9uc2UgPSBhd2FpdCBmZXRj aChibG9iVVJMLCB7aGVhZGVyczogbmV3IEhlYWRlcnMoeydSYW5nZSc6ICdieXRlcz0wLTEnfSl9 KTsKKyAgICBhc3NlcnRfZXF1YWxzKHJlc3BvbnNlLnN0YXR1cywgMjA2KTsKKyAgICBhc3NlcnRf ZXF1YWxzKHJlc3BvbnNlLmhlYWRlcnMuZ2V0KCdDb250ZW50LUxlbmd0aCcpLCAnMicpOworICAg IGFzc2VydF9lcXVhbHMocmVzcG9uc2UuaGVhZGVycy5nZXQoJ0NvbnRlbnQtUmFuZ2UnKSwgJ2J5 dGVzIDAtMS8xMCcpOworfSwgIkJvdW5kZWQgcmFuZ2UgcmVxdWVzdCIpOworCitwcm9taXNlX3Rl c3QoYXN5bmMgKCkgPT4geworICAgIGxldCByZXNwb25zZSA9IGF3YWl0IGZldGNoKGJsb2JVUkws IHtoZWFkZXJzOiBuZXcgSGVhZGVycyh7J1JhbmdlJzogJ2J5dGVzPTgtJ30pfSk7CisgICAgYXNz ZXJ0X2VxdWFscyhyZXNwb25zZS5zdGF0dXMsIDIwNik7CisgICAgYXNzZXJ0X2VxdWFscyhyZXNw b25zZS5oZWFkZXJzLmdldCgnQ29udGVudC1MZW5ndGgnKSwgJzInKTsKKyAgICBhc3NlcnRfZXF1 YWxzKHJlc3BvbnNlLmhlYWRlcnMuZ2V0KCdDb250ZW50LVJhbmdlJyksICdieXRlcyA4LTkvMTAn KTsKK30sICJVbmJvdW5kZWQgcmFuZ2UgcmVxdWVzdCIpOworCis8L3NjcmlwdD4K