238004 2022-03-16 23:54:44 -0700 Adjust anchor/focus nodes after removal when LiveRangeSelection is enabled 2022-03-22 00:23:15 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 220514 1 fred.wang fred.wang darin ews-watchlist mifenton rniwa webkit-bug-importer oldest_to_newest 1852145 0 fred.wang 2022-03-16 23:54:44 -0700 . 1852149 1 454936 fred.wang 2022-03-17 00:04:41 -0700 Created attachment 454936 Patch 1853547 2 454936 fred.wang 2022-03-21 23:48:05 -0700 Comment on attachment 454936 Patch Regarding the mac-AS-debug-wk2 failure: I cannot reproduce the crashes locally + the tests don't seem to enable LiveRangeSelection or use selection API + I see that other builds had similar issues e.g. https://ews-build.webkit.org/#/builders/60/builds/26993 https://ews-build.webkit.org/#/builders/60/builds/26814 https://ews-build.webkit.org/#/builders/60/builds/26792 https://ews-build.webkit.org/#/builders/60/builds/26789 So I'll just land it. 1853553 3 ews-feeder 2022-03-22 00:22:18 -0700 Committed r291605 (248698@main): <https://commits.webkit.org/248698@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454936. 1853554 4 webkit-bug-importer 2022-03-22 00:23:15 -0700 <rdar://problem/90618375> 454936 2022-03-17 00:04:41 -0700 2022-03-22 00:22:20 -0700 Patch 0001-Bug-238004-Adjust-anchor-focus-nodes-when-LiveRangeS.patch text/plain 4953 fred.wang RnJvbSAyYjA4MjRkODljYWU4MzVhMmQwOTYzNmI3ZjE5ODRmZWEyOTg2MTUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RnI9QzM9QTlkPUMzPUE5cmljPTIwV2FuZz89 IDxmd2FuZ0BpZ2FsaWEuY29tPgpEYXRlOiBUaHUsIDE3IE1hciAyMDIyIDA3OjU3OjQyICswMTAw ClN1YmplY3Q6IFtQQVRDSCAxLzJdIEJ1ZyAyMzgwMDQgLSBBZGp1c3QgYW5jaG9yL2ZvY3VzIG5v ZGVzIHdoZW4KIExpdmVSYW5nZVNlbGVjdGlvbiBpcyBlbmFibGVkCgotLS0KIFNvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgIHwgMTkgKysrKysrKysrKysrKysrKysrKwog U291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAgfCAyMyArKysrKysrKysr KysrKysrKysrLS0tLQogU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5oICAg fCAgMiArLQogMyBmaWxlcyBjaGFuZ2VkLCAzOSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCAzY2Y2MTJlMTBiLi5mMWVkNWUyMjIyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjIgQEAKKzIwMjItMDMtMTcgIEZyw6lkw6lyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5j b20+CisKKyAgICAgICAgQWRqdXN0IGFuY2hvci9mb2N1cyBub2RlcyBhZnRlciByZW1vdmFsIHdo ZW4gTGl2ZVJhbmdlU2VsZWN0aW9uIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODAwNAorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5 b3N1a2UgTml3YS4KKworICAgICAgICBUaGlzIHBhdGNoIGVuc3VyZXMgdGhhdCBGcmFtZVNlbGVj dGlvbjo6bm9kZVdpbGxCZVJlbW92ZWQgYWRqdXN0cyBtX2FuY2hvciBhbmQgbV9mb2N1cworICAg ICAgICB3aGVuIGNvcnJlc3BvbmRpbmcgbm9kZXMgYXJlIHJlbW92ZWQgZnJvbSB0aGUgRE9NIHRy ZWUuIFRoZXJlIGFyZSBubyBiZWhhdmlvciBjaGFuZ2VzCisgICAgICAgIHdoZW4gbGl2ZSByYW5n ZSBpcyBkaXNhYmxlZC4KKworICAgICAgICAqIGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RnJhbWVTZWxlY3Rpb246Om5vZGVXaWxsQmVSZW1vdmVkKTogV2hl biBsaXZlIHJhbmdlIGlzIGVuYWJsZWQsCisgICAgICAgIEVuc3VyZSB0aGF0IGFuY2hvciBub2Rl cyBhcmUgdXBkYXRlZCBldmVuIHdoZW4gdGhlIHNlbGVjdGlvbiBpcyBub25lIGFuZCBwYXNzIGlu Zm9ybWF0aW9uCisgICAgICAgIGFib3V0IHdoZXRoZXIgYW5jaG9yIG9yIGZvY3VzIGFyZSByZW1v dmVkIGJ5IHRoZSBub2RlIHJlbW92YWwuCisgICAgICAgIChXZWJDb3JlOjpGcmFtZVNlbGVjdGlv bjo6cmVzcG9uZFRvTm9kZU1vZGlmaWNhdGlvbik6IEFkanVzdCBhbmNob3IgYW5kIGZvY3VzIGlm IHRoZXkKKyAgICAgICAgYXJlIHJlbW92ZWQsIHdoZW4gbGl2ZSByYW5nZSBpcyBlbmFibGVkLgor ICAgICAgICAqIGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uaDogQWRkIGFyZ3VtZW50cyBmb3IgYW5j aG9yIGFuZCBmb2N1cy4KKwogMjAyMi0wMy0xNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBs ZS5jb20+CiAKICAgICAgICAgW0FwcGxlIFBheV0gdmVyc2lvbiB2YWx1ZXMgYXJlIGluY29ycmVj dCwgY2F1c2luZyBpbmNvcnJlY3QgZmVhdHVyZSBkZXRlY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvZWRp dGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKaW5kZXggYWRhYjlkMWE4Yy4uYmI0ZjYxYjIwZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKQEAgLTU1MywxOSArNTUz LDM0IEBAIHZvaWQgRnJhbWVTZWxlY3Rpb246Om5vZGVXaWxsQmVSZW1vdmVkKE5vZGUmIG5vZGUp CiB7CiAgICAgLy8gVGhlcmUgY2FuJ3QgYmUgYSBzZWxlY3Rpb24gaW5zaWRlIGEgZnJhZ21lbnQs IHNvIGlmIGEgZnJhZ21lbnQncyBub2RlIGlzIGJlaW5nIHJlbW92ZWQsCiAgICAgLy8gdGhlIHNl bGVjdGlvbiBpbiB0aGUgZG9jdW1lbnQgdGhhdCBjcmVhdGVkIHRoZSBmcmFnbWVudCBuZWVkcyBu byBhZGp1c3RtZW50LgotICAgIGlmIChpc05vbmUoKSB8fCAhbm9kZS5pc0Nvbm5lY3RlZCgpKQor ICAgIGlmICgoaXNOb25lKCkgJiYgIW1fZG9jdW1lbnQtPnNldHRpbmdzKCkubGl2ZVJhbmdlU2Vs ZWN0aW9uRW5hYmxlZCgpKSB8fCAhbm9kZS5pc0Nvbm5lY3RlZCgpKQogICAgICAgICByZXR1cm47 CiAKLSAgICByZXNwb25kVG9Ob2RlTW9kaWZpY2F0aW9uKG5vZGUsIHJlbW92aW5nTm9kZVJlbW92 ZXNQb3NpdGlvbihub2RlLCBtX3NlbGVjdGlvbi5iYXNlKCkpLCByZW1vdmluZ05vZGVSZW1vdmVz UG9zaXRpb24obm9kZSwgbV9zZWxlY3Rpb24uZXh0ZW50KCkpLAorICAgIHJlc3BvbmRUb05vZGVN b2RpZmljYXRpb24obm9kZSwgcmVtb3ZpbmdOb2RlUmVtb3Zlc1Bvc2l0aW9uKG5vZGUsIG1fc2Vs ZWN0aW9uLmFuY2hvcigpKSwgcmVtb3ZpbmdOb2RlUmVtb3Zlc1Bvc2l0aW9uKG5vZGUsIG1fc2Vs ZWN0aW9uLmZvY3VzKCkpLAorICAgICAgICByZW1vdmluZ05vZGVSZW1vdmVzUG9zaXRpb24obm9k ZSwgbV9zZWxlY3Rpb24uYmFzZSgpKSwgcmVtb3ZpbmdOb2RlUmVtb3Zlc1Bvc2l0aW9uKG5vZGUs IG1fc2VsZWN0aW9uLmV4dGVudCgpKSwKICAgICAgICAgcmVtb3ZpbmdOb2RlUmVtb3Zlc1Bvc2l0 aW9uKG5vZGUsIG1fc2VsZWN0aW9uLnN0YXJ0KCkpLCByZW1vdmluZ05vZGVSZW1vdmVzUG9zaXRp b24obm9kZSwgbV9zZWxlY3Rpb24uZW5kKCkpKTsKIH0KIAotdm9pZCBGcmFtZVNlbGVjdGlvbjo6 cmVzcG9uZFRvTm9kZU1vZGlmaWNhdGlvbihOb2RlJiBub2RlLCBib29sIGJhc2VSZW1vdmVkLCBi b29sIGV4dGVudFJlbW92ZWQsIGJvb2wgc3RhcnRSZW1vdmVkLCBib29sIGVuZFJlbW92ZWQpCit2 b2lkIEZyYW1lU2VsZWN0aW9uOjpyZXNwb25kVG9Ob2RlTW9kaWZpY2F0aW9uKE5vZGUmIG5vZGUs IGJvb2wgYW5jaG9yUmVtb3ZlZCwgYm9vbCBmb2N1c1JlbW92ZWQsIGJvb2wgYmFzZVJlbW92ZWQs IGJvb2wgZXh0ZW50UmVtb3ZlZCwgYm9vbCBzdGFydFJlbW92ZWQsIGJvb2wgZW5kUmVtb3ZlZCkK IHsKICAgICBib29sIGNsZWFyUmVuZGVyVHJlZVNlbGVjdGlvbiA9IGZhbHNlOwogICAgIGJvb2wg Y2xlYXJET01UcmVlU2VsZWN0aW9uID0gZmFsc2U7CiAKLSAgICBpZiAoc3RhcnRSZW1vdmVkIHx8 IGVuZFJlbW92ZWQpIHsKKyAgICBpZiAobV9kb2N1bWVudC0+c2V0dGluZ3MoKS5saXZlUmFuZ2VT ZWxlY3Rpb25FbmFibGVkKCkgJiYgKGFuY2hvclJlbW92ZWQgfHwgZm9jdXNSZW1vdmVkKSkgewor ICAgICAgICBQb3NpdGlvbiBhbmNob3IgPSBtX3NlbGVjdGlvbi5hbmNob3IoKTsKKyAgICAgICAg UG9zaXRpb24gZm9jdXMgPSBtX3NlbGVjdGlvbi5mb2N1cygpOworICAgICAgICBpZiAoYW5jaG9y UmVtb3ZlZCkKKyAgICAgICAgICAgIHVwZGF0ZVBvc2l0aW9uRm9yTm9kZVJlbW92YWwoYW5jaG9y LCBub2RlKTsKKyAgICAgICAgaWYgKGZvY3VzUmVtb3ZlZCkKKyAgICAgICAgICAgIHVwZGF0ZVBv c2l0aW9uRm9yTm9kZVJlbW92YWwoZm9jdXMsIG5vZGUpOworCisgICAgICAgIGlmIChhbmNob3Iu aXNOb3ROdWxsKCkgJiYgZm9jdXMuaXNOb3ROdWxsKCkpCisgICAgICAgICAgICBtX3NlbGVjdGlv bi5zZXRXaXRob3V0VmFsaWRhdGlvbihhbmNob3IsIGZvY3VzKTsKKyAgICAgICAgZWxzZQorICAg ICAgICAgICAgY2xlYXJET01UcmVlU2VsZWN0aW9uID0gdHJ1ZTsKKworICAgICAgICBjbGVhclJl bmRlclRyZWVTZWxlY3Rpb24gPSB0cnVlOworICAgIH0gaWYgKHN0YXJ0UmVtb3ZlZCB8fCBlbmRS ZW1vdmVkKSB7CiAgICAgICAgIFBvc2l0aW9uIHN0YXJ0ID0gbV9zZWxlY3Rpb24uc3RhcnQoKTsK ICAgICAgICAgUG9zaXRpb24gZW5kID0gbV9zZWxlY3Rpb24uZW5kKCk7CiAgICAgICAgIGlmIChz dGFydFJlbW92ZWQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2Vs ZWN0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmgKaW5kZXgg MGQ2ZjFlZTZmMC4uMTQ3ZWFkMTAzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9GcmFtZVNlbGVjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxl Y3Rpb24uaApAQCAtMjcyLDcgKzI3Miw3IEBAIHByaXZhdGU6CiAKICAgICBib29sIHNldFNlbGVj dGlvbldpdGhvdXRVcGRhdGluZ0FwcGVhcmFuY2UoY29uc3QgVmlzaWJsZVNlbGVjdGlvbiYsIE9w dGlvblNldDxTZXRTZWxlY3Rpb25PcHRpb24+LCBDdXJzb3JBbGlnbk9uU2Nyb2xsLCBUZXh0R3Jh bnVsYXJpdHkpOwogCi0gICAgdm9pZCByZXNwb25kVG9Ob2RlTW9kaWZpY2F0aW9uKE5vZGUmLCBi b29sIGJhc2VSZW1vdmVkLCBib29sIGV4dGVudFJlbW92ZWQsIGJvb2wgc3RhcnRSZW1vdmVkLCBi b29sIGVuZFJlbW92ZWQpOworICAgIHZvaWQgcmVzcG9uZFRvTm9kZU1vZGlmaWNhdGlvbihOb2Rl JiwgYm9vbCBhbmNob3JSZW1vdmVkLCBib29sIGZvY3VzUmVtb3ZlZCwgYm9vbCBiYXNlUmVtb3Zl ZCwgYm9vbCBleHRlbnRSZW1vdmVkLCBib29sIHN0YXJ0UmVtb3ZlZCwgYm9vbCBlbmRSZW1vdmVk KTsKICAgICBUZXh0RGlyZWN0aW9uIGRpcmVjdGlvbk9mRW5jbG9zaW5nQmxvY2soKTsKICAgICBU ZXh0RGlyZWN0aW9uIGRpcmVjdGlvbk9mU2VsZWN0aW9uKCk7CiAKLS0gCjIuMjUuMQoK