23796 2009-02-06 12:43:25 -0800 Accelerated compositing code needs to know if a RenderLayer is the root layer 2009-02-06 14:16:36 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 23359 1 simon.fraser simon.fraser oldest_to_newest 108682 0 simon.fraser 2009-02-06 12:43:25 -0800 We need an 'isRootLayer()' method on RenderLayer that works even when the layer is not rooted. 108683 1 27408 simon.fraser 2009-02-06 12:43:51 -0800 Created attachment 27408 Patch, changelog 108710 2 27408 eric 2009-02-06 13:56:32 -0800 Comment on attachment 27408 Patch, changelog Looks sane. 108716 3 simon.fraser 2009-02-06 14:16:36 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderLayer.h M WebCore/rendering/RenderLayerBacking.cpp M WebCore/rendering/RenderLayerCompositor.cpp Committed r40731 27408 2009-02-06 12:43:51 -0800 2009-02-06 13:56:32 -0800 Patch, changelog 23796_patch.txt text/plain 3718 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTRlMDU1ZC4uN2Q3YWE4NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wMi0wNiAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBFeHBvc2UgYW4gaXNSb290TGF5ZXIoKSBtZXRob2Qgb24gUmVu ZGVyTGF5ZXIgdGhhdCB3b3JrcyB3aGV0aGVyIHRoZQorICAgICAgICBsYXllciBpcyByb290ZWQg b3Igbm90LCBhbmQgdXNlIHRoYXQgaW4gYSBmZXcgcGxhY2VzIGluIHRoZQorICAgICAgICBhY2Nl bGVyYXRlZCBjb21wb3NpdGluZyBjb2RlLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxh eWVyLmg6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6aXNSb290TGF5ZXIpOgorICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjpwYWludGluZ0dvZXNUb1dpbmRvdyk6CisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlYnVpbGRDb21wb3NpdGluZ0xheWVyVHJlZSk6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlcXVpcmVzQ29tcG9zaXRpbmdM YXllcik6CisKIDIwMDktMDItMDYgIEFuYW50YW5hcmF5YW5hbiBJeWVuZ2FyICA8YW5hbnRhQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmggYi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllci5oCmluZGV4IDFkYzhiMjQuLmU5MDhhYjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXIuaApAQCAtMzAxLDYgKzMwMSw5IEBAIHB1YmxpYzoKICAgICBib29sIGluUmVzaXplTW9kZSgp IGNvbnN0IHsgcmV0dXJuIG1faW5SZXNpemVNb2RlOyB9CiAgICAgdm9pZCBzZXRJblJlc2l6ZU1v ZGUoYm9vbCBiKSB7IG1faW5SZXNpemVNb2RlID0gYjsgfQogCisgICAgLy8gQ2FuJ3QganVzdCBj aGVjayAhcGFyZW50KCkgYmVjYXVzZSB3ZSBtaWdodCBiZSB1bnJvb3RlZC4KKyAgICBib29sIGlz Um9vdExheWVyKCkgY29uc3QgeyByZXR1cm4gcmVuZGVyZXIoKS0+bm9kZSgpLT5pc0RvY3VtZW50 Tm9kZSgpOyB9CisgICAgCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIFJl bmRlckxheWVyQ29tcG9zaXRvciogY29tcG9zaXRvcigpIGNvbnN0OwogI2VuZGlmCmRpZmYgLS1n aXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwIGIvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAppbmRleCA5NDE1ZTk4Li4yMDNkYTE1IDEw MDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBi L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKQEAgLTYxNyw3ICs2MTcs NyBAQCBGbG9hdFBvaW50IFJlbmRlckxheWVyQmFja2luZzo6Y29udGVudHNUb0dyYXBoaWNzTGF5 ZXJDb29yZGluYXRlcyhjb25zdCBHcmFwaGljcwogCiBib29sIFJlbmRlckxheWVyQmFja2luZzo6 cGFpbnRpbmdHb2VzVG9XaW5kb3coKSBjb25zdAogewotICAgIHJldHVybiBtX293bmluZ0xheWVy LT5pc0RvY3VtZW50TGF5ZXIoKTsKKyAgICByZXR1cm4gbV9vd25pbmdMYXllci0+aXNSb290TGF5 ZXIoKTsKIH0KIAogdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnNldENvbnRlbnRzTmVlZERpc3Bs YXkoKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y LmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXgg MWQ3OGNkZi4uMzFjZjcxOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBv c2l0b3IuY3BwCkBAIC00NTMsNyArNDUzLDcgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6 OnJlYnVpbGRDb21wb3NpdGluZ0xheWVyVHJlZShSZW5kZXJMYXllciogbGF5ZXIsIHN0cnUKICAg ICB1cGRhdGVMYXllckNvbXBvc2l0aW5nU3RhdGUobGF5ZXIsIFN0eWxlRGlmZmVyZW5jZUVxdWFs KTsKIAogICAgIC8vIGhvc3QgdGhlIGRvY3VtZW50IGxheWVyIGluIHRoZSBSZW5kZXJWaWV3J3Mg cm9vdCBsYXllcgotICAgIGlmIChsYXllci0+aXNEb2N1bWVudExheWVyKCkpCisgICAgaWYgKGxh eWVyLT5pc1Jvb3RMYXllcigpKQogICAgICAgICBwYXJlbnRJblJvb3RMYXllcihsYXllcik7CiAK ICAgICBDb21wb3NpdGluZ1N0YXRlIGNoaWxkU3RhdGUgPSBpb0NvbXBTdGF0ZTsKQEAgLTYzNyw3 ICs2MzcsNyBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6cmVxdWlyZXNDb21wb3NpdGlu Z0xheWVyKGNvbnN0IFJlbmRlckxheWVyKiBsYXllcikgYwogI2lmIFZFUkJPU0VfQ09NUE9TSVRJ TkdMQVlFUgogICAgIGJvb2wgZ290UmVhc29uID0gZmFsc2U7CiAKLSAgICBpZiAoIWdvdFJlYXNv biAmJiBpbkNvbXBvc2l0aW5nTW9kZSgpICYmIGxheWVyLT5pc0RvY3VtZW50TGF5ZXIoKSkgewor ICAgIGlmICghZ290UmVhc29uICYmIGluQ29tcG9zaXRpbmdNb2RlKCkgJiYgbGF5ZXItPmlzUm9v dExheWVyKCkpIHsKICAgICAgICAgZnByaW50ZihzdGRlcnIsICJSZW5kZXJMYXllciAlcCByZXF1 aXJlcyBjb21wb3NpdGluZyBsYXllciBiZWNhdXNlOiBpdCdzIHRoZSBkb2N1bWVudCByb290XG4i LCBsYXllcik7CiAgICAgICAgIGdvdFJlYXNvbiA9IHRydWU7CiAgICAgfQpAQCAtNjYxLDggKzY2 MSw4IEBAIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5nTGF5 ZXIoY29uc3QgUmVuZGVyTGF5ZXIqIGxheWVyKSBjCiAgICAgICAgIGZwcmludGYoc3RkZXJyLCAi UmVuZGVyTGF5ZXIgJXAgZG9lcyBub3QgcmVxdWlyZSBjb21wb3NpdGluZyBsYXllclxuIiwgbGF5 ZXIpOwogI2VuZGlmCiAKLSAgICAvLyB0aGUgcm9vdCBsYXllciBhbHdheXMgaGFzIGEgY29tcG9z aXRpbmcgbGF5ZXIgKGZvciBub3cpLgotICAgIHJldHVybiAoaW5Db21wb3NpdGluZ01vZGUoKSAm JiBsYXllci0+aXNEb2N1bWVudExheWVyKCkpIHx8CisgICAgLy8gVGhlIHJvb3QgbGF5ZXIgYWx3 YXlzIGhhcyBhIGNvbXBvc2l0aW5nIGxheWVyLCBidXQgaXQgbWF5IG5vdCBoYXZlIGJhY2tpbmcu CisgICAgcmV0dXJuIChpbkNvbXBvc2l0aW5nTW9kZSgpICYmIGxheWVyLT5pc1Jvb3RMYXllcigp KSB8fAogICAgICAgICAgICAgIHJlcXVpcmVzQ29tcG9zaXRpbmdMYXllckZvclRyYW5zZm9ybShs YXllci0+cmVuZGVyZXIoKSkgfHwKICAgICAgICAgICAgICBjbGlwc0NvbXBvc2l0aW5nRGVzY2Vu ZGFudHMobGF5ZXIpIHx8CiAgICAgICAgICAgICAgcmVxdWlyZXNDb21wb3NpdGluZ0ZvckFuaW1h dGlvbihsYXllcik7Cg==