237812 2022-03-12 15:29:18 -0800 [iOS] editing/spelling/editing-word-with-marker-1.html causes the subsequent test to time out 2022-07-29 13:50:52 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=236794 InRadar P2 Normal --- 1 wenson_hsieh simon.fraser ap heycam Morningstar webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1850724 0 wenson_hsieh 2022-03-12 15:29:18 -0800 editing/spelling/spellcheck-api-crash.html seems to be intermittently failing in EWS -- e.g. https://ews-build.s3-us-west-2.amazonaws.com/iOS-15-Simulator-WK2-Tests-EWS/454527-10366/results.html This is also easily reproducible just by running editing/spelling/editing-word-with-marker-1.html for multiple iterations. 1850727 1 454543 wenson_hsieh 2022-03-12 15:46:45 -0800 Created attachment 454543 Patch 1850732 2 wenson_hsieh 2022-03-12 19:54:17 -0800 (In reply to Wenson Hsieh from comment #1) > Created attachment 454543 [details] > Patch Waiting for a single runloop after calling `resetText` apparently causes Mac WK1 to fail... 1850747 3 ap 2022-03-12 22:00:07 -0800 This only modified the test, is there any way to fix or detect the issue in the harness? 1850748 4 wenson_hsieh 2022-03-12 22:02:21 -0800 (In reply to Alexey Proskuryakov from comment #3) > This only modified the test, is there any way to fix or detect the issue in > the harness? It's surely detectable with a `UIHelper.isWebKit2()` check, but I was hoping to avoid a workaround of that kind. Though, maybe it's worth going that route if it means we can stabilize EWS in the short term? 1850899 5 ap 2022-03-14 09:20:07 -0700 What I mean is that it's difficult to isolate problems of the kind where a test makes subsequent tests fail, so it's important to prevent such situations. Improving one test that does something wrong does nothing to prevent other tests from having the same problem in the future. Either clearing the state between tests, or detecting the issue and failing eagerly with a RELEASE_ASSERT would be a permanent solution for the problem. I do not have a suggestion on how to fix WK2 without breaking WK1, as I don't understand what causes that. 1850934 6 wenson_hsieh 2022-03-14 10:42:09 -0700 (In reply to Alexey Proskuryakov from comment #5) > What I mean is that it's difficult to isolate problems of the kind where a > test makes subsequent tests fail, so it's important to prevent such > situations. Improving one test that does something wrong does nothing to > prevent other tests from having the same problem in the future. Either > clearing the state between tests, or detecting the issue and failing eagerly > with a RELEASE_ASSERT would be a permanent solution for the problem. > AFAIK, the intent of that release assertion is to catch instances like this where tests end before UI-script callbacks are invoked, so I think we would expect crashes in the case where there are dangling callbacks. It is, however, quite unfortunate that it surfaces as a failure in the _subsequent_ layout test, which makes the true failing test a lot more difficult to pin down. > I do not have a suggestion on how to fix WK2 without breaking WK1, as I > don't understand what causes that. 1850994 7 ap 2022-03-14 13:39:51 -0700 Exactly. I'm not talking about that RELEASE_ASSERT, but about adding a new one that would catch the issue in time. 1851003 8 wenson_hsieh 2022-03-14 14:05:58 -0700 (In reply to Alexey Proskuryakov from comment #7) > Exactly. I'm not talking about that RELEASE_ASSERT, but about adding a new > one that would catch the issue in time. Yeah, this sounds like a good area to explore ("attribute the failure to the correct layout test"). I think that refactoring this code so that we can just log a warning and continue (without impacting the correctness of the subsequent test) would also be viable option. I think that both the above, as well as fixing this particular layout test are items we should investigate at some point; either would be sufficient to deal with the flaky test failure tracked in this Bugzilla bug. 1853013 9 webkit-bug-importer 2022-03-19 16:30:16 -0700 <rdar://problem/90529903> 1853927 10 Morningstar 2022-03-22 15:04:56 -0700 r291709 Marking expectations to help EWS queue. 1858073 11 heycam 2022-04-04 14:23:03 -0700 Skipping editing-word-with-marker-1.html in bug 238767. 1887272 12 simon.fraser 2022-07-27 22:15:11 -0700 Pull request: https://github.com/WebKit/WebKit/pull/2803 1887746 13 ews-feeder 2022-07-29 13:50:50 -0700 Committed 252963@main (e456d22e637f): <https://commits.webkit.org/252963@main> Reviewed commits have been landed. Closing PR #2803 and removing active labels. 454543 2022-03-12 15:46:45 -0800 2022-03-12 19:35:10 -0800 Patch bug-237812-20220312154644.patch text/plain 5931 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMjA3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWMxOWQxMjNmZDJkYjEzYTE5YmI1 YjcwZDg4OTZhODYxMTljZmUwZS4uN2MyMTJlZjgyYWQyNWRmNmU1YjA4NzkyMDcyMzJhZDNlZTgx OGU3YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIyLTAzLTEyICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIGVkaXRpbmcvc3BlbGxpbmcv ZWRpdGluZy13b3JkLXdpdGgtbWFya2VyLTEuaHRtbCBjYXVzZXMgdGhlIHN1YnNlcXVlbnQgdGVz dCB0byB0aW1lIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM3ODEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTWl0aWdhdGUgZmxha2luZXNzIGNhdXNlZCBieSBsaW5nZXJpbmcgVUkgc2NyaXB0IGNh bGxiYWNrcyBpbnN0YWxsZWQgZHVyaW5nIHRoaXMgdGVzdC4gVGhlc2UgY2FsbGJhY2tzIGFyZQor ICAgICAgICBpbnN0YWxsZWQgaW4gdGhlIHByb2Nlc3Mgb2Ygd2FpdGluZyBmb3IgdGhlIGtleWJv YXJkIHRvIHNob3cgdXAgaW4gYHJlc2V0VGV4dCgpYCwgd2hpY2ggKHNpbmNlIHIyNjE3OTYpIGF0 dGVtcHRzCisgICAgICAgIHRvIHJlZm9jdXMgdGhlIGB0ZXh0YXJlYWAgYW5kIHdhaXQgZm9yIHRo ZSBrZXlib2FyZCB0byBmaW5pc2ggYXBwZWFyaW5nIG9uIGlPUy4KKworICAgICAgICBIb3dldmVy LCBzaW5jZSB0aGUgbWFpbiBsb2dpYyBpbiB0aGUgYXN5bmMgbWV0aG9kIGBydW5UZXN0KClgIGRv ZXNuJ3QgYWN0dWFsbHkgYGF3YWl0YCB0aGUgcmVzdWx0IG9mCisgICAgICAgIGByZXNldFRleHRg LCB3ZSBuZXZlciBhY3R1YWxseSB3YWl0IGZvciB0aGUga2V5Ym9hcmQgdG8gYXBwZWFyIGR1cmlu ZyBlYWNoIHJlc2V0IChhbmQgaW5zdGVhZCBlbmQgdXAganVzdAorICAgICAgICBxdWV1ZWluZyB1 cCBhIGJ1bmNoIG9mIHByb21pc2VzIHRoYXQgcmVtYWluIHVucmVzb2x2ZWQgd2hlbiB0aGUgdGVz dCBlbmRzKS4KKworICAgICAgICAqIGVkaXRpbmcvc3BlbGxpbmcvZWRpdGluZy13b3JkLXdpdGgt bWFya2VyLTEuaHRtbDoKKworICAgICAgICBBbHNvIGFkZCBhIGNhbGwgdG8gYGludGVybmFscy51 cGRhdGVFZGl0b3JVSU5vd0lmU2NoZWR1bGVkYCBhZnRlciBwcm9ncmFtbWF0aWNhbGx5IHNldHRp bmcgdGhlIHNlbGVjdGlvbi4KKyAgICAgICAgV2l0aG91dCB0aGlzLCB0aGUgc3BlbGxpbmcgbWFy a2VycyBpbiB0aGlzIHN0ZXAgb2YgdGhlIHRlc3QgYXJlbid0IHJlbW92ZWQgd2hlbiBwZXJmb3Jt aW5nIHRoZSBmb3J3YXJkIGRlbGV0ZS4KKwogMjAyMi0wMy0xMSAgTmlrb2xhb3MgTW91Y2h0YXJp cyAgPG5tb3VjaHRhcmlzQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBGaXggb3ZzZXJzY3Jv bGwtYmVoYXZpb3IgZm9yIG1haW4gZG9jdW1lbnQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Vk aXRpbmcvc3BlbGxpbmcvZWRpdGluZy13b3JkLXdpdGgtbWFya2VyLTEuaHRtbCBiL0xheW91dFRl c3RzL2VkaXRpbmcvc3BlbGxpbmcvZWRpdGluZy13b3JkLXdpdGgtbWFya2VyLTEuaHRtbAppbmRl eCAzNWFhMDNjNjA5M2Q4ODQ1YjNhNDBlZWUwZGVlNjBmODBkZjBiMjI4Li5iNmMwOGU0MGI0NTkw NTdkYTIwZDc0ZTFjZGE3OTU1MjUwM2U5NzBjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9lZGl0 aW5nL3NwZWxsaW5nL2VkaXRpbmctd29yZC13aXRoLW1hcmtlci0xLmh0bWwKKysrIGIvTGF5b3V0 VGVzdHMvZWRpdGluZy9zcGVsbGluZy9lZGl0aW5nLXdvcmQtd2l0aC1tYXJrZXItMS5odG1sCkBA IC0zMSwxMCArMzEsMTEgQEAgbGV0IHRleHRhcmVhID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InRlc3QiKTsKIAogYXN5bmMgZnVuY3Rpb24gcmVzZXRUZXh0KCkKIHsKLSAgICB0ZXh0YXJlYS5i bHVyKCk7Ci0gICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIGlmICh3aW5kb3cudGVzdFJ1 bm5lcikgeworICAgICAgICBpZiAoZG9jdW1lbnQuYWN0aXZlRWxlbWVudCA9PSB0ZXh0YXJlYSkK KyAgICAgICAgICAgIHRleHRhcmVhLmJsdXIoKTsKICAgICAgICAgYXdhaXQgVUlIZWxwZXIuYWN0 aXZhdGVFbGVtZW50QW5kV2FpdEZvcklucHV0U2Vzc2lvbih0ZXh0YXJlYSk7Ci0gICAgZWxzZQor ICAgIH0gZWxzZQogICAgICAgICB0ZXh0YXJlYS5mb2N1cygpOwogICAgIHRleHRhcmVhLnZhbHVl ID0gIiI7CiAgICAgdHlwZUNoYXJhY3RlckNvbW1hbmQoJ2knKTsKQEAgLTU3LDcgKzU4LDcgQEAg YXN5bmMgZnVuY3Rpb24gcmVzZXRUZXh0KCkKIAogYXN5bmMgZnVuY3Rpb24gcnVuVGVzdCgpCiB7 Ci0gICAgcmVzZXRUZXh0KCk7CisgICAgYXdhaXQgcmVzZXRUZXh0KCk7CiAgICAgdGV4dGFyZWEu c2V0U2VsZWN0aW9uUmFuZ2UoMTQsIDE1KTsKICAgICBleGVjRGVsZXRlQ29tbWFuZCgpOwogICAg IGlmICh3aW5kb3cuaW50ZXJuYWxzICYmIHdpbmRvdy5pbnRlcm5hbHMuaGFzU3BlbGxpbmdNYXJr ZXIpIHsKQEAgLTY4LDcgKzY5LDcgQEAgYXN5bmMgZnVuY3Rpb24gcnVuVGVzdCgpCiAgICAgfQog CiAgICAgLy8gVGVzdGluZyBkZWxldGlvbiBhdCB2YXJpb3VzIGxvY2F0aW9uLgotICAgIHJlc2V0 VGV4dCgpOworICAgIGF3YWl0IHJlc2V0VGV4dCgpOwogICAgIHRleHRhcmVhLnNldFNlbGVjdGlv blJhbmdlKDYsIDYpOwogICAgIGV4ZWNGb3J3YXJkRGVsZXRlQ29tbWFuZCgpOwogICAgIGlmICh3 aW5kb3cuaW50ZXJuYWxzICYmIHdpbmRvdy5pbnRlcm5hbHMuaGFzU3BlbGxpbmdNYXJrZXIpIHsK QEAgLTc4LDggKzc5LDEwIEBAIGFzeW5jIGZ1bmN0aW9uIHJ1blRlc3QoKQogICAgICAgICAgICAg ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUnKS5pbm5lckhUTUwgKz0gIkZBSUxVUkUu IFRoZSB3b3JkICdhbWVhZ2VzZ2EnIGhhcyB1bmRlcmxpbmUuPGJyPiI7CiAgICAgfQogCi0gICAg cmVzZXRUZXh0KCk7CisgICAgYXdhaXQgcmVzZXRUZXh0KCk7CiAgICAgdGV4dGFyZWEuc2V0U2Vs ZWN0aW9uUmFuZ2UoNywgNyk7CisgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpCisgICAgICAgIGlu dGVybmFscy51cGRhdGVFZGl0b3JVSU5vd0lmU2NoZWR1bGVkKCk7CiAgICAgZXhlY0ZvcndhcmRE ZWxldGVDb21tYW5kKCk7CiAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMgJiYgd2luZG93LmludGVy bmFscy5oYXNTcGVsbGluZ01hcmtlcikgewogICAgICAgICBpZiAoIXdpbmRvdy5pbnRlcm5hbHMu aGFzU3BlbGxpbmdNYXJrZXIoNywgNykpCkBAIC04OCw3ICs5MSw3IEBAIGFzeW5jIGZ1bmN0aW9u IHJ1blRlc3QoKQogICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUn KS5pbm5lckhUTUwgKz0gIkZBSUxVUkUuIFRoZSB3b3JkICdlYWdlc2dhJyBoYXMgdW5kZXJsaW5l Ljxicj4iOwogICAgIH0KIAotICAgIHJlc2V0VGV4dCgpOworICAgIGF3YWl0IHJlc2V0VGV4dCgp OwogICAgIHRleHRhcmVhLnNldFNlbGVjdGlvblJhbmdlKDEwLCAxMCk7CiAgICAgdHlwZUNoYXJh Y3RlckNvbW1hbmQoJyAnKTsKICAgICBpZiAod2luZG93LmludGVybmFscyAmJiB3aW5kb3cuaW50 ZXJuYWxzLmhhc1NwZWxsaW5nTWFya2VyKSB7CkBAIC05OCw3ICsxMDEsNyBAQCBhc3luYyBmdW5j dGlvbiBydW5UZXN0KCkKICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb25z b2xlJykuaW5uZXJIVE1MICs9ICJGQUlMVVJFLiBUaGUgc2VnbWVudCAnbWVhIGdlc2dhJyBoYXMg dW5kZXJsaW5lLjxicj4iOwogICAgIH0KIAotICAgIHJlc2V0VGV4dCgpOworICAgIGF3YWl0IHJl c2V0VGV4dCgpOwogICAgIHRleHRhcmVhLnNldFNlbGVjdGlvblJhbmdlKDEwLCAxMyk7CiAgICAg ZXhlY0RlbGV0ZUNvbW1hbmQoKTsKICAgICBpZiAod2luZG93LmludGVybmFscyAmJiB3aW5kb3cu aW50ZXJuYWxzLmhhc1NwZWxsaW5nTWFya2VyKSB7CkBAIC0xMDgsNyArMTExLDcgQEAgYXN5bmMg ZnVuY3Rpb24gcnVuVGVzdCgpCiAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgn Y29uc29sZScpLmlubmVySFRNTCArPSAiRkFJTFVSRS4gVGhlIHdvcmQgJ21lYWdhJyBoYXMgdW5k ZXJsaW5lLjxicj4iOwogICAgIH0KIAotICAgIHJlc2V0VGV4dCgpOworICAgIGF3YWl0IHJlc2V0 VGV4dCgpOwogICAgIHRleHRhcmVhLnNldFNlbGVjdGlvblJhbmdlKDEwLCAxMyk7CiAgICAgdHlw ZUNoYXJhY3RlckNvbW1hbmQoJyAnKTsKICAgICBpZiAod2luZG93LmludGVybmFscyAmJiB3aW5k b3cuaW50ZXJuYWxzLmhhc1NwZWxsaW5nTWFya2VyKSB7CkBAIC0xMTksNyArMTIyLDcgQEAgYXN5 bmMgZnVuY3Rpb24gcnVuVGVzdCgpCiAgICAgfQogCiAgICAgLy8gVGVzdGluZyBhcHBlbmRpbmcg bm9uLXdoaXRlc3BhY2UgY2hhcmFjdGVyLgotICAgIHJlc2V0VGV4dCgpOworICAgIGF3YWl0IHJl c2V0VGV4dCgpOwogICAgIHRleHRhcmVhLnNldFNlbGVjdGlvblJhbmdlKDcsIDcpOwogICAgIHR5 cGVDaGFyYWN0ZXJDb21tYW5kKCdhJyk7CiAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMgJiYgd2lu ZG93LmludGVybmFscy5oYXNTcGVsbGluZ01hcmtlcikgewpAQCAtMTI5LDcgKzEzMiw3IEBAIGFz eW5jIGZ1bmN0aW9uIHJ1blRlc3QoKQogICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ2NvbnNvbGUnKS5pbm5lckhUTUwgKz0gIkZBSUxVUkUuIFRoZSB3b3JkICdhbWVhZ2VzZ2En IGhhcyB1bmRlcmxpbmUuPGJyPiI7CiAgICAgfQogCi0gICAgcmVzZXRUZXh0KCk7CisgICAgYXdh aXQgcmVzZXRUZXh0KCk7CiAgICAgdGV4dGFyZWEuc2V0U2VsZWN0aW9uUmFuZ2UoMTUsIDE1KTsK ICAgICB0eXBlQ2hhcmFjdGVyQ29tbWFuZCgnYScpOwogICAgIGlmICh3aW5kb3cuaW50ZXJuYWxz ICYmIHdpbmRvdy5pbnRlcm5hbHMuaGFzU3BlbGxpbmdNYXJrZXIpIHsKQEAgLTE0MCw3ICsxNDMs NyBAQCBhc3luYyBmdW5jdGlvbiBydW5UZXN0KCkKICAgICB9CiAKICAgICAvLyBUZXN0aW5nIHBh c3RpbmcuCi0gICAgcmVzZXRUZXh0KCk7CisgICAgYXdhaXQgcmVzZXRUZXh0KCk7CiAgICAgdGV4 dGFyZWEgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdCcpOwogICAgIHRleHRhcmVhLnNl dFNlbGVjdGlvblJhbmdlKDAsIDQpOwogICAgIGV4ZWNDb3B5Q29tbWFuZCgpOwpAQCAtMTUzLDcg KzE1Niw3IEBAIGFzeW5jIGZ1bmN0aW9uIHJ1blRlc3QoKQogICAgICAgICAgICAgZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUnKS5pbm5lckhUTUwgKz0gIkZBSUxVUkUuIFRoZSB3b3Jk ICdtZWFnZXNnYScgaGFzIHVuZGVybGluZS48YnI+IjsKICAgICB9CiAKLSAgICByZXNldFRleHQo KTsKKyAgICBhd2FpdCByZXNldFRleHQoKTsKICAgICB0ZXh0YXJlYSA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCd0ZXN0Jyk7CiAgICAgdGV4dGFyZWEuc2V0U2VsZWN0aW9uUmFuZ2UoMCwgNCk7 CiAgICAgZXhlY0NvcHlDb21tYW5kKCk7CkBAIC0xNjgsNyArMTcxLDcgQEAgYXN5bmMgZnVuY3Rp b24gcnVuVGVzdCgpCiAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29uc29s ZScpLmlubmVySFRNTCArPSAiRkFJTFVSRS4gVGhlIHdvcmQgJ21lYWdlc2dhJyBoYXMgdW5kZXJs aW5lLjxicj4iOwogICAgIH0KIAotICAgIHJlc2V0VGV4dCgpOworICAgIGF3YWl0IHJlc2V0VGV4 dCgpOwogICAgIHRleHRhcmVhID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3QnKTsKICAg ICB0ZXh0YXJlYS5zZXRTZWxlY3Rpb25SYW5nZSgwLCA0KTsKICAgICBleGVjQ29weUNvbW1hbmQo KTsK