23781 2009-02-05 21:26:26 -0800 Call RenderView::willMoveOffscreen/didMoveOnscreen, and update layers correctly 2009-02-06 09:05:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 23359 1 simon.fraser simon.fraser oldest_to_newest 108581 0 simon.fraser 2009-02-05 21:26:26 -0800 We need to call RenderView::willMoveOffscreen() and didMoveOnscreen() when the document goes in and out of the page cache, so that we hook/unhook layers correctly. We also need to them in attach/detach, again to hook up the layers. Finally, we need to update layers in Document::updateRendering(). 108590 1 27381 simon.fraser 2009-02-05 22:26:14 -0800 Created attachment 27381 Patch, changelog 108591 2 27381 hyatt 2009-02-05 22:59:29 -0800 Comment on attachment 27381 Patch, changelog r=me Just yank the amusing FIXME from Eric rather than adding to it. :) 108640 3 simon.fraser 2009-02-06 09:05:16 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/Document.cpp Committed r40719 27381 2009-02-05 22:26:14 -0800 2009-02-05 22:59:29 -0800 Patch, changelog 23781_patch.txt text/plain 3829 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTE3Yzc5My4uYmY3NzYwMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNyBAQAogMjAwOS0wMi0wNSAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjM3ODEKKyAgICAgICAgCisgICAgICAgIFdoZW4gdGhlIGRvY3VtZW50IGlzIGF0dGFjaGVk IGFuZCBkZXRhY2hlZCwgYW5kIHdoZW4gaXQgYmVjb21lcyBhY3RpdmUvaW5hY3RpdmUKKyAgICAg ICAgKGUuZy4gY29taW5nIG91dCBvciBnb2luZyBpbnRvIHRoZSBwYWdlIGNhY2hlKSB3ZSBuZWVk IHRvIGNhbGwKKyAgICAgICAgUmVuZGVyVmlldzo6ZGlkTW92ZU9uc2NyZWVuKCkvd2lsbE1vdmVP ZmZzY3JlZW4oKSB0byBob29rIGFuZCB1bmhvb2sgdGhlIGNvbXBvc2l0ZWQKKyAgICAgICAgbGF5 ZXJzLgorICAgICAgICAKKyAgICAgICAgQWxzbywgaWYgRG9jdW1lbnQ6OnJlY2FsY1N0eWxlKCkg ZG9lcyBub3QgZG8gYSBsYXlvdXQsIGl0IG5lZWRzIHRvCisgICAgICAgIHVwZGF0ZSB0aGUgY29t cG9zaXRpbmcgbGF5ZXJzLgorICAgICAgICAKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnVwZGF0ZVJlbmRlcmluZyk6CisgICAgICAgIChX ZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlTGF5b3V0KToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3Vt ZW50OjphdHRhY2gpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmRldGFjaCk6CisgICAg ICAgIChXZWJDb3JlOjpEb2N1bWVudDo6ZG9jdW1lbnRXaWxsQmVjb21lSW5hY3RpdmUpOgorICAg ICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmRvY3VtZW50RGlkQmVjb21lQWN0aXZlKToKKworMjAw OS0wMi0wNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAg ICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24KIAogICAgICAgICBnZXRBbmltYXRlZFN0eWxl Rm9yUmVuZGVyZXIoKSBzaG91bGQgbm90IGNyZWF0ZSBhIG5ldwpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9kb20vRG9jdW1lbnQuY3BwIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDQ0ZDgw NTcuLjEyNDM3OTEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTExNTUsOCArMTE1NSwxNiBAQCB2b2lkIERvY3Vt ZW50OjpyZWNhbGNTdHlsZShTdHlsZUNoYW5nZSBjaGFuZ2UpCiAgICAgICAgIGlmIChjaGFuZ2Ug Pj0gSW5oZXJpdCB8fCBuLT5oYXNDaGFuZ2VkQ2hpbGQoKSB8fCBuLT5jaGFuZ2VkKCkpCiAgICAg ICAgICAgICBuLT5yZWNhbGNTdHlsZShjaGFuZ2UpOwogCi0gICAgaWYgKGNoYW5nZWQoKSAmJiB2 aWV3KCkpCi0gICAgICAgIHZpZXcoKS0+bGF5b3V0KCk7CisgICAgaWYgKHZpZXcoKSkgeworICAg ICAgICBpZiAoY2hhbmdlZCgpKQorICAgICAgICAgICAgdmlldygpLT5sYXlvdXQoKTsKKyNpZiBV U0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCisgICAgICAgIGVsc2UgeworICAgICAgICAgICAg Ly8gSWYgd2UgZGlkbid0IHVwZGF0ZSBjb21wb3NpdGluZyBsYXllcnMgYmVjYXVzZSBvZiBsYXlv dXQoKSwgd2UgbmVlZCB0byBkbyBzbyBoZXJlLgorICAgICAgICAgICAgdmlldygpLT51cGRhdGVD b21wb3NpdGluZ0xheWVycygpOworICAgICAgICB9CisjZW5kaWYKKyAgICB9CiAKIGJhaWxfb3V0 OgogICAgIHNldENoYW5nZWQoTm9TdHlsZUNoYW5nZSk7CkBAIC0xMjA5LDYgKzEyMTcsNyBAQCB2 b2lkIERvY3VtZW50Ojp1cGRhdGVMYXlvdXQoKQogICAgICAgICBvZS0+ZG9jdW1lbnQoKS0+dXBk YXRlTGF5b3V0KCk7CiAKICAgICAvLyBGSVhNRTogRGF2ZSBIeWF0dCdzIHByZXR0eSBzdXJlIHdl IGNhbiByZW1vdmUgdGhpcyBiZWNhdXNlIGxheW91dCBjYWxscyByZWNhbGNTdHlsZSBhcyBuZWVk ZWQuCisgICAgLy8gRklYTUU6IE5vIGhlIGlzbid0LiBMYXN0IHRpbWUgSSBhc2tlZCBoZSB0aG91 Z2h0IHdlIHN0aWxsIG5lZWRlZCB0aGlzLgogICAgIHVwZGF0ZVJlbmRlcmluZygpOwogCiAgICAg Ly8gT25seSBkbyBhIGxheW91dCBpZiBjaGFuZ2VzIGhhdmUgb2NjdXJyZWQgdGhhdCBtYWtlIGl0 IG5lY2Vzc2FyeS4gICAgICAKQEAgLTEyNjEsNiArMTI3MCw5IEBAIHZvaWQgRG9jdW1lbnQ6OmF0 dGFjaCgpCiAgICAgCiAgICAgLy8gQ3JlYXRlIHRoZSByZW5kZXJpbmcgdHJlZQogICAgIHNldFJl bmRlcmVyKG5ldyAobV9yZW5kZXJBcmVuYSkgUmVuZGVyVmlldyh0aGlzLCB2aWV3KCkpKTsKKyNp ZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCisgICAgcmVuZGVyVmlldygpLT5kaWRNb3Zl T25zY3JlZW4oKTsKKyNlbmRpZgogCiAgICAgaWYgKCFtX3N0eWxlU2VsZWN0b3IpIHsKICAgICAg ICAgYm9vbCBtYXRjaEF1dGhvckFuZFVzZXJTdHlsZXMgPSB0cnVlOwpAQCAtMTI4OSw2ICsxMzAx LDExIEBAIHZvaWQgRG9jdW1lbnQ6OmRldGFjaCgpCiAgICAgCiAgICAgUmVuZGVyT2JqZWN0KiBy ZW5kZXIgPSByZW5kZXJlcigpOwogCisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQor ICAgIGlmIChyZW5kZXIpCisgICAgICAgIHJlbmRlclZpZXcoKS0+d2lsbE1vdmVPZmZzY3JlZW4o KTsKKyNlbmRpZgorCiAgICAgLy8gaW5kaWNhdGUgZGVzdHJ1Y3Rpb24gbW9kZSwgIGkuZS4gYXR0 YWNoZWQoKSBidXQgcmVuZGVyZXIgPT0gMAogICAgIHNldFJlbmRlcmVyKDApOwogICAgIApAQCAt MzE3OSw2ICszMTk2LDExIEBAIHZvaWQgRG9jdW1lbnQ6OnNldEluUGFnZUNhY2hlKGJvb2wgZmxh ZykKIAogdm9pZCBEb2N1bWVudDo6ZG9jdW1lbnRXaWxsQmVjb21lSW5hY3RpdmUoKSAKIHsKKyNp ZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCisgICAgaWYgKHJlbmRlcmVyKCkpCisgICAg ICAgIHJlbmRlclZpZXcoKS0+d2lsbE1vdmVPZmZzY3JlZW4oKTsKKyNlbmRpZgorCiAgICAgSGFz aFNldDxFbGVtZW50Kj46Oml0ZXJhdG9yIGVuZCA9IG1fZG9jdW1lbnRBY3RpdmF0aW9uQ2FsbGJh Y2tFbGVtZW50cy5lbmQoKTsKICAgICBmb3IgKEhhc2hTZXQ8RWxlbWVudCo+OjppdGVyYXRvciBp ID0gbV9kb2N1bWVudEFjdGl2YXRpb25DYWxsYmFja0VsZW1lbnRzLmJlZ2luKCk7IGkgIT0gZW5k OyArK2kpCiAgICAgICAgICgqaSktPmRvY3VtZW50V2lsbEJlY29tZUluYWN0aXZlKCk7CkBAIC0z MTg5LDYgKzMyMTEsMTEgQEAgdm9pZCBEb2N1bWVudDo6ZG9jdW1lbnREaWRCZWNvbWVBY3RpdmUo KQogICAgIEhhc2hTZXQ8RWxlbWVudCo+OjppdGVyYXRvciBlbmQgPSBtX2RvY3VtZW50QWN0aXZh dGlvbkNhbGxiYWNrRWxlbWVudHMuZW5kKCk7CiAgICAgZm9yIChIYXNoU2V0PEVsZW1lbnQqPjo6 aXRlcmF0b3IgaSA9IG1fZG9jdW1lbnRBY3RpdmF0aW9uQ2FsbGJhY2tFbGVtZW50cy5iZWdpbigp OyBpICE9IGVuZDsgKytpKQogICAgICAgICAoKmkpLT5kb2N1bWVudERpZEJlY29tZUFjdGl2ZSgp OworCisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgIGlmIChyZW5kZXJlcigp KQorICAgICAgICByZW5kZXJWaWV3KCktPmRpZE1vdmVPbnNjcmVlbigpOworI2VuZGlmCiB9CiAK IHZvaWQgRG9jdW1lbnQ6OnJlZ2lzdGVyRm9yRG9jdW1lbnRBY3RpdmF0aW9uQ2FsbGJhY2tzKEVs ZW1lbnQqIGUpCg==