237527 2022-03-07 06:31:43 -0800 [GTK][WPE] Add initial adwaita style for PDF.js 2022-03-10 05:28:52 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 237516 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro oldest_to_newest 1848727 0 cgarcia 2022-03-07 06:31:43 -0800 Initial adwaita style. 1848728 1 453972 cgarcia 2022-03-07 06:33:26 -0800 Created attachment 453972 Patch This won't apply as it's based on bug #237516 1848755 2 453972 mcatanzaro 2022-03-07 07:50:43 -0800 Comment on attachment 453972 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453972&action=review > Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:27 > +#openFile { > + display: none !important; > +} Is the file chooser not working? > Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:31 > +.dropdownToolbarButton > select { > + -webkit-appearance: none; > +} Hm, honestly I don't remember exactly what this hack was used for, other than to hide something that was broken in Epiphany. Jan-Michael might remember for sure. 1849141 3 453972 cgarcia 2022-03-08 00:39:39 -0800 Comment on attachment 453972 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453972&action=review >> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:27 >> +} > > Is the file chooser not working? Yes, opening files results in an error message. I don't know why, but I'm not sure we want to provide that functionality either. >> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:31 >> +} > > Hm, honestly I don't remember exactly what this hack was used for, other than to hide something that was broken in Epiphany. Jan-Michael might remember for sure. This is not hiding anything, this is telling WebKit not to use the native appearance for the zoom combo box in the toolbar, because the adwaita one is bigger and doesn't look right. Hopefully Alexander can add customizations here to make it look great and consistent with adwaita. 1849992 4 cgarcia 2022-03-10 01:30:52 -0800 Committed r291096 (248258@trunk): <https://commits.webkit.org/248258@trunk> 453972 2022-03-07 06:33:26 -0800 2022-03-10 05:28:52 -0800 Patch wcore-pdfjs-adwaita.diff text/plain 4550 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ODlhODYzZTFhMWIuLjBmMGU3NGViOGNjYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDIyLTAzLTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIEFkZCBpbml0aWFsIGFkd2FpdGEgc3R5 bGUgZm9yIFBERi5qcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM3NTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBNb2R1bGVzL3BkZmpzLWV4dHJhcy9hZHdhaXRhL3N0eWxlLmNzczogQWRkZWQuCisg ICAgICAgICgjb3BlbkZpbGUpOgorICAgICAgICAoLmRyb3Bkb3duVG9vbGJhckJ1dHRvbiA+IHNl bGVjdCk6CisgICAgICAgICogaHRtbC9QREZEb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpQREZEb2N1bWVudDo6aW5qZWN0U3R5bGVBbmRDb250ZW50U2NyaXB0KToKKwogMjAyMi0wMy0w NyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAg UERGLmpzIGNvbnRlbnQgc2NyaXB0IGlzIGFkZGluZyBjdXN0b20gY29jb2Egc3R5bGUgdW5jb25k aXRpb25hbGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3BkZmpzLWV4dHJh cy9hZHdhaXRhL3N0eWxlLmNzcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvcGRmanMtZXh0cmFz L2Fkd2FpdGEvc3R5bGUuY3NzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MC4uZmQ1YzhhMDVmOTA3Ci0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9wZGZqcy1leHRyYXMvYWR3YWl0YS9zdHlsZS5jc3MKQEAgLTAsMCArMSwzMSBAQAorLyoKKyAq IENvcHlyaWdodCAoQykgMjAyMiBJZ2FsaWEgUy5MLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFu ZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9k aWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25k aXRpb25zCisgKiBhcmUgbWV0OgorICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2Rl IG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0 IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqIDIuIFJlZGlz dHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJp Z2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93 aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBt YXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09G VFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBgYEFTIElTJycgQU5EIEFOWQorICogRVhQ UkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRP LCBUSEUKKyAqIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5F U1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVW RU5UIFNIQUxMIEFQUExFIElOQy4gT1IKKyAqIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFO WSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLAorICogRVhFTVBMQVJZLCBP UiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAor ICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQg T04gQU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJ Q1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJX SVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdB UkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisg Ki8KKworI29wZW5GaWxlIHsKKyAgICBkaXNwbGF5OiBub25lICFpbXBvcnRhbnQ7Cit9CisKKy5k cm9wZG93blRvb2xiYXJCdXR0b24gPiBzZWxlY3QgeworICAgIC13ZWJraXQtYXBwZWFyYW5jZTog bm9uZTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvUERGRG9jdW1lbnQuY3Bw IGIvU291cmNlL1dlYkNvcmUvaHRtbC9QREZEb2N1bWVudC5jcHAKaW5kZXggNWUyODFlNDc2NDkx Li4xNjc5Y2ZhODVkYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvUERGRG9jdW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvUERGRG9jdW1lbnQuY3BwCkBAIC0yMTQs NiArMjE0LDggQEAgdm9pZCBQREZEb2N1bWVudDo6aW5qZWN0U3R5bGVBbmRDb250ZW50U2NyaXB0 KCkKICAgICBsaW5rLT5zZXRBdHRyaWJ1dGUocmVsQXR0ciwgInN0eWxlc2hlZXQiX3MpOwogI2lm IFBMQVRGT1JNKENPQ09BKQogICAgIGxpbmstPnNldEF0dHJpYnV0ZShocmVmQXR0ciwgIndlYmtp dC1wZGZqcy12aWV3ZXI6Ly9wZGZqcy9leHRyYXMvY29jb2Evc3R5bGUuY3NzIl9zKTsKKyNlbGlm IFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKQorICAgIGxpbmstPnNldEF0dHJpYnV0ZSho cmVmQXR0ciwgIndlYmtpdC1wZGZqcy12aWV3ZXI6Ly9wZGZqcy9leHRyYXMvYWR3YWl0YS9zdHls ZS5jc3MiX3MpOwogI2VuZGlmCiAgICAgY29udGVudERvY3VtZW50LT5oZWFkKCktPmFwcGVuZENo aWxkKGxpbmspOwogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VM b2cKaW5kZXggMmU5NmFiYjU1OGMxLi5mNTg4MDcxNjA1OWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMi0wMy0w NyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAg W0dUS11bV1BFXSBBZGQgaW5pdGlhbCBhZHdhaXRhIHN0eWxlIGZvciBQREYuanMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzUyNworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElnbm9yZSBjb2NvYSBkaXJl Y3RvcnkuCisKKyAgICAgICAgKiBnbGliL2dlbmVyYXRlLXBkZmpzLWdyZXNvdXJjZS1tYW5pZmVz dC5weToKKyAgICAgICAgKGdldF9maWxlbmFtZXMuc2hvdWxkX2lnbm9yZV9yZXNvdXJjZSk6Cisg ICAgICAgIChnZXRfZmlsZW5hbWVzKToKKwogMjAyMi0wMy0wNyAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBEbyBub3QgYWRk IG5ldyBtb2R1bGVzIHVuZGVyIFRoaXJkUGFydHkgdG8gdGhlIHRhcmJhbGwKZGlmZiAtLWdpdCBh L1Rvb2xzL2dsaWIvZ2VuZXJhdGUtcGRmanMtZ3Jlc291cmNlLW1hbmlmZXN0LnB5IGIvVG9vbHMv Z2xpYi9nZW5lcmF0ZS1wZGZqcy1ncmVzb3VyY2UtbWFuaWZlc3QucHkKaW5kZXggZmI0ZDA3NTUz ZmNlLi41ZWVjN2I5YWE1Y2UgMTAwNzU1Ci0tLSBhL1Rvb2xzL2dsaWIvZ2VuZXJhdGUtcGRmanMt Z3Jlc291cmNlLW1hbmlmZXN0LnB5CisrKyBiL1Rvb2xzL2dsaWIvZ2VuZXJhdGUtcGRmanMtZ3Jl c291cmNlLW1hbmlmZXN0LnB5CkBAIC0yOCw5ICsyOCw2IEBAIGRlZiBnZXRfZmlsZW5hbWVzKGRp cmVjdG9yeSk6CiAgICAgZmlsZW5hbWVzID0gW10KIAogICAgIGRlZiBzaG91bGRfaWdub3JlX3Jl c291cmNlKHJlc291cmNlKToKLSAgICAgICAgaWYgcmVzb3VyY2UgPT0gJ3N0eWxlLWNvY29hLmNz cyc6Ci0gICAgICAgICAgICByZXR1cm4gVHJ1ZQotCiAgICAgICAgIGlmIG9zLnBhdGguc3BsaXRl eHQocmVzb3VyY2UpWzFdIG5vdCBpbiBWQUxJRF9FWFRFTlNJT05TOgogICAgICAgICAgICAgcmV0 dXJuIFRydWUKIApAQCAtNDUsNiArNDIsOSBAQCBkZWYgZ2V0X2ZpbGVuYW1lcyhkaXJlY3Rvcnkp OgogICAgICAgICBkaXJzLnNvcnQoKQogICAgICAgICBmaWxlcy5zb3J0KCkKICAgICAgICAgZm9y IGZpbGUgaW4gZmlsZXM6CisgICAgICAgICAgICBpZiBvcy5wYXRoLmJhc2VuYW1lKHJvb3QpID09 ICdjb2NvYSc6CisgICAgICAgICAgICAgICAgY29udGludWUKKwogICAgICAgICAgICAgZmlsZW5h bWUgPSBvcy5wYXRoLmpvaW4ocm9vdCwgZmlsZSkKICAgICAgICAgICAgIG5hbWUgPSByZXNvdXJj ZV9uYW1lKGZpbGVuYW1lKQogICAgICAgICAgICAgaWYgbmFtZSBpcyBOb25lOgo=