237089 2022-02-23 08:52:49 -0800 Bubblewrap launcher doesn't bind font locations from XDG_DATA_DIRS 2022-02-23 15:48:44 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 206533 1 maxim.cournoyer webkit-unassigned aperez bugs-noreply cgarcia mcatanzaro pgriffis oldest_to_newest 1845157 0 maxim.cournoyer 2022-02-23 08:52:49 -0800 The BubbleWrap launcher of WebKitGTK doesn't expose font locations present in XDG_DATA_DIRS. This problem was originally reported by a Guix user at https://issues.guix.gnu.org/41174. 1845284 1 453016 maxim.cournoyer 2022-02-23 13:03:21 -0800 Created attachment 453016 Patch 1845307 2 pgriffis 2022-02-23 14:03:46 -0800 Looks reasonable. 1845309 3 453016 mcatanzaro 2022-02-23 14:10:00 -0800 Comment on attachment 453016 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453016&action=review I agree, except for code style nits: > Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:308 > + for (auto dataDir = dataDirs; dataDir != nullptr && *dataDir != nullptr; dataDir++) { I'm surprised the style bot didn't complain about this. Always write out the * on auto* to make it more clear that it's a pointer, and never explicitly compare against nullptr: for (auto* dataDir = dataDirs; dataDir && *dataDir; dataDir++) { 1845310 4 453016 mcatanzaro 2022-02-23 14:10:34 -0800 Comment on attachment 453016 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453016&action=review > Source/WebKit/ChangeLog:3 > + Expose all fonts locations present in XDG_DATA_DIRS First line should match the title of the bug: Bubblewrap launcher doesn't bind font locations from XDG_DATA_DIRS 1845327 5 453031 maxim.cournoyer 2022-02-23 14:42:00 -0800 Created attachment 453031 Patch 1845329 6 maxim.cournoyer 2022-02-23 14:42:53 -0800 (In reply to Michael Catanzaro from comment #3) > Comment on attachment 453016 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453016&action=review > > I agree, except for code style nits: > > > Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:308 > > + for (auto dataDir = dataDirs; dataDir != nullptr && *dataDir != nullptr; dataDir++) { > > I'm surprised the style bot didn't complain about this. Always write out the > * on auto* to make it more clear that it's a pointer, and never explicitly > compare against nullptr: > > for (auto* dataDir = dataDirs; dataDir && *dataDir; dataDir++) { Adjusted. Thanks for the prompt review! 1845330 7 maxim.cournoyer 2022-02-23 14:43:08 -0800 (In reply to Michael Catanzaro from comment #4) > Comment on attachment 453016 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453016&action=review > > > Source/WebKit/ChangeLog:3 > > + Expose all fonts locations present in XDG_DATA_DIRS > > First line should match the title of the bug: > > Bubblewrap launcher doesn't bind font locations from XDG_DATA_DIRS Done. 1845379 8 ews-feeder 2022-02-23 15:48:39 -0800 Committed r290395 (247709@main): <https://commits.webkit.org/247709@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453031. 453016 2022-02-23 13:03:21 -0800 2022-02-23 14:41:55 -0800 Patch bug-237089-20220223160320.patch text/plain 2102 maxim.cournoyer U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM2Y2ZiZWQ1N2UxMzlmNGI4 OGM5MzVmOGVjNDk1ZjljNjVhMzdmNGMuLmQ3ZjNmMzU4YmQyODgyY2RlNjU4ZDU0NzcxYmU5NDBm YTQwNGQ0NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDItMjMgIExpbGlhbmEg TWFyaWUgUHJpa2xlciA8bGlsaWFuYS5wcmlrbGVyQGdtYWlsLmNvbT4KKworICAgICAgICBFeHBv c2UgYWxsIGZvbnRzIGxvY2F0aW9ucyBwcmVzZW50IGluIFhER19EQVRBX0RJUlMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzA4OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0xhdW5j aGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6YmluZEZv bnRzKTogRXhwb3NlIGZvbnQgZGlyZWN0b3JpZXMgcHJlc2VudCBpbiB0aGUKKyAgICAgICAgWERH X0RBVEFfRElSUyBlbnZpcm9ubWVudCB2YXJpYWJsZS4KKwogMjAyMi0wMi0yMyAgUGhpbGlwcGUg Tm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gRGUt aW5pdGlhbGl6ZSBHU3RyZWFtZXIgYmVmb3JlIHRlcm1pbmF0aW5nIFdlYlByb2Nlc3MKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExh dW5jaGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxl d3JhcExhdW5jaGVyLmNwcAppbmRleCBlY2M4MDQ2NjM3ODRiMTNkYzY4NTQzODk2ZDdmODI5MGFl MmYzNjJhLi4xODgxNmUwZWRiNzJmZDM0ZmFiNjFlNDA4MmFiMDg3NmJjZjhiMWIyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVu Y2hlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJi bGV3cmFwTGF1bmNoZXIuY3BwCkBAIC0yODgsNiArMjg4LDcgQEAgc3RhdGljIHZvaWQgYmluZEZv bnRzKFZlY3RvcjxDU3RyaW5nPiYgYXJncykKICAgICBjb25zdCBjaGFyKiBob21lRGlyID0gZ19n ZXRfaG9tZV9kaXIoKTsKICAgICBjb25zdCBjaGFyKiBkYXRhRGlyID0gZ19nZXRfdXNlcl9kYXRh X2RpcigpOwogICAgIGNvbnN0IGNoYXIqIGNhY2hlRGlyID0gZ19nZXRfdXNlcl9jYWNoZV9kaXIo KTsKKyAgICBjb25zdCBjaGFyKiBjb25zdCAqIGRhdGFEaXJzID0gZ19nZXRfc3lzdGVtX2RhdGFf ZGlycygpOwogCiAgICAgLy8gQ29uZmlncyBjYW4gaW5jbHVkZSBjdXN0b20gZGlycyBidXQgdGhl biB3ZSBoYXZlIHRvIHBhcnNlIHRoZW0uLi4KICAgICBHVW5pcXVlUHRyPGNoYXI+IGZvbnRDb25m aWcoZ19idWlsZF9maWxlbmFtZShjb25maWdEaXIsICJmb250Y29uZmlnIiwgbnVsbHB0cikpOwpA QCAtMzA0LDYgKzMwNSwxMCBAQCBzdGF0aWMgdm9pZCBiaW5kRm9udHMoVmVjdG9yPENTdHJpbmc+ JiBhcmdzKQogICAgIGJpbmRJZkV4aXN0cyhhcmdzLCBmb250SG9tZUNvbmZpZ0Rpci5nZXQoKSk7 CiAgICAgYmluZElmRXhpc3RzKGFyZ3MsIGZvbnREYXRhLmdldCgpKTsKICAgICBiaW5kSWZFeGlz dHMoYXJncywgZm9udEhvbWVEYXRhLmdldCgpKTsKKyAgICBmb3IgKGF1dG8gZGF0YURpciA9IGRh dGFEaXJzOyBkYXRhRGlyICE9IG51bGxwdHIgJiYgKmRhdGFEaXIgIT0gbnVsbHB0cjsgZGF0YURp cisrKSB7CisgICAgICAgIEdVbmlxdWVQdHI8Y2hhcj4gZm9udERhdGFEaXIoZ19idWlsZF9maWxl bmFtZSgqZGF0YURpciwgImZvbnRzIiwgbnVsbHB0cikpOworICAgICAgICBiaW5kSWZFeGlzdHMo YXJncywgZm9udERhdGFEaXIuZ2V0KCkpOworICAgIH0KICAgICBiaW5kSWZFeGlzdHMoYXJncywg Ii92YXIvY2FjaGUvZm9udGNvbmZpZyIpOyAvLyBVc2VkIGJ5IERlYmlhbi4KIH0KIAo= 453031 2022-02-23 14:42:00 -0800 2022-02-23 15:48:42 -0800 Patch bug-237089-20220223174159.patch text/plain 2096 maxim.cournoyer U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM2Y2ZiZWQ1N2UxMzlmNGI4 OGM5MzVmOGVjNDk1ZjljNjVhMzdmNGMuLjUyNDg3Y2MwZjYyMDg4ZWYwMDJhYzBjNGI0YTJiMjZj YThkNGZmMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDItMjMgIExpbGlhbmEg TWFyaWUgUHJpa2xlciA8bGlsaWFuYS5wcmlrbGVyQGdtYWlsLmNvbT4KKworICAgICAgICBCdWJi bGV3cmFwIGxhdW5jaGVyIGRvZXNuJ3QgYmluZCBmb250IGxvY2F0aW9ucyBmcm9tIFhER19EQVRB X0RJUlMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz NzA4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNwcDoKKyAgICAgICAg KFdlYktpdDo6YmluZEZvbnRzKTogRXhwb3NlIGZvbnQgZGlyZWN0b3JpZXMgcHJlc2VudCBpbiB0 aGUKKyAgICAgICAgWERHX0RBVEFfRElSUyBlbnZpcm9ubWVudCB2YXJpYWJsZS4KKwogMjAyMi0w Mi0yMyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dTdHJlYW1lcl0gRGUtaW5pdGlhbGl6ZSBHU3RyZWFtZXIgYmVmb3JlIHRlcm1pbmF0aW5nIFdl YlByb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2ds aWIvQnViYmxld3JhcExhdW5jaGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5j aGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNwcAppbmRleCBlY2M4MDQ2NjM3ODRiMTNkYzY4 NTQzODk2ZDdmODI5MGFlMmYzNjJhLi44ZGUxNzRiZTNjMGVkN2QyNjMxMDMxMzI3M2ZhODVkM2Q0 ZDQ2YzQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGli L0J1YmJsZXdyYXBMYXVuY2hlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1 bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwCkBAIC0yODgsNiArMjg4LDcgQEAgc3Rh dGljIHZvaWQgYmluZEZvbnRzKFZlY3RvcjxDU3RyaW5nPiYgYXJncykKICAgICBjb25zdCBjaGFy KiBob21lRGlyID0gZ19nZXRfaG9tZV9kaXIoKTsKICAgICBjb25zdCBjaGFyKiBkYXRhRGlyID0g Z19nZXRfdXNlcl9kYXRhX2RpcigpOwogICAgIGNvbnN0IGNoYXIqIGNhY2hlRGlyID0gZ19nZXRf dXNlcl9jYWNoZV9kaXIoKTsKKyAgICBjb25zdCBjaGFyKiBjb25zdCAqIGRhdGFEaXJzID0gZ19n ZXRfc3lzdGVtX2RhdGFfZGlycygpOwogCiAgICAgLy8gQ29uZmlncyBjYW4gaW5jbHVkZSBjdXN0 b20gZGlycyBidXQgdGhlbiB3ZSBoYXZlIHRvIHBhcnNlIHRoZW0uLi4KICAgICBHVW5pcXVlUHRy PGNoYXI+IGZvbnRDb25maWcoZ19idWlsZF9maWxlbmFtZShjb25maWdEaXIsICJmb250Y29uZmln IiwgbnVsbHB0cikpOwpAQCAtMzA0LDYgKzMwNSwxMCBAQCBzdGF0aWMgdm9pZCBiaW5kRm9udHMo VmVjdG9yPENTdHJpbmc+JiBhcmdzKQogICAgIGJpbmRJZkV4aXN0cyhhcmdzLCBmb250SG9tZUNv bmZpZ0Rpci5nZXQoKSk7CiAgICAgYmluZElmRXhpc3RzKGFyZ3MsIGZvbnREYXRhLmdldCgpKTsK ICAgICBiaW5kSWZFeGlzdHMoYXJncywgZm9udEhvbWVEYXRhLmdldCgpKTsKKyAgICBmb3IgKGF1 dG8qIGRhdGFEaXIgPSBkYXRhRGlyczsgZGF0YURpciAmJiAqZGF0YURpcjsgZGF0YURpcisrKSB7 CisgICAgICAgIEdVbmlxdWVQdHI8Y2hhcj4gZm9udERhdGFEaXIoZ19idWlsZF9maWxlbmFtZSgq ZGF0YURpciwgImZvbnRzIiwgbnVsbHB0cikpOworICAgICAgICBiaW5kSWZFeGlzdHMoYXJncywg Zm9udERhdGFEaXIuZ2V0KCkpOworICAgIH0KICAgICBiaW5kSWZFeGlzdHMoYXJncywgIi92YXIv Y2FjaGUvZm9udGNvbmZpZyIpOyAvLyBVc2VkIGJ5IERlYmlhbi4KIH0KIAo=