236188 2022-02-05 16:24:45 -0800 [LBSE] Extend overflow/clip rect handling for SVG layers 2022-02-07 03:37:20 -0800 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 90738 236194 1 zimmermann zimmermann changseok esprehn+autocc ews-watchlist fred.wang glenn kondapallykalyan pdr rbuis sabouhallawa simon.fraser webkit-bug-importer zimmermann oldest_to_newest 1837816 0 zimmermann 2022-02-05 16:24:45 -0800 Prepare RenderLayer/RenderLayerBacking for RenderSVGModelObject support: Allow to re-use overflow clipping logic for certain type of SVG containers, deriving from RenderSVGModelObject, namely: RenderSVGViewportContainer / RenderSVGResourceMarker (RenderSVGRoot uses the same logic, but through RenderReplaced: it doesn't derived from RenderSVGModelObject). Once all things are in place, the SVG overflow logic is gone, replaced in all areas by the shared CSS one. 1837827 1 451013 zimmermann 2022-02-05 16:43:52 -0800 Created attachment 451013 Patch, v1 1838039 2 451013 rbuis 2022-02-07 02:09:39 -0800 Comment on attachment 451013 Patch, v1 This could be more efficient in the case LAYER_BASED_SVG_ENGINE is not enabled, but since we want to convert to it given all the benefits I think it is no problem. 1838053 3 zimmermann 2022-02-07 03:33:42 -0800 (In reply to Rob Buis from comment #2) > Comment on attachment 451013 [details] > Patch, v1 > > This could be more efficient in the case LAYER_BASED_SVG_ENGINE is not > enabled, but since we want to convert to it given all the benefits I think > it is no problem. I also thought about caching the 'is<RenderBox>(renderer())' somewhere, but this smells like a pre-mature optimization that looks cheaper on first sight, but without instruction level profiling I wouldn't be on it. 1838054 4 zimmermann 2022-02-07 03:36:50 -0800 Committed r289204 (246890@trunk): <https://commits.webkit.org/246890@trunk> 1838055 5 webkit-bug-importer 2022-02-07 03:37:20 -0800 <rdar://problem/88564886> 451013 2022-02-05 16:43:52 -0800 2022-02-07 02:09:39 -0800 Patch, v1 bug-236188-20220205164350.patch text/plain 7253 zimmermann U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGNhZjNlOTIwYTY3NTgw Njg5ZDI0MzY4Y2EzMjFkN2U3ZTI2YjczMC4uZTA3MGE3MWJmZWQyYTgyZmU1NzhlNzgwYjRlN2I1 ODQ4MTAzMzI4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDIyLTAyLTA1ICBOaWtv bGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtMQlNF XSBFeHRlbmQgb3ZlcmZsb3cvY2xpcCByZWN0IGhhbmRsaW5nIGZvciBTVkcgbGF5ZXJzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYxODgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb24tdmlzaWJsZSBv dmVyZmxvdyBpbXBsaWVzIGEgY2xpcCwgdGhhdCBwb3RlbnRpYWxseSBpbmZsdWVuY2VzIHRoZSBs YXllcgorICAgICAgICBnZW9tZXRyeS4gVGhlICdmb3JlZ3JvdW5kUmVjdCcgaXMgaW50ZXJzZWN0 ZWQgd2l0aCB0aGUgJ292ZXJmbG93Q2xpcFJlY3QnCisgICAgICAgIG9mIHRoZSByZW5kZXJlciAt IHVzdWFsbHkgcHJvdmlkZWQgdmlhIFJlbmRlckJveDo6b3ZlcmZsb3dDbGlwUmVjdCgpLgorCisg ICAgICAgIFRoZSBDU1Mgb3ZlcmZsb3cgaGFuZGxpbmcgaXMgYXBwbGljYWJsZSB0byBTVkcgYXMg d2VsbCwgbW9zdCBub3RpY2VhYmxlCisgICAgICAgIHRoZSBvdXRlcm1vc3QgPHN2Zz4gZWxlbWVu dCAoUmVuZGVyU1ZHUm9vdCksIGFscmVhZHkgdXNlcyB0aGUgQ1NTIG92ZXJmbG93CisgICAgICAg IGhhbmRsaW5nLCBhcyBpdCBpcyBSZW5kZXJCb3ggZGVyaXZlZCAodmlhIGl0cyBSZW5kZXJSZXBs YWNlZCBpbmhlcml0YW5jZSkKKyAgICAgICAgYW5kIG5vdCBSZW5kZXJTVkdNb2RlbE9iamVjdCBk ZXJpdmVkLgorCisgICAgICAgIEhvd2V2ZXIgaW5uZXIgPHN2Zz4gZWxlbWVudHMgKFJlbmRlclNW R1ZpZXdwb3J0Q29udGFpbmVyKSBhbmQgPG1hcmtlcj4KKyAgICAgICAgZWxlbWVudHMgYWxzbyBy ZXF1aXJlIG92ZXJmbG93IGhhbmRsaW5nIC0tIHRoaXMgcGF0Y2ggYWxsb3dzIHRoZW0gdG8KKyAg ICAgICAgcGFydGljaXBhdGUgaW4gdGhlIGxheWVyIG92ZXJmbG93IGhhbmRsaW5nIGFuZCB0aGVy ZWZvcmUgZXh0ZW5kcyBib3RoCisgICAgICAgIFJlbmRlckxheWVyOjpjYWxjdWxhdGVDbGlwUmVj dHMoKSBhbmQgUmVuZGVyTGF5ZXI6OmNhbGN1bGF0ZVJlY3RzKCkKKyAgICAgICAgdG8gc3VwcG9y dCBSZW5kZXJTVkdNb2RlbE9iamVjdC4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRl c3RzLCBubyBjaGFuZ2UgaW4gYmVoYXZpb3VyLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpjYWxjdWxhdGVDbGlw UmVjdHMgY29uc3QpOgorCiAyMDIyLTAyLTAzICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVy bWFubkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtMQlNFXSBIYW5kbGUgUmVuZGVyU1ZHU2hhcGUg aW4gU1ZHUmVuZGVyU3VwcG9ydDo6YXBwbHlTdHJva2VTdHlsZVRvQ29udGV4dCgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCA3N2E4YTI3ODEyOTI1YTVhNDY3 MmM2NWRmOThjZjdhZGIyOTZmZGU3Li5iYzlmZDJlN2M4ZmJlMmNmNjU1ZTg0NTk4ZGFlYjhiNTdj ZTliN2M3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTEw Niw2ICsxMDYsNyBAQAogI2luY2x1ZGUgIlJlbmRlck11bHRpQ29sdW1uRmxvdy5oIgogI2luY2x1 ZGUgIlJlbmRlclJlcGxpY2EuaCIKICNpbmNsdWRlICJSZW5kZXJTVkdGb3JlaWduT2JqZWN0Lmgi CisjaW5jbHVkZSAiUmVuZGVyU1ZHTW9kZWxPYmplY3QuaCIKICNpbmNsdWRlICJSZW5kZXJTVkdS ZXNvdXJjZUNsaXBwZXIuaCIKICNpbmNsdWRlICJSZW5kZXJTY3JvbGxiYXIuaCIKICNpbmNsdWRl ICJSZW5kZXJTY3JvbGxiYXJQYXJ0LmgiCkBAIC00NTU2LDcgKzQ1NTcsMTggQEAgdm9pZCBSZW5k ZXJMYXllcjo6Y2FsY3VsYXRlQ2xpcFJlY3RzKGNvbnN0IENsaXBSZWN0c0NvbnRleHQmIGNsaXBS ZWN0c0NvbnRleHQsIEMKICAgICAgICAgICAgIG9mZnNldCAtPSB0b0xheW91dFNpemUocmVuZGVy ZXIoKS52aWV3KCkuZnJhbWVWaWV3KCkuc2Nyb2xsUG9zaXRpb25Gb3JGaXhlZFBvc2l0aW9uKCkp OwogCiAgICAgICAgIGlmIChyZW5kZXJlcigpLmhhc05vblZpc2libGVPdmVyZmxvdygpKSB7Ci0g ICAgICAgICAgICBDbGlwUmVjdCBuZXdPdmVyZmxvd0NsaXAgPSBkb3duY2FzdDxSZW5kZXJCb3g+ KHJlbmRlcmVyKCkpLm92ZXJmbG93Q2xpcFJlY3RGb3JDaGlsZExheWVycyhvZmZzZXQsIG51bGxw dHIsIGNsaXBSZWN0c0NvbnRleHQub3ZlcmxheVNjcm9sbGJhclNpemVSZWxldmFuY3kpOworICAg ICAgICAgICAgQ2xpcFJlY3QgbmV3T3ZlcmZsb3dDbGlwOworICAgICAgICAgICAgaWYgKGlzPFJl bmRlckJveD4ocmVuZGVyZXIoKSkpCisgICAgICAgICAgICAgICAgbmV3T3ZlcmZsb3dDbGlwID0g ZG93bmNhc3Q8UmVuZGVyQm94PihyZW5kZXJlcigpKS5vdmVyZmxvd0NsaXBSZWN0Rm9yQ2hpbGRM YXllcnMob2Zmc2V0LCBudWxscHRyLCBjbGlwUmVjdHNDb250ZXh0Lm92ZXJsYXlTY3JvbGxiYXJT aXplUmVsZXZhbmN5KTsKKyNpZiBFTkFCTEUoTEFZRVJfQkFTRURfU1ZHX0VOR0lORSkKKyAgICAg ICAgICAgIGVsc2UgaWYgKGlzPFJlbmRlclNWR01vZGVsT2JqZWN0PihyZW5kZXJlcigpKSkKKyAg ICAgICAgICAgICAgICBuZXdPdmVyZmxvd0NsaXAgPSBkb3duY2FzdDxSZW5kZXJTVkdNb2RlbE9i amVjdD4ocmVuZGVyZXIoKSkub3ZlcmZsb3dDbGlwUmVjdEZvckNoaWxkTGF5ZXJzKG9mZnNldCwg bnVsbHB0ciwgY2xpcFJlY3RzQ29udGV4dC5vdmVybGF5U2Nyb2xsYmFyU2l6ZVJlbGV2YW5jeSk7 CisjZW5kaWYKKyAgICAgICAgICAgIGVsc2UgeworICAgICAgICAgICAgICAgIEFTU0VSVF9OT1Rf UkVBQ0hFRCgpOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKwogICAg ICAgICAgICAgbmV3T3ZlcmZsb3dDbGlwLnNldEFmZmVjdGVkQnlSYWRpdXMocmVuZGVyZXIoKS5z dHlsZSgpLmhhc0JvcmRlclJhZGl1cygpKTsKICAgICAgICAgICAgIGNsaXBSZWN0cy5zZXRPdmVy Zmxvd0NsaXBSZWN0KGludGVyc2VjdGlvbihuZXdPdmVyZmxvd0NsaXAsIGNsaXBSZWN0cy5vdmVy Zmxvd0NsaXBSZWN0KCkpKTsKICAgICAgICAgICAgIGlmIChyZW5kZXJlcigpLmlzUG9zaXRpb25l ZCgpKQpAQCAtNDU2Niw3ICs0NTc4LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6Y2FsY3VsYXRlQ2xp cFJlY3RzKGNvbnN0IENsaXBSZWN0c0NvbnRleHQmIGNsaXBSZWN0c0NvbnRleHQsIEMKICAgICAg ICAgICAgICAgICBjbGlwUmVjdHMuc2V0Rml4ZWRDbGlwUmVjdChpbnRlcnNlY3Rpb24obmV3T3Zl cmZsb3dDbGlwLCBjbGlwUmVjdHMuZml4ZWRDbGlwUmVjdCgpKSk7CiAgICAgICAgICAgICB9CiAg ICAgICAgIH0KLSAgICAgICAgaWYgKHJlbmRlcmVyKCkuaGFzQ2xpcCgpKSB7CisgICAgICAgIGlm IChyZW5kZXJlcigpLmhhc0NsaXAoKSAmJiBpczxSZW5kZXJCb3g+KHJlbmRlcmVyKCkpKSB7CiAg ICAgICAgICAgICBMYXlvdXRSZWN0IG5ld1Bvc0NsaXAgPSBkb3duY2FzdDxSZW5kZXJCb3g+KHJl bmRlcmVyKCkpLmNsaXBSZWN0KG9mZnNldCwgbnVsbHB0cik7CiAgICAgICAgICAgICBjbGlwUmVj dHMuc2V0UG9zQ2xpcFJlY3QoaW50ZXJzZWN0aW9uKG5ld1Bvc0NsaXAsIGNsaXBSZWN0cy5wb3ND bGlwUmVjdCgpKSk7CiAgICAgICAgICAgICBjbGlwUmVjdHMuc2V0T3ZlcmZsb3dDbGlwUmVjdChp bnRlcnNlY3Rpb24obmV3UG9zQ2xpcCwgY2xpcFJlY3RzLm92ZXJmbG93Q2xpcFJlY3QoKSkpOwpA QCAtNDY0NiwxMyArNDY1OCwyNiBAQCB2b2lkIFJlbmRlckxheWVyOjpjYWxjdWxhdGVSZWN0cyhj b25zdCBDbGlwUmVjdHNDb250ZXh0JiBjbGlwUmVjdHNDb250ZXh0LCBjb25zdAogICAgICAgICAv LyBUaGlzIGxheWVyIGVzdGFibGlzaGVzIGEgY2xpcCBvZiBzb21lIGtpbmQuCiAgICAgICAgIGlm IChyZW5kZXJlcigpLmhhc05vblZpc2libGVPdmVyZmxvdygpKSB7CiAgICAgICAgICAgICBpZiAo dGhpcyAhPSBjbGlwUmVjdHNDb250ZXh0LnJvb3RMYXllciB8fCBjbGlwUmVjdHNDb250ZXh0LnJl c3BlY3RPdmVyZmxvd0NsaXAgPT0gUmVzcGVjdE92ZXJmbG93Q2xpcCkgewotICAgICAgICAgICAg ICAgIGZvcmVncm91bmRSZWN0LmludGVyc2VjdChkb3duY2FzdDxSZW5kZXJCb3g+KHJlbmRlcmVy KCkpLm92ZXJmbG93Q2xpcFJlY3QodG9MYXlvdXRQb2ludChvZmZzZXRGcm9tUm9vdExvY2FsKSwg bnVsbHB0ciwgY2xpcFJlY3RzQ29udGV4dC5vdmVybGF5U2Nyb2xsYmFyU2l6ZVJlbGV2YW5jeSkp OworICAgICAgICAgICAgICAgIExheW91dFJlY3Qgb3ZlcmZsb3dDbGlwUmVjdDsKKworICAgICAg ICAgICAgICAgIGlmIChpczxSZW5kZXJCb3g+KHJlbmRlcmVyKCkpKQorICAgICAgICAgICAgICAg ICAgICBvdmVyZmxvd0NsaXBSZWN0ID0gZG93bmNhc3Q8UmVuZGVyQm94PihyZW5kZXJlcigpKS5v dmVyZmxvd0NsaXBSZWN0KHRvTGF5b3V0UG9pbnQob2Zmc2V0RnJvbVJvb3RMb2NhbCksIG51bGxw dHIsIGNsaXBSZWN0c0NvbnRleHQub3ZlcmxheVNjcm9sbGJhclNpemVSZWxldmFuY3kpOworI2lm IEVOQUJMRShMQVlFUl9CQVNFRF9TVkdfRU5HSU5FKQorICAgICAgICAgICAgICAgIGVsc2UgaWYg KGlzPFJlbmRlclNWR01vZGVsT2JqZWN0PihyZW5kZXJlcigpKSkKKyAgICAgICAgICAgICAgICAg ICAgb3ZlcmZsb3dDbGlwUmVjdCA9IGRvd25jYXN0PFJlbmRlclNWR01vZGVsT2JqZWN0PihyZW5k ZXJlcigpKS5vdmVyZmxvd0NsaXBSZWN0KHRvTGF5b3V0UG9pbnQob2Zmc2V0RnJvbVJvb3RMb2Nh bCksIG51bGxwdHIsIGNsaXBSZWN0c0NvbnRleHQub3ZlcmxheVNjcm9sbGJhclNpemVSZWxldmFu Y3kpOworI2VuZGlmCisgICAgICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICAgICAgICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICAgICAgICAgICAgICByZXR1cm47CisgICAg ICAgICAgICAgICAgfQorCisgICAgICAgICAgICAgICAgZm9yZWdyb3VuZFJlY3QuaW50ZXJzZWN0 KG92ZXJmbG93Q2xpcFJlY3QpOwogICAgICAgICAgICAgICAgIGZvcmVncm91bmRSZWN0LnNldEFm ZmVjdGVkQnlSYWRpdXModHJ1ZSk7CiAgICAgICAgICAgICB9IGVsc2UgaWYgKHRyYW5zZm9ybSgp ICYmIHJlbmRlcmVyKCkuc3R5bGUoKS5oYXNCb3JkZXJSYWRpdXMoKSkKICAgICAgICAgICAgICAg ICBmb3JlZ3JvdW5kUmVjdC5zZXRBZmZlY3RlZEJ5UmFkaXVzKHRydWUpOwogICAgICAgICB9CiAK LSAgICAgICAgaWYgKHJlbmRlcmVyKCkuaGFzQ2xpcCgpKSB7CisgICAgICAgIGlmIChyZW5kZXJl cigpLmhhc0NsaXAoKSAmJiBpczxSZW5kZXJCb3g+KHJlbmRlcmVyKCkpKSB7CiAgICAgICAgICAg ICAvLyBDbGlwIGFwcGxpZXMgdG8gKnVzKiBhcyB3ZWxsLCBzbyB1cGRhdGUgdGhlIGRhbWFnZVJl Y3QuCiAgICAgICAgICAgICBMYXlvdXRSZWN0IG5ld1Bvc0NsaXAgPSBkb3duY2FzdDxSZW5kZXJC b3g+KHJlbmRlcmVyKCkpLmNsaXBSZWN0KHRvTGF5b3V0UG9pbnQob2Zmc2V0RnJvbVJvb3RMb2Nh bCksIG51bGxwdHIpOwogICAgICAgICAgICAgYmFja2dyb3VuZFJlY3QuaW50ZXJzZWN0KG5ld1Bv c0NsaXApOwpAQCAtNDY2MSw3ICs0Njg2LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6Y2FsY3VsYXRl UmVjdHMoY29uc3QgQ2xpcFJlY3RzQ29udGV4dCYgY2xpcFJlY3RzQ29udGV4dCwgY29uc3QKIAog ICAgICAgICAvLyBJZiB3ZSBlc3RhYmxpc2ggYSBjbGlwIGF0IGFsbCwgdGhlbiBtYWtlIHN1cmUg b3VyIGJhY2tncm91bmQgcmVjdCBpcyBpbnRlcnNlY3RlZCB3aXRoIG91ciBsYXllcidzIGJvdW5k cyBpbmNsdWRpbmcgb3VyIHZpc3VhbCBvdmVyZmxvdywKICAgICAgICAgLy8gc2luY2UgYW55IHZp c3VhbCBvdmVyZmxvdyBsaWtlIGJveC1zaGFkb3cgb3IgYm9yZGVyLW91dHNldCBpcyBub3QgY2xp cHBlZCBieSBvdmVyZmxvdzphdXRvL2hpZGRlbi4KLSAgICAgICAgaWYgKHJlbmRlckJveCgpLT5o YXNWaXN1YWxPdmVyZmxvdygpKSB7CisgICAgICAgIGlmIChyZW5kZXJCb3goKSAmJiByZW5kZXJC b3goKS0+aGFzVmlzdWFsT3ZlcmZsb3coKSkgewogICAgICAgICAgICAgLy8gRklYTUU6IERvZXMg bm90IGRvIHRoZSByaWdodCB0aGluZyB3aXRoIENTUyByZWdpb25zIHlldCwgc2luY2Ugd2UgZG9u J3QgeWV0IGZhY3RvciBpbiB0aGUKICAgICAgICAgICAgIC8vIGluZGl2aWR1YWwgcmVnaW9uIGJv eGVzIGFzIG92ZXJmbG93LgogICAgICAgICAgICAgTGF5b3V0UmVjdCBsYXllckJvdW5kc1dpdGhW aXN1YWxPdmVyZmxvdyA9IHJlbmRlckJveCgpLT52aXN1YWxPdmVyZmxvd1JlY3QoKTsKQEAgLTQ3 MjksNyArNDc1NCw3IEBAIExheW91dFJlY3QgUmVuZGVyTGF5ZXI6OmxvY2FsQ2xpcFJlY3QoYm9v bCYgY2xpcEV4Y2VlZHNCb3VuZHMpIGNvbnN0CiAgICAgaWYgKGNsaXBSZWN0LmlzSW5maW5pdGUo KSkKICAgICAgICAgcmV0dXJuIGNsaXBSZWN0OwogCi0gICAgaWYgKHJlbmRlcmVyKCkuaGFzQ2xp cCgpKSB7CisgICAgaWYgKHJlbmRlcmVyKCkuaGFzQ2xpcCgpICYmIGlzPFJlbmRlckJveD4ocmVu ZGVyZXIoKSkpIHsKICAgICAgICAgLy8gQ1NTIGNsaXAgbWF5IGJlIGxhcmdlciB0aGFuIG91ciBi b3JkZXIgYm94LgogICAgICAgICBMYXlvdXRSZWN0IGNzc0NsaXBSZWN0ID0gZG93bmNhc3Q8UmVu ZGVyQm94PihyZW5kZXJlcigpKS5jbGlwUmVjdCh7IH0sIG51bGxwdHIpOwogICAgICAgICBjbGlw RXhjZWVkc0JvdW5kcyA9ICFjc3NDbGlwUmVjdC5pc0VtcHR5KCkgJiYgKGNsaXBSZWN0LndpZHRo KCkgPCBjc3NDbGlwUmVjdC53aWR0aCgpIHx8IGNsaXBSZWN0LmhlaWdodCgpIDwgY3NzQ2xpcFJl Y3QuaGVpZ2h0KCkpOwo=