235959 2022-02-01 09:14:16 -0800 [REGRESSION][WinCairo] Since r288284 compilation fails when REMOTE_INSPECTOR is enabled 2023-02-12 17:26:01 -0800 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 194905 1 yurys webkit-unassigned annulen don.olmstead ews-watchlist fujii gyuyoung.kim ryuan.choi sergio oldest_to_newest 1836004 0 yurys 2022-02-01 09:14:16 -0800 WinCairo compilation fails after https://trac.webkit.org/changeset/288284/webkit if REMOTE_INSPECTOR is enabled. It looks like WebProcessPoolWin does depend on Core Foundation for loading inspector resources: 58>D:\webkit\Source\WebKit\UIProcess\win\WebProcessPoolWin.cpp(44,15): error C2065: 'CFURLRef': undeclared identifier 58>D:\webkit\Source\WebKit\UIProcess\win\WebProcessPoolWin.cpp(44,5): error C2923: 'WTF::RetainPtr': 'CFURLRef' is not a valid template type argument for parameter '<unnamed-symbol>' 58>D:\webkit\Source\WebKit\UIProcess\win\WebProcessPoolWin.cpp(44): message : see declaration of 'CFURLRef' 58>D:\webkit\Source\WebKit\UIProcess\win\WebProcessPoolWin.cpp(44,75): error C2039: 'webKitBundle': is not a member of 'WebCore' 58>D:\webkit\Source\WebKit\UIProcess\WebProcessPool.h(94): message : see declaration of 'WebCore' 1836094 1 450556 fujii 2022-02-01 12:14:13 -0800 Created attachment 450556 Patch We should revert r288284 until WinCairo WK2 will remove the CF dependency (Bug 176236). 1933045 2 fujii 2023-02-12 17:26:01 -0800 Fixed by 260172@main. 450556 2022-02-01 12:14:13 -0800 2022-02-01 12:14:13 -0800 Patch revert.diff text/plain 1533 fujii ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxMDkzZmUxODc0NTQuLjRl MTczOGE3OTA5OCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDIyLTAyLTAxICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNv bnkuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjg4Mjg0LgorCisgICAg ICAgIFdpbkNhaXJvIFdLMiBjYW4ndCBjb21waWxlIHdpdGhvdXQgV0sxCisKKyAgICAgICAgUmV2 ZXJ0ZWQgY2hhbmdlc2V0OgorCisgICAgICAgICJbV2luQ2Fpcm9dIE1ha2UgVVNFX0NGIGNvbmRp dGlvbmFsIG9uIEVOQUJMRV9XRUJLSVRfTEVHQUNZIgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1MzkzCisgICAgICAgIGh0dHBzOi8vY29tbWl0cy53 ZWJraXQub3JnL3IyODgyODQKKwogMjAyMi0wMi0wMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBTd2l0Y2ggdG8gdXNlIEFU U1BJIGluc3RlYWQgb2YgQVRLCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbkNh aXJvLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW5DYWlyby5jbWFrZQppbmRleCA2MmI0 YmM2ZTkxYjEuLjU0ZGMwOTVkOWY5OCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNX aW5DYWlyby5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbkNhaXJvLmNtYWtlCkBA IC01MSw2ICs1MSw3IEBAIHNldChVU0VfQU5HTEVfV0VCR0wgT04pCiAKIFNFVF9BTkRfRVhQT1NF X1RPX0JVSUxEKFVTRV9BTkdMRSBPTikKIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9DQUlS TyBPTikKK1NFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9DRiBPTikKIFNFVF9BTkRfRVhQT1NF X1RPX0JVSUxEKFVTRV9DVVJMIE9OKQogU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX0dSQVBI SUNTX0xBWUVSX1RFWFRVUkVfTUFQUEVSIE9OKQogU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNF X0dSQVBISUNTX0xBWUVSX1dDIE9OKQpAQCAtNjcsMTEgKzY4LDcgQEAgU0VUX0FORF9FWFBPU0Vf VE9fQlVJTEQoRU5BQkxFX0RFVkVMT1BFUl9NT0RFICR7REVWRUxPUEVSX01PREV9KQogCiBTRVRf QU5EX0VYUE9TRV9UT19CVUlMRChIQVZFX09TX0RBUktfTU9ERV9TVVBQT1JUIDEpCiAKLSMgQ29y ZUZvdW5kYXRpb24gaXMgcmVxdWlyZWQgd2hlbiBidWlsZGluZyBXZWJLaXRMZWdhY3kKLWlmIChF TkFCTEVfV0VCS0lUX0xFR0FDWSkKLSAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfQ0Yg T04pCi0gICAgc2V0KENPUkVGT1VOREFUSU9OX0xJQlJBUlkgQ0ZsaXRlKQotZW5kaWYgKCkKK3Nl dChDT1JFRk9VTkRBVElPTl9MSUJSQVJZIENGbGl0ZSkKIAogYWRkX2RlZmluaXRpb25zKC1EV1RG X1BMQVRGT1JNX1dJTl9DQUlSTz0xKQogYWRkX2RlZmluaXRpb25zKC1ETk9DUllQVCkK