235088 2022-01-11 16:06:19 -0800 [MediaFoundation] Invalidate only the video area using MediaPlayer::repaint(), not the whole FrameView 2022-01-12 13:19:18 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=150941 InRadar P2 Normal --- 233676 1 fujii fujii don.olmstead eric.carlson ews-watchlist glenn jer.noble philipj pvollan sergio webkit-bug-importer oldest_to_newest 1829948 0 fujii 2022-01-11 16:06:19 -0800 [MediaFoundation] Invalidate only the videa area using MediaPlayer::repaint(), not the whole FrameView MediaPlayerPrivateMediaFoundation::invalidateFrameView() is invalidating the whole FrameView to render the next frame. (Bug 150941) It's too much. And, this doesn't work with TiledBacking (attachment 448832). 1829954 1 448888 fujii 2022-01-11 16:18:34 -0800 Created attachment 448888 Patch 1830311 2 448888 fujii 2022-01-12 13:18:05 -0800 Comment on attachment 448888 Patch Clearing flags on attachment: 448888 Committed r287948 (?): <https://commits.webkit.org/r287948> 1830312 3 fujii 2022-01-12 13:18:10 -0800 All reviewed patches have been landed. Closing bug. 1830314 4 webkit-bug-importer 2022-01-12 13:19:18 -0800 <rdar://problem/87484080> 448888 2022-01-11 16:18:34 -0800 2022-01-12 13:18:05 -0800 Patch bug-235088-20220112091833.patch text/plain 3527 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3ODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNjNWE2MjhlNjg3MGVm ZTFhYjE4NGZiODkzODE3MjkzNWU4MzlmYi4uNTYwZWZhMjI1OTI2NTk3Y2NkYWQzN2E2MTlkMGIw Y2FkNTc2Zjg5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIyLTAxLTExICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtNZWRpYUZv dW5kYXRpb25dIEludmFsaWRhdGUgb25seSB0aGUgdmlkZWEgYXJlYSB1c2luZyBNZWRpYVBsYXll cjo6cmVwYWludCgpLCBub3QgdGhlIHdob2xlIEZyYW1lVmlldworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1MDg4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjE5MjE3NiBhZGRlZCBNZWRpYVBsYXllclBy aXZhdGVNZWRpYUZvdW5kYXRpb246OmludmFsaWRhdGVGcmFtZVZpZXcoKQorICAgICAgICB0byBy ZW5kZXIgdGhlIG5leHQgZnJhbWUuIEl0IHdhcywgYXMgcGVyIHRoZSBtZXRob2QgbmFtZSwKKyAg ICAgICAgaW52YWxpZGF0aW5nIHRoZSB3aG9sZSBGcmFtZVZpZXcuCisKKyAgICAgICAgVGhpcyBh cHByb2FjaCBkb2Vzbid0IHJlbmRlciB2aWRlbyBmcmFtZXMgd2l0aCBUaWxlZEJhY2tpbmcgKEJ1 ZworICAgICAgICAyMzM2NzYpLiBDYWxsaW5nIE1lZGlhUGxheWVyOjpyZXBhaW50KCkgaXMgdGhl IGNvcnJlY3Qgd2F5IHRvCisgICAgICAgIGludmFsaWRhdGUgdGhlIHZpZGVvIGFyZWEuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3Vu ZGF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91 bmRhdGlvbjo6aW52YWxpZGF0ZVZpZGVvQXJlYSk6IENhbGwgTWVkaWFQbGF5ZXI6OnJlcGFpbnQo KS4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6 Q3VzdG9tVmlkZW9QcmVzZW50ZXI6OnByb2Nlc3NJbnB1dE5vdGlmeSk6CisgICAgICAgIChXZWJD b3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OmludmFsaWRhdGVGcmFtZVZp ZXcpOiBEZWxldGVkLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXll clByaXZhdGVNZWRpYUZvdW5kYXRpb24uaDoKKwogMjAyMi0wMS0xMSAgU2FpZCBBYm91LUhhbGxh d2EgIDxzYWlkQGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BVIFByb2Nlc3NdIFJlbW92ZSB0aGUg ZGVwZW5kZW5jeSBmcm9tIEZpbHRlckVmZmVjdCB0byBpdHMgaW5wdXRzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlTWVk aWFGb3VuZGF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9N ZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCmluZGV4IGM5ZDA4YzdiZTI1ZTRm ZDQ3MWNkOTczNzYxZDM5NmNjM2M0YmVjNGUuLjk1M2RmMzc4ZWM1ZjFiZjZhMGZhZGQ5ZDlhYmIx OTdjOGYwMGEwMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5k YXRpb24uY3BwCkBAIC02MzUsMTYgKzYzNSw5IEBAIEhXTkQgTWVkaWFQbGF5ZXJQcml2YXRlTWVk aWFGb3VuZGF0aW9uOjpob3N0V2luZG93KCkKICAgICByZXR1cm4gR2V0RGVza3RvcFdpbmRvdygp OwogfQogCi12b2lkIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6aW52YWxpZGF0 ZUZyYW1lVmlldygpCit2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6aW52 YWxpZGF0ZVZpZGVvQXJlYSgpCiB7Ci0gICAgRnJhbWVWaWV3KiB2aWV3ID0gbnVsbHB0cjsKLSAg ICBpZiAoIW1fcGxheWVyIHx8ICFtX3BsYXllci0+Y2FjaGVkUmVzb3VyY2VMb2FkZXIoKSB8fCAh bV9wbGF5ZXItPmNhY2hlZFJlc291cmNlTG9hZGVyKCktPmRvY3VtZW50KCkpCi0gICAgICAgIHJl dHVybjsKLSAgICB2aWV3ID0gbV9wbGF5ZXItPmNhY2hlZFJlc291cmNlTG9hZGVyKCktPmRvY3Vt ZW50KCktPnZpZXcoKTsKLSAgICBpZiAoIXZpZXcpCi0gICAgICAgIHJldHVybjsKLQotICAgIHZp ZXctPmludmFsaWRhdGUoKTsKKyAgICBtX3BsYXllci0+cmVwYWludCgpOwogfQogCiB2b2lkIE1l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6YWRkTGlzdGVuZXIoTWVkaWFQbGF5ZXJM aXN0ZW5lciogbGlzdGVuZXIpCkBAIC0xNjIyLDcgKzE2MTUsNyBAQCBIUkVTVUxUIE1lZGlhUGxh eWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6Q3VzdG9tVmlkZW9QcmVzZW50ZXI6OnByb2Nlc3NJ bnB1dE5vdAogICAgIGlmIChtX21lZGlhUGxheWVyKSB7CiAgICAgICAgIGNhbGxPbk1haW5UaHJl YWQoW3dlYWtQdHIgPSBtX21lZGlhUGxheWVyLT5tX3dlYWtUaGlzXSB7CiAgICAgICAgICAgICBp ZiAod2Vha1B0cikKLSAgICAgICAgICAgICAgICB3ZWFrUHRyLT5pbnZhbGlkYXRlRnJhbWVWaWV3 KCk7CisgICAgICAgICAgICAgICAgd2Vha1B0ci0+aW52YWxpZGF0ZVZpZGVvQXJlYSgpOwogICAg ICAgICB9KTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5k YXRpb24uaAppbmRleCAwZGUxOWRiYTI1YzEzYWQ0Y2E5OGU3MTFiNTYzODg5ZmZhNTM3NDNhLi41 NDliYTg3ZTc5YzNjZTMwZDhmNDI0OGJjNTkzZDc0MjhiMTlmNDExIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFG b3VuZGF0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5oCkBAIC0xNTcsNyArMTU3LDcgQEAgcHJp dmF0ZToKICAgICB2b2lkIG9uU2Vzc2lvbkVuZGVkKCk7CiAKICAgICBIV05EIGhvc3RXaW5kb3co KTsKLSAgICB2b2lkIGludmFsaWRhdGVGcmFtZVZpZXcoKTsKKyAgICB2b2lkIGludmFsaWRhdGVW aWRlb0FyZWEoKTsKIAogICAgIHZvaWQgYWRkTGlzdGVuZXIoTWVkaWFQbGF5ZXJMaXN0ZW5lciop OwogICAgIHZvaWQgcmVtb3ZlTGlzdGVuZXIoTWVkaWFQbGF5ZXJMaXN0ZW5lciopOwo=