234546 2021-12-20 21:30:56 -0800 MSVC reports "SVGPropertyAnimator.h(94): error C2839: invalid return type 'T *' for overloaded 'operator ->'" with /std:c++20 2022-02-01 14:49:10 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=233963 InRadar P2 Normal --- 233448 1 fujii fujii achristensen darin dino don.olmstead ews-watchlist fmalita gyuyoung.kim pdr sabouhallawa schenney sergio webkit-bug-importer oldest_to_newest 1825872 0 fujii 2021-12-20 21:30:56 -0800 MSVC reports "SVGPropertyAnimator.h(94): error C2839: invalid return type 'T *' for overloaded 'operator ->'" with /std:c++20 > Source\WebCore\svg\properties\SVGPropertyAnimator.h(94): error C2839: invalid return type 'T *' for overloaded 'operator ->' > Source\WebCore\svg\properties\SVGPropertyAnimator.h(102): note: see reference to class template instantiation 'WebCore::SVGPropertyAnimator<AnimationFunction>' being compiled > Source\WebCore\svg\properties\SVGPropertyAnimator.h(94): error C2039: 'isSVGElement': is not a member of 'WTF::RefPtr' 1825873 1 447688 fujii 2021-12-20 21:37:59 -0800 Created attachment 447688 Patch 1825882 2 447688 achristensen 2021-12-20 22:46:33 -0800 Comment on attachment 447688 Patch auto* 1825883 3 447691 fujii 2021-12-20 23:17:27 -0800 Created attachment 447691 Patch for landing Thank you for the review. 1825896 4 ews-feeder 2021-12-21 00:30:11 -0800 Committed r287300 (245452@main): <https://commits.webkit.org/245452@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447691. 1825897 5 webkit-bug-importer 2021-12-21 00:31:19 -0800 <rdar://problem/86757805> 1825912 6 447691 darin 2021-12-21 01:05:33 -0800 Comment on attachment 447691 Patch for landing This change is going in the opposite direction that our future code is going. Taking out the use of RefPtr because we know nothing is done between the call to parentElement and the call to computeCSSPropertyValue is absolutely *not* the theme of our modern code. Why does the use of RefPtr here not compile? We need to fix that, not remove smart pointers. To move in the direction of more secure code, we need to move to always using smart pointers for local variables. 1825943 7 fujii 2021-12-21 02:25:44 -0800 Thank you for the feedback. Reopened. 1826127 8 achristensen 2021-12-21 15:07:06 -0800 I agree with Darin's feedback. 1826617 9 fujii 2021-12-23 13:02:15 -0800 I created a repro and reported the bug to MSVC team. https://developercommunity.visualstudio.com/t/error-c2839-invalid-return-type-t-for-overloaded-o/1620672 1826791 10 don.olmstead 2021-12-24 19:24:50 -0800 Fujii just provide the full templated type here. Look at my WIP patch for the /permissive- to see what got me past this error 1826909 11 fujii 2021-12-26 13:06:17 -0800 Yup. Your workaround seems the best (attachment 445038). I just wanted to confirm that this is MSVC bug and let them know before preparing a patch for WebKit. 1836128 12 450563 fujii 2022-02-01 13:35:29 -0800 Created attachment 450563 Patch 1836160 13 ews-feeder 2022-02-01 14:49:05 -0800 Committed r288913 (246653@main): <https://commits.webkit.org/246653@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450563. 447688 2021-12-20 21:37:59 -0800 2021-12-20 23:17:16 -0800 Patch bug-234546-20211221143758.patch text/plain 1668 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3Mjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzA4YjE0NWNjMjZkYjk5 NjQ3N2M3MzI0YTA4NTUyM2YxMzFlMWJiNS4uMzQ4NmFjYWMyZDM2NGRmYzUyNDBkMzFhMTE4NDg2 M2VhMjk5NDY4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEyLTIwICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIE1TVkMgcmVw b3J0cyAiU1ZHUHJvcGVydHlBbmltYXRvci5oKDk0KTogZXJyb3IgQzI4Mzk6IGludmFsaWQgcmV0 dXJuIHR5cGUgJ1QgKicgZm9yIG92ZXJsb2FkZWQgJ29wZXJhdG9yIC0+JyIgd2l0aCAvc3RkOmMr KzIwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ1 NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN2 Zy9wcm9wZXJ0aWVzL1NWR1Byb3BlcnR5QW5pbWF0b3IuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNW R1Byb3BlcnR5QW5pbWF0b3I6OmNvbXB1dGVJbmhlcml0ZWRDU1NQcm9wZXJ0eVZhbHVlIGNvbnN0 KToKKyAgICAgICAgY29tcHV0ZUNTU1Byb3BlcnR5VmFsdWUgcHJvdGVjdHMgdGhlIGZpcnN0IGFy Z3VlbW50IFNWR0VsZW1lbnQuCisgICAgICAgIGNvbXB1dGVJbmhlcml0ZWRDU1NQcm9wZXJ0eVZh bHVlIGRvZXNuJ3QgbmVlZCB0byBwcm90ZWN0ICJwYXJlbnQiLgorICAgICAgICBVc2UgRWxlbWVu dCogaW5zdGVhZCBvZiBSZWZQdHIgZm9yICJwYXJlbnQiLgorCiAyMDIxLTEyLTIwICBBbGV4ZXkg U2h2YXlrYSAgPGFzaHZheWthQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViSURMXSBjb252ZXJ0 VmFyaWFkaWNBcmd1bWVudHMoKSBzaG91bGQgcmV0dXJuIGEgRml4ZWRWZWN0b3IKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0aWVzL1NWR1Byb3BlcnR5QW5pbWF0b3IuaCBi L1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0aWVzL1NWR1Byb3BlcnR5QW5pbWF0b3IuaAppbmRl eCA4OTFhNDY2OTYwNjQ3NjQ1MDhiMWFkZjUwNWIwYmE1ZjI1MzU5ZjYyLi45MTAwODE5N2ExMjRk ZTU4ZTY4MGJhMDBiMjE0YTYyZmZjZjE5YmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9z dmcvcHJvcGVydGllcy9TVkdQcm9wZXJ0eUFuaW1hdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUv c3ZnL3Byb3BlcnRpZXMvU1ZHUHJvcGVydHlBbmltYXRvci5oCkBAIC04OSw3ICs4OSw3IEBAIHBy b3RlY3RlZDoKIAogICAgIFN0cmluZyBjb21wdXRlSW5oZXJpdGVkQ1NTUHJvcGVydHlWYWx1ZShT VkdFbGVtZW50JiB0YXJnZXRFbGVtZW50KSBjb25zdAogICAgIHsKLSAgICAgICAgUmVmUHRyIHBh cmVudCA9IHRhcmdldEVsZW1lbnQucGFyZW50RWxlbWVudCgpOworICAgICAgICBhdXRvIHBhcmVu dCA9IHRhcmdldEVsZW1lbnQucGFyZW50RWxlbWVudCgpOwogICAgICAgICBpZiAoIXBhcmVudCB8 fCAhcGFyZW50LT5pc1NWR0VsZW1lbnQoKSkKICAgICAgICAgICAgIHJldHVybiBlbXB0eVN0cmlu ZygpOwogICAgICAgICAK 447691 2021-12-20 23:17:27 -0800 2022-02-01 13:35:18 -0800 Patch for landing bug-234546-20211221161726.patch text/plain 1671 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3Mjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzA4YjE0NWNjMjZkYjk5 NjQ3N2M3MzI0YTA4NTUyM2YxMzFlMWJiNS4uMDQ5NzhiMzVmN2NlYzA1MjdmMzdlOTFkNmNlNDFm Mjg3ZTdmMmNhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEyLTIwICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIE1TVkMgcmVw b3J0cyAiU1ZHUHJvcGVydHlBbmltYXRvci5oKDk0KTogZXJyb3IgQzI4Mzk6IGludmFsaWQgcmV0 dXJuIHR5cGUgJ1QgKicgZm9yIG92ZXJsb2FkZWQgJ29wZXJhdG9yIC0+JyIgd2l0aCAvc3RkOmMr KzIwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ1 NDYKKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4IENocmlzdGVuc2VuLgorCisgICAgICAgICog c3ZnL3Byb3BlcnRpZXMvU1ZHUHJvcGVydHlBbmltYXRvci5oOgorICAgICAgICAoV2ViQ29yZTo6 U1ZHUHJvcGVydHlBbmltYXRvcjo6Y29tcHV0ZUluaGVyaXRlZENTU1Byb3BlcnR5VmFsdWUgY29u c3QpOgorICAgICAgICBjb21wdXRlQ1NTUHJvcGVydHlWYWx1ZSBwcm90ZWN0cyB0aGUgZmlyc3Qg YXJndWVtbnQgU1ZHRWxlbWVudC4KKyAgICAgICAgY29tcHV0ZUluaGVyaXRlZENTU1Byb3BlcnR5 VmFsdWUgZG9lc24ndCBuZWVkIHRvIHByb3RlY3QgInBhcmVudCIuCisgICAgICAgIFVzZSBFbGVt ZW50KiBpbnN0ZWFkIG9mIFJlZlB0ciBmb3IgInBhcmVudCIuCisKIDIwMjEtMTItMjAgIEFsZXhl eSBTaHZheWthICA8YXNodmF5a2FAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJJRExdIGNvbnZl cnRWYXJpYWRpY0FyZ3VtZW50cygpIHNob3VsZCByZXR1cm4gYSBGaXhlZFZlY3RvcgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL3Byb3BlcnRpZXMvU1ZHUHJvcGVydHlBbmltYXRvci5o IGIvU291cmNlL1dlYkNvcmUvc3ZnL3Byb3BlcnRpZXMvU1ZHUHJvcGVydHlBbmltYXRvci5oCmlu ZGV4IDg5MWE0NjY5NjA2NDc2NDUwOGIxYWRmNTA1YjBiYTVmMjUzNTlmNjIuLjYyYTUxOGFlOTlm NzVkYjI2NDNiMDgwNTc2MWM4NjI1NmE0YjU1NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3N2Zy9wcm9wZXJ0aWVzL1NWR1Byb3BlcnR5QW5pbWF0b3IuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9zdmcvcHJvcGVydGllcy9TVkdQcm9wZXJ0eUFuaW1hdG9yLmgKQEAgLTg5LDcgKzg5LDcgQEAg cHJvdGVjdGVkOgogCiAgICAgU3RyaW5nIGNvbXB1dGVJbmhlcml0ZWRDU1NQcm9wZXJ0eVZhbHVl KFNWR0VsZW1lbnQmIHRhcmdldEVsZW1lbnQpIGNvbnN0CiAgICAgewotICAgICAgICBSZWZQdHIg cGFyZW50ID0gdGFyZ2V0RWxlbWVudC5wYXJlbnRFbGVtZW50KCk7CisgICAgICAgIGF1dG8qIHBh cmVudCA9IHRhcmdldEVsZW1lbnQucGFyZW50RWxlbWVudCgpOwogICAgICAgICBpZiAoIXBhcmVu dCB8fCAhcGFyZW50LT5pc1NWR0VsZW1lbnQoKSkKICAgICAgICAgICAgIHJldHVybiBlbXB0eVN0 cmluZygpOwogICAgICAgICAK 450563 2022-02-01 13:35:29 -0800 2022-02-01 14:49:08 -0800 Patch bug-234546-20220202063528.patch text/plain 1985 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4ODYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDAxODc5MzBiOGEyN2M4 YTE3ODEwMjU5YTNmNjZjMmNkNTVjNjg3My4uNTZlODRjMjllMjZhZDhiMGFhMGJhZGU5NThkMDhm MWU4N2I3MDYyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIyLTAyLTAxICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIE1TVkMgcmVw b3J0cyAiU1ZHUHJvcGVydHlBbmltYXRvci5oKDk0KTogZXJyb3IgQzI4Mzk6IGludmFsaWQgcmV0 dXJuIHR5cGUgJ1QgKicgZm9yIG92ZXJsb2FkZWQgJ29wZXJhdG9yIC0+JyIgd2l0aCAvc3RkOmMr KzIwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ1 NDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg2NzU3ODA1PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIyODczMDAgd2FzIGEgd3JvbmcgZml4IHRo YXQgdXNlZCBhIHJhdyBwb2ludGVyIHRvIHdvcmsgYXJvdW5kIGFuCisgICAgICAgIE1TVkMncyBS ZWZQdHIgY29tcGlsYXRpb24gZXJyb3IuIFdlIHNob3VsZCB1c2Ugc21hcnQgcG9pbnRlcnMgZm9y CisgICAgICAgIGxvY2FsIHZhcmlhYmxlcy4KKworICAgICAgICBUaGlzIHNlZW1zIGEgTVNWQyBi dWcgdGhhdCB0aGUgY2xhc3MgdGVtcGxhdGUgYXJndW1lbnQgZGVkdWN0aW9uCisgICAgICAgIGRv ZXNuJ3Qgd29yayBpbiB0aGlzIGNhc2UuIEV4cGxpY2l0bHkgc3BlY2lmeWluZyBhIGNsYXNzIHRl bXBsYXRlCisgICAgICAgIGFyZ3VtZW50IGlzIGEgd29ya2Fyb3VuZC4KKworICAgICAgICAqIHN2 Zy9wcm9wZXJ0aWVzL1NWR1Byb3BlcnR5QW5pbWF0b3IuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNW R1Byb3BlcnR5QW5pbWF0b3I6OmNvbXB1dGVJbmhlcml0ZWRDU1NQcm9wZXJ0eVZhbHVlIGNvbnN0 KToKKyAgICAgICAgQ2hhbmdlZCB0aGUgdHlwZSBvZiB0aGUgbG9jYWwgdmFyaWFibGUgJ3BhcmVu dCcgZnJvbSBhIHJhdyBwb2ludGVyCisgICAgICAgIHRvIFJlZlB0cjxFbGVtZW50Pi4KKwogMjAy Mi0wMS0zMSAgQW5kcmVzIEdvbnphbGV6ICA8YW5kcmVzZ18yMkBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIHRvIEFYTG9nZ2VyIHRoZSBhYmlsaXR5IHRvIGxvZyBvbmx5IGZyb20gdGhlIHNwZWNp ZmllZCB0aHJlYWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvcHJvcGVydGllcy9T VkdQcm9wZXJ0eUFuaW1hdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcvcHJvcGVydGllcy9TVkdQ cm9wZXJ0eUFuaW1hdG9yLmgKaW5kZXggNjJhNTE4YWU5OWY3NWRiMjY0M2IwODA1NzYxYzg2MjU2 YTRiNTU0NC4uY2Q4ZTAzZWE3MTI4ZTg5NzBmZmJkNGJhZTAzZjkxZWIxZjE1NTFjMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL3Byb3BlcnRpZXMvU1ZHUHJvcGVydHlBbmltYXRvci5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0aWVzL1NWR1Byb3BlcnR5QW5pbWF0b3Iu aApAQCAtODksNyArODksNyBAQCBwcm90ZWN0ZWQ6CiAKICAgICBTdHJpbmcgY29tcHV0ZUluaGVy aXRlZENTU1Byb3BlcnR5VmFsdWUoU1ZHRWxlbWVudCYgdGFyZ2V0RWxlbWVudCkgY29uc3QKICAg ICB7Ci0gICAgICAgIGF1dG8qIHBhcmVudCA9IHRhcmdldEVsZW1lbnQucGFyZW50RWxlbWVudCgp OworICAgICAgICBSZWZQdHI8RWxlbWVudD4gcGFyZW50ID0gdGFyZ2V0RWxlbWVudC5wYXJlbnRF bGVtZW50KCk7CiAgICAgICAgIGlmICghcGFyZW50IHx8ICFwYXJlbnQtPmlzU1ZHRWxlbWVudCgp KQogICAgICAgICAgICAgcmV0dXJuIGVtcHR5U3RyaW5nKCk7CiAgICAgICAgIAo=