233834 2021-12-03 11:54:26 -0800 JSErrorHandler should not set window.event if invocation target is in shadow tree 2021-12-10 14:23:30 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build All All RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/31893 https://bugs.webkit.org/show_bug.cgi?id=186266 InRadar P2 Trivial --- 1 ashvayka ashvayka clopez ews-watchlist rniwa webkit-bug-importer youennf oldest_to_newest 1820255 0 ashvayka 2021-12-03 11:54:26 -0800 JSErrorHandler should not set window.event if invocation target is in shadow tree 1820256 1 445886 ashvayka 2021-12-03 11:55:18 -0800 Created attachment 445886 Patch 1820257 2 ews-watchlist 2021-12-03 11:56:26 -0800 This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess 1820387 3 445886 rniwa 2021-12-03 17:33:31 -0800 Comment on attachment 445886 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445886&action=review > LayoutTests/imported/w3c/ChangeLog:9 > + * web-platform-tests/dom/events/event-global-expected.txt: > + * web-platform-tests/dom/events/event-global.html: Is this merging upstream change? Or are you making a WPT change? It's unclear from the change log. 1820395 4 ashvayka 2021-12-03 18:11:29 -0800 (In reply to Ryosuke Niwa from comment #3) Thanks Ryosuke! > Is this merging upstream change? Or are you making a WPT change? It's > unclear from the change log. We are exporting the tests; I will make sure to note that in ChangeLog. 1820437 5 rniwa 2021-12-03 23:52:14 -0800 (In reply to Alexey Shvayka from comment #4) > (In reply to Ryosuke Niwa from comment #3) > > Thanks Ryosuke! > > > Is this merging upstream change? Or are you making a WPT change? It's > > unclear from the change log. > > We are exporting the tests; I will make sure to note that in ChangeLog. Okay, in that case, please be sure to land WPT side of change first. 1822862 6 webkit-bug-importer 2021-12-10 11:55:19 -0800 <rdar://problem/86333697> 1822933 7 ashvayka 2021-12-10 13:24:51 -0800 Committed r286871 (245102@trunk): <https://commits.webkit.org/245102@trunk> 445886 2021-12-03 11:55:18 -0800 2021-12-03 17:33:31 -0800 Patch bug-233834-20211203195517.patch text/plain 5275 ashvayka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NjQ1NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIxLTEyLTAzICBBbGV4ZXkg U2h2YXlrYSAgPGFzaHZheWthQGFwcGxlLmNvbT4KKworICAgICAgICBKU0Vycm9ySGFuZGxlciBz aG91bGQgbm90IHNldCB3aW5kb3cuZXZlbnQgaWYgaW52b2NhdGlvbiB0YXJnZXQgaXMgaW4gc2hh ZG93IHRyZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzMzgzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgcGF0Y2ggYnJpbmdzIHIyMzM0ODkgZm9yIEpTRXJyb3JIYW5kbGVyICh3aW5kb3cub25l cnJvciBoYW5kbGVyIGZvciBFcnJvckV2ZW50KSwKKyAgICAgICAgaW1wbGVtZW50aW5nIHRoZSBz cGVjIFsxXSBhbmQgYWxpZ25pbmcgV2ViS2l0IHdpdGggQmxpbmsgYW5kIEdlY2tvLgorCisgICAg ICAgIFsxXSBodHRwczovL2RvbS5zcGVjLndoYXR3Zy5vcmcvI3JlZi1mb3Itd2luZG93LWN1cnJl bnQtZXZlbnQlRTIlOTElQTEKKworICAgICAgICBUZXN0OiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2RvbS9ldmVudHMvZXZlbnQtZ2xvYmFsLmh0bWwKKworICAgICAgICAqIGJpbmRp bmdzL2pzL0pTRXJyb3JIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRXJyb3JIYW5k bGVyOjpoYW5kbGVFdmVudCk6CisKIDIwMjEtMTItMDIgIERldmluIFJvdXNzbyAgPGRyb3Vzc29A YXBwbGUuY29tPgogCiAgICAgICAgIFtBcHBsZSBQYXldIHJlY3VycmluZyBsaW5lIGl0ZW1zIGFw cGVhciB3YXkgaW4gdGhlIGZ1dHVyZQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMv SlNFcnJvckhhbmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTRXJyb3JIYW5kbGVyLmNwcAkocmV2aXNpb24gMjg2NDU0KQorKysgU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNFcnJvckhhbmRsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NCw3 ICs4NCwxMCBAQCB2b2lkIEpTRXJyb3JIYW5kbGVyOjpoYW5kbGVFdmVudChTY3JpcHRFCiAgICAg ICAgIGF1dG8qIGpzRnVuY3Rpb25XaW5kb3cgPSBqc0R5bmFtaWNDYXN0PEpTRE9NV2luZG93Kj4o dm0sIGpzRnVuY3Rpb24tPmdsb2JhbE9iamVjdCgpKTsKICAgICAgICAgaWYgKGpzRnVuY3Rpb25X aW5kb3cpIHsKICAgICAgICAgICAgIHNhdmVkRXZlbnQgPSBqc0Z1bmN0aW9uV2luZG93LT5jdXJy ZW50RXZlbnQoKTsKLSAgICAgICAgICAgIGpzRnVuY3Rpb25XaW5kb3ctPnNldEN1cnJlbnRFdmVu dCgmZXZlbnQpOworCisgICAgICAgICAgICAvLyB3aW5kb3cuZXZlbnQgc2hvdWxkIG5vdCBiZSBz ZXQgd2hlbiB0aGUgdGFyZ2V0IGlzIGluc2lkZSBhIHNoYWRvdyB0cmVlLCBhcyBwZXIgdGhlIERP TSBzcGVjaWZpY2F0aW9uLgorICAgICAgICAgICAgaWYgKCFldmVudC5jdXJyZW50VGFyZ2V0SXNJ blNoYWRvd1RyZWUoKSkKKyAgICAgICAgICAgICAgICBqc0Z1bmN0aW9uV2luZG93LT5zZXRDdXJy ZW50RXZlbnQoJmV2ZW50KTsKICAgICAgICAgfQogCiAgICAgICAgIGF1dG8mIGVycm9yRXZlbnQg PSBkb3duY2FzdDxFcnJvckV2ZW50PihldmVudCk7CkluZGV4OiBMYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2MvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2ltcG9ydGVkL3czYy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI4NjUwNikKKysrIExheW91dFRlc3RzL2ltcG9ydGVkL3czYy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAyMS0xMi0wMyAgQWxl eGV5IFNodmF5a2EgIDxhc2h2YXlrYUBhcHBsZS5jb20+CisKKyAgICAgICAgSlNFcnJvckhhbmRs ZXIgc2hvdWxkIG5vdCBzZXQgd2luZG93LmV2ZW50IGlmIGludm9jYXRpb24gdGFyZ2V0IGlzIGlu IHNoYWRvdyB0cmVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzM4MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRzL2V2ZW50LWdsb2JhbC1leHBlY3Rl ZC50eHQ6CisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ldmVudHMvZXZlbnQtZ2xv YmFsLmh0bWw6CisKIDIwMjEtMTItMDMgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGln YWxpYS5jb20+CiAKICAgICAgICAgW2Nzcy1mbGV4Ym94XSBXUFQgaW1wb3J0LiBEZWNlbWJlciAy MDIxIGVkaXRpb24KSW5kZXg6IExheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvZG9tL2V2ZW50cy9ldmVudC1nbG9iYWwtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL2V2ZW50cy9l dmVudC1nbG9iYWwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAyODY0NTQpCisrKyBMYXlvdXRUZXN0 cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ldmVudHMvZXZlbnQtZ2xvYmFs LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMyw2ICszLDcgQEAgUEFTUyBldmVudCBl eGlzdHMgb24gd2luZG93LCB3aGljaCBpcyBpbgogUEFTUyB3aW5kb3cuZXZlbnQgaXMgb25seSBk ZWZpbmVkIGR1cmluZyBkaXNwYXRjaAogUEFTUyB3aW5kb3cuZXZlbnQgaXMgdW5kZWZpbmVkIGlm IHRoZSB0YXJnZXQgaXMgaW4gYSBzaGFkb3cgdHJlZSAoZXZlbnQgZGlzcGF0Y2hlZCBvdXRzaWRl IHNoYWRvdyB0cmVlKQogUEFTUyB3aW5kb3cuZXZlbnQgaXMgdW5kZWZpbmVkIGlmIHRoZSB0YXJn ZXQgaXMgaW4gYSBzaGFkb3cgdHJlZSAoZXZlbnQgZGlzcGF0Y2hlZCBpbnNpZGUgc2hhZG93IHRy ZWUpCitQQVNTIHdpbmRvdy5ldmVudCBpcyB1bmRlZmluZWQgaW5zaWRlIHdpbmRvdy5vbmVycm9y IGlmIHRoZSB0YXJnZXQgaXMgaW4gYSBzaGFkb3cgdHJlZSAoRXJyb3JFdmVudCBkaXNwYXRjaGVk IGluc2lkZSBzaGFkb3cgdHJlZSkKIFBBU1Mgd2luZG93LmV2ZW50IGlzIHNldCB0byB0aGUgY3Vy cmVudCBldmVudCBkdXJpbmcgZGlzcGF0Y2gKIFBBU1Mgd2luZG93LmV2ZW50IGlzIHNldCB0byB0 aGUgY3VycmVudCBldmVudCwgd2hpY2ggaXMgdGhlIGV2ZW50IHBhc3NlZCB0byBkaXNwYXRjaAog CkluZGV4OiBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9l dmVudHMvZXZlbnQtZ2xvYmFsLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRzL2V2ZW50LWdsb2JhbC5odG1sCShy ZXZpc2lvbiAyODY0NTQpCisrKyBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2RvbS9ldmVudHMvZXZlbnQtZ2xvYmFsLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTUs NiArNSw4IEBACiA8c2NyaXB0IHNyYz0iL3Jlc291cmNlcy90ZXN0aGFybmVzc3JlcG9ydC5qcyI+ PC9zY3JpcHQ+CiA8ZGl2IGlkPWxvZz48L2Rpdj4KIDxzY3JpcHQ+CitzZXR1cCh7YWxsb3dfdW5j YXVnaHRfZXhjZXB0aW9uOiB0cnVlfSk7CisKIHRlc3QodCA9PiB7CiAgIGFzc2VydF9vd25fcHJv cGVydHkod2luZG93LCAiZXZlbnQiKTsKICAgYXNzZXJ0X2VxdWFscyh3aW5kb3cuZXZlbnQsIHVu ZGVmaW5lZCk7CkBAIC02Myw2ICs2NSwzMCBAQCBhc3luY190ZXN0KHQgPT4gewogfSwgIndpbmRv dy5ldmVudCBpcyB1bmRlZmluZWQgaWYgdGhlIHRhcmdldCBpcyBpbiBhIHNoYWRvdyB0cmVlIChl dmVudCBkaXNwYXRjaGVkIGluc2lkZSBzaGFkb3cgdHJlZSkiKTsKIAogYXN5bmNfdGVzdCh0ID0+ IHsKKyAgbGV0IHBhcmVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOworICBsZXQg cm9vdCA9IHBhcmVudC5hdHRhY2hTaGFkb3coe21vZGU6ICJvcGVuIn0pOworICBkb2N1bWVudC5i b2R5LmFwcGVuZChwYXJlbnQpCisgIGxldCBzcGFuID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgi c3BhbiIpOworICByb290LmFwcGVuZChzcGFuKTsKKyAgbGV0IHNoYWRvd05vZGUgPSByb290LmZp cnN0RWxlbWVudENoaWxkOworCisgIHNoYWRvd05vZGUuYWRkRXZlbnRMaXN0ZW5lcigiZXJyb3Ii LCB0LnN0ZXBfZnVuYyhlID0+IHsKKyAgICBhc3NlcnRfbm90X2VxdWFscyh3aW5kb3cuZXZlbnQs IGUpOworICAgIGFzc2VydF9lcXVhbHMod2luZG93LmV2ZW50LCB1bmRlZmluZWQpOworICB9KSk7 CisKKyAgbGV0IHdpbmRvd09uRXJyb3JDYWxsZWQgPSBmYWxzZTsKKyAgd2luZG93Lm9uZXJyb3Ig PSB0LnN0ZXBfZnVuY19kb25lKCgpID0+IHsKKyAgICB3aW5kb3dPbkVycm9yQ2FsbGVkID0gdHJ1 ZTsKKyAgICBhc3NlcnRfZXF1YWxzKHR5cGVvZiB3aW5kb3cuZXZlbnQsICJvYmplY3QiKTsKKyAg ICBhc3NlcnRfZXF1YWxzKHdpbmRvdy5ldmVudC50eXBlLCAiZXJyb3IiKTsKKyAgfSk7CisKKyAg c2hhZG93Tm9kZS5kaXNwYXRjaEV2ZW50KG5ldyBFcnJvckV2ZW50KCJlcnJvciIsIHtjb21wb3Nl ZDogdHJ1ZSwgYnViYmxlczogdHJ1ZX0pKTsKKyAgYXNzZXJ0X3RydWUod2luZG93T25FcnJvckNh bGxlZCk7Cit9LCAid2luZG93LmV2ZW50IGlzIHVuZGVmaW5lZCBpbnNpZGUgd2luZG93Lm9uZXJy b3IgaWYgdGhlIHRhcmdldCBpcyBpbiBhIHNoYWRvdyB0cmVlIChFcnJvckV2ZW50IGRpc3BhdGNo ZWQgaW5zaWRlIHNoYWRvdyB0cmVlKSIpOworCithc3luY190ZXN0KHQgPT4gewogICBsZXQgdGFy Z2V0MSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICBsZXQgdGFyZ2V0MiA9IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogCg==