233320 2021-11-18 10:17:54 -0800 Update shadow DOM and dialog element focusing to latest spec 2022-07-29 13:01:32 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 233777 148695 84635 1 d ntim ashvayka cdumez d jouni ntim rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1816498 0 d 2021-11-18 10:17:54 -0800 The spec was previously not shadow DOM aware. In https://github.com/whatwg/html/pull/7285 we made it behave the same as delegatesFocus: they both "delegate focus" to either autofocus="" if it's specified on a (non-shadow-including) descendant, or the first focusable element among their shadow-including descendants if not. Tests: https://github.com/web-platform-tests/wpt/pull/31523 1817822 1 webkit-bug-importer 2021-11-25 10:18:18 -0800 <rdar://problem/85753180> 1835542 2 d 2022-01-31 08:15:55 -0800 After https://github.com/whatwg/html/pull/7361 and https://github.com/web-platform-tests/wpt/pull/31724 I believe this algorithm is now in good shape and implementable. 1848700 3 jouni 2022-03-07 05:35:26 -0800 I’m not entirely sure this is 100% related or worthy a new bug report, but there’s an issue in Safari Tech Preview 141, when the dialog and the content of the dialog are in different DOM "scopes" (light DOM vs shadow DOM). The content is not focusable at all using the Tab key, and the dialog is not closed when clicking a button inside a <form method="dialog">. Here’s a test case I created for the four different cases: https://jsbin.com/finugon/ - Dialog and content in light DOM (works) - Dialog in light DOM, content in shadow DOM (broken) - Dialog and content in shadow DOM (works) - Dialog in shadow DOM, content in light DOM (slotted) (broken) 1887468 4 ntim 2022-07-28 15:33:14 -0700 Pull request: https://github.com/WebKit/WebKit/pull/2828 1887732 5 ews-feeder 2022-07-29 13:01:30 -0700 Committed 252959@main (696e8c1c47e2): <https://commits.webkit.org/252959@main> Reviewed commits have been landed. Closing PR #2828 and removing active labels.