23283 2009-01-12 21:23:38 -0800 Optimize RenderBox::localToAbsoluteQuad() to use LayoutState 2009-03-12 11:26:57 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 24163 1 simon.fraser simon.fraser mitz oldest_to_newest 105441 0 simon.fraser 2009-01-12 21:23:38 -0800 RenderBox::localToAbsoluteQuad() shows up in some profiles for deeply nested content. It should be fixed to use LayoutState when possible. 105442 1 26660 simon.fraser 2009-01-12 21:30:01 -0800 Created attachment 26660 Patch, changelog 108713 2 26660 eric 2009-02-06 14:01:00 -0800 Comment on attachment 26660 Patch, changelog This looks sane to me. I can't promise I'm an expert in this code though. You might yet want Hyatt or Mitz to look at this. But as I said above, it looks right by my eyes. 113427 3 simon.fraser 2009-03-12 11:26:57 -0700 Got done as part of the patch in bug 24163. 26660 2009-01-12 21:30:01 -0800 2009-02-06 14:01:00 -0800 Patch, changelog 23283_patch.txt text/plain 1498 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTFkNDJkOC4uMzFkYjBiMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wMS0xMiAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMyODMKKworICAgICAgICBGaXggUmVuZGVyQm94Ojpsb2NhbFRvQWJzb2x1dGVRdWFkKCkg dG8gdXNlIExheW91dFN0YXRlCisgICAgICAgIHdoZW4gcG9zc2libGUuCisgICAgICAgIAorICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy Qm94Ojpsb2NhbFRvQWJzb2x1dGVRdWFkKToKKwogMjAwOS0wMS0xMiAgQ2hyaXMgTWFycmluICA8 Y21hcnJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCb3guY3BwCmluZGV4IGRhY2RmMTIuLjk3NjlhNTcgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94LmNwcApAQCAtMTA1NSw2ICsxMDU1LDE5IEBAIEZsb2F0UG9pbnQgUmVuZGVyQm94 OjphYnNvbHV0ZVRvTG9jYWwoRmxvYXRQb2ludCBjb250YWluZXJQb2ludCwgYm9vbCBmaXhlZCwg Ym9vCiAKIEZsb2F0UXVhZCBSZW5kZXJCb3g6OmxvY2FsVG9BYnNvbHV0ZVF1YWQoY29uc3QgRmxv YXRRdWFkJiBsb2NhbFF1YWQsIGJvb2wgZml4ZWQpIGNvbnN0CiB7CisgICAgaWYgKFJlbmRlclZp ZXcqIHYgPSB2aWV3KCkpIHsKKyAgICAgICAgaWYgKHYtPmxheW91dFN0YXRlRW5hYmxlZCgpKSB7 CisgICAgICAgICAgICBMYXlvdXRTdGF0ZSogbGF5b3V0U3RhdGUgPSB2LT5sYXlvdXRTdGF0ZSgp OworICAgICAgICAgICAgSW50U2l6ZSBvZmZzZXQgPSBsYXlvdXRTdGF0ZS0+bV9vZmZzZXQ7Cisg ICAgICAgICAgICBvZmZzZXQuZXhwYW5kKG1feCwgbV95KTsKKyAgICAgICAgICAgIGlmIChzdHls ZSgpLT5wb3NpdGlvbigpID09IFJlbGF0aXZlUG9zaXRpb24gJiYgbV9sYXllcikKKyAgICAgICAg ICAgICAgICBvZmZzZXQgKz0gbV9sYXllci0+cmVsYXRpdmVQb3NpdGlvbk9mZnNldCgpOworICAg ICAgICAgICAgRmxvYXRRdWFkIHF1YWQgPSBsb2NhbFF1YWQ7CisgICAgICAgICAgICBxdWFkLm1v dmUob2Zmc2V0KTsKKyAgICAgICAgICAgIHJldHVybiBxdWFkOworICAgICAgICB9CisgICAgfQor CiAgICAgaWYgKHN0eWxlKCktPnBvc2l0aW9uKCkgPT0gRml4ZWRQb3NpdGlvbikKICAgICAgICAg Zml4ZWQgPSB0cnVlOwogCg==