232555 2021-10-31 22:34:13 -0700 [WinCairo] Enable gpu_process_canvas_rendering and gpu_process_webgl by default 2021-11-01 15:09:20 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii don.olmstead kkinnunen ross.kirsling simon.fraser webkit-bug-importer oldest_to_newest 1810555 0 fujii 2021-10-31 22:34:13 -0700 [WinCairo] Enable gpu_process_canvas_rendering and gpu_process_webgl by default 1810557 1 442959 fujii 2021-10-31 22:38:37 -0700 Created attachment 442959 Patch 1810767 2 442959 don.olmstead 2021-11-01 12:36:56 -0700 Comment on attachment 442959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442959&action=review Think there's a better way to address this. As an aside it would be nice to be able to set these registry values through the MiniBrowser. > Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:164 > -#if ENABLE(GPU_PROCESS_BY_DEFAULT) > +#if ENABLE(GPU_PROCESS_BY_DEFAULT) || PLATFORM(WIN) Can't we just add `ENABLE_GPU_PROCESS_BY_DEFAULT` in the CMake code? > Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:196 > - return isFeatureFlagEnabled("gpu_process_webgl", false); > +#if PLATFORM(WIN) > + bool defaultValue = true; > +#else > + bool defaultValue = false; > +#endif > + return isFeatureFlagEnabled("gpu_process_webgl", defaultValue); Couldn't this be written in terms of `ENABLE(GPU_PROCESS_BY_DEFAULT)`? Maybe need to ask the Apple folks if this is ok. > Source/WebKit/Shared/win/WebPreferencesDefaultValuesWin.cpp:46 > - return false; > + return defaultValue; > if (keyType != REG_DWORD) > - return false; > + return defaultValue; > if (dataSize != sizeof data) > - return false; > + return defaultValue; Whoops! This is a good catch here. 1810828 3 442959 simon.fraser 2021-11-01 12:56:40 -0700 Comment on attachment 442959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442959&action=review >> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:196 >> + return isFeatureFlagEnabled("gpu_process_webgl", defaultValue); > > Couldn't this be written in terms of `ENABLE(GPU_PROCESS_BY_DEFAULT)`? > > Maybe need to ask the Apple folks if this is ok. I don't think we want the default to be true if ENABLE(GPU_PROCESS_BY_DEFAULT) is defined. We switch WebGL independently from the other GPU Process things. 1810831 4 442959 don.olmstead 2021-11-01 13:07:10 -0700 Comment on attachment 442959 Patch After getting more info on what Apple is up to with that ENABLE_GPU_PROCESS_BY_DEFAULT I agree that wee should just use PLATFORM(WIN) here. Changing my review 1810840 5 ews-feeder 2021-11-01 13:32:58 -0700 Committed r285127 (243766@main): <https://commits.webkit.org/243766@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442959. 1810842 6 webkit-bug-importer 2021-11-01 13:33:37 -0700 <rdar://problem/84896922> 1810845 7 fujii 2021-11-01 13:35:48 -0700 Thank you for the review. (In reply to Don Olmstead from comment #2) > As an aside it would be nice to be able to set these registry values through > the MiniBrowser. I'd like to remove WinCairo WK2 non-GPU process mode support. WinCairo supports WK1 that supports only non-GPU process mode. 1810902 8 don.olmstead 2021-11-01 15:09:20 -0700 (In reply to Fujii Hironori from comment #7) > Thank you for the review. > > (In reply to Don Olmstead from comment #2) > > As an aside it would be nice to be able to set these registry values through > > the MiniBrowser. > > I'd like to remove WinCairo WK2 non-GPU process mode support. > WinCairo supports WK1 that supports only non-GPU process mode. Agreed to removing non-GPU Process mode support. The comment was not just about GPU Process feature flags it was about not having a good way to set any feature flags in MiniBrowser. 442959 2021-10-31 22:38:37 -0700 2021-11-01 13:32:59 -0700 Patch bug-232555-20211101143836.patch text/plain 3025 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNjYTNjOWVkZmY0MmY4Mzhl N2Q1M2FlMDlhNTcyNjIwZjFmODQ1M2YuLmMyYmE0ZThjMTU5YjdkNTU1ODFhMzIzYjI3YTExYWVj ZmNhZTU1YzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMTAtMzEgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBF bmFibGUgZ3B1X3Byb2Nlc3NfY2FudmFzX3JlbmRlcmluZyBhbmQgZ3B1X3Byb2Nlc3Nfd2ViZ2wg YnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMyNTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhleSBjYW4gYmUgZGlzYWJsZWQgYnkgdGhlIHJlZ2lzdHJ5LgorCisgICAgICAgID4gcmVn IGFkZCBIS0VZX0NVUlJFTlRfVVNFUlxTb2Z0d2FyZVxXZWJLaXQgL3YgZ3B1X3Byb2Nlc3NfY2Fu dmFzX3JlbmRlcmluZyAvdCBSRUdfRFdPUkQgL2QgMCAvZgorICAgICAgICA+IHJlZyBhZGQgSEtF WV9DVVJSRU5UX1VTRVJcU29mdHdhcmVcV2ViS2l0IC92IGdwdV9wcm9jZXNzX3dlYmdsIC90IFJF R19EV09SRCAvZCAwIC9mCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0 VmFsdWVzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6ZGVmYXVsdFVzZUdQVVByb2Nlc3NGb3JDYW52 YXNSZW5kZXJpbmdFbmFibGVkKToKKyAgICAgICAgKFdlYktpdDo6ZGVmYXVsdFVzZUdQVVByb2Nl c3NGb3JXZWJHTEVuYWJsZWQpOgorICAgICAgICAqIFNoYXJlZC93aW4vV2ViUHJlZmVyZW5jZXNE ZWZhdWx0VmFsdWVzV2luLmNwcDoKKyAgICAgICAgKFdlYktpdDo6aXNGZWF0dXJlRmxhZ0VuYWJs ZWQpOgorCiAyMDIxLTEwLTMxICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnku Y29tPgogCiAgICAgICAgIFtXaW5DYWlyb10gTmV3IEdyYXBoaWNzTGF5ZXIgZm9yIEdQVSBwcm9j ZXNzIG1vZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2Vz RGVmYXVsdFZhbHVlcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0Rl ZmF1bHRWYWx1ZXMuY3BwCmluZGV4IGUwYzcyYzJkMGQ5MDgzZGQ3YjFmZTVmNDQwOWFjZjJkNmMy NTY5NDAuLmU3YWQ4NjhlNGRhZTc1YjllZDk3ODA4NTVhNGZlZmE3MzQwZWExYWQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5jcHAK KysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmNw cApAQCAtMTYxLDcgKzE2MSw3IEBAIGJvb2wgZGVmYXVsdE9mZmxpbmVXZWJBcHBsaWNhdGlvbkNh Y2hlRW5hYmxlZCgpCiAKIGJvb2wgZGVmYXVsdFVzZUdQVVByb2Nlc3NGb3JDYW52YXNSZW5kZXJp bmdFbmFibGVkKCkKIHsKLSNpZiBFTkFCTEUoR1BVX1BST0NFU1NfQllfREVGQVVMVCkKKyNpZiBF TkFCTEUoR1BVX1BST0NFU1NfQllfREVGQVVMVCkgfHwgUExBVEZPUk0oV0lOKQogICAgIGJvb2wg ZGVmYXVsdFZhbHVlID0gdHJ1ZTsKICNlbHNlCiAgICAgYm9vbCBkZWZhdWx0VmFsdWUgPSBmYWxz ZTsKQEAgLTE4OCw3ICsxODgsMTIgQEAgYm9vbCBkZWZhdWx0VXNlR1BVUHJvY2Vzc0Zvck1lZGlh RW5hYmxlZCgpCiAKIGJvb2wgZGVmYXVsdFVzZUdQVVByb2Nlc3NGb3JXZWJHTEVuYWJsZWQoKQog ewotICAgIHJldHVybiBpc0ZlYXR1cmVGbGFnRW5hYmxlZCgiZ3B1X3Byb2Nlc3Nfd2ViZ2wiLCBm YWxzZSk7CisjaWYgUExBVEZPUk0oV0lOKQorICAgIGJvb2wgZGVmYXVsdFZhbHVlID0gdHJ1ZTsK KyNlbHNlCisgICAgYm9vbCBkZWZhdWx0VmFsdWUgPSBmYWxzZTsKKyNlbmRpZgorICAgIHJldHVy biBpc0ZlYXR1cmVGbGFnRW5hYmxlZCgiZ3B1X3Byb2Nlc3Nfd2ViZ2wiLCBkZWZhdWx0VmFsdWUp OwogfQogCiAjZW5kaWYgLy8gRU5BQkxFKEdQVV9QUk9DRVNTKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9TaGFyZWQvd2luL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlc1dpbi5jcHAgYi9T b3VyY2UvV2ViS2l0L1NoYXJlZC93aW4vV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzV2luLmNw cAppbmRleCA1ZTA0ZDM0Y2Q0ODA2OGQ1MWVjOTUzNDQ2MDk5MjRmOTdhY2M2YWU1Li40OGU0ZTRi MWJkNjk0OWRlZjFhOTk0NTk2MWMxNGExYWU4ZDYzNTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1NoYXJlZC93aW4vV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzV2luLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L1NoYXJlZC93aW4vV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzV2luLmNw cApAQCAtMzksMTEgKzM5LDExIEBAIGJvb2wgaXNGZWF0dXJlRmxhZ0VuYWJsZWQoY29uc3QgY2hh ciogZmVhdHVyZU5hbWUsIGJvb2wgZGVmYXVsdFZhbHVlKQogICAgIERXT1JEIGtleVR5cGU7CiAg ICAgSFJFU1VMVCBociA9IGdldFJlZ2lzdHJ5VmFsdWUoSEtFWV9DVVJSRU5UX1VTRVIsIEwiU29m dHdhcmVcXFdlYktpdCIsIGZlYXR1cmVOYW1lV2lkZS5kYXRhKCksICZrZXlUeXBlLCAmZGF0YSwg JmRhdGFTaXplKTsKICAgICBpZiAoaHIgIT0gRVJST1JfU1VDQ0VTUykKLSAgICAgICAgcmV0dXJu IGZhbHNlOworICAgICAgICByZXR1cm4gZGVmYXVsdFZhbHVlOwogICAgIGlmIChrZXlUeXBlICE9 IFJFR19EV09SRCkKLSAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICByZXR1cm4gZGVmYXVs dFZhbHVlOwogICAgIGlmIChkYXRhU2l6ZSAhPSBzaXplb2YgZGF0YSkKLSAgICAgICAgcmV0dXJu IGZhbHNlOworICAgICAgICByZXR1cm4gZGVmYXVsdFZhbHVlOwogICAgIHJldHVybiBkYXRhOwog fQogCg==