232525 2021-10-29 22:04:47 -0700 Fuzzy pixel data need to be computed in terms of CSS pixels 2021-12-21 21:16:55 -0800 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 233609 149828 1 simon.fraser simon.fraser gsnedders jbedard mrobinson simon.fraser thorton webkit-bug-importer oldest_to_newest 1810387 0 simon.fraser 2021-10-29 22:04:47 -0700 The fuzzy pixel data probably need to be resolution-independent, so when we use 3x snapshots for iOS and hi-dpi tests, we need to adjust the fuzzy matching accordingly. 1812350 1 webkit-bug-importer 2021-11-05 22:05:17 -0700 <rdar://problem/85095900> 1824032 2 gsnedders 2021-12-14 09:52:07 -0800 see also https://github.com/web-platform-tests/wpt/issues/31457 1826148 3 447759 simon.fraser 2021-12-21 15:56:04 -0800 Created attachment 447759 Patch 1826215 4 ews-feeder 2021-12-21 21:16:52 -0800 Committed r287345 (245487@main): <https://commits.webkit.org/245487@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447759. 447759 2021-12-21 15:56:04 -0800 2021-12-21 21:16:54 -0800 Patch bug-232525-20211221155603.patch text/plain 6281 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MzIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDUzOTQ4Y2RkNGQzYTllZmNiYWMzNmI3YWExYjE5MTIw ZGVkNmM3OC4uNGMxZGY5OGJkMjJkNzI3NWUwOGMyNzk3MjFiMWVhMDlkMDM1MjY0YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDIxLTEyLTIxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIEZ1enp5IHBpeGVsIGRhdGEgbmVlZCB0byBiZSBjb21wdXRlZCBpbiB0ZXJtcyBv ZiBDU1MgcGl4ZWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzI1MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQaXhlbCB0b2xlcmFuY2UgaXMgY29tcHV0ZWQgaW4gQ1NTIHBpeGVscywgc28gaGF2ZSBJ bWFnZURpZmYgZGl2aWRlIHRoZSB0b3RhbCBudW1iZXIgb2YKKyAgICAgICAgZGlmZmVyaW5nIHBp eGVscyBieSB0aGUgc3F1YXJlIG9mIHRoZSBzY2FsZSBmYWN0b3IgKGEgc2luZ2xlIGRpZmZlcmVu dCBwaXhlbCBhdCAxeCBiZWNvbWVzIDQKKyAgICAgICAgZGlmZmVyZW50IHBpeGVscyBhdCAyeCku CisKKyAgICAgICAgKiBJbWFnZURpZmYvSW1hZ2VEaWZmLmNwcDoKKyAgICAgICAgKHByb2Nlc3NJ bWFnZXMpOgorICAgICAgICAqIEltYWdlRGlmZi9QbGF0Zm9ybUltYWdlLmNwcDoKKyAgICAgICAg KEltYWdlRGlmZjo6UGxhdGZvcm1JbWFnZTo6aXNDb21wYXRpYmxlIGNvbnN0KToKKyAgICAgICAg KEltYWdlRGlmZjo6UGxhdGZvcm1JbWFnZTo6ZGlmZmVyZW5jZSk6CisKIDIwMjEtMTItMjEgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgQWxsb3cgYSB3 YXkgdG8gc3BlY2lmeSBhIGN1c3RvbSBwaXhlbCB0b2xlcmFuY2UgaW4gYSByZWYgdGVzdApkaWZm IC0tZ2l0IGEvVG9vbHMvSW1hZ2VEaWZmL0ltYWdlRGlmZi5jcHAgYi9Ub29scy9JbWFnZURpZmYv SW1hZ2VEaWZmLmNwcAppbmRleCA3NGMyMjgxZDk2NDE5ZTc1MGIxMzY4ZTYyY2Q4NDBlZjllYTAx M2NkLi44MzQ0YTc3MWIwODg4MjRkNzRmNGVhOGJmZTcxN2FiYzM4YjlkNmNmIDEwMDY0NAotLS0g YS9Ub29scy9JbWFnZURpZmYvSW1hZ2VEaWZmLmNwcAorKysgYi9Ub29scy9JbWFnZURpZmYvSW1h Z2VEaWZmLmNwcApAQCAtNTgsNiArNTgsOSBAQCBzdGF0aWMgaW50IHByb2Nlc3NJbWFnZXMoc3Rk Ojp1bmlxdWVfcHRyPFBsYXRmb3JtSW1hZ2U+JiYgYWN0dWFsSW1hZ2UsIHN0ZDo6dW5pcQogICAg ICAgICB9IGVsc2UgaWYgKGFjdHVhbEltYWdlLT5oYXNBbHBoYSgpICE9IGJhc2VsaW5lSW1hZ2Ut Pmhhc0FscGhhKCkpIHsKICAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiRXJyb3I6IHRlc3Qg YW5kIHJlZmVyZW5jZSBpbWFnZXMgZGlmZmVyIGluIGFscGhhLiBUZXN0IGltYWdlICVzIGFscGhh LCByZWZlcmVuY2UgaW1hZ2UgJXMgYWxwaGEuXG4iLAogICAgICAgICAgICAgICAgIGFjdHVhbElt YWdlLT5oYXNBbHBoYSgpID8gImhhcyIgOiAiZG9lcyBub3QgaGF2ZSIsIGJhc2VsaW5lSW1hZ2Ut Pmhhc0FscGhhKCkgPyAiaGFzIiA6ICJkb2VzIG5vdCBoYXZlIik7CisgICAgICAgIH0gZWxzZSBp ZiAoYWN0dWFsSW1hZ2UtPnNjYWxlRmFjdG9yKCkgIT0gYmFzZWxpbmVJbWFnZS0+c2NhbGVGYWN0 b3IoKSkgeworICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJFcnJvcjogdGVzdCBhbmQgcmVm ZXJlbmNlIGltYWdlcyBkaWZmZXIgaW4gc2NhbGUgZmFjdG9yLiBUZXN0IGltYWdlIHNjYWxlIGZh Y3RvciAlLjFmLCByZWZlcmVuY2UgaW1hZ2Ugc2NhbGUgZmFjdG9yICUuMWYuXG4iLAorICAgICAg ICAgICAgICAgIGFjdHVhbEltYWdlLT5zY2FsZUZhY3RvcigpLCBiYXNlbGluZUltYWdlLT5zY2Fs ZUZhY3RvcigpKTsKICAgICAgICAgfQogCiAgICAgICAgIHJldHVybiBFWElUX0ZBSUxVUkU7CmRp ZmYgLS1naXQgYS9Ub29scy9JbWFnZURpZmYvUGxhdGZvcm1JbWFnZS5jcHAgYi9Ub29scy9JbWFn ZURpZmYvUGxhdGZvcm1JbWFnZS5jcHAKaW5kZXggYjgyZGU1ODJhNjRjMWM3N2Q5ZTE5ZmZlYzhk YTNkOWQ2MTk5NWM3NS4uNzA5NTM0NWRmNDNiM2MwY2M4ZWY2Yzg1ZDBjYmY1YzMyM2IxNTY0MCAx MDA2NDQKLS0tIGEvVG9vbHMvSW1hZ2VEaWZmL1BsYXRmb3JtSW1hZ2UuY3BwCisrKyBiL1Rvb2xz L0ltYWdlRGlmZi9QbGF0Zm9ybUltYWdlLmNwcApAQCAtMzYsNiArMzYsNyBAQCBib29sIFBsYXRm b3JtSW1hZ2U6OmlzQ29tcGF0aWJsZShjb25zdCBQbGF0Zm9ybUltYWdlJiBvdGhlcikgY29uc3QK IHsKICAgICByZXR1cm4gd2lkdGgoKSA9PSBvdGhlci53aWR0aCgpCiAgICAgICAgICYmIGhlaWdo dCgpID09IG90aGVyLmhlaWdodCgpCisgICAgICAgICYmIHNjYWxlRmFjdG9yKCkgPT0gb3RoZXIu c2NhbGVGYWN0b3IoKQogICAgICAgICAmJiByb3dCeXRlcygpID09IG90aGVyLnJvd0J5dGVzKCkK ICAgICAgICAgJiYgaGFzQWxwaGEoKSA9PSBvdGhlci5oYXNBbHBoYSgpOwogfQpAQCAtMTA1LDYg KzEwNiw5IEBAIHN0ZDo6dW5pcXVlX3B0cjxQbGF0Zm9ybUltYWdlPiBQbGF0Zm9ybUltYWdlOjpk aWZmZXJlbmNlKGNvbnN0IFBsYXRmb3JtSW1hZ2UmIG90CiAgICAgICAgICAgICBkaWZmUGl4ZWxb cF0gPSBzdGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyPihwaXhlbCk7CiAgICAgICAgIH0KIAorICAg ICAgICAvLyB0b3RhbFBpeGVscyBpcyAiQ1NTIHBpeGVscyIgb3IgInBvaW50cyIuCisgICAgICAg IGRpZmZlcmVuY2UudG90YWxQaXhlbHMgLz0gKHNjYWxlRmFjdG9yKCkgKiBzY2FsZUZhY3Rvcigp KTsKKwogICAgICAgICByZXR1cm4gUGxhdGZvcm1JbWFnZTo6Y3JlYXRlRnJvbURpZmZEYXRhKGRp ZmZCdWZmZXIsIHdpZHRoLCBoZWlnaHQpOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDQ2NGFkNjdlZGUyZmQz ZWI0OWE3MjdjZTI3ZTJlMGI1NjVmNmNlNjMuLjU2ZWIzMmRhNzA5ZDAyOGRiMjA4NzM5NzgwNmZj MGVkNTgzMjIyNzQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMS0xMi0yMSAgU2ltb24gRnJh c2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBGdXp6eSBwaXhlbCBkYXRh IG5lZWQgdG8gYmUgY29tcHV0ZWQgaW4gdGVybXMgb2YgQ1NTIHBpeGVscworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyNTI1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgaGlkcGkgcGl4ZWwgdG9s ZXJhbmNlIHRlc3QuCisKKyAgICAgICAgKiBmYXN0L2hhcm5lc3MvaW1hZ2UtZGlmZi9oaWRwaS1w aXhlbC10b2xlcmFuY2UtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9oYXJu ZXNzL2ltYWdlLWRpZmYvaGlkcGktcGl4ZWwtdG9sZXJhbmNlLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIHBsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9uczogUmVtb3ZlIGZhc3QvaGFybmVz cy9pbWFnZS1kaWZmL2Z1enotMi0yNS5odG1sLgorCiAyMDIxLTEyLTIxICBTaW1vbiBGcmFzZXIg IDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IGEgd2F5IHRvIHNwZWNp ZnkgYSBjdXN0b20gcGl4ZWwgdG9sZXJhbmNlIGluIGEgcmVmIHRlc3QKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvaGFybmVzcy9pbWFnZS1kaWZmL2hpZHBpLXBpeGVsLXRvbGVyYW5jZS1l eHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL2ltYWdlLWRpZmYvaGlkcGkt cGl4ZWwtdG9sZXJhbmNlLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uODI3YTAwZjdkYmFkMmE2 NDc3MWY1OTUwODIxZWNmZjViN2VlMTMwZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvaGFybmVzcy9pbWFnZS1kaWZmL2hpZHBpLXBpeGVsLXRvbGVyYW5jZS1leHBlY3RlZC5o dG1sCkBAIC0wLDAgKzEsMTYgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKyAg ICA8c3R5bGU+CisgICAgICAgIC5ib3ggeworICAgICAgICAgICAgcG9zaXRpb246IHJlbGF0aXZl OworICAgICAgICAgICAgd2lkdGg6IDEwMHB4OworICAgICAgICAgICAgaGVpZ2h0OiAxMDBweDsK KyAgICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IHJnYigwLCAxMjgsIDApOworICAgICAgICB9 CisgICAgPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorICAgIDxkaXYgY2xhc3M9ImJveCI+PC9k aXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2hhcm5l c3MvaW1hZ2UtZGlmZi9oaWRwaS1waXhlbC10b2xlcmFuY2UuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvaGFybmVzcy9pbWFnZS1kaWZmL2hpZHBpLXBpeGVsLXRvbGVyYW5jZS5odG1sCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjgzYTBkZjE3OWIwMGIzYjkwNDU5NGM2MjI5Yzc2MjAyMTBhODZhZTQKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvaW1hZ2UtZGlmZi9oaWRwaS1waXhlbC10 b2xlcmFuY2UuaHRtbApAQCAtMCwwICsxLDI3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGhlYWQ+CisgICAgPG1ldGEgbmFtZT0iZnV6enkiIGNvbnRlbnQ9Im1heERpZmZlcmVuY2U9Mjt0 b3RhbFBpeGVscz0yNSI+CisgICAgPHN0eWxlPgorICAgICAgICAuYm94IHsKKyAgICAgICAgICAg IHBvc2l0aW9uOiByZWxhdGl2ZTsKKyAgICAgICAgICAgIHdpZHRoOiAxMDBweDsKKyAgICAgICAg ICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZ2IoMCwg MTI4LCAwKTsKKyAgICAgICAgfQorCisgICAgICAgIC5taXNtYXRjaC1ib3ggeworICAgICAgICAg ICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAgICAgICAgbWFyZ2luOiAxMHB4OworICAgICAg ICAgICAgd2lkdGg6IDVweDsKKyAgICAgICAgICAgIGhlaWdodDogNXB4OworICAgICAgICAgICAg YmFja2dyb3VuZC1jb2xvcjogcmdiKDAsIDEyNiwgMCk7CisgICAgICAgIH0KKyAgICA8L3N0eWxl PgorPC9oZWFkPgorPGJvZHk+CisgICAgPGRpdiBjbGFzcz0iYm94Ij4KKyAgICAgICAgPGRpdiBj bGFzcz0ibWlzbWF0Y2gtYm94Ij48L2Rpdj4KKyAgICA8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9u cyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA3 Y2MzZDc3N2RkNjBmYjNmMjhkMDUxYjc0M2ExMGJhYWE5Nzk3MjZmLi5jN2E2ZjYyN2E0Yzg2OTRh YTlkMjZjMTVmZmMwOTUzMTBkZDNlZmFjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9z LXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMTEyLDggKzExMTIsNiBAQCBmYXN0L3Njcm9sbGlu Zy9pb3Mvc2Nyb2xsLWV2ZW50cy1iYWNrLWZvcndhcmQtYWZ0ZXItcGFnZXNob3cuaHRtbCBbIFBh c3MgRmFpbHVyZQogCiB3ZWJraXQub3JnL2IvMTU3NTg5IGZhc3QvdGV4dC1hdXRvc2l6aW5nL2lv cy90ZXh0LWF1dG9zaXppbmctYWZ0ZXItYmFjay5odG1sIFsgUGFzcyBUaW1lb3V0IF0KIAotd2Vi a2l0Lm9yZy9iLzIzMjUyNSBmYXN0L2hhcm5lc3MvaW1hZ2UtZGlmZi9mdXp6LTItMjUuaHRtbCBb IEltYWdlT25seUZhaWx1cmUgXQotCiAjIHN0YXJ0ZWQgdG8gZmFpbCBhZnRlciBuZXcgc25hcHNo b3R0aW5nIGluIHIyMDI1MzIKIHdlYmtpdC5vcmcvYi8xNTA5NDIgYW5pbWF0aW9ucy9tdWx0aXBs ZS1iYWNrZ3JvdW5kcy5odG1sIFsgUGFzcyBJbWFnZU9ubHlGYWlsdXJlIF0KIGNvbXBvc2l0aW5n L292ZXJsYXAtYmxlbmRpbmcvcmVmbGVjdGlvbi1vcGFjaXR5LWh1Z2UuaHRtbCBbIEltYWdlT25s eUZhaWx1cmUgXQo=