23250 2009-01-12 07:14:48 -0800 [Qt] NULL string should not be arbitrarily converted to empty string 2014-04-24 16:44:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED DUPLICATE 31863 Qt P2 Normal --- 31863 1 yael webkit-unassigned jedrzej.nowacki oldest_to_newest 105325 0 yael 2009-01-12 07:14:48 -0800 When a QtWebKit based application returns a null string, it is converted to an empty string. From the JavaScript side, it is not possible to tell if the return value was an empty string or null. 105326 1 26630 yael 2009-01-12 07:16:51 -0800 Created attachment 26630 change qt-runtime so it does not convert a null string to an empty string. 105492 2 26630 vestbo 2009-01-13 08:20:47 -0800 Comment on attachment 26630 change qt-runtime so it does not convert a null string to an empty string. > - QCOMPARE(evalJS("myObject.stringProperty"), QString()); > + QCOMPARE(evalJS("myObject.stringProperty"), sUndefined); As discussed on IRC this behavior should apply to QVariants instead. > + if (variant.isNull() ) { > + if (type == QMetaType::QString) > + return jsUndefined(); So that if !variant.isValid() then return jsUndefined(); A default-constructed QVarant is not valid, i.e has the type set to QMetaType::Invalid 105575 3 26684 yael 2009-01-13 14:50:22 -0800 Created attachment 26684 Return jsundefined instead of jsnull. This patch is not a solution to the bug, it was created to allow others to continue experimenting with the problem. In fact it breaks the test case evalJSV("myObject.myInvokableWithVariantArg(null)", type); 166684 4 jedrzej.nowacki 2009-11-26 01:50:17 -0800 Closing as duplicate of bug 31863. Integration between QtWebKit - QtScript is a nicer and more generic solution. If I'm wrong feel free to reopen the bug. *** This bug has been marked as a duplicate of bug 31863 *** 1003837 5 darin 2014-04-24 16:44:55 -0700 Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. 26630 2009-01-12 07:16:51 -0800 2009-01-13 08:20:47 -0800 change qt-runtime so it does not convert a null string to an empty string. null.patch text/plain 3018 yael SW5kZXg6IFdlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcAkocmV2 aXNpb24gMzk4MTEpCisrKyBXZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03ODIsMTAgKzc4MiwxMCBAQAogICAgICAgICAgICAgICAg ICAgICAibXlPYmplY3Quc3RyaW5nUHJvcGVydHkiKSwgUUxhdGluMVN0cmluZygiMTIzIikpOwog ICAgIFFDT01QQVJFKG1fbXlPYmplY3QtPnN0cmluZ1Byb3BlcnR5KCksIFFMYXRpbjFTdHJpbmco IjEyMyIpKTsKICAgICBRQ09NUEFSRShldmFsSlMoIm15T2JqZWN0LnN0cmluZ1Byb3BlcnR5ID0g bnVsbCIpLCBRU3RyaW5nKCkpOwotICAgIFFDT01QQVJFKGV2YWxKUygibXlPYmplY3Quc3RyaW5n UHJvcGVydHkiKSwgUVN0cmluZygpKTsKKyAgICBRQ09NUEFSRShldmFsSlMoIm15T2JqZWN0LnN0 cmluZ1Byb3BlcnR5IiksIHNVbmRlZmluZWQpOwogICAgIFFDT01QQVJFKG1fbXlPYmplY3QtPnN0 cmluZ1Byb3BlcnR5KCksIFFTdHJpbmcoKSk7CiAgICAgUUNPTVBBUkUoZXZhbEpTKCJteU9iamVj dC5zdHJpbmdQcm9wZXJ0eSA9IHVuZGVmaW5lZCIpLCBzVW5kZWZpbmVkKTsKLSAgICBRQ09NUEFS RShldmFsSlMoIm15T2JqZWN0LnN0cmluZ1Byb3BlcnR5IiksIFFTdHJpbmcoKSk7CisgICAgUUNP TVBBUkUoZXZhbEpTKCJteU9iamVjdC5zdHJpbmdQcm9wZXJ0eSIpLCBzVW5kZWZpbmVkKTsKICAg ICBRQ09NUEFSRShtX215T2JqZWN0LT5zdHJpbmdQcm9wZXJ0eSgpLCBRU3RyaW5nKCkpOwogCiAg ICAgUUNPTVBBUkUoZXZhbEpTKCJteU9iamVjdC52YXJpYW50UHJvcGVydHkgPSBuZXcgTnVtYmVy KDEyMzQpOyIKSW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L3F0L0NoYW5nZUxvZwkocmV2aXNpb24gMzk4MjYpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsOSBAQAorMjAwOS0wMS0xMiAgWWFlbCBBaGFyb24gIDx5 YWVsLmFoYXJvbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisgICAgICAgIFVwZGF0ZSBleHBlY3RlZCB0ZXN0IHJlc3VsdHMsIHNpbmNlIGEgTlVMTCBz dHJpbmcgbm93IHJldHVybnMganN1bmRlZmluZWQgaW5zdGVhZCBvZiBhbiBlbXB0eSBzdHJpbmcu CisgICAgICAgICogdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwOgorCiAyMDA5LTAx LTEyICBUb3IgQXJuZSBWZXN0YsO4ICA8dGF2ZXN0Ym9AdHJvbGx0ZWNoLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAzOTgyNikKKysrIFdlYkNv cmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDktMDEtMTIg IFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBXaGVuIHRoZSBhcHBsaWNhdGlvbiByZXR1cm5z IGEgTlVMTCBzdHJpbmcsIGl0IHNob3VsZCByZXR1cm4ganN1bmRlZmluZWQgdG8gSmF2YVNjcmlw dCwgbm90IGFuIGVtcHR5IHN0cmluZy4KKworICAgICAgICAqIGJyaWRnZS9xdC9xdF9ydW50aW1l LmNwcDoKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6OmNvbnZlcnRRVmFyaWFudFRvVmFsdWUpOgor CiAyMDA5LTAxLTEyICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEBwbGV5by5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL2JyaWRnZS9x dC9xdF9ydW50aW1lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50 aW1lLmNwcAkocmV2aXNpb24gMzk4MTEpCisrKyBXZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50aW1l LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzQ1LDEyICs3NDUsMTMgQEAKICAgICBRTWV0YVR5cGU6 OlR5cGUgdHlwZSA9IChRTWV0YVR5cGU6OlR5cGUpIHZhcmlhbnQudXNlclR5cGUoKTsKIAogICAg IHFDb252RGVidWcoKSA8PCAiY29udmVydFFWYXJpYW50VG9WYWx1ZTogbWV0YXR5cGU6IiA8PCB0 eXBlIDw8ICIsIGlzbnVsbDogIiA8PCB2YXJpYW50LmlzTnVsbCgpOwotICAgIGlmICh2YXJpYW50 LmlzTnVsbCgpICYmCi0gICAgICAgIHR5cGUgIT0gUU1ldGFUeXBlOjpRT2JqZWN0U3RhciAmJgot ICAgICAgICB0eXBlICE9IFFNZXRhVHlwZTo6Vm9pZFN0YXIgJiYKLSAgICAgICAgdHlwZSAhPSBR TWV0YVR5cGU6OlFXaWRnZXRTdGFyICYmCi0gICAgICAgIHR5cGUgIT0gUU1ldGFUeXBlOjpRU3Ry aW5nKSB7Ci0gICAgICAgIHJldHVybiBqc051bGwoKTsKKyAgICBpZiAodmFyaWFudC5pc051bGwo KSApIHsKKyAgICAgICAgaWYgKHR5cGUgPT0gUU1ldGFUeXBlOjpRU3RyaW5nKQorICAgICAgICAg ICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CisgICAgICAgIGlmICh0eXBlICE9IFFNZXRhVHlwZTo6 UU9iamVjdFN0YXIgJiYKKyAgICAgICAgICAgIHR5cGUgIT0gUU1ldGFUeXBlOjpWb2lkU3RhciAm JgorICAgICAgICAgICAgdHlwZSAhPSBRTWV0YVR5cGU6OlFXaWRnZXRTdGFyKQorICAgICAgICAg ICAgcmV0dXJuIGpzTnVsbCgpOwogICAgIH0KIAogICAgIEpTTG9jayBsb2NrKGZhbHNlKTsK 26684 2009-01-13 14:50:22 -0800 2009-05-28 17:20:34 -0700 Return jsundefined instead of jsnull. null.patch text/plain 1265 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTgyNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDktMDEtMTIgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBX aGVuIHRoZSBhcHBsaWNhdGlvbiByZXR1cm5zIGEgTlVMTCBzdHJpbmcsIGl0IHNob3VsZCByZXR1 cm4ganN1bmRlZmluZWQgdG8gSmF2YVNjcmlwdCwgbm90IGFuIGVtcHR5IHN0cmluZy4KKworICAg ICAgICAqIGJyaWRnZS9xdC9xdF9ydW50aW1lLmNwcDoKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6 OmNvbnZlcnRRVmFyaWFudFRvVmFsdWUpOgorCiAyMDA5LTAxLTEyICBKdWxpZW4gQ2hhZmZyYWl4 ICA8amNoYWZmcmFpeEBwbGV5by5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCkluZGV4OiBXZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50aW1lLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50aW1lLmNwcAkocmV2aXNpb24gMzk4MTEpCisrKyBX ZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50aW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzQzLDgg Kzc0Myw5IEBACiAgICAgLy8gVmFyaWFudHMgd2l0aCBRT2JqZWN0ICogY2FuIGJlIGlzTnVsbCBi dXQgbm90IGEgbnVsbCBwb2ludGVyCiAgICAgLy8gQW4gZW1wdHkgUVN0cmluZyB2YXJpYW50IGlz IGFsc28gbnVsbAogICAgIFFNZXRhVHlwZTo6VHlwZSB0eXBlID0gKFFNZXRhVHlwZTo6VHlwZSkg dmFyaWFudC51c2VyVHlwZSgpOwotCiAgICAgcUNvbnZEZWJ1ZygpIDw8ICJjb252ZXJ0UVZhcmlh bnRUb1ZhbHVlOiBtZXRhdHlwZToiIDw8IHR5cGUgPDwgIiwgaXNudWxsOiAiIDw8IHZhcmlhbnQu aXNOdWxsKCk7CisgICAgaWYgKCF2YXJpYW50LmlzVmFsaWQoKSkKKyAgICAgICAgcmV0dXJuIGpz VW5kZWZpbmVkKCk7CiAgICAgaWYgKHZhcmlhbnQuaXNOdWxsKCkgJiYKICAgICAgICAgdHlwZSAh PSBRTWV0YVR5cGU6OlFPYmplY3RTdGFyICYmCiAgICAgICAgIHR5cGUgIT0gUU1ldGFUeXBlOjpW b2lkU3RhciAmJgo=