231934 2021-10-18 19:56:37 -0700 Image::orientation() shouldn't return ImageOrientation::FromImage 2021-10-25 19:57:18 -0700 1 1 1 Unclassified WebKit Images WebKit Local Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 heycam webkit-unassigned sabouhallawa webkit-bug-importer oldest_to_newest 1805847 0 heycam 2021-10-18 19:56:37 -0700 It's a bit weird that Image::orientation() has a default implementation that returns ImageOrientation::FromImage. I think Image::orientation() should return the image's native orientation metadata, and so for image types that don't have any orientation metadata, a better default would be ImageOrientation::None. There are places in the code where we check for FromImage and turn it into None, because we need a concrete orientation value to call e.g. swapsWidthAndHeight() on. We could: 1. Rename Image::orientation() to say nativeOrientation(), make it protected, and add a new public Image::orientation() accessor that calls nativeOrientation() and asserts that its return value is not FromImage. 2. Have two types -- ImageOrientation, as it is now, and a new type (NativeImageOrientation? ResolvedImageOrientation? Orientation?) that doesn't have a FromImage value. Then update functions to take the appropriate type. 1808739 1 webkit-bug-importer 2021-10-25 19:57:18 -0700 <rdar://problem/84643755>