23082 2009-01-02 15:33:14 -0800 REGRESSION: Animated GIF as CSS background fails to animate 2009-01-06 13:50:18 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://aislian.org/tile.html P2 Normal --- 1 simon.fraser simon.fraser hyatt pkasting webkit webkit zimmermann oldest_to_newest 104183 0 simon.fraser 2009-01-02 15:33:14 -0800 When an animated GIF is used as a CSS background-image, it fails to animate. This works in Safari 3.2. 104187 1 simon.fraser 2009-01-02 16:21:33 -0800 This is caused by bug 19663. 104195 2 26386 simon.fraser 2009-01-02 16:46:13 -0800 Created attachment 26386 Patch, testcase, changelog This was a regression from bug 19663, which changed the signature of startAnimation() in BitmapImage, but not in the base class. 104198 3 26386 darin 2009-01-02 16:48:02 -0800 Comment on attachment 26386 Patch, testcase, changelog r=me 104201 4 simon.fraser 2009-01-02 16:48:56 -0800 *** Bug 22647 has been marked as a duplicate of this bug. *** 104203 5 simon.fraser 2009-01-02 17:06:20 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/backgrounds/animated-gif-as-background.html A LayoutTests/fast/backgrounds/resources/red-green-animated.gif A LayoutTests/platform/mac/fast/backgrounds/animated-gif-as-background-expected.checksum A LayoutTests/platform/mac/fast/backgrounds/animated-gif-as-background-expected.png A LayoutTests/platform/mac/fast/backgrounds/animated-gif-as-background-expected.txt M WebCore/ChangeLog M WebCore/platform/graphics/Image.h Committed r39564 104458 6 webkit 2009-01-05 11:42:33 -0800 This fix doesn't work for me in WebKit r39572 on Mac OS X. 104460 7 simon.fraser 2009-01-05 11:46:28 -0800 Robert: what is your testcase? http://aislian.org/tile.html does fail for me sporadically (when the GIF is not cached?). 104465 8 webkit 2009-01-05 11:55:18 -0800 (In reply to comment #7) > Robert: what is your testcase? > > http://aislian.org/tile.html does fail for me sporadically (when the GIF is not > cached?). > I tested this reported URL. It doesn't work completely for me. 104523 9 webkit 2009-01-05 20:42:50 -0800 (In reply to comment #7) > http://aislian.org/tile.html does fail for me sporadically (when the GIF is not > cached?). when the gif is not cached and when you view the image before it is finished loading if I let a gif load completely in a background tab before viewing it, the gif always animates correctly (using Webkit nightly on OS X at least). 104575 10 pkasting 2009-01-06 10:24:58 -0800 While I don't know precisely what's going on here, in general the reason for this kind of issue is that the image animation won't advance to incomplete frames and won't advances past the end of the image for non-repeating images; if a frame never gets marked complete, or the repeat count is erroneously set to "don't repeat", or draw() doesn't get called again when new data comes in from the network layer, the animation won't advance. Similar issues in the past: * In the original patch to bug 19663, the image rect was getting cleared by draw() when no animation timers were running, and thus nothing would ever automatically re-call draw() (and hence re-call startAnimation() to keep the animation moving). You can see in the final patch on that bug that there's a big comment about this in startAnimation() along with an explicit call back to startAnimation() again to keep the timer going in this case. * In bug 22108 the decoder was being destroyed mid-stream, and if it was then re-queried for the repeat count, it would return a bogus value. That patch fixed this issue by not deleting the decoder. 104619 11 pkasting 2009-01-06 13:50:18 -0800 I'm going to call the remainder of this a dupe of bug 22995, which I've just taken, and re-close this bug, claiming it's just about the bogus method signature portion. 26386 2009-01-02 16:46:13 -0800 2009-01-02 16:48:02 -0800 Patch, testcase, changelog 23082_patch.txt text/plain 5303 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyODk0OTc0Li5iYTgxYWU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMDktMDEt MDIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzMDgyCisKKyAgICAgICAgVGVzdGNhc2UgZm9yIGFuaW1hdGVk IEdJRiB1c2VkIGFzIENTUyBiYWNrZ3JvdW5kLgorICAgICAgICAKKyAgICAgICAgKiBmYXN0L2Jh Y2tncm91bmRzL2FuaW1hdGVkLWdpZi1hcy1iYWNrZ3JvdW5kLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvYmFja2dyb3VuZHMvcmVzb3VyY2VzL3JlZC1ncmVlbi1hbmltYXRlZC5naWY6IEFk ZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L2JhY2tncm91bmRzL2FuaW1hdGVkLWdp Zi1hcy1iYWNrZ3JvdW5kLWV4cGVjdGVkLmNoZWNrc3VtOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0 Zm9ybS9tYWMvZmFzdC9iYWNrZ3JvdW5kcy9hbmltYXRlZC1naWYtYXMtYmFja2dyb3VuZC1leHBl Y3RlZC5wbmc6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L2JhY2tncm91bmRz L2FuaW1hdGVkLWdpZi1hcy1iYWNrZ3JvdW5kLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKKzIwMDkt MDEtMDIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIKIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI5ODEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvYmFj a2dyb3VuZHMvYW5pbWF0ZWQtZ2lmLWFzLWJhY2tncm91bmQuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvYmFja2dyb3VuZHMvYW5pbWF0ZWQtZ2lmLWFzLWJhY2tncm91bmQuaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5lYjg4YzI0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9iYWNrZ3JvdW5kcy9hbmltYXRlZC1naWYtYXMtYmFja2dyb3VuZC5odG1s CkBAIC0wLDAgKzEsMzEgQEAKKzxodG1sPgorPGhlYWQ+CisgIDxzdHlsZSB0eXBlPSJ0ZXh0L2Nz cyIgbWVkaWE9InNjcmVlbiI+CisgICAgZGl2IHsKKyAgICAgIGJhY2tncm91bmQ6IGJsdWU7Cisg ICAgICBiYWNrZ3JvdW5kLWltYWdlOiB1cmwoJ3Jlc291cmNlcy9yZWQtZ3JlZW4tYW5pbWF0ZWQu Z2lmJyk7CisgICAgICBoZWlnaHQ6IDIwMHB4OworICAgICAgd2lkdGg6IDIwMHB4OworICAgIH0K KyAgPC9zdHlsZT4KKyAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0 Zi04Ij4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgIAorICAgIGZ1bmN0aW9uIHBhZ2VM b2FkZWQoKSAKKyAgICB7CisgICAgICB3aW5kb3cuc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAg ICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgICB9LCAyMDApOyAgICAvLyBSZWQgZnJh bWUgb2YgR0lGIGhhcyAxMDBtcyBkdXJhdGlvbgorICAgIH0KKworICAgIHdpbmRvdy5hZGRFdmVu dExpc3RlbmVyKCdsb2FkJywgcGFnZUxvYWRlZCwgZmFsc2UpOworICA8L3NjcmlwdD4KKyAgPC9z Y3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgPHA+RGl2IGJhY2tncm91bmQgc2hvdWxkIGFuaW1h dGUgYmV0d2VlbiByZWQgYW5kIGdyZWVuLiBEUlQgc2hvdWxkIHNuYXBzaG90IHdoZW4gaXQgaXMg Z3JlZW4uPC9wPgorICA8ZGl2PjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9iYWNrZ3JvdW5kcy9yZXNvdXJjZXMvcmVkLWdyZWVuLWFuaW1hdGVk LmdpZiBiL0xheW91dFRlc3RzL2Zhc3QvYmFja2dyb3VuZHMvcmVzb3VyY2VzL3JlZC1ncmVlbi1h bmltYXRlZC5naWYKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZGQwOWU0ZQpC aW5hcnkgZmlsZXMgL2Rldi9udWxsIGFuZCBiL0xheW91dFRlc3RzL2Zhc3QvYmFja2dyb3VuZHMv cmVzb3VyY2VzL3JlZC1ncmVlbi1hbmltYXRlZC5naWYgZGlmZmVyCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9iYWNrZ3JvdW5kcy9hbmltYXRlZC1naWYtYXMtYmFj a2dyb3VuZC1leHBlY3RlZC5jaGVja3N1bSBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0 L2JhY2tncm91bmRzL2FuaW1hdGVkLWdpZi1hcy1iYWNrZ3JvdW5kLWV4cGVjdGVkLmNoZWNrc3Vt Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjU0ZjQ5ZjAKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9iYWNrZ3JvdW5kcy9hbmltYXRl ZC1naWYtYXMtYmFja2dyb3VuZC1leHBlY3RlZC5jaGVja3N1bQpAQCAtMCwwICsxIEBACis0Y2I1 ZTY4ZDllN2I0MjlmMDAyODg5Mzg0OGViZWUzYgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2JhY2tncm91bmRzL2Fu aW1hdGVkLWdpZi1hcy1iYWNrZ3JvdW5kLWV4cGVjdGVkLnBuZyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9mYXN0L2JhY2tncm91bmRzL2FuaW1hdGVkLWdpZi1hcy1iYWNrZ3JvdW5kLWV4cGVj dGVkLnBuZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi45MzUzNDBlCkJpbmFy eSBmaWxlcyAvZGV2L251bGwgYW5kIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvYmFj a2dyb3VuZHMvYW5pbWF0ZWQtZ2lmLWFzLWJhY2tncm91bmQtZXhwZWN0ZWQucG5nIGRpZmZlcgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvYmFja2dyb3VuZHMvYW5p bWF0ZWQtZ2lmLWFzLWJhY2tncm91bmQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL2Zhc3QvYmFja2dyb3VuZHMvYW5pbWF0ZWQtZ2lmLWFzLWJhY2tncm91bmQtZXhwZWN0 ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjI5ODBhZGUKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9iYWNrZ3JvdW5kcy9h bmltYXRlZC1naWYtYXMtYmFja2dyb3VuZC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw5IEBACits YXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgw MHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJCbG9jayB7SFRNTH0g YXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsOCkgc2l6 ZSA3ODR4NTg0CisgICAgICBSZW5kZXJCbG9jayB7UH0gYXQgKDAsMCkgc2l6ZSA3ODR4MTgKKyAg ICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgNjAzeDE4CisgICAgICAgICAg dGV4dCBydW4gYXQgKDAsMCkgd2lkdGggNjAzOiAiRGl2IGJhY2tncm91bmQgc2hvdWxkIGFuaW1h dGUgYmV0d2VlbiByZWQgYW5kIGdyZWVuLiBEUlQgc2hvdWxkIHNuYXBzaG90IHdoZW4gaXQgaXMg Z3JlZW4uIgorICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAsMzQpIHNpemUgMjAweDIwMCBb Ymdjb2xvcj0jMDAwMEZGXQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCAxNmJlNDg2Li4xNmQxY2FiIDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDA5LTAx LTAyICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA4MgorICAgICAgICAKKyAgICAgICAgRml4IEdJRiBhbmlt YXRpb24gYnkgZW5zdXJpbmcgdGhhdCB0aGUgc2lnbmF0dXJlIG9mCisgICAgICAgIHN0YXJ0QW5p bWF0aW9uKCkgaW4gdGhlIGJhc2UgY2xhc3MgbWF0Y2hlcyB0aGUgbWV0aG9kIGluIEJpdG1hcElt YWdlLgorICAgICAgICAKKyAgICAgICAgVGVzdDogZmFzdC9iYWNrZ3JvdW5kcy9hbmltYXRlZC1n aWYtYXMtYmFja2dyb3VuZC5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbWFn ZS5oOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2U6OnN0YXJ0QW5pbWF0aW9uKToKKwogMjAwOS0w MS0wMiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1ZyAy MzA4MTogVGhlc2UgZmlsZXMgYXJlIG5vIGxvbmdlciBwYXJ0IG9mIHRoZSBLREUgbGlicmFyaWVz CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmggYi9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmgKaW5kZXggMDczNWRkZS4uODc2ZjI3YyAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZS5oCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvSW1hZ2UuaApAQCAtMTU5LDcgKzE1OSw3IEBAIHByb3RlY3RlZDoKICAg ICB2aXJ0dWFsIGJvb2wgbWF5RmlsbFdpdGhTb2xpZENvbG9yKCkgY29uc3QgeyByZXR1cm4gZmFs c2U7IH0KICAgICB2aXJ0dWFsIENvbG9yIHNvbGlkQ29sb3IoKSBjb25zdCB7IHJldHVybiBDb2xv cigpOyB9CiAgICAgCi0gICAgdmlydHVhbCB2b2lkIHN0YXJ0QW5pbWF0aW9uKCkgeyB9CisgICAg dmlydHVhbCB2b2lkIHN0YXJ0QW5pbWF0aW9uKGJvb2wgY2F0Y2hVcElmTmVjZXNzYXJ5ID0gdHJ1 ZSkgeyB9CiAgICAgCiAgICAgdmlydHVhbCB2b2lkIGRyYXdQYXR0ZXJuKEdyYXBoaWNzQ29udGV4 dCosIGNvbnN0IEZsb2F0UmVjdCYgc3JjUmVjdCwgY29uc3QgQWZmaW5lVHJhbnNmb3JtJiBwYXR0 ZXJuVHJhbnNmb3JtLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBGbG9hdFBv aW50JiBwaGFzZSwgQ29tcG9zaXRlT3BlcmF0b3IsIGNvbnN0IEZsb2F0UmVjdCYgZGVzdFJlY3Qp Owo=