230743 2021-09-24 01:47:53 -0700 IPC SimpleArgumentEncoder should static_assert(std::is_trivially_copyable<T>) 2021-10-06 08:21:42 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=230714 InRadar P2 Normal --- 230744 1 kkinnunen cdumez andersca cdumez darin ggaren kkinnunen sam simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1796824 0 kkinnunen 2021-09-24 01:47:53 -0700 IPC SimpleArgumentEncoder should static_assert(std::is_trivially_copyable<T>) 1799205 1 webkit-bug-importer 2021-10-01 01:48:17 -0700 <rdar://problem/83757335> 1800713 2 440250 cdumez 2021-10-05 12:49:43 -0700 Created attachment 440250 Patch 1801016 3 440250 kkinnunen 2021-10-06 04:16:26 -0700 Comment on attachment 440250 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440250&action=review > Source/WebKit/Platform/IPC/ArgumentCoders.h:47 > template<typename Encoder> I think you should be able to assert once in the class scope. template<typename T> struct SimpleArgumentCoder { static_assert(std::is_trivially_copyable_v<T>); .... 1801054 4 440364 cdumez 2021-10-06 07:30:55 -0700 Created attachment 440364 Patch 1801055 5 cdumez 2021-10-06 07:31:03 -0700 (In reply to Kimmo Kinnunen from comment #3) > Comment on attachment 440250 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440250&action=review > > > Source/WebKit/Platform/IPC/ArgumentCoders.h:47 > > template<typename Encoder> > > I think you should be able to assert once in the class scope. > > template<typename T> struct SimpleArgumentCoder { > static_assert(std::is_trivially_copyable_v<T>); > .... Indeed, fixed. 1801057 6 ews-feeder 2021-10-06 07:32:10 -0700 Kimmo Kinnunen found in /Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 1801078 7 ews-feeder 2021-10-06 08:21:38 -0700 Committed r283618 (242570@main): <https://commits.webkit.org/242570@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440364. 440250 2021-10-05 12:49:43 -0700 2021-10-06 07:30:51 -0700 Patch bug-230743-20211005124942.patch text/plain 1982 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY4NWRmM2YwYWUzYjlmMGM2 M2FhN2M5MTNlODI2MjcyZmE1ZmEzZTMuLjE1Zjc0NTg1YWUwNDc3YjhlNTE3ZDNmMDZhYzcwOTE1 MzJmOTYyMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTAtMDUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBJUEMgU2ltcGxlQXJndW1lbnRFbmNv ZGVyIHNob3VsZCBzdGF0aWNfYXNzZXJ0KHN0ZDo6aXNfdHJpdmlhbGx5X2NvcHlhYmxlPFQ+KQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwNzQzCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS84Mzc1NzMzNT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc3RhdGljX2Fzc2VydChzdGQ6OmlzX3RyaXZp YWxseV9jb3B5YWJsZTxUPikgdG8gSVBDIFNpbXBsZUFyZ3VtZW50RW5jb2RlciB0byBhdm9pZCBt aXN1c2VzLgorCisgICAgICAgICogUGxhdGZvcm0vSVBDL0FyZ3VtZW50Q29kZXJzLmg6CisgICAg ICAgIChJUEM6OlNpbXBsZUFyZ3VtZW50Q29kZXI6OmVuY29kZSk6CisgICAgICAgIChJUEM6OlNp bXBsZUFyZ3VtZW50Q29kZXI6OmRlY29kZSk6CisKIDIwMjEtMTAtMDQgIENocmlzIER1bWV6ICA8 Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgU1BJIHRvIGxhdW5jaCBhIHNlcnZpY2Ug c2VydmljZSB3b3JrZXIgaW4gYSBXS1dlYlZpZXcgYW5kIGV4cG9zZSBzZXJ2aWNlIHdvcmtlciB0 byBpbmplY3RlZCBidW5kbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBD L0FyZ3VtZW50Q29kZXJzLmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9Bcmd1bWVudENv ZGVycy5oCmluZGV4IDQ3OWRiNjBlZGMyNzE2ZDU1NjA2ZjY1MmYyNDMxYWQzNjlmNjU3MGMuLmEx ODE0NmEzZTE4ZjU3ZmM2Yzg0NDY3ZTA2ZjMwZWNiNWExODM5NDIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0FyZ3VtZW50Q29kZXJzLmgKKysrIGIvU291cmNlL1dlYktp dC9QbGF0Zm9ybS9JUEMvQXJndW1lbnRDb2RlcnMuaApAQCAtMjcsNiArMjcsNyBAQAogCiAjaW5j bHVkZSAiQXJndW1lbnRDb2Rlci5oIgogI2luY2x1ZGUgIkFycmF5UmVmZXJlbmNlLmgiCisjaW5j bHVkZSA8dHlwZV90cmFpdHM+CiAjaW5jbHVkZSA8dXRpbGl0eT4KICNpbmNsdWRlIDx3dGYvQm94 Lmg+CiAjaW5jbHVkZSA8d3RmL0NoZWNrZWRBcml0aG1ldGljLmg+CkBAIC00NiwxMSArNDcsMTMg QEAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gc3RydWN0IFNpbXBsZUFyZ3VtZW50Q29kZXIgewogICAg IHRlbXBsYXRlPHR5cGVuYW1lIEVuY29kZXI+CiAgICAgc3RhdGljIHZvaWQgZW5jb2RlKEVuY29k ZXImIGVuY29kZXIsIGNvbnN0IFQmIHQpCiAgICAgeworICAgICAgICBzdGF0aWNfYXNzZXJ0KHN0 ZDo6aXNfdHJpdmlhbGx5X2NvcHlhYmxlX3Y8VD4pOwogICAgICAgICBlbmNvZGVyLmVuY29kZUZp eGVkTGVuZ3RoRGF0YShyZWludGVycHJldF9jYXN0PGNvbnN0IHVpbnQ4X3QqPigmdCksIHNpemVv ZihUKSwgYWxpZ25vZihUKSk7CiAgICAgfQogCiAgICAgc3RhdGljIFdBUk5fVU5VU0VEX1JFVFVS TiBib29sIGRlY29kZShEZWNvZGVyJiBkZWNvZGVyLCBUJiB0KQogICAgIHsKKyAgICAgICAgc3Rh dGljX2Fzc2VydChzdGQ6OmlzX3RyaXZpYWxseV9jb3B5YWJsZV92PFQ+KTsKICAgICAgICAgcmV0 dXJuIGRlY29kZXIuZGVjb2RlRml4ZWRMZW5ndGhEYXRhKHJlaW50ZXJwcmV0X2Nhc3Q8dWludDhf dCo+KCZ0KSwgc2l6ZW9mKFQpLCBhbGlnbm9mKFQpKTsKICAgICB9CiB9Owo= 440364 2021-10-06 07:30:55 -0700 2021-10-06 08:21:40 -0700 Patch bug-230743-20211006073053.patch text/plain 1381 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIyNmYwZTFhMDY2YzJkMGY1 MmQ1OThkNjI3MzZhZjc0MzkzZWZmY2YuLjg1ZmRkZDNiNmFmZDU3ZmMxMjhhZjMwNTcyOTI4Zjk3 ZmYzOGJhZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMTAtMDYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBJUEMgU2ltcGxlQXJndW1lbnRFbmNv ZGVyIHNob3VsZCBzdGF0aWNfYXNzZXJ0KHN0ZDo6aXNfdHJpdmlhbGx5X2NvcHlhYmxlPFQ+KQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwNzQzCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS84Mzc1NzMzNT4KKworICAgICAgICBSZXZpZXdlZCBieSBL aW1tbyBLaW5udW5lbi4KKworICAgICAgICBBZGQgc3RhdGljX2Fzc2VydChzdGQ6OmlzX3RyaXZp YWxseV9jb3B5YWJsZTxUPikgdG8gSVBDIFNpbXBsZUFyZ3VtZW50RW5jb2RlciB0byBhdm9pZCBt aXN1c2VzLgorCisgICAgICAgICogUGxhdGZvcm0vSVBDL0FyZ3VtZW50Q29kZXJzLmg6CisKIDIw MjEtMTAtMDYgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIElt cGxlbWVudCBodHRwczovL3czYy5naXRodWIuaW8vcHVzaC1hcGkvI3JlY2VpdmluZy1hLXB1c2gt bWVzc2FnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvQXJndW1lbnRD b2RlcnMuaCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0FyZ3VtZW50Q29kZXJzLmgKaW5k ZXggNDc5ZGI2MGVkYzI3MTZkNTU2MDZmNjUyZjI0MzFhZDM2OWY2NTcwYy4uZDlmYzZhYTgxOTU1 YzQ2ZGY5ZjU1NDQ5MmFlZjIwMTM1ZjRlNTZlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9Q bGF0Zm9ybS9JUEMvQXJndW1lbnRDb2RlcnMuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3Jt L0lQQy9Bcmd1bWVudENvZGVycy5oCkBAIC00Myw2ICs0Myw4IEBAIG5hbWVzcGFjZSBJUEMgewog CiAvLyBBbiBhcmd1bWVudCBjb2RlciB3b3JrcyBvbiBQT0QgdHlwZXMKIHRlbXBsYXRlPHR5cGVu YW1lIFQ+IHN0cnVjdCBTaW1wbGVBcmd1bWVudENvZGVyIHsKKyAgICBzdGF0aWNfYXNzZXJ0KHN0 ZDo6aXNfdHJpdmlhbGx5X2NvcHlhYmxlX3Y8VD4pOworCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUg RW5jb2Rlcj4KICAgICBzdGF0aWMgdm9pZCBlbmNvZGUoRW5jb2RlciYgZW5jb2RlciwgY29uc3Qg VCYgdCkKICAgICB7Cg==