23019 2008-12-28 20:48:46 -0800 The embed element is still not hidden by display:none 2009-02-24 22:08:56 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED DUPLICATE 15081 P2 Normal --- 1 weihong.zeng webkit-unassigned simon.fraser oldest_to_newest 103662 0 weihong.zeng 2008-12-28 20:48:46 -0800 As follow: <embed id="fc" src="http://801.tianya.cn/2008/12/sanguo/1224/640.swf"></embed> <script> var obj = document.getElementById("fc"); obj.style.display ="none"; </script> If the display equals to "none", rendererIsNeeded should return false. bool HTMLEmbedElement::rendererIsNeeded(RenderStyle* style) { if (isImageType()) return HTMLPlugInElement::rendererIsNeeded(style); Frame* frame = document()->frame(); if (!frame) return false; Node* p = parentNode(); if (p && p->hasTagName(objectTag)) { ASSERT(p->renderer()); return false; } - return true; + return HTMLElement::rendererIsNeeded(style); } 110899 1 27957 simon.fraser 2009-02-24 21:30:45 -0800 Created attachment 27957 Testcase 110904 2 simon.fraser 2009-02-24 22:08:56 -0800 *** This bug has been marked as a duplicate of 15081 *** 27957 2009-02-24 21:30:45 -0800 2009-02-24 21:30:45 -0800 Testcase flash-block.html text/html 652 simon.fraser PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+Cgo8aHRtbCBs YW5nPSJlbiI+CjxoZWFkPgogIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KICA8dGl0bGU+RGlzcGxheTpub25lIG9uIHBs dWdpbjwvdGl0bGU+CiAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVuIj4KICAg IGVtYmVkW3R5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIl0gewogICAgICBkaXNw bGF5OiBub25lOwogICAgfQogIDwvc3R5bGU+CjwvaGVhZD4KPGJvZHk+CgogIDxlbWJlZCBzcmM9 Imh0dHA6Ly93d3cuaG9tZXN0YXJydW5uZXIuY29tL3dlbGNvbWUuc3dmIiBxdWFsaXR5PSJoaWdo IiAgd2lkdGg9IjU1MCIgaGVpZ2h0PSI0MDAiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZl LWZsYXNoIiBwbHVnaW5zcGFnZT0iaHR0cDovL3d3dy5tYWNyb21lZGlhLmNvbS9zaG9ja3dhdmUv ZG93bmxvYWQvaW5kZXguY2dpP1AxX1Byb2RfVmVyc2lvbj1TaG9ja3dhdmVGbGFzaCI+CiAgPC9l bWJlZD4KICAKPC9ib2R5Pgo8L2h0bWw+Cg==