22995 2008-12-25 17:12:51 -0800 REGRESSION: radar loops don't animate 2009-01-11 10:02:58 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED http://radar.weather.gov/ridge/radar_lite.php?rid=EYX&product=NCR&loop=yes Regression P1 Normal --- 1 pilotgi pkasting jimoase ndfore simon.fraser webkit webkit oldest_to_newest 103425 0 pilotgi 2008-12-25 17:12:51 -0800 Bug #22108 was marked resolved related to the problem of radar loops not animating but it has never worked for me. The claim was it was fixed with version r39309 but I don't get any animations from this version or any subsequent versions. Is there some additional work around that is needed? 103437 1 ap 2008-12-26 01:29:59 -0800 Confirmed with r39437. On first load, there is no animation - and on a reload, animation seems to work, but a lot of errors are printed to console: Fri Dec 26 12:27:17 ap-mbp.local Safari[31961] <Error>: CGImageSourceUpdateData image source was already finalized No such problem on shipping Safari/WebKit, although the behavior is not very good either, with a lot of flashing. 103467 2 webkit 2008-12-26 10:25:56 -0800 *** Bug 21753 has been marked as a duplicate of this bug. *** 103470 3 webkit 2008-12-26 10:26:45 -0800 *** Bug 23000 has been marked as a duplicate of this bug. *** 103472 4 webkit 2008-12-26 10:27:51 -0800 *** Bug 22646 has been marked as a duplicate of this bug. *** 103474 5 webkit 2008-12-26 10:28:08 -0800 *** Bug 22366 has been marked as a duplicate of this bug. *** 103517 6 pkasting 2008-12-26 19:52:10 -0800 The errors to console would be fixed by the patch on bug 22929. I don't know why this isn't animating. I am almost at the point of wanting Safari to just use the open source decoders instead of the CG ones since they're both more performant and less buggy :( (of course, they lack color profile handling, etc...) 103982 7 pilotgi 2009-01-01 12:49:54 -0800 Just downloaded and installed r39524. Went to weather.gov to try animating radar loops but no luck. On a whim, I control-clicked the image and choose the selection 'Inspect Element'. The window that pops up shows html code and behind this I noticed that the radar loop had started animating. I closed the Inspect Element window and was able to turn the animation on and off with no problems. I was also able to reload the page and start the animation again. CPU usage was 1 to 5 %. If I click on a different part of the map to try a different radar loop, some will work and some don't but they always start animating after I ctrl-click and select 'Inspect Element'. Weird, huh? 104205 8 jimoase 2009-01-02 17:44:31 -0800 (In reply to comment #7) > Just downloaded and installed r39524. Went to weather.gov to try animating > radar loops but no luck. On a whim, I control-clicked the image and choose the > selection 'Inspect Element'. > > The window that pops up shows html code and behind this I noticed that the > radar loop had started animating. I closed the Inspect Element window and was > able to turn the animation on and off with no problems. I was also able to > reload the page and start the animation again. CPU usage was 1 to 5 %. > > If I click on a different part of the map to try a different radar loop, some > will work and some don't but they always start animating after I ctrl-click and > select 'Inspect Element'. > > Weird, huh? > I duplicated this operation the first couple times I tried it (using the same build as above), then the could not get animation again. I have just loaded WebKit-SVN-r39553 and still can not get animation to function even using the above technique. Maybe this site doesn't like me. 104281 9 jimoase 2009-01-03 19:28:49 -0800 (In reply to comment #7) > Just downloaded and installed r39524. Went to weather.gov to try animating > radar loops but no luck. On a whim, I control-clicked the image and choose the > selection 'Inspect Element'. > > The window that pops up shows html code and behind this I noticed that the > radar loop had started animating. I closed the Inspect Element window and was > able to turn the animation on and off with no problems. I was also able to > reload the page and start the animation again. CPU usage was 1 to 5 %. > > If I click on a different part of the map to try a different radar loop, some > will work and some don't but they always start animating after I ctrl-click and > select 'Inspect Element'. > > Weird, huh? > I reported earlier that I tried the above and the first couple of times it animation started just as reported above. Then i could not get it to work again, even after load the latest build. This afternoon I tried it again. This time I clicked on the xxxx.gif and waited. Animation finally began. I am going with "Weird, huh?" 104456 10 pkasting 2009-01-05 11:34:58 -0800 Has the fix for bug 23082 fixed this as well? 104467 11 webkit 2009-01-05 12:26:30 -0800 (In reply to comment #10) > Has the fix for bug 23082 fixed this as well? > No, it doesn't work for me in WebKit r39572 on Mac OS X. 104509 12 jimoase 2009-01-05 16:52:22 -0800 The bug still exists as of WebKit-SVN-r39572 Animation can be made operate most of the time using the instructions in comment #7, right click on the map, click inspect element, wait, click on the highlighted line, wait some more and most times the animation will begin to work. I still haven't found the magic sequence that makes animation work immediately. Jim 104747 13 jimoase 2009-01-07 12:24:22 -0800 Radar loop animation still does not work with build WebKit-SVN-r39671 Animation can be made to work using the Inspect Element scheme pilotgi@gmail.com discovered... listed in the comment section. When animation is working, using the inspect elements scheme, scrolling becomes erratic when using the scroll ball on my super mouse. Scrolling has been a problem and been fixed with this site before. Jim 104835 14 simon.fraser 2009-01-07 20:11:07 -0800 I think I see the issue. You get into a state where you've got frame 0, and are waiting until frame 1 is decoded. frameIsCompleteAtIndex(1) has been called before the frame is ready, so frame 1 has m_frame == 0, but m_haveMetadata == true. Now you keep calling frameIsCompleteAtIndex(1) over and over via startAnimation(). frameIsCompleteAtIndex() never calls cacheFrame again, because m_haveMetadata is true, so it does nothing (and m_isComplete stays at false). So you never make progress. Someone needs to call cacheFrame() if m_frame is still 0. Something like this: diff --git a/WebCore/WebCore.xcodeproj/project.pbxproj b/WebCore/WebCore.xcodeproj/project.pbxproj diff --git a/WebCore/platform/graphics/BitmapImage.cpp b/WebCore/platform/graphics/BitmapImage.cpp index 779787e..2eed9c6 100644 --- a/WebCore/platform/graphics/BitmapImage.cpp +++ b/WebCore/platform/graphics/BitmapImage.cpp @@ -287,6 +287,8 @@ void BitmapImage::startAnimation(bool catchUpIfNecessary) // Don't advance the animation to an incomplete frame. size_t nextFrame = (m_currentFrame + 1) % frameCount(); + // Update the state of the frame by asking for it + (void)frameAtIndex(nextFrame); if (!frameIsCompleteAtIndex(nextFrame)) return; 104837 15 simon.fraser 2009-01-07 20:17:41 -0800 Also, how can you trust the frame duration, alpha and size in BitmapImage::cacheFrame() if you don't have a frame yet? Seems like this method is over-zealous in thinking that it has valid metadata. 104838 16 simon.fraser 2009-01-07 21:04:03 -0800 Here's a good test URL for animated GIFs: http://www.neogaf.com/forum/showthread.php?t=294041 104978 17 26552 pkasting 2009-01-08 17:29:30 -0800 Created attachment 26552 patch v1 This isn't tested, but if smfr is correct about the cause of the flakiness (and it certainly looks like a problem to me too), this should fix it, and in a more robust way than the proposed workaround of forcing the frame to re-cache in startAnimation(). This clears the frame's metadata if we get more data for it. This should match fairly well with when the metadata _can_ actually change (it's just slightly aggressive in clearing the metadata, but not in a way that will have any real effect). 105022 18 26552 hyatt 2009-01-09 10:41:20 -0800 Comment on attachment 26552 patch v1 r=me 105024 19 pkasting 2009-01-09 10:47:30 -0800 Fixed, I hope, in r39751. 105125 20 webkit 2009-01-10 13:50:17 -0800 *** Bug 23224 has been marked as a duplicate of this bug. *** 105207 21 pilotgi 2009-01-11 05:20:39 -0800 I just installed r39790. Radar loops work for me! 105218 22 jimoase 2009-01-11 08:29:15 -0800 The radar animation loop works.....But....... now initial scrolling with a super mouse ball is delayed and jerky. ARGH!!! Takes a bite for animation to start. After animation starts slowly scroll continuously east. The picture will not move at first... then jerk to the correct location and in that axis work smoothly from then on. Change axis to north/south and repeat the scroll process. Again the picture will not move at first then jerk to the correct location 105235 23 simon.fraser 2009-01-11 10:02:58 -0800 Jim: please file a new bug on the performance problem, and, if you can, try to identify the nightly build where it first occurred. 26552 2009-01-08 17:29:30 -0800 2009-01-09 10:41:20 -0800 patch v1 patch text/plain 7450 pkasting SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTczMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjcgQEAKKzIwMDktMDEtMDggIFBldGVyIEthc3RpbmcgIDxwa2FzdGluZ0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjk5NQorICAgICAgICBG aXggZmxha3kgaW1hZ2UgYW5pbWF0aW9uIGJ5IHJlc2V0dGluZyB0aGUgbWV0YWRhdGEgZm9yIGEg ZnJhbWUgd2hlbgorICAgICAgICB3ZSBnZXQgbmV3IGRhdGEgZm9yIHRoYXQgZnJhbWUuICBUaGlz IGZpeGVzIGFuaW1hdGlvbnMgdGhhdCBoYWx0ZWQKKyAgICAgICAgd2hlbiB0aGUgbmV4dCBmcmFt ZSBvZiB0aGUgYW5pbWF0aW9uIHdhc24ndCBjb21wbGV0ZSBieSB0aGUgdGltZSB0aGUKKyAgICAg ICAgY3VycmVudCBmcmFtZSdzIGR1cmF0aW9uIGV4cGlyZWQuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJbWFn ZTo6ZGVzdHJveURlY29kZWREYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcEltYWdlOjpk YXRhQ2hhbmdlZCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuaDoK KyAgICAgICAgKFdlYkNvcmU6OkZyYW1lRGF0YTo6fkZyYW1lRGF0YSk6CisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpG cmFtZURhdGE6OmNsZWFyKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNH LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lRGF0YTo6Y2xlYXIpOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVE YXRhOjpjbGVhcik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvSW1hZ2VXeC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpGcmFtZURhdGE6OmNsZWFyKToKKwogMjAwOS0wMS0wOCAgQmVy ZW5kLUphbiBXZXZlciAgPHNreUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QWRhbSBCYXJ0aC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2Uu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2Uu Y3BwCShyZXZpc2lvbiAzOTY5NCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFw SW1hZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NSw4ICs3NSwxMyBAQCB2b2lkIEJpdG1hcElt YWdlOjpkZXN0cm95RGVjb2RlZERhdGEoYm9vCiB7CiAgICAgaW50IGZyYW1lc0NsZWFyZWQgPSAw OwogICAgIGNvbnN0IHNpemVfdCBjbGVhckJlZm9yZUZyYW1lID0gZGVzdHJveUFsbCA/IG1fZnJh bWVzLnNpemUoKSA6IG1fY3VycmVudEZyYW1lOwotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwg Y2xlYXJCZWZvcmVGcmFtZTsgKytpKQotICAgICAgICBmcmFtZXNDbGVhcmVkICs9IGNsZWFyRnJh bWUoaSk7CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBjbGVhckJlZm9yZUZyYW1lOyArK2kp IHsKKyAgICAgICAgLy8gVGhlIHVuZGVybHlpbmcgZnJhbWUgaXNuJ3QgYWN0dWFsbHkgY2hhbmdp bmcgKHdlJ3JlIGp1c3QgdHJ5aW5nIHRvCisgICAgICAgIC8vIHNhdmUgdGhlIG1lbW9yeSBmb3Ig dGhlIGZyYW1lYnVmZmVyIGRhdGEpLCBzbyB3ZSBkb24ndCBuZWVkIHRvIGNsZWFyCisgICAgICAg IC8vIHRoZSBtZXRhZGF0YS4KKyAgICAgICAgaWYgKG1fZnJhbWVzW2ldLmNsZWFyKGZhbHNlKSkK KyAgICAgICAgICArK2ZyYW1lc0NsZWFyZWQ7CisgICAgfQogCiAgICAgZGVzdHJveU1ldGFkYXRh QW5kTm90aWZ5KGZyYW1lc0NsZWFyZWQpOwogCkBAIC0xMDQsMTUgKzEwOSw2IEBAIHZvaWQgQml0 bWFwSW1hZ2U6OmRlc3Ryb3lNZXRhZGF0YUFuZE5vdGkKICAgICAgICAgaW1hZ2VPYnNlcnZlcigp LT5kZWNvZGVkU2l6ZUNoYW5nZWQodGhpcywgZGVsdGFCeXRlcyk7CiB9CiAKLWludCBCaXRtYXBJ bWFnZTo6Y2xlYXJGcmFtZShzaXplX3QgZnJhbWUpCi17Ci0gICAgaWYgKCFtX2ZyYW1lc1tmcmFt ZV0ubV9mcmFtZSkKLSAgICAgICAgcmV0dXJuIDA7Ci0KLSAgICBtX2ZyYW1lc1tmcmFtZV0uY2xl YXIoKTsKLSAgICByZXR1cm4gMTsKLX0KLQogdm9pZCBCaXRtYXBJbWFnZTo6Y2FjaGVGcmFtZShz aXplX3QgaW5kZXgpCiB7CiAgICAgc2l6ZV90IG51bUZyYW1lcyA9IGZyYW1lQ291bnQoKTsKQEAg LTE2MCw3ICsxNTYsOSBAQCBJbnRTaXplIEJpdG1hcEltYWdlOjpjdXJyZW50RnJhbWVTaXplKCkg CiAKIGJvb2wgQml0bWFwSW1hZ2U6OmRhdGFDaGFuZ2VkKGJvb2wgYWxsRGF0YVJlY2VpdmVkKQog ewotICAgIGRlc3Ryb3lNZXRhZGF0YUFuZE5vdGlmeShtX2ZyYW1lcy5pc0VtcHR5KCkgPyAwIDog Y2xlYXJGcmFtZShtX2ZyYW1lcy5zaXplKCkgLSAxKSk7CisgICAgLy8gQmVjYXVzZSB3ZSdyZSBt b2RpZnlpbmcgdGhlIGN1cnJlbnQgZnJhbWUsIGNsZWFyIGl0cyAobm93IHBvc3NpYmx5CisgICAg Ly8gaW5hY2N1cmF0ZSkgbWV0YWRhdGEgYXMgd2VsbC4KKyAgICBkZXN0cm95TWV0YWRhdGFBbmRO b3RpZnkoKCFtX2ZyYW1lcy5pc0VtcHR5KCkgJiYgbV9mcmFtZXNbbV9mcmFtZXMuc2l6ZSgpIC0g MV0uY2xlYXIodHJ1ZSkpID8gMSA6IDApOwogICAgIAogICAgIC8vIEZlZWQgYWxsIHRoZSBkYXRh IHdlJ3ZlIHNlZW4gc28gZmFyIHRvIHRoZSBpbWFnZSBkZWNvZGVyLgogICAgIG1fYWxsRGF0YVJl Y2VpdmVkID0gYWxsRGF0YVJlY2VpdmVkOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9CaXRtYXBJbWFnZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Qml0bWFwSW1hZ2UuaAkocmV2aXNpb24gMzk2OTMpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0JpdG1hcEltYWdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTc1LDEwICs3NSwxMiBAQCBzdHJ1 Y3QgRnJhbWVEYXRhIDogTm9uY29weWFibGUgewogCiAgICAgfkZyYW1lRGF0YSgpCiAgICAgeyAK LSAgICAgICAgY2xlYXIoKTsKKyAgICAgICAgY2xlYXIodHJ1ZSk7CiAgICAgfQogCi0gICAgdm9p ZCBjbGVhcigpOworICAgIC8vIENsZWFyIHRoZSBjYWNoZWQgaW1hZ2UgZGF0YSBvbiB0aGUgZnJh bWUsIGFuZCAob3B0aW9uYWxseSkgdGhlIG1ldGFkYXRhLgorICAgIC8vIFJldHVybnMgd2hldGhl ciB0aGVyZSB3YXMgY2FjaGVkIGltYWdlIGRhdGEgdG8gY2xlYXIuCisgICAgYm9vbCBjbGVhcihi b29sIGNsZWFyTWV0YWRhdGEpOwogCiAgICAgTmF0aXZlSW1hZ2VQdHIgbV9mcmFtZTsKICAgICBi b29sIG1faGF2ZU1ldGFkYXRhOwpAQCAtMTg1LDEwICsxODcsNiBAQCBwcm90ZWN0ZWQ6CiAgICAg Ly8gZGVjcmVhc2VkIGJ5IHxmcmFtZXNDbGVhcmVkfCB0aW1lcyB0aGUgc2l6ZSAoaW4gYnl0ZXMp IG9mIGEgZnJhbWUuCiAgICAgdm9pZCBkZXN0cm95TWV0YWRhdGFBbmROb3RpZnkoaW50IGZyYW1l c0NsZWFyZWQpOwogCi0gICAgLy8gSWYgZnJhbWUgfGZyYW1lfCBpcyBjYWNoZWQsIGNsZWFycyB0 aGUgY2FjaGUgaGFuZGxlLiAgUmV0dXJucyB0aGUgbnVtYmVyCi0gICAgLy8gb2YgZnJhbWVzIGFj dHVhbGx5IGNsZWFyZWQuCi0gICAgaW50IGNsZWFyRnJhbWUoc2l6ZV90IGZyYW1lKTsKLQogICAg IC8vIFdoZXRoZXIgb3Igbm90IHNpemUgaXMgYXZhaWxhYmxlIHlldC4gICAgCiAgICAgYm9vbCBp c1NpemVBdmFpbGFibGUoKTsKIApJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWly by9JbWFnZUNhaXJvLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0ltYWdlQ2Fpcm8uY3BwCShyZXZpc2lvbiAzOTY5MykKKysrIFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VDYWlyby5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4LDE1 ICszOCwxNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXZvaWQgRnJhbWVEYXRhOjpjbGVh cigpCitib29sIEZyYW1lRGF0YTo6Y2xlYXIoYm9vbCBjbGVhck1ldGFkYXRhKQogeworICAgIGlm IChjbGVhck1ldGFkYXRhKQorICAgICAgICBtX2hhdmVNZXRhZGF0YSA9IGZhbHNlOworCiAgICAg aWYgKG1fZnJhbWUpIHsKICAgICAgICAgY2Fpcm9fc3VyZmFjZV9kZXN0cm95KG1fZnJhbWUpOwog ICAgICAgICBtX2ZyYW1lID0gMDsKLSAgICAgICAgLy8gTk9URTogV2UgcHVycG9zZWZ1bGx5IGRv bid0IHJlc2V0IG1ldGFkYXRhIGhlcmUsIHNvIHRoYXQgZXZlbiBpZiB3ZQotICAgICAgICAvLyB0 aHJvdyBhd2F5IHByZXZpb3VzbHktZGVjb2RlZCBkYXRhLCBhbmltYXRpb24gbG9vcHMgY2FuIHN0 aWxsIGFjY2VzcwotICAgICAgICAvLyBwcm9wZXJ0aWVzIGxpa2UgZnJhbWUgZHVyYXRpb25zIHdp dGhvdXQgcmUtZGVjb2RpbmcuCisgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KKyAgICByZXR1 cm4gZmFsc2U7CiB9CiAKIEJpdG1hcEltYWdlOjpCaXRtYXBJbWFnZShjYWlyb19zdXJmYWNlX3Qq IHN1cmZhY2UsIEltYWdlT2JzZXJ2ZXIqIG9ic2VydmVyKQpJbmRleDogV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jZy9JbWFnZUNHLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NnL0ltYWdlQ0cuY3BwCShyZXZpc2lvbiAzOTY5MykKKysrIFdlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VDRy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDE1ICs0 NywxNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXZvaWQgRnJhbWVEYXRhOjpjbGVhcigp Citib29sIEZyYW1lRGF0YTo6Y2xlYXIoYm9vbCBjbGVhck1ldGFkYXRhKQogeworICAgIGlmIChj bGVhck1ldGFkYXRhKQorICAgICAgICBtX2hhdmVNZXRhZGF0YSA9IGZhbHNlOworCiAgICAgaWYg KG1fZnJhbWUpIHsKICAgICAgICAgQ0dJbWFnZVJlbGVhc2UobV9mcmFtZSk7CiAgICAgICAgIG1f ZnJhbWUgPSAwOwotICAgICAgICAvLyBOT1RFOiBXZSBwdXJwb3NlZnVsbHkgZG9uJ3QgcmVzZXQg bWV0YWRhdGEgaGVyZSwgc28gdGhhdCBldmVuIGlmIHdlCi0gICAgICAgIC8vIHRocm93IGF3YXkg cHJldmlvdXNseS1kZWNvZGVkIGRhdGEsIGFuaW1hdGlvbiBsb29wcyBjYW4gc3RpbGwgYWNjZXNz Ci0gICAgICAgIC8vIHByb3BlcnRpZXMgbGlrZSBmcmFtZSBkdXJhdGlvbnMgd2l0aG91dCByZS1k ZWNvZGluZy4KKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQorICAgIHJldHVybiBmYWxzZTsK IH0KIAogLy8gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlUXQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VRdC5jcHAJKHJldmlzaW9u IDM5NjkzKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZVF0LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNjksMTQgKzY5LDE2IEBAIHN0YXRpYyBRUGl4bWFwIGxvYWRSZXNvdXJj ZVBpeG1hcChjb25zdCAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi12b2lkIEZyYW1lRGF0YTo6 Y2xlYXIoKQorYm9vbCBGcmFtZURhdGE6OmNsZWFyKGJvb2wgY2xlYXJNZXRhZGF0YSkKIHsKKyAg ICBpZiAoY2xlYXJNZXRhZGF0YSkKKyAgICAgICAgbV9oYXZlTWV0YWRhdGEgPSBmYWxzZTsKKwog ICAgIGlmIChtX2ZyYW1lKSB7CiAgICAgICAgIG1fZnJhbWUgPSAwOwotICAgICAgICAvLyBOT1RF OiBXZSBwdXJwb3NlZnVsbHkgZG9uJ3QgcmVzZXQgbWV0YWRhdGEgaGVyZSwgc28gdGhhdCBldmVu IGlmIHdlCi0gICAgICAgIC8vIHRocm93IGF3YXkgcHJldmlvdXNseS1kZWNvZGVkIGRhdGEsIGFu aW1hdGlvbiBsb29wcyBjYW4gc3RpbGwgYWNjZXNzCi0gICAgICAgIC8vIHByb3BlcnRpZXMgbGlr ZSBmcmFtZSBkdXJhdGlvbnMgd2l0aG91dCByZS1kZWNvZGluZy4KKyAgICAgICAgcmV0dXJuIHRy dWU7CiAgICAgfQorICAgIHJldHVybiBmYWxzZTsKIH0KIAogCkluZGV4OiBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3d4L0ltYWdlV3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvd3gvSW1hZ2VXeC5jcHAJKHJldmlzaW9uIDM5NjkzKQorKysgV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy93eC9JbWFnZVd4LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTIsMTUg KzUyLDE3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIC8vIHRoaXMgaXMgaW4gR3JhcGhpY3NDb250 ZXh0V3guY3BwCiBpbnQgZ2V0V3hDb21wb3NpdGluZ09wZXJhdGlvbihDb21wb3NpdGVPcGVyYXRv ciBvcCwgYm9vbCBoYXNBbHBoYSk7CiAKLXZvaWQgRnJhbWVEYXRhOjpjbGVhcigpCitib29sIEZy YW1lRGF0YTo6Y2xlYXIoYm9vbCBjbGVhck1ldGFkYXRhKQogeworICAgIGlmIChjbGVhck1ldGFk YXRhKQorICAgICAgICBtX2hhdmVNZXRhZGF0YSA9IGZhbHNlOworCiAgICAgaWYgKG1fZnJhbWUp IHsKICAgICAgICAgZGVsZXRlIG1fZnJhbWU7CiAgICAgICAgIG1fZnJhbWUgPSAwOwotICAgICAg ICAvLyBOT1RFOiBXZSBwdXJwb3NlZnVsbHkgZG9uJ3QgcmVzZXQgbWV0YWRhdGEgaGVyZSwgc28g dGhhdCBldmVuIGlmIHdlCi0gICAgICAgIC8vIHRocm93IGF3YXkgcHJldmlvdXNseS1kZWNvZGVk IGRhdGEsIGFuaW1hdGlvbiBsb29wcyBjYW4gc3RpbGwgYWNjZXNzCi0gICAgICAgIC8vIHByb3Bl cnRpZXMgbGlrZSBmcmFtZSBkdXJhdGlvbnMgd2l0aG91dCByZS1kZWNvZGluZy4KKyAgICAgICAg cmV0dXJuIHRydWU7CiAgICAgfQorICAgIHJldHVybiBmYWxzZTsKIH0KIAogLy8gPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Cg==