229866 2021-09-03 07:20:13 -0700 apply-watchlist fails for patches with non-unicode characters 2021-09-10 09:14:30 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified ASSIGNED https://bugs.webkit.org/show_bug.cgi?id=223525 InRadar P2 Normal --- 1 aakash_jain jbedard aakash_jain ap jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1790148 0 aakash_jain 2021-09-03 07:20:13 -0700 apply-watchlist fails for patches with non-unicode characters, both with python2 and python3. e.g.: e.g.: https://ews-build.webkit-uat.org/#/builders/2/builds/115 (python 2) https://ews-build.webkit-uat.org/#/builders/2/builds/114 (python 3) Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 80, in <module> main() File "Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/steps/applywatchlist.py", line 48, in run cc_and_messages = self._tool.watch_list().determine_cc_and_messages(diff) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/watchlist/watchlist.py", line 71, in determine_cc_and_messages definitions = self.find_matching_definitions(diff) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/watchlist/watchlist.py", line 40, in find_matching_definitions patch_files = DiffParser(diff.splitlines()).files File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/checkout/diff_parser.py", line 148, in __init__ self.files = self._parse_into_diff_files(diff_input) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/checkout/diff_parser.py", line 159, in _parse_into_diff_files line = string_utils.decode(line).rstrip("\n") File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/string_utils.py", line 46, in decode return data.decode(encoding, errors=errors) UnicodeDecodeError: 'utf-8' codec can't decode byte 0xcf in position 18: invalid continuation byte 1790161 1 jbedard 2021-09-03 07:49:41 -0700 Seems like we might need to parse this as bytes, then, which is what I was trying to avoid. 1792369 2 webkit-bug-importer 2021-09-10 09:14:30 -0700 <rdar://problem/82975130>