229321 2021-08-19 22:19:54 -0700 REGRESSION(r274166): [GTK] It broke run-javascriptcore-tests causing all tests to use lot of memory 2021-08-20 13:06:27 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=181916 https://bugs.webkit.org/show_bug.cgi?id=222972 P2 Normal --- 1 clopez clopez annulen aperez bugs-noreply cdumez cgarcia don.olmstead esprehn+autocc ews-watchlist fujii gyuyoung.kim kangil.han mcatanzaro pnormand ryuan.choi sergio oldest_to_newest 1785694 0 clopez 2021-08-19 22:19:54 -0700 The GTK JSC bot <https://build.webkit.org/#/builders/GTK-Linux-64-bit-Release-JS-Tests> has been failing for a long time, with crashes on all tests caused by two much memory usage. Example: basic-tests.yaml/stress-test.js.no-ftl: Running mandatory iteration #1: basic-tests.yaml/stress-test.js.no-ftl: Crashing because current footprint: 633380864 exceeds limit: 629145600 basic-tests.yaml/stress-test.js.no-ftl: 1 0x55762feeb519 WTFCrash basic-tests.yaml/stress-test.js.no-ftl: 2 0x55762ff90513 ../../../.vm/JavaScriptCore.framework/Helpers/jsc(+0xcd513) [0x55762ff90513] basic-tests.yaml/stress-test.js.no-ftl: 3 0x55762ff1164a ../../../.vm/JavaScriptCore.framework/Helpers/jsc(+0x4e64a) [0x55762ff1164a] basic-tests.yaml/stress-test.js.no-ftl: 4 0x55762ff87a89 ../../../.vm/JavaScriptCore.framework/Helpers/jsc(+0xc4a89) [0x55762ff87a89] basic-tests.yaml/stress-test.js.no-ftl: 5 0x7fb909d4b4d2 /usr/lib/x86_64-linux-gnu/libpthread.so.0(+0x84d2) [0x7fb909d4b4d2] basic-tests.yaml/stress-test.js.no-ftl: 6 0x7fb908086323 clone basic-tests.yaml/stress-test.js.no-ftl: test_script_693: line 2: 11836 Segmentation fault (core dumped) ( "$@" ../../../.vm/JavaScriptCore.framework/Helpers/jsc --useFTLJIT\=false --useFunctionDotArguments\=true --validateExceptionChecks\=true --useDollarVM\=true --maxPerThreadStackUsage\=1572864 stress-test.js ) basic-tests.yaml/stress-test.js.no-ftl: ERROR: Unexpected exit code: 139 I have bisected this and the cause is r274166, also I have double-checked that by reverting locally this commit the issue is fixed. The problem can be easily reproduced with this command: Tools/Scripts/run-javascriptcore-tests --gtk --release --memory-limit --verbose --no-testb3 --no-testapi Then almost all the JSC tests starts crashing due to trying to use more than the memory limit (which is 600 MB when passing --memory-limit) with a log like the above one. Notes: - If you don't pass --memory-limit then your machine may crash due to OOM - Passing --no-testb3 and --no-testapi is needed to avoid also an OOM crash because the testb3 and testapi tests don't seem to honour the --memory-limit switch The issue is not happening on WPE, only on GTK 1785698 1 clopez 2021-08-19 22:26:55 -0700 Bug 222972 seems related 1785737 2 cgarcia 2021-08-20 01:45:10 -0700 Let's revert then. 1785805 3 mcatanzaro 2021-08-20 06:09:04 -0700 Alas. :( Unfortunately there's no way I can debug something like this. It would need to be investigated by the JSC developers. 1785873 4 435999 clopez 2021-08-20 09:47:14 -0700 Created attachment 435999 Patch 1785954 5 clopez 2021-08-20 13:06:08 -0700 Committed r281333 (240750@main): <https://commits.webkit.org/240750@main> 435999 2021-08-20 09:47:14 -0700 2021-08-20 13:06:27 -0700 Patch bug-229321-20210820174642.patch text/plain 6427 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODU3ODFkYjdmYTlmNTM4 YjNlMmE0Yjg3ODRiNWJmMDFlOGI3N2E1OS4uOGM2ZjU5ZjNlMjhmMGQzOTU1ZmJkZDMxNTY1ZWUy Zjg3YzM3ZDhjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA4LTIwICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJF R1JFU1NJT04ocjI3NDE2Nik6IFtHVEtdIEl0IGJyb2tlIHJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0 cyBjYXVzaW5nIGFsbCB0ZXN0cyB0byB1c2UgbG90IG9mIG1lbW9yeQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5MzIxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV2ZXJ0aW5nIHIyNzQxNjYgYmVjYXVz ZSBpdCBjYXVzZWQgSlNDIHRlc3RzIHRvIHVzZSB0b28gbXVjaCBtZW1vcnkuCisKKyAgICAgICAg UmV2ZXJ0ZWQgY2hhbmdlc2V0OgorICAgICAgICAgICAgICAgICJbR1RLXSBSZWVuYWJsZSAtZnZp c2liaWxpdHk9aGlkZGVuIgorICAgICAgICAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODE5MTYKKyAgICAgICAgICAgICAgICBodHRwczovL2NvbW1pdHMu d2Via2l0Lm9yZy9yMjc0MTY2CisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4K KworICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOgorICAgICAgICAqIGRvbS9FdmVudFRhcmdl dC5jcHA6CisgICAgICAgICogZG9tL0V2ZW50VGFyZ2V0Lmg6CisKIDIwMjEtMDgtMjAgIENvbW1p dCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJldmVydGluZyByMjgxMzA3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1H VEsuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCA0MWNkNmE2 Y2ExMDc1NjNiNDBlM2E4YTg2ODliMjQyM2UxZTZjYzcwLi5iZjRjMjdiNjY4Y2QzZDFiNTdhOGM0 MWQ0YzY5NTk4OWRjYmQzYTdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdU Sy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtOCw2ICs4 LDEzIEBAIGluY2x1ZGUocGxhdGZvcm0vVGV4dHVyZU1hcHBlci5jbWFrZSkKIAogc2V0KFdlYkNv cmVfT1VUUFVUX05BTUUgV2ViQ29yZUdUSykKIAorIyBGSVhNRTogaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTkxNgorIyBSZW1vdmUgdGhlc2UgbGluZXMgd2hlbiB0 dXJuaW5nIG9uIGhpZGRlbiB2aXNpYmlsaXR5CitsaXN0KEFQUEVORCBXZWJDb3JlX1BSSVZBVEVf TElCUkFSSUVTIFdlYktpdDo6V1RGKQoraWYgKE5PVCBVU0VfU1lTVEVNX01BTExPQykKKyAgICBs aXN0KEFQUEVORCBXZWJDb3JlX1BSSVZBVEVfTElCUkFSSUVTIFdlYktpdDo6Ym1hbGxvYykKK2Vu ZGlmICgpCisKIGxpc3QoQVBQRU5EIFdlYkNvcmVfVU5JRklFRF9TT1VSQ0VfTElTVF9GSUxFUwog ICAgICJTb3VyY2VzR1RLLnR4dCIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2 ZW50VGFyZ2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFRhcmdldC5jcHAKaW5kZXgg Y2ZkYzE5MWNkNWRjYTIxODU1YmQxY2FkMWNiYmRmOTBmYThjMjc3OS4uZTBiYjEwOGU1ODk5Mzg4 YWUyMDQ2NGZlM2VlZjg4ZmY4ZTM4OTNmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L0V2ZW50VGFyZ2V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRUYXJnZXQuY3Bw CkBAIC02Niw4ICs2Niw2IEBAIFJlZjxFdmVudFRhcmdldD4gRXZlbnRUYXJnZXQ6OmNyZWF0ZShT Y3JpcHRFeGVjdXRpb25Db250ZXh0JiBjb250ZXh0KQogICAgIHJldHVybiBFdmVudFRhcmdldENv bmNyZXRlOjpjcmVhdGUoY29udGV4dCk7CiB9CiAKLUV2ZW50VGFyZ2V0Ojp+RXZlbnRUYXJnZXQo KSA9IGRlZmF1bHQ7Ci0KIGJvb2wgRXZlbnRUYXJnZXQ6OmlzTm9kZSgpIGNvbnN0CiB7CiAgICAg cmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50VGFyZ2V0 LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRUYXJnZXQuaAppbmRleCA2ODY2YWYxNjVlYzA3 OWI5ZDAzNWJmMzA2ZGQ1ODc2NjlkMjRiNTkyLi5iM2Y0MmVhNWRjMzQwMjM4NjM3MWE1YTkyYThl ODAzZDM4NTkxZTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRUYXJnZXQu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRUYXJnZXQuaApAQCAtMTAzLDcgKzEwMyw3 IEBAIHB1YmxpYzoKICAgICBjb25zdCBFdmVudFRhcmdldERhdGEqIGV2ZW50VGFyZ2V0RGF0YSgp IGNvbnN0OwogCiBwcm90ZWN0ZWQ6Ci0gICAgV0VCQ09SRV9FWFBPUlQgdmlydHVhbCB+RXZlbnRU YXJnZXQoKTsKKyAgICB2aXJ0dWFsIH5FdmVudFRhcmdldCgpID0gZGVmYXVsdDsKICAgICAKICAg ICB2aXJ0dWFsIEV2ZW50VGFyZ2V0RGF0YSogZXZlbnRUYXJnZXREYXRhKCkgPSAwOwogICAgIHZp cnR1YWwgRXZlbnRUYXJnZXREYXRhKiBldmVudFRhcmdldERhdGFDb25jdXJyZW50bHkoKSA9IDA7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFr ZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGU2NWRmNzFjMGEyNDczNTBkNWU5MTNmZmMxOGRkNGQ3 YmFiMzU0YWIuLjMwNTY1ZDRmYTAzZTYxOGI5NWQ2M2IyYzI1YmVhMzEyZDdiMmY5MzIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9P cHRpb25zR1RLLmNtYWtlCkBAIC01LDEwICs1LDYgQEAgV0VCS0lUX09QVElPTl9CRUdJTigpCiAK IFNFVF9QUk9KRUNUX1ZFUlNJT04oMiAzMyAzKQogCi1zZXQoQ01BS0VfQ19WSVNJQklMSVRZX1BS RVNFVCBoaWRkZW4pCi1zZXQoQ01BS0VfQ1hYX1ZJU0lCSUxJVFlfUFJFU0VUIGhpZGRlbikKLXNl dChibWFsbG9jX0xJQlJBUllfVFlQRSBPQkpFQ1QpCi1zZXQoV1RGX0xJQlJBUllfVFlQRSBPQkpF Q1QpCiAKIHNldChVU0VSX0FHRU5UX0JSQU5ESU5HICIiIENBQ0hFIFNUUklORyAiQnJhbmRpbmcg dG8gYWRkIHRvIHVzZXIgYWdlbnQgc3RyaW5nIikKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDAzMjcyMGZiMzZlYjQ2MWFiMTM2N2NhNWJiMjI4 NzkwOWYxNDEwM2UuLmU1YjY4ZjY3ZmEzZGYxZjRhNWZjMGNiOTc2ZGM3YzE3MGM0ZGEzYzggMTAw NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwyMCBAQAorMjAyMS0wOC0yMCAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpA aWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNzQxNjYpOiBbR1RLXSBJdCBicm9r ZSBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgY2F1c2luZyBhbGwgdGVzdHMgdG8gdXNlIGxvdCBv ZiBtZW1vcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyOTMyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJldmVydGluZyByMjc0MTY2IGJlY2F1c2UgaXQgY2F1c2VkIEpTQyB0ZXN0cyB0byB1c2UgdG9v IG11Y2ggbWVtb3J5LgorCisgICAgICAgIFJldmVydGVkIGNoYW5nZXNldDoKKyAgICAgICAgICAg ICAgICAiW0dUS10gUmVlbmFibGUgLWZ2aXNpYmlsaXR5PWhpZGRlbiIKKyAgICAgICAgICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxOTE2CisgICAgICAg ICAgICAgICAgaHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvcjI3NDE2NgorCisgICAgICAgICog VGVzdFdlYktpdEFQSS9QbGF0Zm9ybUdUSy5jbWFrZToKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJ L2dsaWIvVGVzdEV4cGVjdGF0aW9ucy5qc29uOgorCiAyMDIxLTA4LTIwICBZb3Vlbm4gRmFibGV0 ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgYWxsIFdUUiBvdXRwdXQgYmVm b3JlIENvbnRlbnQtVHlwZTp0ZXh0L3BsYWluIGZvciBXZWJSVEMgdGVzdHMgaW4gY2FzZSBvZiBr bm93biBleGNlc3NpdmUgbG9nZ2luZwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9Q bGF0Zm9ybUdUSy5jbWFrZSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1HVEsuY21ha2UK aW5kZXggY2ZmZTMyMDZlYzUxMGU5NzYxNTk5NDJlZjY1YmU0ZTBjYzE4ZDA5Ny4uZDRiMDdjMWI1 NDQyOGRkYzlmNTU0MTI2YTRlZTE0ZjBiZTVlZGYwNyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdl YktpdEFQSS9QbGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRm b3JtR1RLLmNtYWtlCkBAIC0yOCw2ICsyOCw5IEBAIGxpc3QoQVBQRU5EIFRlc3RXVEZfTElCUkFS SUVTCiAgICAgR1RLOjpHVEsKICkKIAorIyBGSVhNRTogUmVtb3ZlIHdoZW4gdHVybmluZyBvbiBo aWRkZW4gdmlzaWJpbGl0eSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTgxOTE2CitsaXN0KEFQUEVORCBUZXN0SmF2YVNjcmlwdENvcmVfTElCUkFSSUVTIFdURikKKwog IyBUZXN0V2ViQ29yZQogbGlzdChBUFBFTkQgVGVzdFdlYkNvcmVfU09VUkNFUwogICAgICR7dGVz dF9tYWluX1NPVVJDRVN9CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL2dsaWIvVGVz dEV4cGVjdGF0aW9ucy5qc29uIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9nbGliL1Rlc3RFeHBlY3Rh dGlvbnMuanNvbgppbmRleCA0NzFiYmIyNmU3NDg5YTYwNTU3NTY4MGRlOGE3MDRkMzk1MmY2ZGY3 Li44ZGQyM2I5ODVlMGQ5Y2Y1ZmQ3YmNlMDAxZmNkMzc5YTQwNDQ0NTUyIDEwMDY0NAotLS0gYS9U b29scy9UZXN0V2ViS2l0QVBJL2dsaWIvVGVzdEV4cGVjdGF0aW9ucy5qc29uCisrKyBiL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvZ2xpYi9UZXN0RXhwZWN0YXRpb25zLmpzb24KQEAgLTMyMSw5ICszMjEs NiBAQAogICAgICAgICAic3VidGVzdHMiOiB7CiAgICAgICAgICAgICAiL2pzYy92bSI6IHsKICAg ICAgICAgICAgICAgICAiZXhwZWN0ZWQiOiB7ImFsbCI6IHsic2xvdyI6IHRydWV9fQotICAgICAg ICAgICAgfSwKLSAgICAgICAgICAgICIvanNjL3dlYWstdmFsdWUiOiB7Ci0gICAgICAgICAgICAg ICAgImV4cGVjdGVkIjogeyJhbGwiOiB7InN0YXR1cyI6IFsiRkFJTCIsICJQQVNTIl0sICJidWci OiAid2Via2l0Lm9yZy9iLzIyMjk3MiJ9fQogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAg fSwKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwNGZhM2MwYjViMGEx Y2E2NzdlNmI4YzVlYTQ3NWQ5Y2FkNzMzOGUyLi4xOTNjNGM0MTUyZGJkOGQ2MTQ3ZWQ2Y2IwMzIw Mzc5ZTg3NzExNTE4IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTkgQEAKKzIwMjEtMDgtMjAgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xv cGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjc0MTY2KTogW0dUS10gSXQg YnJva2UgcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIGNhdXNpbmcgYWxsIHRlc3RzIHRvIHVzZSBs b3Qgb2YgbWVtb3J5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjkzMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZXZlcnRpbmcgcjI3NDE2NiBiZWNhdXNlIGl0IGNhdXNlZCBKU0MgdGVzdHMgdG8gdXNl IHRvbyBtdWNoIG1lbW9yeS4KKworICAgICAgICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisgICAgICAg ICAgICAgICAgIltHVEtdIFJlZW5hYmxlIC1mdmlzaWJpbGl0eT1oaWRkZW4iCisgICAgICAgICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTkxNgorICAg ICAgICAgICAgICAgIGh0dHBzOi8vY29tbWl0cy53ZWJraXQub3JnL3IyNzQxNjYKKworICAgICAg ICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOgorCiAyMDIxLTA4LTE2ICBEYXZpZCBL aWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgIm1ha2UgYW5hbHl6ZSIgc2hv dWxkIHJ1biBjbGFuZyBzdGF0aWMgYW5hbHl6ZXIgaW4gZGVlcCBtb2RlCg==