228996 2021-08-11 04:49:03 -0700 Cherry-pick ANGLE: Disable SH_SCALARIZE_VEC_AND_MAT_CONSTRUCTOR_ARGS workaround 2021-12-21 03:30:40 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Local Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 223316 1 kkinnunen kkinnunen dino ews-watchlist kbr kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1783463 0 kkinnunen 2021-08-11 04:49:03 -0700 From 572afd90bd6b1d0ff43553250a361d6ff93be36f Mon Sep 17 00:00:00 2001 From: Kenneth Russell <kbr@chromium.org> Date: Fri, 29 Jan 2021 22:45:29 -0800 Subject: [PATCH] Disable SH_SCALARIZE_VEC_AND_MAT_CONSTRUCTOR_ARGS workaround. It causes incorrect compilation of some shaders. The original graphics driver bugs that motivated enabling it have been fixed, at least on one of the platforms (macOS). Tested with new WebGL conformance test in https://github.com/KhronosGroup/WebGL/pull/3214 . Cannot be cherry-picked before bug 223316 is fixed. Must be applied locally before fixing bug 223316. 1783466 1 435335 kkinnunen 2021-08-11 04:53:59 -0700 Created attachment 435335 Patch 1783467 2 ews-watchlist 2021-08-11 04:54:55 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1783597 3 435335 kbr 2021-08-11 12:35:01 -0700 Comment on attachment 435335 Patch Sounds like there's a bug in the direct-to-MSL translator to fix here; let's defer approving this until that's known to be fixed. 1785091 4 webkit-bug-importer 2021-08-18 04:50:17 -0700 <rdar://problem/82071981> 435335 2021-08-11 04:53:59 -0700 2021-12-21 03:30:31 -0800 Patch bug-228996-20210811145358.patch text/plain 3154 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwODgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggYTY1NjFjYmI2NThlNTkyOTUzMDY1NzkyNjZiY2UzZmIxMzJhYTgzZS4uMTc4MmY4M2ZmNTY3 MGJjYjdmODUzZjIzNmMyOWZiYzc2ZjM1NzA3YSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI2IEBACisyMDIxLTA4LTExICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hlcnJ5LXBpY2sgQU5HTEU6IERpc2FibGUgU0hfU0NB TEFSSVpFX1ZFQ19BTkRfTUFUX0NPTlNUUlVDVE9SX0FSR1Mgd29ya2Fyb3VuZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4OTk2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlcnJ5LXBpY2sgQU5HTEUg Y29tbWl0OiA1NzJhZmQ5MGJkNmIxZDBmZjQzNTUzMjUwYTM2MWQ2ZmY5M2JlMzZmCisgICAgICAg IEZyb206IEtlbm5ldGggUnVzc2VsbCA8a2JyQGNocm9taXVtLm9yZz4KKyAgICAgICAgRGF0ZTog RnJpLCAyOSBKYW4gMjAyMSAyMjo0NToyOSAtMDgwMAorICAgICAgICBEaXNhYmxlIFNIX1NDQUxB UklaRV9WRUNfQU5EX01BVF9DT05TVFJVQ1RPUl9BUkdTIHdvcmthcm91bmQuCisKKyAgICAgICAg SXQgY2F1c2VzIGluY29ycmVjdCBjb21waWxhdGlvbiBvZiBzb21lIHNoYWRlcnMuIFRoZSBvcmln aW5hbCBncmFwaGljcworICAgICAgICBkcml2ZXIgYnVncyB0aGF0IG1vdGl2YXRlZCBlbmFibGlu ZyBpdCBoYXZlIGJlZW4gZml4ZWQsIGF0IGxlYXN0IG9uCisgICAgICAgIG9uZSBvZiB0aGUgcGxh dGZvcm1zIChtYWNPUykuCisKKyAgICAgICAgVGVzdGVkIHdpdGggbmV3IFdlYkdMIGNvbmZvcm1h bmNlIHRlc3QgaW4KKyAgICAgICAgaHR0cHM6Ly9naXRodWIuY29tL0tocm9ub3NHcm91cC9XZWJH TC9wdWxsLzMyMTQgLgorCisgICAgICAgICogaW5jbHVkZS9wbGF0Zm9ybS9Gcm9udGVuZEZlYXR1 cmVzLmg6CisgICAgICAgICogc3JjL2xpYkFOR0xFL0Rpc3BsYXkuY3BwOgorICAgICAgICAoZWds OjpEaXNwbGF5Ojppbml0aWFsaXplRnJvbnRlbmRGZWF0dXJlcyk6CisKIDIwMjEtMDgtMTEgIEtp bW1vIEtpbm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBBTkdMRSBDb2Nv YSBjb21waWxlcyBjb250ZW50cyBvZiBDb250ZXh0RUFHTCBvbiBtYWMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL2luY2x1ZGUvcGxhdGZvcm0vRnJvbnRlbmRGZWF0dXJlcy5o IGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5jbHVkZS9wbGF0Zm9ybS9Gcm9udGVuZEZlYXR1 cmVzLmgKaW5kZXggYzM5MGY0NDllMGU5YmE3MWQyMmQwYjQxOTA1ZDQwYTlhMmM5Y2UwMy4uZWRh YTZkZjUzNmQ3MjZiM2M4YTJlMTAzYzNiMTY5NDRkOWVmODE5NCAxMDA2NDQKLS0tIGEvU291cmNl L1RoaXJkUGFydHkvQU5HTEUvaW5jbHVkZS9wbGF0Zm9ybS9Gcm9udGVuZEZlYXR1cmVzLmgKKysr IGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5jbHVkZS9wbGF0Zm9ybS9Gcm9udGVuZEZlYXR1 cmVzLmgKQEAgLTQ4LDcgKzQ4LDcgQEAgc3RydWN0IEZyb250ZW5kRmVhdHVyZXMgOiBhbmdsZTo6 RmVhdHVyZVNldEJhc2UKICAgICBhbmdsZTo6RmVhdHVyZSBzY2FsYXJpemVWZWNBbmRNYXRDb25z dHJ1Y3RvckFyZ3MgPSB7CiAgICAgICAgICJzY2FsYXJpemVfdmVjX2FuZF9tYXRfY29uc3RydWN0 b3JfYXJncyIsIGFuZ2xlOjpGZWF0dXJlQ2F0ZWdvcnk6OkZyb250ZW5kV29ya2Fyb3VuZHMsCiAg ICAgICAgICJBbHdheXMgcmV3cml0ZSB2ZWMvbWF0IGNvbnN0cnVjdG9ycyB0byBiZSBjb25zaXN0 ZW50IiwgJm1lbWJlcnMsCi0gICAgICAgICJodHRwOi8vY3JidWcuY29tLzM5ODY5NCJ9OworICAg ICAgICAiaHR0cDovL2NyYnVnLmNvbS8xMTY1NzUxIn07CiAKICAgICAvLyBEaXNhYmxlIHN1cHBv cnQgZm9yIEdMX09FU19nZXRfcHJvZ3JhbV9iaW5hcnkKICAgICBhbmdsZTo6RmVhdHVyZSBkaXNh YmxlUHJvZ3JhbUJpbmFyeSA9IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L3NyYy9saWJBTkdMRS9EaXNwbGF5LmNwcCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9s aWJBTkdMRS9EaXNwbGF5LmNwcAppbmRleCA2NTc4MTRmZTA2NzM4OTVhODMxYTQzY2ZjY2VmYjY5 OWUyNTZmYzRhLi5jMDkzN2VlMGI4ZWQ4Y2VjZmVkNGE0NzNkMzVhNDBlNDEyNjM5YmZiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvRGlzcGxheS5jcHAK KysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL0Rpc3BsYXkuY3BwCkBA IC0xODU5LDkgKzE4NTksMTEgQEAgdm9pZCBEaXNwbGF5Ojppbml0aWFsaXplRnJvbnRlbmRGZWF0 dXJlcygpCiB7CiAgICAgLy8gRW5hYmxlIG9uIGFsbCBJbXBscwogICAgIEFOR0xFX0ZFQVRVUkVf Q09ORElUSU9OKCgmbUZyb250ZW5kRmVhdHVyZXMpLCBsb3NlQ29udGV4dE9uT3V0T2ZNZW1vcnks IHRydWUpOwotICAgIEFOR0xFX0ZFQVRVUkVfQ09ORElUSU9OKCgmbUZyb250ZW5kRmVhdHVyZXMp LCBzY2FsYXJpemVWZWNBbmRNYXRDb25zdHJ1Y3RvckFyZ3MsIHRydWUpOwogICAgIEFOR0xFX0ZF QVRVUkVfQ09ORElUSU9OKCgmbUZyb250ZW5kRmVhdHVyZXMpLCBhbGxvd0NvbXByZXNzZWRGb3Jt YXRzLCB0cnVlKTsKIAorICAgIC8vIE5vIGxvbmdlciBlbmFibGUgdGhpcyBvbiBhbnkgSW1wbCAt IGNyYnVnLmNvbS8xMTY1NzUxCisgICAgQU5HTEVfRkVBVFVSRV9DT05ESVRJT04oKCZtRnJvbnRl bmRGZWF0dXJlcyksIHNjYWxhcml6ZVZlY0FuZE1hdENvbnN0cnVjdG9yQXJncywgZmFsc2UpOwor CiAgICAgbUltcGxlbWVudGF0aW9uLT5pbml0aWFsaXplRnJvbnRlbmRGZWF0dXJlcygmbUZyb250 ZW5kRmVhdHVyZXMpOwogCiAgICAgcng6OkFwcGx5RmVhdHVyZU92ZXJyaWRlcygmbUZyb250ZW5k RmVhdHVyZXMsIG1TdGF0ZSk7Cg==