228759 2021-08-03 15:47:48 -0700 [GPUP] Test WebKit2.CrashGPUProcessAfterApplyingConstraints fails when Media in GPU Process is enabled 2021-08-16 04:41:58 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=228589 https://bugs.webkit.org/show_bug.cgi?id=228941 InRadar P2 Normal --- 1 peng.liu6 youennf eric.carlson ews-watchlist ggaren glenn hta jer.noble philipj pnormand sergio tommyw webkit-bug-importer youennf oldest_to_newest 1781772 0 peng.liu6 2021-08-03 15:47:48 -0700 /Volumes/Data/webkit/OpenSource/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:82 Expected equality of these values: @"PASS" Which is: "PASS" [message body] Which is: "FAIL checkConstraints, width is not 320 but 640" worker/0 TestWebKitAPI.WebKit2.CrashGPUProcessAfterApplyingConstraints Failed 1782010 1 webkit-bug-importer 2021-08-04 13:09:24 -0700 <rdar://problem/81529641> 1782461 2 435060 youennf 2021-08-06 02:51:46 -0700 Created attachment 435060 Patch 1782462 3 youennf 2021-08-06 02:52:44 -0700 @Phil, is reverting this change breaking GStreamer backend? How about if GStreamerVideoCaptureSource is wrapped around a RealtimeVideoSource? 1782471 4 435060 youennf 2021-08-06 05:44:03 -0700 Comment on attachment 435060 Patch Mac-wk2 debug error is unrelated 1782472 5 youennf 2021-08-06 05:45:17 -0700 @Eric, it seems https://bugs.webkit.org/show_bug.cgi?id=228795 did not fix the audio shared unit assert. 1782508 6 435060 ggaren 2021-08-06 09:39:06 -0700 Comment on attachment 435060 Patch r=me 1782537 7 435060 youennf 2021-08-06 11:58:58 -0700 Comment on attachment 435060 Patch Landing fix since it removes the regression. @Philn, let me know if you need further help for GStreamer layer 1782540 8 ews-feeder 2021-08-06 12:06:22 -0700 Committed r280732 (240319@main): <https://commits.webkit.org/240319@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435060. 1784455 9 pnormand 2021-08-16 04:10:38 -0700 (In reply to youenn fablet from comment #7) > Comment on attachment 435060 [details] > Patch > > Landing fix since it removes the regression. > @Philn, let me know if you need further help for GStreamer layer Maybe it fixed your regression but it introduced another one in WPE/GTK: https://bugs.webkit.org/show_bug.cgi?id=228941 I think I'll have to add a ifdef there, I don´t see how else to fix this, the mock sources of Cocoa and GStreamer ports differ regarding constraints validation. 1784461 10 youennf 2021-08-16 04:30:47 -0700 (In reply to Philippe Normand from comment #9) > (In reply to youenn fablet from comment #7) > > Comment on attachment 435060 [details] > > Patch > > > > Landing fix since it removes the regression. > > @Philn, let me know if you need further help for GStreamer layer > > Maybe it fixed your regression but it introduced another one in WPE/GTK: > https://bugs.webkit.org/show_bug.cgi?id=228941 > > I think I'll have to add a ifdef there, I don´t see how else to fix this, > the mock sources of Cocoa and GStreamer ports differ regarding constraints > validation. Could you try updating GStreamer to wrap GStreamerVideoCaptureSource with a RealtimeVideoSource? That is how it is used by other classes like AVVideoCaptureSource. Ideally RealtimeVideoCaptureSource should not be a RealtimeMediaSource, but I haven't refactored the code to do so. 1784468 11 pnormand 2021-08-16 04:41:58 -0700 (In reply to youenn fablet from comment #10) > (In reply to Philippe Normand from comment #9) > > (In reply to youenn fablet from comment #7) > > > Comment on attachment 435060 [details] > > > Patch > > > > > > Landing fix since it removes the regression. > > > @Philn, let me know if you need further help for GStreamer layer > > > > Maybe it fixed your regression but it introduced another one in WPE/GTK: > > https://bugs.webkit.org/show_bug.cgi?id=228941 > > > > I think I'll have to add a ifdef there, I don´t see how else to fix this, > > the mock sources of Cocoa and GStreamer ports differ regarding constraints > > validation. > > Could you try updating GStreamer to wrap GStreamerVideoCaptureSource with a > RealtimeVideoSource? I tried already, didn't change anything :( 435060 2021-08-06 02:51:46 -0700 2021-08-06 12:06:23 -0700 Patch bug-228759-20210806115144.patch text/plain 3106 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTRhMjQ5M2M5MmJhYTg2 ZjEzNjA4MmFhYWM5OTRkOTdiZDUzZTBiOS4uNDE4Y2NhY2Y3NjZlZTk2ZDFlZWRlNGQ4N2YyODk2 YmYyMzg1MmM3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA4LTA2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVUF0gVGVzdCBXZWJL aXQyLkNyYXNoR1BVUHJvY2Vzc0FmdGVyQXBwbHlpbmdDb25zdHJhaW50cyBmYWlscyB3aGVuIE1l ZGlhIGluIEdQVSBQcm9jZXNzIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyODc1OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODE1 Mjk2NDE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmV2ZXJ0IHBhcnQgb2YgaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzI3OTk0MC93 ZWJraXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZVZpZGVvU291 cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lVmlkZW9Tb3VyY2U6OnNvdXJjZVNl dHRpbmdzQ2hhbmdlZCk6CisgICAgICAgIENvdmVyZWQgYnkgQVBJIHRlc3QuCisKIDIwMjEtMDgt MDUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYktpdDo6 U2FtcGxlQnVmZmVyRGlzcGxheUxheWVyIG5lZWRzIHRvIGhhbmRsZSBHUFVQcm9jZXNzIGNyYXNo CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGlt ZVZpZGVvU291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1Jl YWx0aW1lVmlkZW9Tb3VyY2UuY3BwCmluZGV4IDFmZWE3OTE3MTJiMDEyYjY2YmQ5NmFmOWY3MzNl OWJkYjM0NDYxNDYuLmY2Nzc0MDAxNDE2ZDY2NDM1YjE5OTBlZmVmM2U2ZmY2MTUwY2VlZWYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lVmlk ZW9Tb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1Jl YWx0aW1lVmlkZW9Tb3VyY2UuY3BwCkBAIC0xMTIsNyArMTEyLDEwIEBAIHZvaWQgUmVhbHRpbWVW aWRlb1NvdXJjZTo6c291cmNlTXV0ZWRDaGFuZ2VkKCkKIHZvaWQgUmVhbHRpbWVWaWRlb1NvdXJj ZTo6c291cmNlU2V0dGluZ3NDaGFuZ2VkKCkKIHsKICAgICBhdXRvIHJvdGF0aW9uID0gbV9zb3Vy Y2UtPnNhbXBsZVJvdGF0aW9uKCk7Ci0gICAgYXV0byBzaXplID0gbV9zb3VyY2UtPnNpemUoKTsK KyAgICBhdXRvIHNpemUgPSB0aGlzLT5zaXplKCk7CisgICAgaWYgKHNpemUuaXNFbXB0eSgpKQor ICAgICAgICBzaXplID0gbV9zb3VyY2UtPnNpemUoKTsKKwogICAgIGlmIChyb3RhdGlvbiA9PSBN ZWRpYVNhbXBsZTo6VmlkZW9Sb3RhdGlvbjo6TGVmdCB8fCByb3RhdGlvbiA9PSBNZWRpYVNhbXBs ZTo6VmlkZW9Sb3RhdGlvbjo6UmlnaHQpCiAgICAgICAgIHNpemUgPSBzaXplLnRyYW5zcG9zZWRT aXplKCk7CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwpp bmRleCAzYTUyYTA5MDE0NjQ5ODEzNzkwNjc5MTQ4Mzg5ZTgxMDlhYjg2YzU5Li5hOGE1YWFmMmJi YWY0OTIyNGM1NTA2NjRmNmM0NzQ4NWFkYjFjNzE4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VM b2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDgtMDYgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFtHUFVQXSBUZXN0IFdl YktpdDIuQ3Jhc2hHUFVQcm9jZXNzQWZ0ZXJBcHBseWluZ0NvbnN0cmFpbnRzIGZhaWxzIHdoZW4g TWVkaWEgaW4gR1BVIFByb2Nlc3MgaXMgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4NzU5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84 MTUyOTY0MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L0dldFVzZXJNZWRpYS5tbToKKyAgICAgICAg UmVlbmFibGUgdGVzdC4KKwogMjAyMS0wNy0zMCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBh cHBsZS5jb20+CiAKICAgICAgICAgW2dpdC13ZWJraXRdIE5vdCBhbGwgcGxhdGZvcm1zIHN1cHBv cnQgbW9yZSAtRgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQv R2V0VXNlck1lZGlhLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvR2V0VXNl ck1lZGlhLm1tCmluZGV4IGZhMTU2ZjdkYmRkZjBjZGNkZmY5MTE5NWFmNWExYjAwMDVlNTMzNTcu LjVlNTI2MDMyYWZhMTZiYjU2NmI4ZmQyMzJkYWY4ZDRiYmMzMTcyZmQgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L0dldFVzZXJNZWRpYS5tbQorKysgYi9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9HZXRVc2VyTWVkaWEubW0KQEAgLTY0OCw3ICs2 NDgsNyBAQCBURVNUKFdlYktpdDIsIENyYXNoR1BVUHJvY2Vzc1doaWxlQ2FwdHVyaW5nKQogICAg IEVYUEVDVF9FUSh3ZWJWaWV3UElELCBbd2ViVmlldyBfd2ViUHJvY2Vzc0lkZW50aWZpZXJdKTsK IH0KIAotVEVTVChXZWJLaXQyLCBESVNBQkxFRF9DcmFzaEdQVVByb2Nlc3NBZnRlckFwcGx5aW5n Q29uc3RyYWludHMpCitURVNUKFdlYktpdDIsIENyYXNoR1BVUHJvY2Vzc0FmdGVyQXBwbHlpbmdD b25zdHJhaW50cykKIHsKICAgICBhdXRvIGNvbmZpZ3VyYXRpb24gPSBhZG9wdE5TKFtbV0tXZWJW aWV3Q29uZmlndXJhdGlvbiBhbGxvY10gaW5pdF0pOwogICAgIGF1dG8gcHJlZmVyZW5jZXMgPSBb Y29uZmlndXJhdGlvbiBwcmVmZXJlbmNlc107Cg==