228679 2021-07-31 03:26:34 -0700 REGRESSION(r279800): IntersectionObserver may never get a delivery of an observation if the element has been unobserved and is disconnected 2021-08-17 10:36:18 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=228693 https://bugs.webkit.org/show_bug.cgi?id=229196 InRadar P2 Normal --- 227194 1 rniwa rniwa ajuma cathiechen cdumez ggaren simon.fraser oldest_to_newest 1781070 0 rniwa 2021-07-31 03:26:34 -0700 After r279800 IntersectionObserver's callback may never be delivered if the observed element has been disconnected from the document, and the element has been explicitly unobserved by IntersectionObserver. 1781071 1 rniwa 2021-07-31 04:17:28 -0700 ResizeObserver has a similar code but ResizeObserver.unobserve active observation as well so it doesn't exhibit a bug per se. I don't think this is correct per spec though. Will investigate separately. 1781072 2 434696 rniwa 2021-07-31 04:28:06 -0700 Created attachment 434696 Fixes the bug 1781244 3 434696 cdumez 2021-08-02 08:21:22 -0700 Comment on attachment 434696 Fixes the bug r=me 1781349 4 rniwa 2021-08-02 12:14:39 -0700 <rdar://81057759> 1781350 5 434696 rniwa 2021-08-02 12:14:52 -0700 Comment on attachment 434696 Fixes the bug Clearing flags on attachment: 434696 Committed r280549 (240176@main): <https://commits.webkit.org/240176@main> 1781351 6 rniwa 2021-08-02 12:14:54 -0700 All reviewed patches have been landed. Closing bug. 434696 2021-07-31 04:28:06 -0700 2021-08-02 12:14:52 -0700 Fixes the bug bug-228679-20210731042805.patch text/plain 7068 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4MDUxNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA3LTMxICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3OTgwMCk6 IEludGVyc2VjdGlvbk9ic2VydmVyIG1heSBuZXZlciBnZXQgYSBkZWxpdmVyeSBvZiBhbiBvYnNl cnZhdGlvbiBpZiB0aGUgZWxlbWVudAorICAgICAgICBoYXMgYmVlbiB1bm9ic2VydmVkIGFuZCBp cyBkaXNjb25uZWN0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyODY3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBidWcgd2FzIGNhdXNlZCBieSB0aGUgZWxlbWVudHMgb2YgdGhlIHBlbmRpbmcg ZW50cmllcyBub3QgYmVpbmcgY29uc2lkZXJlZCBhcyBvcGFxdWUgcm9vdHMKKyAgICAgICAgb2Yg dGhlIGludGVyc2VjdGlvbiBvYnNlcnZlci4gSWYgdGhlIGludGVyc2VjdGlvbiBvYnNlcnZlciBp cyBubyBsb25nZXIgb2JzZXJ2aW5nIHRob3NlIGVsZW1lbnRzLAorICAgICAgICB0aGUgSlMgd3Jh cHBlciBvZiB0aGUgaW50ZXJzZWN0aW9uIG9ic2VydmVyIG1heSBiZSBjb2xsZWN0ZWQgZXJyb25l b3VzbHkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRyZXNzZXMgdGhpcyBpc3N1ZSBieSBleHBs aWNpdGx5IHRyZWF0aW5nIHRoZSBlbGVtZW50cyBvZiBwZW5kaW5nIGVudHJpZXMgYXMKKyAgICAg ICAgb3BhcXVlIHJvb3RzIG9mIHRoZSBpbnRlcnNlY3Rpb24gb2JzZXJ2ZXIgaW4gSW50ZXJzZWN0 aW9uT2JzZXJ2ZXI6OmlzUmVhY2hhYmxlRnJvbU9wYXF1ZVJvb3RzLgorCisgICAgICAgIFRlc3Q6 IGludGVyc2VjdGlvbi1vYnNlcnZlci9pbnRlcnNlY3Rpb24tb2JzZXJ2ZXIta2VlcHMtZWxlbWVu dC1vZi1xdWV1ZWQtZW50cnktYWxpdmUuaHRtbAorCisgICAgICAgICogcGFnZS9JbnRlcnNlY3Rp b25PYnNlcnZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcnNlY3Rpb25PYnNlcnZlcjo6 aXNSZWFjaGFibGVGcm9tT3BhcXVlUm9vdHMgY29uc3QpOgorCiAyMDIxLTA3LTMxICBDb21taXQg UXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBy ZXZlcnRpbmcgcjI4MDQ4OC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvSW50ZXJzZWN0aW9u T2JzZXJ2ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvSW50ZXJzZWN0 aW9uT2JzZXJ2ZXIuY3BwCShyZXZpc2lvbiAyODA1MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdl L0ludGVyc2VjdGlvbk9ic2VydmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjkwLDYgKzI5MCwx MCBAQCBib29sIEludGVyc2VjdGlvbk9ic2VydmVyOjppc1JlYWNoYWJsZUZyCiAgICAgICAgIGlm IChhdXRvKiBlbGVtZW50ID0gdGFyZ2V0LmdldCgpOyBlbGVtZW50ICYmIHZpc2l0b3IuY29udGFp bnNPcGFxdWVSb290KGVsZW1lbnQtPm9wYXF1ZVJvb3QoKSkpCiAgICAgICAgICAgICByZXR1cm4g dHJ1ZTsKICAgICB9CisgICAgZm9yIChhdXRvJiB0YXJnZXQgOiBtX3BlbmRpbmdUYXJnZXRzKSB7 CisgICAgICAgIGlmICh2aXNpdG9yLmNvbnRhaW5zT3BhcXVlUm9vdCh0YXJnZXQtPm9wYXF1ZVJv b3QoKSkpCisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CiAgICAgcmV0dXJuIGZhbHNl OwogfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODA1MTQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAyMS0wNy0zMSAgUnlvc3VrZSBO aXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNzk4MDApOiBJ bnRlcnNlY3Rpb25PYnNlcnZlciBtYXkgbmV2ZXIgZ2V0IGEgZGVsaXZlcnkgb2YgYW4gb2JzZXJ2 YXRpb24gaWYgdGhlIGVsZW1lbnQgaGFzIGJlZW4gdW5vYnNlcnZlZCBhbmQgaXMgZGlzY29ubmVj dGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg2 NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRl ZCBhIHJlZ3Jlc3Npb24gdGVzdC4KKworICAgICAgICAqIGludGVyc2VjdGlvbi1vYnNlcnZlci9p bnRlcnNlY3Rpb24tb2JzZXJ2ZXIta2VlcHMtZWxlbWVudC1vZi1xdWV1ZWQtZW50cnktYWxpdmUt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBpbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvaW50 ZXJzZWN0aW9uLW9ic2VydmVyLWtlZXBzLWVsZW1lbnQtb2YtcXVldWVkLWVudHJ5LWFsaXZlLmh0 bWw6IEFkZGVkLgorCiAyMDIxLTA3LTMxICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5j b20+CiAKICAgICAgICAgTW92ZSBET00tdW5yZWxhdGVkIHRlc3RzIG91dCBvZiBmYXN0L3JlZ2V4 L2RvbQpJbmRleDogTGF5b3V0VGVzdHMvaW50ZXJzZWN0aW9uLW9ic2VydmVyL2ludGVyc2VjdGlv bi1vYnNlcnZlci1rZWVwcy1lbGVtZW50LW9mLXF1ZXVlZC1lbnRyeS1hbGl2ZS1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaW50ZXJzZWN0aW9uLW9ic2VydmVyL2ludGVy c2VjdGlvbi1vYnNlcnZlci1rZWVwcy1lbGVtZW50LW9mLXF1ZXVlZC1lbnRyeS1hbGl2ZS1leHBl Y3RlZC50eHQJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvaW50ZXJzZWN0aW9uLW9ic2Vy dmVyL2ludGVyc2VjdGlvbi1vYnNlcnZlci1rZWVwcy1lbGVtZW50LW9mLXF1ZXVlZC1lbnRyeS1h bGl2ZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyMyBAQAorVGhpcyB0 ZXN0cyBvYnNlcnZpbmcgYW4gZWxlbWVudCB3aXRoIGFuIEludGVyc2VjdGlvbk9ic2VydmVyIGFu ZCByZW1vdmluZyB0aGUgZWxlbWVudCBmcm9tIHRoZSBkb2N1bWVudCB3aGlsZSBpdCBpcyBxdWV1 ZWQgZm9yIGRlbGl2ZXJ5LgorCitQQVNTIC0gSW50ZXJzZWN0aW9uT2JzZXJ2ZXIgd3JhcHBlciBp cyBhbGl2ZQorUEFTUyAtIEludGVyc2VjdGlvbk9ic2VydmVyIHdyYXBwZXIgaXMgYWxpdmUKK1BB U1MgLSBJbnRlcnNlY3Rpb25PYnNlcnZlciB3cmFwcGVyIGlzIGFsaXZlCitQQVNTIC0gSW50ZXJz ZWN0aW9uT2JzZXJ2ZXIgd3JhcHBlciBpcyBhbGl2ZQorUEFTUyAtIEludGVyc2VjdGlvbk9ic2Vy dmVyIHdyYXBwZXIgaXMgYWxpdmUKK1BBU1MgLSBJbnRlcnNlY3Rpb25PYnNlcnZlciB3cmFwcGVy IGlzIGFsaXZlCitQQVNTIC0gSW50ZXJzZWN0aW9uT2JzZXJ2ZXIgd3JhcHBlciBpcyBhbGl2ZQor UEFTUyAtIEludGVyc2VjdGlvbk9ic2VydmVyIHdyYXBwZXIgaXMgYWxpdmUKK1BBU1MgLSBJbnRl cnNlY3Rpb25PYnNlcnZlciB3cmFwcGVyIGlzIGFsaXZlCitQQVNTIC0gSW50ZXJzZWN0aW9uT2Jz ZXJ2ZXIgd3JhcHBlciBpcyBhbGl2ZQorUEFTUyAtIEludGVyc2VjdGlvbk9ic2VydmVyIHdyYXBw ZXIgaXMgYWxpdmUKK1BBU1MgLSBJbnRlcnNlY3Rpb25PYnNlcnZlciB3cmFwcGVyIGlzIGFsaXZl CitQQVNTIC0gSW50ZXJzZWN0aW9uT2JzZXJ2ZXIgd3JhcHBlciBpcyBhbGl2ZQorUEFTUyAtIElu dGVyc2VjdGlvbk9ic2VydmVyIHdyYXBwZXIgaXMgYWxpdmUKK1BBU1MgLSBJbnRlcnNlY3Rpb25P YnNlcnZlciB3cmFwcGVyIGlzIGFsaXZlCitQQVNTIC0gSW50ZXJzZWN0aW9uT2JzZXJ2ZXIgd3Jh cHBlciBpcyBhbGl2ZQorUEFTUyAtIEludGVyc2VjdGlvbk9ic2VydmVyIHdyYXBwZXIgaXMgYWxp dmUKK1BBU1MgLSBJbnRlcnNlY3Rpb25PYnNlcnZlciB3cmFwcGVyIGlzIGFsaXZlCitQQVNTIC0g SW50ZXJzZWN0aW9uT2JzZXJ2ZXIgd3JhcHBlciBpcyBhbGl2ZQorUEFTUyAtIEludGVyc2VjdGlv bk9ic2VydmVyIHdyYXBwZXIgaXMgYWxpdmUKKwpJbmRleDogTGF5b3V0VGVzdHMvaW50ZXJzZWN0 aW9uLW9ic2VydmVyL2ludGVyc2VjdGlvbi1vYnNlcnZlci1rZWVwcy1lbGVtZW50LW9mLXF1ZXVl ZC1lbnRyeS1hbGl2ZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2ludGVyc2VjdGlv bi1vYnNlcnZlci9pbnRlcnNlY3Rpb24tb2JzZXJ2ZXIta2VlcHMtZWxlbWVudC1vZi1xdWV1ZWQt ZW50cnktYWxpdmUuaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9pbnRlcnNlY3Rp b24tb2JzZXJ2ZXIvaW50ZXJzZWN0aW9uLW9ic2VydmVyLWtlZXBzLWVsZW1lbnQtb2YtcXVldWVk LWVudHJ5LWFsaXZlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw4NCBAQAorPCFET0NU WVBFIGh0bWw+PCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBJbnRlcnNlY3Rpb25PYnNlcnZlckVu YWJsZWQ9dHJ1ZSBdIC0tPgorPGh0bWw+Cis8Ym9keT4KKzxwcmUgaWQ9ImxvZyI+VGhpcyB0ZXN0 cyBvYnNlcnZpbmcgYW4gZWxlbWVudCB3aXRoIGFuIEludGVyc2VjdGlvbk9ic2VydmVyIGFuZCBy ZW1vdmluZyB0aGUgZWxlbWVudCBmcm9tIHRoZSBkb2N1bWVudCB3aGlsZSBpdCBpcyBxdWV1ZWQg Zm9yIGRlbGl2ZXJ5LgorCis8L3ByZT4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvZ2MuanMi Pjwvc2NyaXB0PgorPHNjcmlwdD4KKworbGV0IGluaXRpYWxOb2RlQ291bnQ7CitmdW5jdGlvbiBy dW5UZXN0KCkKK3sKKyAgICBpZiAoIXdpbmRvdy50ZXN0UnVubmVyIHx8ICF3aW5kb3cuaW50ZXJu YWxzKSB7CisgICAgICAgIGxvZy50ZXh0Q29udGVudCArPSAnRkFJTCAtIFRoaXMgdGVzdCByZXF1 aXJlcyBpbnRlcm5hbHMnOyAKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICB0ZXN0UnVubmVy LmR1bXBBc1RleHQoKTsKKyAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKworICAgIGNv bnN0IHByb21pc2VzID0gW107CisgICAgZm9yIChsZXQgaSA9IDA7IGkgPCA1OyArK2kpCisgICAg ICAgIHByb21pc2VzLnB1c2goY3JlYXRlSW50ZXJzZWN0aW9uT2JzZXJ2ZXIoKSk7CisKKyAgICBQ cm9taXNlLmFsbChwcm9taXNlcykudGhlbigoKSA9PiB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKSk7 Cit9CisKK2Z1bmN0aW9uIGNyZWF0ZUludGVyc2VjdGlvbk9ic2VydmVyKCkKK3sKKyAgICBsZXQg ZWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOworICAgIGVsZW1lbnQuc3R5 bGUucG9zaXRpb24gPSAnYWJzb2x1dGUnOworICAgIGVsZW1lbnQuc3R5bGUud2lkdGggPSAnMTAw cHgnOworICAgIGVsZW1lbnQuc3R5bGUuaGVpZ2h0ID0gJzEwMHB4JzsKKworICAgIGxldCBzdG9w cGVkID0gZmFsc2U7CisgICAgbGV0IHRlc3RpbmcgPSBmYWxzZTsKKyAgICBsZXQgaW50ZXJzZWN0 aW9uT2JzZXJ2ZXJzID0gW107CisKKyAgICBmdW5jdGlvbiBoZWxwZXIob2JzZXJ2ZXIpIHsKKyAg ICAgICAgaWYgKCF0ZXN0aW5nKQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICBpZiAoc3Rv cHBlZCkgeworICAgICAgICAgICAgbG9nLnRleHRDb250ZW50ICs9IG9ic2VydmVyLmFsaXZlID8g J1BBU1MgLSBJbnRlcnNlY3Rpb25PYnNlcnZlciB3cmFwcGVyIGlzIGFsaXZlXG4nIDogJ0ZBSUwg LSBJbnRlcnNlY3Rpb25PYnNlcnZlciB3cmFwcGVyIGlzIGRlYWRcbic7CisgICAgICAgICAgICBy ZXR1cm47CisgICAgICAgIH0KKyAgICAgICAgc3RvcHBlZCA9IHRydWU7CisgICAgICAgIGZvciAo Y29uc3Qgb2JzZXJ2ZXIgb2YgaW50ZXJzZWN0aW9uT2JzZXJ2ZXJzKQorICAgICAgICAgICAgb2Jz ZXJ2ZXIudW5vYnNlcnZlKGVsZW1lbnQpOworICAgICAgICBpbnRlcnNlY3Rpb25PYnNlcnZlcnMg PSBbXTsKKyAgICAgICAgZWxlbWVudC5yZW1vdmUoKTsKKyAgICAgICAgZWxlbWVudCA9IG51bGw7 CisgICAgfQorCisgICAgKCgpID0+IHsKKyAgICAgICAgZm9yIChsZXQgaSA9IDA7IGkgPCA1OyAr K2kpIHsKKyAgICAgICAgICAgIGNvbnN0IG9ic2VydmVyID0gbmV3IEludGVyc2VjdGlvbk9ic2Vy dmVyKGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgICAgICBoZWxwZXIodGhpcyk7CisgICAgICAg ICAgICAgICAgZ2MoKTsKKyAgICAgICAgICAgIH0pOworICAgICAgICAgICAgb2JzZXJ2ZXIuYWxp dmUgPSB0cnVlOworICAgICAgICAgICAgb2JzZXJ2ZXIub2JzZXJ2ZShlbGVtZW50KTsKKyAgICAg ICAgICAgIGludGVyc2VjdGlvbk9ic2VydmVycy5wdXNoKG9ic2VydmVyKTsKKyAgICAgICAgfQor ICAgIH0pKCk7CisKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGVsZW1lbnQpOworCisg ICAgcmV0dXJuIG5ldyBQcm9taXNlKChyZXNvbHZlKSA9PiB7CisgICAgICAgIHJlcXVlc3RBbmlt YXRpb25GcmFtZSgoKSA9PiB7CisgICAgICAgICAgICBzZXRUaW1lb3V0KCgpID0+IHsKKyAgICAg ICAgICAgICAgICB0ZXN0aW5nID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICBlbGVtZW50LnN0eWxl LnRvcCA9ICcxMDAwMHB4JzsKKyAgICAgICAgICAgICAgICByZXF1ZXN0QW5pbWF0aW9uRnJhbWUo KCkgPT4geworICAgICAgICAgICAgICAgICAgICBzZXRUaW1lb3V0KHJlc29sdmUsIDApOworICAg ICAgICAgICAgICAgIH0pOworICAgICAgICAgICAgfSwgMCk7CisgICAgICAgIH0pOworICAgIH0p OworfQorCitvbmxvYWQgPSBydW5UZXN0OworCis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K