227905 2021-07-13 08:38:18 -0700 Remove USE_64KB_PAGE_BLOCK 2022-08-17 08:59:44 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=217989 https://bugs.webkit.org/show_bug.cgi?id=244036 P2 Normal --- 1 mcatanzaro mcatanzaro annulen benjamin bugs-noreply cdumez cmarcelo ews-watchlist gyuyoung.kim mcatanzaro ryuan.choi sergio ysuzuki oldest_to_newest 1776635 0 mcatanzaro 2021-07-13 08:38:18 -0700 I added the USE_64KB_PAGE_BLOCK build option in bug #217989 for use by RHEL. But going forward, I don't need it anymore, and can maintain it downstream where it is needed. (This option might also be useful to SUSE, but they already don't use it, so won't miss it.) I've seen users who don't understand the consequences of this option enabling it on x86_64, even though there are serious negative consequences and zero benefits to using it. So let's get rid of it. 1776637 1 433407 mcatanzaro 2021-07-13 08:42:42 -0700 Created attachment 433407 Patch 1776697 2 433407 ysuzuki 2021-07-13 11:35:13 -0700 Comment on attachment 433407 Patch r=me 1776761 3 ews-feeder 2021-07-13 14:53:28 -0700 Committed r279892 (239643@main): <https://commits.webkit.org/239643@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433407. 433407 2021-07-13 08:42:42 -0700 2021-07-13 14:53:30 -0700 Patch bug-227905-20210713104241.patch text/plain 5678 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5ODcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDk3YjEwMzE0YjYxZDczYjI1YjUzYzJl ZjJiODMyMDM2N2MxMjkzNzEuLjNlN2E5ZmM3YThiZDE1YTE0NDM0MjhkZjc0OWNhYjU2NzNmNGUy NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMDctMTMgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIFVTRV82NEtCX1BBR0VfQkxP Q0sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzkw NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3Rm L1BhZ2VCbG9jay5oOgorCiAyMDIxLTA3LTEyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+IGFuZCBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgTmV3 IG1hbGxvYyBhbGdvcml0aG0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BhZ2VCbG9jay5o IGIvU291cmNlL1dURi93dGYvUGFnZUJsb2NrLmgKaW5kZXggNjA4MmYyZDYyYmJkMzJmNTE1MTFk M2U1NWRjNjdkZTI3ZGUzMmYxYi4uYzIxOTBlOGZhZmFhYzY1NDNlZDRmMGM5MDAzZDFmMTk1MmFk ZDZlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGFnZUJsb2NrLmgKKysrIGIvU291cmNl L1dURi93dGYvUGFnZUJsb2NrLmgKQEAgLTQzLDEzICs0MywxMCBAQCBuYW1lc3BhY2UgV1RGIHsK IC8vCiAvLyBPbiBMaW51eCwgUG93ZXIgc3lzdGVtcyBub3JtYWxseSB1c2UgNjQgS2lCIHBhZ2Vz LgogLy8KLS8vIGFhcmNoNjQgc3lzdGVtcyBzZWVtIHRvIGJlIGFsbCBvdmVyIHRoZSBwbGFjZS4g TW9zdCBMaW51eCBkaXN0cm9zIHVzZSA0IEtpQiwgYnV0IFJIRUwgdXNlcwotLy8gNjQgS2lCLiAo QXBwbGUgdXNlcyAxNiBLaUIuKQotLy8KIC8vIFVzZSA2NCBLaUIgZm9yIGFueSB1bmtub3duIENQ VXMgdG8gYmUgY29uc2VydmF0aXZlLgogI2lmIE9TKERBUldJTikgfHwgUExBVEZPUk0oUExBWVNU QVRJT04pIHx8IENQVShNSVBTKSB8fCBDUFUoTUlQUzY0KQogY29uc3RleHByIHNpemVfdCBDZWls aW5nT25QYWdlU2l6ZSA9IDE2ICogS0I7Ci0jZWxpZiBVU0UoNjRLQl9QQUdFX0JMT0NLKSB8fCBD UFUoUFBDKSB8fCBDUFUoUFBDNjQpIHx8IENQVShQUEM2NExFKSB8fCBDUFUoVU5LTk9XTikKKyNl bGlmIENQVShQUEMpIHx8IENQVShQUEM2NCkgfHwgQ1BVKFBQQzY0TEUpIHx8IENQVShVTktOT1dO KQogY29uc3RleHByIHNpemVfdCBDZWlsaW5nT25QYWdlU2l6ZSA9IDY0ICogS0I7CiAjZWxpZiBP UyhXSU5ET1dTKSB8fCBDUFUoWDg2KSB8fCBDUFUoWDg2XzY0KSB8fCBDUFUoQVJNKSB8fCBDUFUo QVJNNjQpCiBjb25zdGV4cHIgc2l6ZV90IENlaWxpbmdPblBhZ2VTaXplID0gNCAqIEtCOwpkaWZm IC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlIGIvU291cmNlL2NtYWtl L1dlYktpdEZlYXR1cmVzLmNtYWtlCmluZGV4IGI5Mjk0YWQxMTZhYjFjYjY5NWExOTlkN2FkOWIz NmYyOGE1OWIzMzYuLjBkMWVmOGEzNWI5ZGE1NDI0MTgyZjNlYjE4NTY4OWNmZTU1MzI1ZTIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZQorKysgYi9Tb3VyY2Uv Y21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKQEAgLTU5LDM5ICs1OSwxMCBAQCBtYWNybyhXRUJL SVRfT1BUSU9OX0RFUEVORCBfbmFtZSBfZGVwZW5kKQogICAgIGxpc3QoQVBQRU5EIF9XRUJLSVRf QVZBSUxBQkxFX09QVElPTlNfJHtfbmFtZX1fREVQRU5ERU5DSUVTICR7X2RlcGVuZH0pCiBlbmRt YWNybygpCiAKLSMgV2UgY2FuJ3QgdXNlIFdFQktJVF9PUFRJT05fREVGSU5FIGZvciBVU0VfNjRL Ql9QQUdFX0JMT0NLIGJlY2F1c2UgaXQncyBuZWVkZWQgdG8gc2V0IHRoZSBkZWZhdWx0Ci0jIHZh bHVlIG9mIG90aGVyIG9wdGlvbnMuIFdoeSBkbyB3ZSBuZWVkIHRoaXMgb3B0aW9uPyBCZWNhdXNl IEpTQyBhbmQgYm1hbGxvYyBib3RoIHdhbnQgdG8ga25vdyB0aGUKLSMgdXNlcnNwYWNlIHBhZ2Ug c2l6ZSBhdCBjb21waWxlIHRpbWUsIHdoaWNoIGlzIGltcG9zc2libGUgb24gTGludXggYmVjYXVz ZSBpdCdzIGEgcnVudGltZSBzZXR0aW5nLgotIyBXZSBjYW5ub3QgdGVzdCB0aGUgc3lzdGVtIHBh Z2Ugc2l6ZSBhdCBidWlsZCB0aW1lIGluIGhvcGVzIHRoYXQgaXQgd2lsbCBiZSB0aGUgc2FtZSBv biB0aGUgdGFyZ2V0Ci0jIHN5c3RlbSwgYmVjYXVzZSAoYSkgY3Jvc3MgY29tcGlsaW5nIHdvdWxk bid0IHdvcmssIGFuZCAoYikgdGhlIGJ1aWxkIHN5c3RlbSBjb3VsZCB1c2UgYSBkaWZmZXJlbnQK LSMgcGFnZSBzaXplIHRoYW4gdGhlIHRhcmdldCBzeXN0ZW0gKHdoaWNoIHdpbGwgYmUgdHJ1ZSBm b3IgRmVkb3JhIGFhcmNoNjQsIGJlY2F1c2UgRmVkb3JhIGlzIGJ1aWx0Ci0jIHVzaW5nIFJIRUwp LCBzbyB0aGUgYmVzdCB3ZSBjYW4gZG8gaXMgZ3Vlc3MgYmFzZWQgb24gYmFzZWQgb24gdGhlIHRh cmdldCBDUFUgYXJjaGl0ZWN0dXJlLiBJbgotIyBwcmFjdGljZSwgZ3Vlc3Npbmcgd29ya3MgZm9y IGFsbCBhcmNoaXRlY3R1cmVzIGV4Y2VwdCBhYXJjaDY0ICh1bmxlc3MgdW51c3VhbCBwYWdlIHNp emVzIGFyZQotIyB1c2VkKSwgYnV0IGl0IGZhaWxzIGZvciBhYXJjaDY0IGJlY2F1c2UgZGlzdHJv cyBhcmUgc3BsaXQgYmV0d2VlbiB1c2luZyA0IEtCIGFuZCA2NCBLQiBwYWdlcwotIyB0aGVyZS4g TW9zdCBkaXN0cm9zIChpbmNsdWRpbmcgRmVkb3JhKSB1c2UgNCBLQiwgYnV0IFJIRUwgdXNlcyA2 NCBLQi4gU1VTRSBhY3R1YWxseSBzdXBwb3J0cyBib3RoLgotIyBTaW5jZSB0aGVyZSBpcyBubyB3 YXkgdG8gZ3Vlc3MgY29ycmVjdGx5LCB0aGUgYmVzdCB3ZSBjYW4gZG8gaXMgcHJvdmlkZSBhbiBv cHRpb24gZm9yIGl0LiBZb3UKLSMgc2hvdWxkIHByb2JhYmx5IG9ubHkgdXNlIHRoaXMgaWYgYnVp bGRpbmcgZm9yIGFhcmNoNjQuIE90aGVyd2lzZSwga25vd24gQ1BVcyBleGNlcHQgUG93ZXJQQwot IyB3aWxsIHVzZSA0IEtCLCB3aGlsZSBQb3dlclBDIGFuZCB1bmtub3duIENQVXMgd2lsbCB1c2Ug NjQgS0IgKHNlZSB3dGYvUGFnZUJsb2NrLmgpLiBhYXJjaDY0IHdpbGwKLSMgY29udGludWUgdG8g ZGVmYXVsdCB0byA0IEtCIGJlY2F1c2UgdGhpcyBpcyBhIGJldHRlciBkZWZhdWx0IG9uIHN5c3Rl bXMgd2hlcmUgaXQgZG9lc24ndCBjcmFzaC4KLSMgKExpbnV4IGFhcmNoNjQgaXMgZGlmZmVyZW50 IGZyb20gQXBwbGUncyBBUk02NCwgd2hpY2ggdXNlcyAxNiBLQi4pCi1vcHRpb24oVVNFXzY0S0Jf UEFHRV9CTE9DSyAiRm9yY2Ugc3VwcG9ydCA2NCBLQiB1c2Vyc3BhY2UgcGFnZSBzaXplIChyZWR1 Y2VzIHNlY3VyaXR5IGFuZCBwZXJmb3JtYW5jZSkiIE9GRikKLQogbWFjcm8oV0VCS0lUX09QVElP Tl9CRUdJTikKICAgICBzZXQoX1NFVFRJTkdfV0VCS0lUX09QVElPTlMgVFJVRSkKIAotICAgIGlm IChVU0VfNjRLQl9QQUdFX0JMT0NLKQotICAgICAgICBzZXQoRU5BQkxFX0pJVF9ERUZBVUxUIE9G RikKLSAgICAgICAgc2V0KEVOQUJMRV9GVExfREVGQVVMVCBPRkYpCi0gICAgICAgIHNldChVU0Vf U1lTVEVNX01BTExPQ19ERUZBVUxUIE9OKQotICAgICAgICBpZiAoV1RGX0NQVV9BUk02NCkKLSAg ICAgICAgICAgIHNldChFTkFCTEVfQ19MT09QX0RFRkFVTFQgT0ZGKQotICAgICAgICAgICAgc2V0 KEVOQUJMRV9TQU1QTElOR19QUk9GSUxFUl9ERUZBVUxUIE9OKQotICAgICAgICBlbHNlICgpCi0g ICAgICAgICAgICBtZXNzYWdlKFdBUk5JTkcgIkJ1aWxkaW5nIHdpdGggVVNFXzY0S0JfUEFHRV9C TE9DSyBvbiBhbiBhcmNoaXRlY3R1cmUgb3RoZXIgdGhhbiBhYXJjaDY0IGlzIHVudXN1YWwuIEFy ZSB5b3Ugc3VyZSB5b3Ugd2FudCBVU0VfNjRLQl9QQUdFX0JMT0NLPyIpCi0gICAgICAgICAgICBz ZXQoRU5BQkxFX0NfTE9PUF9ERUZBVUxUIE9OKQotICAgICAgICAgICAgc2V0KEVOQUJMRV9TQU1Q TElOR19QUk9GSUxFUl9ERUZBVUxUIE9GRikKLSAgICAgICAgZW5kaWYgKCkKLSAgICBlbHNlaWYg KFdURl9DUFVfQVJNNjQgT1IgV1RGX0NQVV9YODZfNjQpCisgICAgaWYgKFdURl9DUFVfQVJNNjQg T1IgV1RGX0NQVV9YODZfNjQpCiAgICAgICAgIHNldChFTkFCTEVfSklUX0RFRkFVTFQgT04pCiAg ICAgICAgIHNldChFTkFCTEVfRlRMX0RFRkFVTFQgT04pCiAgICAgICAgIHNldChVU0VfU1lTVEVN X01BTExPQ19ERUZBVUxUIE9GRikKQEAgLTQ1Miw1ICs0MjMsMyBAQCBlbmRtYWNybygpCiAKIG9w dGlvbihFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTICJFbmFibGUgZXhwZXJpbWVudGFsIGZl YXR1cmVzIiBPRkYpCiBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChFTkFCTEVfRVhQRVJJTUVOVEFM X0ZFQVRVUkVTICR7RU5BQkxFX0VYUEVSSU1FTlRBTF9GRUFUVVJFU30pCi0KLVNFVF9BTkRfRVhQ T1NFX1RPX0JVSUxEKFVTRV82NEtCX1BBR0VfQkxPQ0sgJHtVU0VfNjRLQl9QQUdFX0JMT0NLfSkK ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5YTBiNTMwNGE0MTgzYjc0 ZWMwYjEzYWZhNWJmNDdmNGQzMmQ2YzI4Li44ZmZkYmFiZjk3YTEwYjdkOTFkNjY5MGU0MTBjMmUx MjJhODgyYWIzIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjAgQEAKKzIwMjEtMDctMTMgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9t ZS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIFVTRV82NEtCX1BBR0VfQkxPQ0sKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzkwNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEkgYWRkZWQgdGhlIFVTRV82NEtC X1BBR0VfQkxPQ0sgYnVpbGQgb3B0aW9uIGluIGJ1ZyAjMjE3OTg5IGZvciB1c2UgYnkgUkhFTC4g QnV0IGdvaW5nCisgICAgICAgIGZvcndhcmQsIEkgZG9uJ3QgbmVlZCBpdCBhbnltb3JlLCBhbmQg Y2FuIG1haW50YWluIGl0IGRvd25zdHJlYW0gd2hlcmUgaXQgaXMgbmVlZGVkLiAoVGhpcworICAg ICAgICBvcHRpb24gbWlnaHQgYWxzbyBiZSB1c2VmdWwgdG8gU1VTRSwgYnV0IHRoZXkgYWxyZWFk eSBkb24ndCB1c2UgaXQsIHNvIHdvbid0IG1pc3MgaXQuKQorCisgICAgICAgIEkndmUgc2VlbiB1 c2VycyB3aG8gZG9uJ3QgdW5kZXJzdGFuZCB0aGUgY29uc2VxdWVuY2VzIG9mIHRoaXMgb3B0aW9u IGVuYWJsaW5nIGl0IG9uIHg4Nl82NCwKKyAgICAgICAgZXZlbiB0aG91Z2ggdGhlcmUgYXJlIHNl cmlvdXMgbmVnYXRpdmUgY29uc2VxdWVuY2VzIGFuZCB6ZXJvIGJlbmVmaXRzIHRvIHVzaW5nIGl0 LiBTbyBsZXQncworICAgICAgICBnZXQgcmlkIG9mIGl0LgorCisgICAgICAgICogU291cmNlL2Nt YWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlOgorCiAyMDIxLTA3LTEzICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIEV4cG9zZSBz dXBwb3J0IGZvciBjbGllbnQgY2VydGlmaWNhdGUgYXV0aAo=