<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>226557</bug_id>
          
          <creation_ts>2021-06-02 15:41:34 -0700</creation_ts>
          <short_desc>-Warray-bounds, -Wstringop-truncation, -Wstringop-overread warnings in Packed.h</short_desc>
          <delta_ts>2021-11-11 13:09:53 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=226193</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Minor</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>228601</dependson>
    
    <dependson>228808</dependson>
          <blocked>155047</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>annulen</cc>
    
    <cc>aperez</cc>
    
    <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>msaboff</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>saam</cc>
    
    <cc>sergio</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1766189</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-06-02 15:41:34 -0700</bug_when>
    <thetext>Splitting this from bug #226193. We have a -Warray-bounds warning in Packed.h. Fortunately it&apos;s only triggered when compiling WebSocket.cpp, which is why it&apos;s not a more serious warning spam:

[506/1614] Building CXX object Source/WebCore/CMakeFiles/...edSources/unified-sources/UnifiedSource-4babe430-49.cpp.o
In file included from WTF/Headers/wtf/text/StringImpl.h:32,
                 from WTF/Headers/wtf/text/WTFString.h:31,
                 from ../../Source/WebCore/dom/Exception.h:30,
                 from ../../Source/WebCore/dom/ExceptionOr.h:29,
                 from ../../Source/WebCore/dom/Event.h:29,
                 from ../../Source/WebCore/Modules/websockets/CloseEvent.h:33,
                 from ../../Source/WebCore/Modules/websockets/CloseEvent.cpp:27,
                 from WebCore/DerivedSources/unified-sources/UnifiedSource-4babe430-49.cpp:2:
In member function ‘T* WTF::PackedAlignedPtr&lt;T, &lt;anonymous&gt; &gt;::get() const [with T = JSC::SharedArrayBufferContents; long unsigned int passedAlignment = 1]’,
    inlined from ‘WTF::PackedAlignedPtr&lt;T, &lt;anonymous&gt; &gt;::operator bool() const [with T = JSC::SharedArrayBufferContents; long unsigned int passedAlignment = 1]’ at WTF/Headers/wtf/Packed.h:188:48,
    inlined from ‘WTF::RefPtr&lt;T, &lt;template-parameter-1-2&gt;, &lt;template-parameter-1-3&gt; &gt;::operator WTF::RefPtr&lt;T, &lt;template-parameter-1-2&gt;, &lt;template-parameter-1-3&gt; &gt;::UnspecifiedBoolType() const [with T = JSC::SharedArrayBufferContents; _PtrTraits = WTF::PackedPtrTraits&lt;JSC::SharedArrayBufferContents&gt;; _RefDerefTraits = WTF::DefaultRefDerefTraits&lt;JSC::SharedArrayBufferContents&gt;]’ at WTF/Headers/wtf/RefPtr.h:91:57,
    inlined from ‘bool JSC::ArrayBufferContents::isShared() const’ at JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBuffer.h:84:36,
    inlined from ‘bool JSC::ArrayBuffer::isShared() const’ at JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBuffer.h:202:31,
    inlined from ‘WTF::RefPtr&lt;JSC::ArrayBuffer&gt; JSC::ArrayBufferView::unsharedBuffer() const’ at JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBufferView.h:60:9,
    inlined from ‘WebCore::ExceptionOr&lt;void&gt; WebCore::WebSocket::send(JSC::ArrayBufferView&amp;)’ at ../../Source/WebCore/Modules/websockets/WebSocket.cpp:389:52:
WTF/Headers/wtf/Packed.h:140:15: warning: ‘void* memcpy(void*, const void*, size_t)’ offset [0, 5] is out of the bounds [0, 0] [-Warray-bounds]
  140 |         memcpy(&amp;value, m_storage.data(), storageSize);
      |         ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1768372</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-06-09 15:42:21 -0700</bug_when>
    <thetext>&lt;rdar://problem/79103658&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1769527</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-06-14 13:35:33 -0700</bug_when>
    <thetext>OK, at first I thought this was yet another false-positive, but now I see why GCC is complaining. Here is PackedAlignedPtr::get in Packed.h:

    T* get() const
    {
        // FIXME: PackedPtr&lt;&gt; can load memory with one mov by checking page boundary.
        // https://bugs.webkit.org/show_bug.cgi?id=197754
        uintptr_t value = 0;
#if CPU(LITTLE_ENDIAN)
        memcpy(&amp;value, m_storage.data(), storageSize);
#else
        memcpy(bitwise_cast&lt;uint8_t*&gt;(&amp;value) + (sizeof(void*) - storageSize), m_storage.data(), storageSize);
#endif
        if (isAlignmentShiftProfitable)
            value &lt;&lt;= alignmentShiftSize;

#if CPU(X86_64) &amp;&amp; !(OS(DARWIN) || OS(LINUX) || OS(WINDOWS))
        // The AMD specification requires that the most significant 16
        // bits of any virtual address, bits 48 through 63, must be
        // copies of bit 47 (in a manner akin to sign extension).
        //
        // The above-named OSes will never allocate user space addresses
        // with bit 47 set, thus are already in canonical form.
        //
        // Reference: https://en.wikipedia.org/wiki/X86-64#Virtual_address_space_details
        constexpr unsigned shiftBits = countOfBits&lt;uintptr_t&gt; - OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH);
        value = (bitwise_cast&lt;intptr_t&gt;(value) &lt;&lt; shiftBits) &gt;&gt; shiftBits;
#endif

        return bitwise_cast&lt;T*&gt;(value);
    }

The only lines that matter are here:

        uintptr_t value = 0;
#if CPU(LITTLE_ENDIAN)
        memcpy(&amp;value, m_storage.data(), storageSize);

Here storageSize is 5, so we copy five bytes of data from m_storage.data() to &amp;value, which the compiler expects to be an array but is actually a uintptr_t declared on the stack. So I guess the compiler is reasonable to treat one uintptr_t as a zero-length memory region and emit the warning. We know this ought to be OK for 64-bit systems because we know that uintptr_t will be 8-bytes long, so it&apos;s not really zero-length. It is clearly intentional, so the warning should be suppressed manually.

The safety depends on (a) storageSize &lt;= sizeof(uintptr_t) -- so maybe we should add a static_assert for that --, and (b) compiler not deciding the memcpy is undefined behavior that can be &quot;optimized&quot; away.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1769549</commentid>
    <comment_count>3</comment_count>
      <attachid>431366</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-06-14 14:31:43 -0700</bug_when>
    <thetext>Created attachment 431366
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1769837</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-06-15 09:47:50 -0700</bug_when>
    <thetext>Committed r278878 (238821@main): &lt;https://commits.webkit.org/238821@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431366.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1773071</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-06-28 08:08:19 -0700</bug_when>
    <thetext>Reopening because I forgot to suppress the -Wstringop-overread warning that appears when the -Warray-bounds warning is suppressed. The analysis in comment #2 applies just the same to this:

[2629/5494] Building CXX object Source...ources/UnifiedSource-4babe430-49.cpp.o
In file included from WTF/Headers/wtf/text/StringImpl.h:32,
                 from WTF/Headers/wtf/text/WTFString.h:31,
                 from ../../Source/WebCore/dom/Exception.h:30,
                 from ../../Source/WebCore/dom/ExceptionOr.h:29,
                 from ../../Source/WebCore/dom/Event.h:29,
                 from ../../Source/WebCore/Modules/websockets/CloseEvent.h:33,
                 from ../../Source/WebCore/Modules/websockets/CloseEvent.cpp:27,
                 from WebCore/DerivedSources/unified-sources/UnifiedSource-4babe430-49.cpp:1:
In member function ‘T* WTF::PackedAlignedPtr&lt;T, &lt;anonymous&gt; &gt;::get() const [with T = JSC::SharedArrayBufferContents; long unsigned int passedAlignment = 1]’,
    inlined from ‘WTF::PackedAlignedPtr&lt;T, &lt;anonymous&gt; &gt;::operator bool() const [with T = JSC::SharedArrayBufferContents; long unsigned int passedAlignment = 1]’ at WTF/Headers/wtf/Packed.h:197:48,
    inlined from ‘WTF::RefPtr&lt;T, &lt;template-parameter-1-2&gt;, &lt;template-parameter-1-3&gt; &gt;::operator WTF::RefPtr&lt;T, &lt;template-parameter-1-2&gt;, &lt;template-parameter-1-3&gt; &gt;::UnspecifiedBoolType() const [with T = JSC::SharedArrayBufferContents; _PtrTraits = WTF::PackedPtrTraits&lt;JSC::SharedArrayBufferContents&gt;; _RefDerefTraits = WTF::DefaultRefDerefTraits&lt;JSC::SharedArrayBufferContents&gt;]’ at WTF/Headers/wtf/RefPtr.h:91:57,
    inlined from ‘bool JSC::ArrayBufferContents::isShared() const’ at JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBuffer.h:84:36,
    inlined from ‘bool JSC::ArrayBuffer::isShared() const’ at JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBuffer.h:202:31,
    inlined from ‘WTF::RefPtr&lt;JSC::ArrayBuffer&gt; JSC::ArrayBufferView::unsharedBuffer() const’ at JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBufferView.h:60:9,
    inlined from ‘WebCore::ExceptionOr&lt;void&gt; WebCore::WebSocket::send(JSC::ArrayBufferView&amp;)’ at ../../Source/WebCore/Modules/websockets/WebSocket.cpp:389:52:
WTF/Headers/wtf/Packed.h:147:15: warning: ‘void* memcpy(void*, const void*, size_t)’ reading 6 bytes from a region of size 0 [-Wstringop-overread]
  147 |         memcpy(&amp;value, m_storage.data(), storageSize);
      |         ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

We know it&apos;s &quot;safe&quot; because storageSize &lt;= sizeof(uintptr_t), and since r278878 we now have a static_assert to guarantee that. But the compiler not-unreasonably thinks it&apos;s bad because value is not an array.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1773072</commentid>
    <comment_count>6</comment_count>
      <attachid>432395</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-06-28 08:15:31 -0700</bug_when>
    <thetext>Created attachment 432395
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1773086</commentid>
    <comment_count>7</comment_count>
      <attachid>432395</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-06-28 08:54:56 -0700</bug_when>
    <thetext>Comment on attachment 432395
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432395&amp;action=review

&gt; Source/WTF/wtf/Packed.h:149
&gt; +IGNORE_WARNINGS_BEGIN(&quot;stringop-overread&quot;)

It doesn&apos;t work. GCC is just ignoring the pragma.

We might have to rewrite this code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1773814</commentid>
    <comment_count>8</comment_count>
      <attachid>432610</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-06-30 10:57:40 -0700</bug_when>
    <thetext>Created attachment 432610
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1773864</commentid>
    <comment_count>9</comment_count>
      <attachid>432610</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-06-30 12:52:36 -0700</bug_when>
    <thetext>Comment on attachment 432610
Patch

Ugh, I made a last-minute improvement that reintroduced the -Wstringop-overread warning that this patch was intended to fix. This warning is brutal. I don&apos;t understand why the usual warning pragmas are unable to suppress it. Normally they work for all warnings except those implemented by the preprocessor (cpp)....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1780529</commentid>
    <comment_count>10</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-07-29 13:13:37 -0700</bug_when>
    <thetext>We&apos;ll use -Wno-array-bounds to eliminate the -Warray-bounds warning, bug #228601.

That will introduce the -Wstringop-truncation warning. The only solution I found is -Wno-stringop-truncation. So far I&apos;ve tested using it globally, but since this warning does not have an excessive amount of false positives like -Warray-bounds does, I think we can safely remove WebSocket.cpp from the unified build and apply the flag only to this file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1780560</commentid>
    <comment_count>11</comment_count>
      <attachid>434570</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-07-29 14:00:20 -0700</bug_when>
    <thetext>Created attachment 434570
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1780627</commentid>
    <comment_count>12</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-07-29 16:29:20 -0700</bug_when>
    <thetext>Ah, I need to add WebSocket.cpp to the XCode project, because that is a thing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1780766</commentid>
    <comment_count>13</comment_count>
      <attachid>434621</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-07-30 07:28:33 -0700</bug_when>
    <thetext>Created attachment 434621
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1780770</commentid>
    <comment_count>14</comment_count>
      <attachid>434622</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-07-30 07:36:11 -0700</bug_when>
    <thetext>Created attachment 434622
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1780774</commentid>
    <comment_count>15</comment_count>
      <attachid>434624</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-07-30 07:42:07 -0700</bug_when>
    <thetext>Created attachment 434624
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1780775</commentid>
    <comment_count>16</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-07-30 07:42:54 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #15)
&gt; Created attachment 434624 [details]
&gt; Patch

If this doesn&apos;t work, I&apos;m going to give up on editing the XCode project, and suppress -Wstringop-overread globally instead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1780777</commentid>
    <comment_count>17</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-07-30 07:46:48 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #16)
&gt; If this doesn&apos;t work, I&apos;m going to give up on editing the XCode project

I am defeated. :/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1780782</commentid>
    <comment_count>18</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-07-30 08:01:39 -0700</bug_when>
    <thetext>Maybe an Apple developer would be willing to help with removing WebSocket.cpp from the unified build? Otherwise, I will suppress -Wstringop-truncation globally when built with GCC in bug #228601. It&apos;s very frustrating that it cannot be suppressed with pragmas. :/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1782201</commentid>
    <comment_count>19</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-08-05 07:52:44 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #18)
&gt; Maybe an Apple developer would be willing to help with removing
&gt; WebSocket.cpp from the unified build? Otherwise, I will suppress
&gt; -Wstringop-truncation globally when built with GCC in bug #228601. It&apos;s very
&gt; frustrating that it cannot be suppressed with pragmas. :/

Darin handled this in bug #228808. Thanks Darin!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1782205</commentid>
    <comment_count>20</comment_count>
      <attachid>434985</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-08-05 08:04:21 -0700</bug_when>
    <thetext>Created attachment 434985
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1782895</commentid>
    <comment_count>21</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-08-09 08:59:35 -0700</bug_when>
    <thetext>Committed r280778 (240362@main): &lt;https://commits.webkit.org/240362@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434985.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1814111</commentid>
    <comment_count>22</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-11-11 10:42:35 -0800</bug_when>
    <thetext>Reopening. When building with LTO enabled, there are more warnings here:

[5489/5749] Linking CXX executable bin/TestWebKitAPI/TestWebCore
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.h:33: note: type name ‘sh::TParseContext’ should match type name ‘angle::pp::Tokenizer::Context’
   33 | class TParseContext : angle::NonCopyable
      | 
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.h:25: note: the incompatible type is defined here
   25 |     struct Context
      | 
In member function ‘get’,
    inlined from ‘__conv_op ’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WTF/Headers/wtf/Packed.h:198:48,
    inlined from ‘__conv_op ’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WTF/Headers/wtf/RefPtr.h:89:57,
    inlined from ‘isShared’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBuffer.h:93:36,
    inlined from ‘isShared’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBuffer.h:211:31,
    inlined from ‘unsharedBuffer’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBufferView.h:61:9,
    inlined from ‘send’ at /home/mcatanzaro/Projects/WebKit/Source/WebCore/Modules/websockets/WebSocket.cpp:386:52,
    inlined from ‘operator()’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/JSWebSocket.cpp:537:5,
    inlined from ‘toJS’ at /home/mcatanzaro/Projects/WebKit/Source/WebCore/bindings/js/JSDOMConvertBase.h:168:18,
    inlined from ‘jsWebSocketPrototypeFunction_send2Body’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/JSWebSocket.cpp:537:5,
    inlined from ‘jsWebSocketPrototypeFunction_sendOverloadDispatcher’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/JSWebSocket.cpp:578:13,
    inlined from ‘call’ at /home/mcatanzaro/Projects/WebKit/Source/WebCore/bindings/js/JSDOMOperation.h:63:9,
    inlined from ‘jsWebSocketPrototypeFunction_send’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/JSWebSocket.cpp:588:96:
/home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WTF/Headers/wtf/Packed.h:146:15: warning: ‘__builtin_memcpy’ reading 6 bytes from a region of size 0 [-Wstringop-overread]
  146 |         memcpy(&amp;value, m_storage.data(), storageSize);
      |               ^

[5490/5749] Linking CXX shared library lib/libwebkit2gtk-4.1.so.0.1.0
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.h:33: note: type name ‘sh::TParseContext’ should match type name ‘angle::pp::Tokenizer::Context’
   33 | class TParseContext : angle::NonCopyable
      | 
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.h:25: note: the incompatible type is defined here
   25 |     struct Context
      | 
In member function ‘get’,
    inlined from ‘__conv_op ’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WTF/Headers/wtf/Packed.h:198:48,
    inlined from ‘__conv_op ’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WTF/Headers/wtf/RefPtr.h:89:57,
    inlined from ‘isShared’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBuffer.h:93:36,
    inlined from ‘isShared’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBuffer.h:211:31,
    inlined from ‘unsharedBuffer’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBufferView.h:61:9,
    inlined from ‘send’ at /home/mcatanzaro/Projects/WebKit/Source/WebCore/Modules/websockets/WebSocket.cpp:386:52,
    inlined from ‘operator()’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/JSWebSocket.cpp:537:5,
    inlined from ‘toJS’ at /home/mcatanzaro/Projects/WebKit/Source/WebCore/bindings/js/JSDOMConvertBase.h:168:18,
    inlined from ‘jsWebSocketPrototypeFunction_send2Body’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/JSWebSocket.cpp:537:5,
    inlined from ‘jsWebSocketPrototypeFunction_sendOverloadDispatcher’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/JSWebSocket.cpp:578:13,
    inlined from ‘call’ at /home/mcatanzaro/Projects/WebKit/Source/WebCore/bindings/js/JSDOMOperation.h:63:9,
    inlined from ‘jsWebSocketPrototypeFunction_send’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/JSWebSocket.cpp:588:96:
/home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WTF/Headers/wtf/Packed.h:146:15: warning: ‘memcpy’ reading 6 bytes from a region of size 0 [-Wstringop-overread]
  146 |         memcpy(&amp;value, m_storage.data(), storageSize);
      |               ^

I&apos;m not sure if it is possible to suppress them only for affected source files because they are derived sources and would have to be somehow removed from the unified build. Might need to revert r240362 and suppress -Wstringop-overread globally when building with GCC, since this is yet another case where pragmas fail to suppress the warning.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1814116</commentid>
    <comment_count>23</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-11-11 10:56:49 -0800</bug_when>
    <thetext>I&apos;m going to turn off -Wstringop-overread for all of WebKit when building with GCC 11 or newer.

Note this particular instance of the warning is a false-positive because we read storageSize bytes from m_storage.data(), and m_storage.data() is guaranteed to storageSize, and m_storage is a std::array of size storageSize. So this seems is an extremely simple case, where it is obvious that GCC is wrong, but we can&apos;t use the IGNORE_WARNINGS scalpel, and therefore must resort to the sledgehammer....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1814119</commentid>
    <comment_count>24</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-11-11 10:58:04 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #22)
&gt; Might need to revert r240362

I meant 240362@main, which is r280778.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1814129</commentid>
    <comment_count>25</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2021-11-11 11:11:30 -0800</bug_when>
    <thetext>In general, when we have these kinds of warning issues, I think it’s OK to first turn off the warning globally (for the particular problematic compiler, and no more) and then try to restore the warning, but without the time pressure caused by having builds failing with -Werror.

Do you think that can work? Of course we are worried that eventually we’ll have many useful warnings left turned off, but the harder we work at it, the more we can restore those warnings.

Meanwhile, we’ll still have a project that can build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1814135</commentid>
    <comment_count>26</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-11-11 11:18:48 -0800</bug_when>
    <thetext>Note we don&apos;t use -Werror at all currently, but I&apos;m trying to change that in bug #155047, so this does block the effort to enable it.

(In reply to Darin Adler from comment #25)
&gt; In general, when we have these kinds of warning issues, I think it’s OK to
&gt; first turn off the warning globally (for the particular problematic
&gt; compiler, and no more)

I have a patch to turn it off specifically for GCC 11 and newer versions.

&gt; and then try to restore the warning, but without the
&gt; time pressure caused by having builds failing with -Werror.

Realistically, it will require changes in GCC. I&apos;ve complained to GCC devs and we&apos;ll see what they say.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1814136</commentid>
    <comment_count>27</comment_count>
      <attachid>443980</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-11-11 11:20:38 -0800</bug_when>
    <thetext>Created attachment 443980
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1814182</commentid>
    <comment_count>28</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-11-11 13:09:45 -0800</bug_when>
    <thetext>Committed r285652 (244150@main): &lt;https://commits.webkit.org/244150@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443980.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>431366</attachid>
            <date>2021-06-14 14:31:43 -0700</date>
            <delta_ts>2021-06-30 10:57:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-226557-20210614163142.patch</filename>
            <type>text/plain</type>
            <size>5844</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj
NjIwYzBmMjE5N2JlY2NhYzNmMmU2Mzg0MjlmODQwMjhkZGE4NjU5Li4xM2ExNzg2M2RiYzEyNmEw
N2NhMDY0NTdkYTg4ZGY3ZWEzMGI2Y2Y0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNSBAQAorMjAyMS0wNi0xNCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdu
b21lLm9yZz4KKworICAgICAgICAtV2FycmF5LWJvdW5kcyB3YXJuaW5nIGluIFBhY2tlZC5oCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY1NTcKKyAg
ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc5MTAzNjU4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogYjMvYWlyL0FpckFsbG9jYXRlUmVnaXN0ZXJzQnlH
cmFwaENvbG9yaW5nLmNwcDoKKyAgICAgICAgKiBqaXQvSklUQ2FsbC5jcHA6CisgICAgICAgIChK
U0M6OkpJVDo6Y29tcGlsZU9wQ2FsbCk6CisKIDIwMjEtMDYtMTAgIE1hcmsgTGFtICA8bWFyay5s
YW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFub3RoZXIgc3BlY3VsYXRpdmUgYnVpbGQgZml4IGZv
ciBXaW4zMi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9D
aGFuZ2VMb2cKaW5kZXggMzNiNDZiNjk2MGM3MmZmNGYxYWMzNzg3NjVlNDJjYzljYmUzZDM2MC4u
MDk1ZDZkZjQzMThkM2VmYmZhNWI3NWExZmU2ODliOWZkNmE0NTdkOCAxMDA2NDQKLS0tIGEvU291
cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
OCBAQAorMjAyMS0wNi0xNCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9y
Zz4KKworICAgICAgICAtV2FycmF5LWJvdW5kcyB3YXJuaW5nIGluIFBhY2tlZC5oCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY1NTcKKyAgICAgICAg
PHJkYXI6Ly9wcm9ibGVtLzc5MTAzNjU4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogd3RmL0JpdG1hcC5oOgorICAgICAgICAoV1RGOjpXb3JkVHlw
ZT46OmNsZWFyKTogVXNlIHRoZSBuZXdseS1pbnRyb2R1Y2VkIElHTk9SRV9BUlJBWV9CT1VORFNf
V0FSTklOR1MgbWFjcm9zCisgICAgICAgIGluc3RlYWQgb2YgdmFuaWxsYSBJR05PUkVfV0FSTklO
R1MuCisgICAgICAgICogd3RmL0NvbXBpbGVyLmg6IEFkZCBuZXcgSUdOT1JFX0FSUkFZX0JPVU5E
U19XQVJOSU5HU19bQkVHSU4sRU5EXSBtYWNyb3MsIHNpbmNlIHRoaXMKKyAgICAgICAgd2Fybmlu
ZyBpcyBub3cgc3VwcHJlc3NlZCBpbiBzZXZlcmFsIGRpZmZlcmVudCBwbGFjZXMuCisgICAgICAg
ICogd3RmL1BhY2tlZC5oOiBTdXBwcmVzcyB0aGUgd2FybmluZy4gQWxzbywgYWRkIGEgc3RhdGlj
X2Fzc2VydCBmb3Igc2FmZXR5LgorCiAyMDIxLTA2LTA5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh
cHBsZS5jb20+CiAKICAgICAgICAgQXZvaWQgc29tZSBjYWxscyB0byBTdHJpbmdWaWV3Ojp0b1N0
cmluZygpIC8gU3RyaW5nVmlldzo6dG9TdHJpbmdXaXRob3V0Q29weWluZygpCmRpZmYgLS1naXQg
YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0FpckFsbG9jYXRlUmVnaXN0ZXJzQnlHcmFw
aENvbG9yaW5nLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyQWxsb2NhdGVS
ZWdpc3RlcnNCeUdyYXBoQ29sb3JpbmcuY3BwCmluZGV4IGZiMjE1N2Y5NWY4ZjFkNDZlYjcwOWE2
NWU5ZWI3NDJjNzA3M2YzYTcuLjRmYzY2N2YzOWNkZjcxNjFjMmFiMjAzMmZmNDg0OWMxOGU4MDYy
NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyQWxsb2NhdGVS
ZWdpc3RlcnNCeUdyYXBoQ29sb3JpbmcuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i
My9haXIvQWlyQWxsb2NhdGVSZWdpc3RlcnNCeUdyYXBoQ29sb3JpbmcuY3BwCkBAIC0xNDY3LDkg
KzE0NjcsOSBAQCBwdWJsaWM6CiAgICAgICAgICAgICBkYXRhTG9nKCJGQVRBTDogTm8gY29sb3Ig
Zm9yICIsIHRtcCwgIlxuIik7CiAgICAgICAgICAgICBkYXRhTG9nKCJDb2RlOlxuIik7CiAvLyBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NzgyCi1JR05PUkVfR0ND
X1dBUk5JTkdTX0JFR0lOKCJhcnJheS1ib3VuZHMiKQorSUdOT1JFX0FSUkFZX0JPVU5EU19XQVJO
SU5HU19CRUdJTgogICAgICAgICAgICAgZGF0YUxvZyhtX2NvZGUpOwotSUdOT1JFX0dDQ19XQVJO
SU5HU19FTkQKK0lHTk9SRV9BUlJBWV9CT1VORFNfV0FSTklOR1NfRU5ECiAgICAgICAgICAgICBS
RUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICB9CiAgICAgICAgIHJldHVybiBy
ZWc7CkBAIC0xNDg1LDE0ICsxNDg1LDE0IEBAIHByb3RlY3RlZDoKICAgICB2b2lkIGluaXRpYWxp
emVQcmVjb2xvcmVkVG1wKCkKICAgICB7CiAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MjI0NzgyCi1JR05PUkVfR0NDX1dBUk5JTkdTX0JFR0lOKCJhcnJheS1ib3Vu
ZHMiKQorSUdOT1JFX0FSUkFZX0JPVU5EU19XQVJOSU5HU19CRUdJTgogICAgICAgICBtX2NvbG9y
ZWRUbXAucmVzaXplKG1fbGFzdFByZWNvbG9yZWRSZWdpc3RlckluZGV4ICsgMSk7CiAgICAgICAg
IGZvciAodW5zaWduZWQgaSA9IDE7IGkgPD0gbV9sYXN0UHJlY29sb3JlZFJlZ2lzdGVySW5kZXg7
ICsraSkgewogICAgICAgICAgICAgVG1wIHRtcCA9IFRtcE1hcHBlcjo6dG1wRnJvbUFic29sdXRl
SW5kZXgoaSk7CiAgICAgICAgICAgICBBU1NFUlQodG1wLmlzUmVnKCkpOwogICAgICAgICAgICAg
bV9jb2xvcmVkVG1wW2ldID0gdG1wLnJlZygpOwogICAgICAgICB9Ci1JR05PUkVfR0NDX1dBUk5J
TkdTX0VORAorSUdOT1JFX0FSUkFZX0JPVU5EU19XQVJOSU5HU19FTkQKICAgICB9CiAKICAgICBi
b29sIG1heUJlQ29hbGVzY2VkKEFyZyBsZWZ0LCBBcmcgcmlnaHQpCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV1RGL3d0Zi9CaXRtYXAuaCBiL1NvdXJjZS9XVEYvd3RmL0JpdG1hcC5oCmluZGV4IDVhNWE4
ZGNjZmUxYWFjMTYxNmYzZDAxNTY2MDA1MmIxMmIyMzM0MmEuLjhmMTMyN2E0NzQxMmZkMmFkZDRl
YWY1OWIxZjVhZWUzNmRmZjFhODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0JpdG1hcC5o
CisrKyBiL1NvdXJjZS9XVEYvd3RmL0JpdG1hcC5oCkBAIC0yMjYsOSArMjI2LDkgQEAgQUxXQVlT
X0lOTElORSBib29sIEJpdG1hcDxiaXRtYXBTaXplLCBXb3JkVHlwZT46OmNvbmN1cnJlbnRUZXN0
QW5kQ2xlYXIoc2l6ZV90IG4KIHRlbXBsYXRlPHNpemVfdCBiaXRtYXBTaXplLCB0eXBlbmFtZSBX
b3JkVHlwZT4KIGlubGluZSB2b2lkIEJpdG1hcDxiaXRtYXBTaXplLCBXb3JkVHlwZT46OmNsZWFy
KHNpemVfdCBuKQogewotSUdOT1JFX1dBUk5JTkdTX0JFR0lOKCJhcnJheS1ib3VuZHMiKQorSUdO
T1JFX0FSUkFZX0JPVU5EU19XQVJOSU5HU19CRUdJTgogICAgIGJpdHNbbiAvIHdvcmRTaXplXSAm
PSB+KG9uZSA8PCAobiAlIHdvcmRTaXplKSk7Ci1JR05PUkVfV0FSTklOR1NfRU5ECitJR05PUkVf
QVJSQVlfQk9VTkRTX1dBUk5JTkdTX0VORAogfQogCiB0ZW1wbGF0ZTxzaXplX3QgYml0bWFwU2l6
ZSwgdHlwZW5hbWUgV29yZFR5cGU+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Db21waWxl
ci5oIGIvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaAppbmRleCBiZTQ1ZGJlOWIyZTJkOWUwMzQw
ODZhNTBlM2IxZDk1YjNjNTlkY2QyLi42MmZjMTkyMDM0MzNkNTBkM2VmMzdiN2QwNjkzZDc0ODJm
ZTlhMTlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCisrKyBiL1NvdXJj
ZS9XVEYvd3RmL0NvbXBpbGVyLmgKQEAgLTUwMyw2ICs1MDMsOSBAQAogI2RlZmluZSBJR05PUkVf
TlVMTF9DSEVDS19XQVJOSU5HU19CRUdJTiBJR05PUkVfV0FSTklOR1NfQkVHSU4oIm5vbm51bGwi
KQogI2RlZmluZSBJR05PUkVfTlVMTF9DSEVDS19XQVJOSU5HU19FTkQgSUdOT1JFX1dBUk5JTkdT
X0VORAogCisjZGVmaW5lIElHTk9SRV9BUlJBWV9CT1VORFNfV0FSTklOR1NfQkVHSU4gSUdOT1JF
X1dBUk5JTkdTX0JFR0lOKCJhcnJheS1ib3VuZHMiKQorI2RlZmluZSBJR05PUkVfQVJSQVlfQk9V
TkRTX1dBUk5JTkdTX0VORCBJR05PUkVfV0FSTklOR1NfRU5ECisKIC8qIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ0NTIgKi8KICNkZWZpbmUgSUdOT1JFX0VSUk9O
RU9VU19HQ0NfTlVMTF9DSEVDS19XQVJOSU5HU19CRUdJTiBJR05PUkVfR0NDX1dBUk5JTkdTX0JF
R0lOKCJub25udWxsIikKICNkZWZpbmUgSUdOT1JFX0VSUk9ORU9VU19HQ0NfTlVMTF9DSEVDS19X
QVJOSU5HU19FTkQgSUdOT1JFX0dDQ19XQVJOSU5HU19FTkQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
VEYvd3RmL1BhY2tlZC5oIGIvU291cmNlL1dURi93dGYvUGFja2VkLmgKaW5kZXggYjc2YWVmOGYx
YjY1YWIwMjE1MWE0ZGNkZjRhODQ2MWM3MmM4YTg4Yi4uYTM1MzkzZDQzN2Y2NzRiNTg1NzJkODE4
MmIwNDlhNTc0ZDBhZGE0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGFja2VkLmgKKysr
IGIvU291cmNlL1dURi93dGYvUGFja2VkLmgKQEAgLTExNSw2ICsxMTUsNyBAQCBwdWJsaWM6CiAg
ICAgc3RhdGljIGNvbnN0ZXhwciBib29sIGlzQWxpZ25tZW50U2hpZnRQcm9maXRhYmxlID0gc3Rv
cmFnZVNpemVXaXRob3V0QWxpZ25tZW50U2hpZnQgPiBzdG9yYWdlU2l6ZVdpdGhBbGlnbm1lbnRT
aGlmdDsKICAgICBzdGF0aWMgY29uc3RleHByIHVuc2lnbmVkIGFsaWdubWVudFNoaWZ0U2l6ZSA9
IGlzQWxpZ25tZW50U2hpZnRQcm9maXRhYmxlID8gYWxpZ25tZW50U2hpZnRTaXplSWZQcm9maXRh
YmxlIDogMDsKICAgICBzdGF0aWMgY29uc3RleHByIHVuc2lnbmVkIHN0b3JhZ2VTaXplID0gc3Rv
cmFnZVNpemVXaXRoQWxpZ25tZW50U2hpZnQ7CisgICAgc3RhdGljX2Fzc2VydChzdG9yYWdlU2l6
ZSA8PSBzaXplb2YodWludHB0cl90KSk7CiAKICAgICBjb25zdGV4cHIgUGFja2VkQWxpZ25lZFB0
cigpCiAgICAgICAgIDogbV9zdG9yYWdlKCkKQEAgLTEzNiwxMSArMTM3LDE1IEBAIHB1YmxpYzoK
ICAgICAgICAgLy8gRklYTUU6IFBhY2tlZFB0cjw+IGNhbiBsb2FkIG1lbW9yeSB3aXRoIG9uZSBt
b3YgYnkgY2hlY2tpbmcgcGFnZSBib3VuZGFyeS4KICAgICAgICAgLy8gaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Nzc1NAogICAgICAgICB1aW50cHRyX3QgdmFsdWUg
PSAwOworCitJR05PUkVfQVJSQVlfQk9VTkRTX1dBUk5JTkdTX0JFR0lOCiAjaWYgQ1BVKExJVFRM
RV9FTkRJQU4pCiAgICAgICAgIG1lbWNweSgmdmFsdWUsIG1fc3RvcmFnZS5kYXRhKCksIHN0b3Jh
Z2VTaXplKTsKICNlbHNlCiAgICAgICAgIG1lbWNweShiaXR3aXNlX2Nhc3Q8dWludDhfdCo+KCZ2
YWx1ZSkgKyAoc2l6ZW9mKHZvaWQqKSAtIHN0b3JhZ2VTaXplKSwgbV9zdG9yYWdlLmRhdGEoKSwg
c3RvcmFnZVNpemUpOwogI2VuZGlmCitJR05PUkVfQVJSQVlfQk9VTkRTX1dBUk5JTkdTX0VORAor
CiAgICAgICAgIGlmIChpc0FsaWdubWVudFNoaWZ0UHJvZml0YWJsZSkKICAgICAgICAgICAgIHZh
bHVlIDw8PSBhbGlnbm1lbnRTaGlmdFNpemU7CiAK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>432395</attachid>
            <date>2021-06-28 08:15:31 -0700</date>
            <delta_ts>2021-06-30 10:58:27 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-226557-20210628101530.patch</filename>
            <type>text/plain</type>
            <size>1962</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGYwOTEzZDFhYzQ4ZjI4MDI2YmY1YTli
OTc1NDFhYzI5Y2UwN2E1YmQuLjIxMWFmNmY4YTViMzhiZjE4NTU2MGZlZWMyOTAzZmIwY2E3YjQx
MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDYtMjggIE1pY2hhZWwgQ2F0YW56YXJvICA8
bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgLVdhcnJheS1ib3VuZHMgd2FybmluZyBp
biBQYWNrZWQuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MjI2NTU3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTEwMzY1OD4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBoYXZlIHRvIHN1cHByZXNz
IC1Xc3RyaW5nb3Atb3ZlcnJlYWQgaW4gYWRkaXRpb24gdG8gLVdhcnJheS1ib3VuZHMuCisKKyAg
ICAgICAgRm9yIGJvbnVzIHBvaW50cywgYWRkIGEgY29tbWVudCBleHBsYWluaW5nIHdoeSB0aGlz
IGlzIHNhZmUgdG8gZG8uCisKKyAgICAgICAgKiB3dGYvUGFja2VkLmg6CisgICAgICAgIChXVEY6
OlBhY2tlZEFsaWduZWRQdHI6OmdldCBjb25zdCk6CisKIDIwMjEtMDYtMjcgIEFudG9pbmUgUXVp
bnQgIDxncmFvdXRzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW01vZGVsXSBbaU9TXSBBZGQgc3Vw
cG9ydCBmb3IgcmVuZGVyaW5nIG1vZGVsIHJlc291cmNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dU
Ri93dGYvUGFja2VkLmggYi9Tb3VyY2UvV1RGL3d0Zi9QYWNrZWQuaAppbmRleCAzZmM4NThlYzM0
NmM2ZjdiNmY2MjkzY2ZmNmQ0ZDgyMzM4NmUxY2IzLi40ZGE3MzhhMjk4M2Y0ZmQ4MmY5NGQxZTQ5
M2YyOTAyODE4ZTE0MzMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QYWNrZWQuaAorKysg
Yi9Tb3VyY2UvV1RGL3d0Zi9QYWNrZWQuaApAQCAtMTQyLDYgKzE0MiwxMSBAQCBwdWJsaWM6CiAg
ICAgICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc3NTQK
ICAgICAgICAgdWludHB0cl90IHZhbHVlID0gMDsKIAorICAgICAgICAvLyBHQ0MsIG5vdCB1bnJl
YXNvbmFibHksIGRvZXMgbm90IGxpa2UgdGhpcyBiZWNhdXNlIGl0IGtub3dzIHRoYXQgdmFsdWUK
KyAgICAgICAgLy8gaXMgbm90IGFuIGFycmF5IGFuZCBzbyB0aGUgbGVuZ3RoIG9mIHN0b3JhZ2VT
aXplIGV4Y2VlZHMgdGhlIGxlbmd0aAorICAgICAgICAvLyBvZiB2YWx1ZSAoMCkuIFdoYXQgaXQg
ZG9lc24ndCBrbm93IGlzIHRoYXQgd2UgaGF2ZSBndWFyYW50ZWVkIHRoYXQKKyAgICAgICAgLy8g
c3RvcmFnZVNpemUgPD0gc2l6ZW9mKHZhbHVlKSB2aWEgdGhlIHN0YXRpY19hc3NlcnQgdXAgYWJv
dmUuCitJR05PUkVfV0FSTklOR1NfQkVHSU4oInN0cmluZ29wLW92ZXJyZWFkIikKIElHTk9SRV9B
UlJBWV9CT1VORFNfV0FSTklOR1NfQkVHSU4KICNpZiBDUFUoTElUVExFX0VORElBTikKICAgICAg
ICAgbWVtY3B5KCZ2YWx1ZSwgbV9zdG9yYWdlLmRhdGEoKSwgc3RvcmFnZVNpemUpOwpAQCAtMTQ5
LDYgKzE1NCw3IEBAIElHTk9SRV9BUlJBWV9CT1VORFNfV0FSTklOR1NfQkVHSU4KICAgICAgICAg
bWVtY3B5KGJpdHdpc2VfY2FzdDx1aW50OF90Kj4oJnZhbHVlKSArIChzaXplb2Yodm9pZCopIC0g
c3RvcmFnZVNpemUpLCBtX3N0b3JhZ2UuZGF0YSgpLCBzdG9yYWdlU2l6ZSk7CiAjZW5kaWYKIElH
Tk9SRV9BUlJBWV9CT1VORFNfV0FSTklOR1NfRU5ECitJR05PUkVfV0FSTklOR1NfRU5ECiAKICAg
ICAgICAgaWYgKGlzQWxpZ25tZW50U2hpZnRQcm9maXRhYmxlKQogICAgICAgICAgICAgdmFsdWUg
PDw9IGFsaWdubWVudFNoaWZ0U2l6ZTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>432610</attachid>
            <date>2021-06-30 10:57:40 -0700</date>
            <delta_ts>2021-07-29 14:00:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-226557-20210630125739.patch</filename>
            <type>text/plain</type>
            <size>3359</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5Mzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGJiYTg0NmU4Y2QyNWE0MThkNWQ4YWUy
ZTNmZDNhNjA3NDU0YWNmYTMuLmE2ZmFlODM1NmViZmRhMjM2YTc3NmUwMTZiMWUyMDA3NDIwZjUw
NGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMjEtMDYtMjkgIE1pY2hhZWwgQ2F0YW56YXJvICA8
bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgLVdhcnJheS1ib3VuZHMgd2FybmluZyBp
biBQYWNrZWQuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MjI2NTU3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTEwMzY1OD4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXdyaXRlIFBhY2tlZEFsaWdu
ZWRQdHI6OmdldCB0byBhdm9pZCB0cmlnZ2VyaW5nIC1Xc3RyaW5nb3Atb3ZlcnJlYWQsIHdoaWNo
IGNhbm5vdCBiZQorICAgICAgICBzdXBwcmVzc2VkIHdpdGggb3VyIHR5cGljYWwgSUdOT1JFX1dB
Uk5JTkdTIHByYWdtYXMgZm9yIHNvbWUgcmVhc29uLiBUaGlzIHdhcyBoYXJkLCBidXQKKyAgICAg
ICAgZXZlbnR1YWxseSBJIGZpZ3VyZWQgb3V0IGEgd2F5IHRvIG1ha2UgaXQgd29yay4gVW5mb3J0
dW5hdGVseSwgbXkgc29sdXRpb24gYWN0dWFsbHkKKyAgICAgICAgaW50cm9kdWNlcyB5ZXQgYW5v
dGhlciAtV2FycmF5LWJvdW5kcyB3YXJuaW5nIChhY3R1YWxseSB0d28gb2YgdGhlbSB3aGVuIEkg
dGVzdGVkIGEgYnVpbGQKKyAgICAgICAgd2l0aCB0aGUgbm9uLURhcndpbi9MaW51eC9XaW5kb3dz
IGZhbGxiYWNrIGVuYWJsZWQpLCBzbyBJIHN1cHByZXNzIHRoYXQgYXMgd2VsbCwgYnV0IHRoYXQn
cworICAgICAgICBPSyBiZWNhdXNlIHRoZSBwcmltYXJ5IGdvYWwgaXMgdG8gYXZvaWQgdGhlIG5v
bi1zdXBwcmVzc2FibGUgLVdzdHJpbmdvcC1vdmVycmVhZC4KKworICAgICAgICBUaGlzIGFjdHVh
bGx5IHR1cm5lZCBvdXQgbXVjaCBjbGVhbmVyIHRoYW4gbXkgbWFueSBmYWlsZWQgYXR0ZW1wdHMu
IFdlIGp1c3QgbmVlZCB0byBrZWVwCisgICAgICAgIGEgdWludDhfdCBhcnJheSBvbiB0aGUgc3Rh
Y2sgaW5zdGVhZCBvZiBhIHVpbnRwdHJfdCwgdGhlbiBjcmVhdGUgYSB1aW50cHRyX3QmIGFsaWFz
IHRvIHRoZQorICAgICAgICBhcnJheSBzbyB3ZSBjYW4gbWFuaXB1bGF0ZSBpdCBhcyBhIHVpbnRw
dHJfdC4gSSB0cmllZCBtYW55IGRpZmZlcmVudCB3YXlzIHRvIGtlZXAgdWludHB0cl90CisgICAg
ICAgIGFzIHRoZSBhY3R1YWwgdW5kZXJseWluZyB0eXBlLCBidXQgYWxsIGZhaWxlZC4KKworICAg
ICAgICAqIHd0Zi9QYWNrZWQuaDoKKyAgICAgICAgKFdURjo6UGFja2VkQWxpZ25lZFB0cjo6Z2V0
IGNvbnN0KToKKwogMjAyMS0wNi0yOSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+
CiAKICAgICAgICAgRW5hYmxlIFByb2JhYmlsaXN0aWMgR3VhcmQgTWFsbG9jIGZvciBSdWxlRGF0
YSBhbmQgUnVsZUZlYXR1cmUgdmVjdG9ycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGFj
a2VkLmggYi9Tb3VyY2UvV1RGL3d0Zi9QYWNrZWQuaAppbmRleCAzZmM4NThlYzM0NmM2ZjdiNmY2
MjkzY2ZmNmQ0ZDgyMzM4NmUxY2IzLi5hYTBjM2I3YWE1NTNhZThiNWRiYWM4NWM3NGEyZDhkZDJi
YTk3YTdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QYWNrZWQuaAorKysgYi9Tb3VyY2Uv
V1RGL3d0Zi9QYWNrZWQuaApAQCAtMTE5LDcgKzExOSw5IEBAIHB1YmxpYzoKICAgICBzdGF0aWMg
Y29uc3RleHByIGJvb2wgaXNBbGlnbm1lbnRTaGlmdFByb2ZpdGFibGUgPSBzdG9yYWdlU2l6ZVdp
dGhvdXRBbGlnbm1lbnRTaGlmdCA+IHN0b3JhZ2VTaXplV2l0aEFsaWdubWVudFNoaWZ0OwogICAg
IHN0YXRpYyBjb25zdGV4cHIgdW5zaWduZWQgYWxpZ25tZW50U2hpZnRTaXplID0gaXNBbGlnbm1l
bnRTaGlmdFByb2ZpdGFibGUgPyBhbGlnbm1lbnRTaGlmdFNpemVJZlByb2ZpdGFibGUgOiAwOwog
ICAgIHN0YXRpYyBjb25zdGV4cHIgdW5zaWduZWQgc3RvcmFnZVNpemUgPSBzdG9yYWdlU2l6ZVdp
dGhBbGlnbm1lbnRTaGlmdDsKKwogICAgIHN0YXRpY19hc3NlcnQoc3RvcmFnZVNpemUgPD0gc2l6
ZW9mKHVpbnRwdHJfdCkpOworICAgIHN0YXRpY19hc3NlcnQoc2l6ZW9mKHZvaWQqKSA9PSBzaXpl
b2YodWludHB0cl90KSk7CiAKICAgICBjb25zdGV4cHIgUGFja2VkQWxpZ25lZFB0cigpCiAgICAg
ICAgIDogbV9zdG9yYWdlKCkKQEAgLTE0MCwxNiArMTQyLDE2IEBAIHB1YmxpYzoKICAgICB7CiAg
ICAgICAgIC8vIEZJWE1FOiBQYWNrZWRQdHI8PiBjYW4gbG9hZCBtZW1vcnkgd2l0aCBvbmUgbW92
IGJ5IGNoZWNraW5nIHBhZ2UgYm91bmRhcnkuCiAgICAgICAgIC8vIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc3NTQKLSAgICAgICAgdWludHB0cl90IHZhbHVlID0g
MDsKKyAgICAgICAgdWludDhfdCBkYXRhW3NpemVvZih2b2lkKildID0geyAwIH07CiAKIElHTk9S
RV9BUlJBWV9CT1VORFNfV0FSTklOR1NfQkVHSU4KICNpZiBDUFUoTElUVExFX0VORElBTikKLSAg
ICAgICAgbWVtY3B5KCZ2YWx1ZSwgbV9zdG9yYWdlLmRhdGEoKSwgc3RvcmFnZVNpemUpOworICAg
ICAgICBtZW1jcHkoZGF0YSwgbV9zdG9yYWdlLmRhdGEoKSwgc3RvcmFnZVNpemUpOwogI2Vsc2UK
LSAgICAgICAgbWVtY3B5KGJpdHdpc2VfY2FzdDx1aW50OF90Kj4oJnZhbHVlKSArIChzaXplb2Yo
dm9pZCopIC0gc3RvcmFnZVNpemUpLCBtX3N0b3JhZ2UuZGF0YSgpLCBzdG9yYWdlU2l6ZSk7Cisg
ICAgICAgIG1lbWNweShkYXRhICsgKHNpemVvZih2b2lkKikgLSBzdG9yYWdlU2l6ZSksIG1fc3Rv
cmFnZS5kYXRhKCksIHN0b3JhZ2VTaXplKTsKICNlbmRpZgotSUdOT1JFX0FSUkFZX0JPVU5EU19X
QVJOSU5HU19FTkQKIAorICAgICAgICB1aW50cHRyX3QmIHZhbHVlID0gKmJpdHdpc2VfY2FzdDx1
aW50cHRyX3QqPihkYXRhKTsKICAgICAgICAgaWYgKGlzQWxpZ25tZW50U2hpZnRQcm9maXRhYmxl
KQogICAgICAgICAgICAgdmFsdWUgPDw9IGFsaWdubWVudFNoaWZ0U2l6ZTsKIApAQCAtMTY3LDYg
KzE2OSw3IEBAIElHTk9SRV9BUlJBWV9CT1VORFNfV0FSTklOR1NfRU5ECiAjZW5kaWYKIAogICAg
ICAgICByZXR1cm4gYml0d2lzZV9jYXN0PFQqPih2YWx1ZSk7CitJR05PUkVfQVJSQVlfQk9VTkRT
X1dBUk5JTkdTX0VORAogICAgIH0KIAogICAgIHZvaWQgc2V0KFQqIHBhc3NlZFZhbHVlKQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>434570</attachid>
            <date>2021-07-29 14:00:20 -0700</date>
            <delta_ts>2021-07-30 07:28:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-226557-20210729160019.patch</filename>
            <type>text/plain</type>
            <size>2465</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2RhYmM1NTg2N2QwNTkx
YzJiMzJkZjJmMGRmZTJjZmIzMjVlNzFhNy4uZTExNDEwZWIxYzc1ZWM4ZTdiYzczZThmZjdhYmRj
NzQ1ZTlkZjVlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTA3LTI5ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIC1XYXJyYXkt
Ym91bmRzLCAtV3N0cmluZ29wLXRydW5jYXRpb24gd2FybmluZ3MgaW4gUGFja2VkLmgKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjU1NworICAgICAg
ICA8cmRhcjovL3Byb2JsZW0vNzkxMDM2NTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgU3VwcHJlc3NpbmcgdGhlIC1XYXJyYXktYm91bmRzIHdhcm5p
bmcgaW50cm9kdWNlcyB0aGUgLVdzdHJpbmdvcC10cnVuY2F0aW9uIHdhcm5pbmcsIHdoaWNoCisg
ICAgICAgIGNhbm5vdCBiZSBzdXBwcmVzc2VkIHdpdGggcHJhZ21hcy4gVGhlIG9ubHkgc29sdXRp
b24gSSBmb3VuZCBpcyAtV25vLXN0cmluZ29wLXRydW5jYXRpb24uIEkKKyAgICAgICAgY291bGQg
YXBwbHkgaXQgZ2xvYmFsbHksIGJ1dCB0aGlzIHdhcm5pbmcgZG9lcyBub3QgaGF2ZSBtYW55IGZh
bHNlIHBvc2l0aXZlcywgc28gSSB0aGluaworICAgICAgICBpdCdzIGJldHRlciB0byBzdXBwcmVz
cyB0aGUgd2FybmluZyBvbmx5IGZvciBXZWJTb2NrZXQuY3BwLiBVbmZvcnR1bmF0ZWx5IHdlIGhh
dmUgdG8gcmVtb3ZlCisgICAgICAgIGl0IGZyb20gdGhlIHVuaWZpZWQgYnVpbGQgaW4gb3JkZXIg
dG8gYWRkIGN1c3RvbSBmbGFncywgYnV0IGl0IHNlZW1zIHdvcnRoIGl0IHRvIGF2b2lkCisgICAg
ICAgIHN1cHByZXNzaW5nIHRoZSB3YXJuaW5nIGdsb2JhbGx5LgorCisgICAgICAgICogQ01ha2VM
aXN0cy50eHQ6CisgICAgICAgICogU291cmNlcy50eHQ6CisKIDIwMjEtMDctMjkgIEFkcmlhbiBQ
ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ01ha2VdIFVz
ZSBhbiBpbXBvcnRlZCB0YXJnZXQgZm9yIHRoZSBsaWJnY3J5cHQgbGlicmFyeQpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxp
c3RzLnR4dAppbmRleCBjNTRhMjgyNmY3MDFmNDJhZmY0MjYyZjNlZTViZDQ5YjRlN2VjNDVhLi5m
YzljMmYxYzMwYjI2ZjM0NmE5NDExYTk3ZmEzZTQ2YTUzZjEyNzgxIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3Rz
LnR4dApAQCAtMjI2MiwzICsyMjYyLDggQEAgaWYgKE1TVkMpCiAgICAgICAgIENPTVBJTEVfUERC
X05BTUUgJHtXZWJDb3JlX09VVFBVVF9OQU1FfQogICAgICkKIGVuZGlmICgpCisKKyMgVGhpcyBH
Q0Mgd2FybmluZyBjYW5ub3QgYmUgc3VwcHJlc3NlZCB3aXRoIGEgcHJhZ21hLgoraWYgKENNQUtF
X0NYWF9DT01QSUxFUl9JRCBNQVRDSEVTICJHTlUiKQorICAgIHNldF9zb3VyY2VfZmlsZXNfcHJv
cGVydGllcyhNb2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcCBQUk9QRVJUSUVTIENPTVBJ
TEVfRkxBR1MgLVduby1zdHJpbmdvcC1vdmVycmVhZCkKK2VuZGlmICgpCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9Tb3VyY2VzLnR4dCBiL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXMudHh0Cmlu
ZGV4IDJlYTljYzU2OWNmNDVkNWY0Mjg4ZTMwZThiNGYzZmEzYjYwODBiMzQuLmU5NmZiZDIzYmQ1
NjczMWUyOGI1NGU2ZjJiYTllYjExNThhN2I2OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L1NvdXJjZXMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXMudHh0CkBAIC00MDgsNyAr
NDA4LDcgQEAgTW9kdWxlcy93ZWJncHUvV29ya2VyTmF2aWdhdG9yR1BVLmNwcAogTW9kdWxlcy93
ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuY3BwCiBNb2R1bGVzL3dlYnNvY2tldHMvVGhyZWFkYWJsZVdl
YlNvY2tldENoYW5uZWwuY3BwCiBNb2R1bGVzL3dlYnNvY2tldHMvVGhyZWFkYWJsZVdlYlNvY2tl
dENoYW5uZWxDbGllbnRXcmFwcGVyLmNwcAotTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldC5j
cHAKK01vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXQuY3BwIEBuby11bmlmeQogTW9kdWxlcy93
ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwCiBNb2R1bGVzL3dlYnNvY2tldHMvV2ViU29j
a2V0Q2hhbm5lbEluc3BlY3Rvci5jcHAKIE1vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXREZWZs
YXRlRnJhbWVyLmNwcAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>434621</attachid>
            <date>2021-07-30 07:28:33 -0700</date>
            <delta_ts>2021-07-30 07:45:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-226557-20210730092832.patch</filename>
            <type>text/plain</type>
            <size>3338</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjYxNWQ2NjU0YzJlYTk0
YTE1N2MwM2M0ZDhlNjBlY2E0MzQ5M2Q1YS4uOTJhYTBjYjVlMDNiODUwNjc4ZDgwYzVjYTk2Y2Q5
ZDliN2ZjNWQwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA3LTMwICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIC1XYXJyYXkt
Ym91bmRzLCAtV3N0cmluZ29wLXRydW5jYXRpb24gd2FybmluZ3MgaW4gUGFja2VkLmgKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjU1NworICAgICAg
ICA8cmRhcjovL3Byb2JsZW0vNzkxMDM2NTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgU3VwcHJlc3NpbmcgdGhlIC1XYXJyYXktYm91bmRzIHdhcm5p
bmcgaW50cm9kdWNlcyB0aGUgLVdzdHJpbmdvcC10cnVuY2F0aW9uIHdhcm5pbmcsIHdoaWNoCisg
ICAgICAgIGNhbm5vdCBiZSBzdXBwcmVzc2VkIHdpdGggcHJhZ21hcy4gVGhlIG9ubHkgc29sdXRp
b24gSSBmb3VuZCBpcyAtV25vLXN0cmluZ29wLXRydW5jYXRpb24uIEkKKyAgICAgICAgY291bGQg
YXBwbHkgaXQgZ2xvYmFsbHksIGJ1dCB0aGlzIHdhcm5pbmcgZG9lcyBub3QgaGF2ZSBtYW55IGZh
bHNlIHBvc2l0aXZlcywgc28gSSB0aGluaworICAgICAgICBpdCdzIGJldHRlciB0byBzdXBwcmVz
cyB0aGUgd2FybmluZyBvbmx5IGZvciBXZWJTb2NrZXQuY3BwLiBVbmZvcnR1bmF0ZWx5IHdlIGhh
dmUgdG8gcmVtb3ZlCisgICAgICAgIGl0IGZyb20gdGhlIHVuaWZpZWQgYnVpbGQgaW4gb3JkZXIg
dG8gYWRkIGN1c3RvbSBmbGFncywgYnV0IGl0IHNlZW1zIHdvcnRoIGl0IHRvIGF2b2lkCisgICAg
ICAgIHN1cHByZXNzaW5nIHRoZSB3YXJuaW5nIGdsb2JhbGx5LgorCisgICAgICAgICogQ01ha2VM
aXN0cy50eHQ6CisgICAgICAgICogU291cmNlcy50eHQ6CisgICAgICAgICogV2ViQ29yZS54Y29k
ZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAyMDIxLTA3LTMwICBSb2IgQnVpcyAgPHJidWlzQGln
YWxpYS5jb20+CiAKICAgICAgICAgW0FzcGVjdFJhdGlvXSBGaXggcmVwbGFjZWQtZWxlbWVudC0w
MzQuaHRtbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3Vy
Y2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBjODg0ODAyYzJmNmQwZjE4MzhjNThlY2Ri
YjNlYTk4YTA3MGZhZDU4Li42ODliYjZjYzAzZjU0ZjBmMTlkZmNmMmY1NWExMjVkMzg0ODQ4NmRj
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMjE5OSwzICsyMTk5LDggQEAgaWYgKE1TVkMpCiAg
ICAgICAgIENPTVBJTEVfUERCX05BTUUgJHtXZWJDb3JlX09VVFBVVF9OQU1FfQogICAgICkKIGVu
ZGlmICgpCisKKyMgVGhpcyBHQ0Mgd2FybmluZyBjYW5ub3QgYmUgc3VwcHJlc3NlZCB3aXRoIGEg
cHJhZ21hLgoraWYgKENNQUtFX0NYWF9DT01QSUxFUl9JRCBNQVRDSEVTICJHTlUiKQorICAgIHNl
dF9zb3VyY2VfZmlsZXNfcHJvcGVydGllcyhNb2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0LmNw
cCBQUk9QRVJUSUVTIENPTVBJTEVfRkxBR1MgLVduby1zdHJpbmdvcC1vdmVycmVhZCkKK2VuZGlm
ICgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Tb3VyY2VzLnR4dCBiL1NvdXJjZS9XZWJD
b3JlL1NvdXJjZXMudHh0CmluZGV4IDU0NDQzZmI4OGE0ZGNhYmNiYjM2ZTUxZjVjMjc3ZTRmZmNj
ZjVhNjIuLmFjOGY3MDlkYjA2MDRkOTM5YjdjMjlkYTcxM2JhY2Q1MjdmMjQwMDEgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL1NvdXJj
ZXMudHh0CkBAIC0zMjMsNyArMzIzLDcgQEAgTW9kdWxlcy93ZWJkcml2ZXIvTmF2aWdhdG9yV2Vi
RHJpdmVyLmNwcAogTW9kdWxlcy93ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuY3BwCiBNb2R1bGVzL3dl
YnNvY2tldHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuY3BwCiBNb2R1bGVzL3dlYnNvY2tl
dHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxDbGllbnRXcmFwcGVyLmNwcAotTW9kdWxlcy93
ZWJzb2NrZXRzL1dlYlNvY2tldC5jcHAKK01vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXQuY3Bw
IEBuby11bmlmeQogTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwCiBNb2R1
bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbEluc3BlY3Rvci5jcHAKIE1vZHVsZXMvd2Vi
c29ja2V0cy9XZWJTb2NrZXREZWZsYXRlRnJhbWVyLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL1dlYkNvcmUv
V2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IGUwYmRiYjZmMGVmYzU1YTQ4
MzNhYTlkZTFiZTI1NzkwYTRmZGNiNGIuLjAzOGUxZWU4M2JkOTk3NTFmZWMyOTRlNGY5NjMyYmJl
MDMzMDZiMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3By
b2plY3QucGJ4cHJvagorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9q
ZWN0LnBieHByb2oKQEAgLTM2NTg0LDYgKzM2NTg0LDcgQEAKIAkJCQkwN0Y1Q0ZGNjI1ODJBNTI5
MDA2NjJFRjUgLyogV2ViTUF1ZGlvVXRpbGl0aWVzQ29jb2EubW0gaW4gU291cmNlcyAqLywKIAkJ
CQkwNzA5RDc5MjFBRTU1NTdFMDA0RTQyRjggLyogV2ViTWVkaWFTZXNzaW9uTWFuYWdlck1hYy5j
cHAgaW4gU291cmNlcyAqLywKIAkJCQkxQ0FGMzQ4MjBBNkM0MDUyMDBBQkUwNkUgLyogV2ViU2Ny
aXB0T2JqZWN0Lm1tIGluIFNvdXJjZXMgKi8sCisJCQkJOTdBQUJDRkYxNEZBMDlENTAwNzQ1N0FF
IC8qIFdlYlNvY2tldC5jcHAgaW4gU291cmNlcyAqLywKIAkJCQlDRUNEQzkzQzIxRjI5NzI5MDA5
NzZCRDEgLyogV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlckFWS2l0Lm1tIGluIFNvdXJjZXMg
Ki8sCiAJCQkJRTFFRThCODAyNDEzMTkxRjAwRTc5NEQ2IC8qIFdlYlhSQm91bmRlZFJlZmVyZW5j
ZVNwYWNlLmNwcCBpbiBTb3VyY2VzICovLAogCQkJCUUxRUU4QjkzMjQxMzE5NTAwMEU3OTRENiAv
KiBXZWJYUkZyYW1lLmNwcCBpbiBTb3VyY2VzICovLAo=
</data>
<flag name="commit-queue"
          id="457166"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>434622</attachid>
            <date>2021-07-30 07:36:11 -0700</date>
            <delta_ts>2021-07-30 07:52:32 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-226557-20210730093610.patch</filename>
            <type>text/plain</type>
            <size>4623</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjYxNWQ2NjU0YzJlYTk0
YTE1N2MwM2M0ZDhlNjBlY2E0MzQ5M2Q1YS4uOTJhYTBjYjVlMDNiODUwNjc4ZDgwYzVjYTk2Y2Q5
ZDliN2ZjNWQwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA3LTMwICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIC1XYXJyYXkt
Ym91bmRzLCAtV3N0cmluZ29wLXRydW5jYXRpb24gd2FybmluZ3MgaW4gUGFja2VkLmgKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjU1NworICAgICAg
ICA8cmRhcjovL3Byb2JsZW0vNzkxMDM2NTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgU3VwcHJlc3NpbmcgdGhlIC1XYXJyYXktYm91bmRzIHdhcm5p
bmcgaW50cm9kdWNlcyB0aGUgLVdzdHJpbmdvcC10cnVuY2F0aW9uIHdhcm5pbmcsIHdoaWNoCisg
ICAgICAgIGNhbm5vdCBiZSBzdXBwcmVzc2VkIHdpdGggcHJhZ21hcy4gVGhlIG9ubHkgc29sdXRp
b24gSSBmb3VuZCBpcyAtV25vLXN0cmluZ29wLXRydW5jYXRpb24uIEkKKyAgICAgICAgY291bGQg
YXBwbHkgaXQgZ2xvYmFsbHksIGJ1dCB0aGlzIHdhcm5pbmcgZG9lcyBub3QgaGF2ZSBtYW55IGZh
bHNlIHBvc2l0aXZlcywgc28gSSB0aGluaworICAgICAgICBpdCdzIGJldHRlciB0byBzdXBwcmVz
cyB0aGUgd2FybmluZyBvbmx5IGZvciBXZWJTb2NrZXQuY3BwLiBVbmZvcnR1bmF0ZWx5IHdlIGhh
dmUgdG8gcmVtb3ZlCisgICAgICAgIGl0IGZyb20gdGhlIHVuaWZpZWQgYnVpbGQgaW4gb3JkZXIg
dG8gYWRkIGN1c3RvbSBmbGFncywgYnV0IGl0IHNlZW1zIHdvcnRoIGl0IHRvIGF2b2lkCisgICAg
ICAgIHN1cHByZXNzaW5nIHRoZSB3YXJuaW5nIGdsb2JhbGx5LgorCisgICAgICAgICogQ01ha2VM
aXN0cy50eHQ6CisgICAgICAgICogU291cmNlcy50eHQ6CisgICAgICAgICogV2ViQ29yZS54Y29k
ZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAyMDIxLTA3LTMwICBSb2IgQnVpcyAgPHJidWlzQGln
YWxpYS5jb20+CiAKICAgICAgICAgW0FzcGVjdFJhdGlvXSBGaXggcmVwbGFjZWQtZWxlbWVudC0w
MzQuaHRtbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3Vy
Y2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBjODg0ODAyYzJmNmQwZjE4MzhjNThlY2Ri
YjNlYTk4YTA3MGZhZDU4Li42ODliYjZjYzAzZjU0ZjBmMTlkZmNmMmY1NWExMjVkMzg0ODQ4NmRj
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMjE5OSwzICsyMTk5LDggQEAgaWYgKE1TVkMpCiAg
ICAgICAgIENPTVBJTEVfUERCX05BTUUgJHtXZWJDb3JlX09VVFBVVF9OQU1FfQogICAgICkKIGVu
ZGlmICgpCisKKyMgVGhpcyBHQ0Mgd2FybmluZyBjYW5ub3QgYmUgc3VwcHJlc3NlZCB3aXRoIGEg
cHJhZ21hLgoraWYgKENNQUtFX0NYWF9DT01QSUxFUl9JRCBNQVRDSEVTICJHTlUiKQorICAgIHNl
dF9zb3VyY2VfZmlsZXNfcHJvcGVydGllcyhNb2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0LmNw
cCBQUk9QRVJUSUVTIENPTVBJTEVfRkxBR1MgLVduby1zdHJpbmdvcC1vdmVycmVhZCkKK2VuZGlm
ICgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Tb3VyY2VzLnR4dCBiL1NvdXJjZS9XZWJD
b3JlL1NvdXJjZXMudHh0CmluZGV4IDU0NDQzZmI4OGE0ZGNhYmNiYjM2ZTUxZjVjMjc3ZTRmZmNj
ZjVhNjIuLmFjOGY3MDlkYjA2MDRkOTM5YjdjMjlkYTcxM2JhY2Q1MjdmMjQwMDEgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL1NvdXJj
ZXMudHh0CkBAIC0zMjMsNyArMzIzLDcgQEAgTW9kdWxlcy93ZWJkcml2ZXIvTmF2aWdhdG9yV2Vi
RHJpdmVyLmNwcAogTW9kdWxlcy93ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuY3BwCiBNb2R1bGVzL3dl
YnNvY2tldHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuY3BwCiBNb2R1bGVzL3dlYnNvY2tl
dHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxDbGllbnRXcmFwcGVyLmNwcAotTW9kdWxlcy93
ZWJzb2NrZXRzL1dlYlNvY2tldC5jcHAKK01vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXQuY3Bw
IEBuby11bmlmeQogTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwCiBNb2R1
bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbEluc3BlY3Rvci5jcHAKIE1vZHVsZXMvd2Vi
c29ja2V0cy9XZWJTb2NrZXREZWZsYXRlRnJhbWVyLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL1dlYkNvcmUv
V2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IGUwYmRiYjZmMGVmYzU1YTQ4
MzNhYTlkZTFiZTI1NzkwYTRmZGNiNGIuLjBhZTBiM2NkZDU3MjM4ZDczYjQzNDc4ZmI4YzgwMjlj
MjU2MTI1OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3By
b2plY3QucGJ4cHJvagorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9q
ZWN0LnBieHByb2oKQEAgLTMwNjMsNiArMzA2Myw3IEBACiAJCTk3QUFCRDEzMTRGQTA5RDUwMDc0
NTdBRSAvKiBDbG9zZUV2ZW50LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7
IGZpbGVSZWYgPSA5N0FBQkNGODE0RkEwOUQ1MDA3NDU3QUUgLyogQ2xvc2VFdmVudC5oICovOyB9
OwogCQk5N0FBQkQxNzE0RkEwOUQ1MDA3NDU3QUUgLyogVGhyZWFkYWJsZVdlYlNvY2tldENoYW5u
ZWwuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDk3QUFC
Q0ZDMTRGQTA5RDUwMDc0NTdBRSAvKiBUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbC5oICovOyBz
ZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CiAJCTk3QUFCRDE5MTRG
QTA5RDUwMDc0NTdBRSAvKiBUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbENsaWVudFdyYXBwZXIu
aCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDk3QUFCQ0ZF
MTRGQTA5RDUwMDc0NTdBRSAvKiBUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbENsaWVudFdyYXBw
ZXIuaCAqLzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQcml2YXRlLCApOyB9OyB9OworCQk5
N0FBQkQxQzc0RkEwOUQ1MDA3NDU3QUUgLyogV2ViU29ja2V0LmNwcCBpbiBTb3VyY2VzICovID0g
e2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDk3QUFCRDAwNDJGQTA5RDUwMDc0NTdBRSAv
KiBXZWJTb2NrZXQuY3BwICovOyB9OwogCQk5N0FBQkQxQjE0RkEwOUQ1MDA3NDU3QUUgLyogV2Vi
U29ja2V0LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5
N0FBQkQwMDE0RkEwOUQ1MDA3NDU3QUUgLyogV2ViU29ja2V0LmggKi87IH07CiAJCTk3QUFCRDFF
MTRGQTA5RDUwMDc0NTdBRSAvKiBXZWJTb2NrZXRDaGFubmVsLmggaW4gSGVhZGVycyAqLyA9IHtp
c2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5N0FBQkQwMzE0RkEwOUQ1MDA3NDU3QUUgLyog
V2ViU29ja2V0Q2hhbm5lbC5oICovOyBzZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUs
ICk7IH07IH07CiAJCTk3QUFCRDFGMTRGQTA5RDUwMDc0NTdBRSAvKiBXZWJTb2NrZXRDaGFubmVs
Q2xpZW50LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5
N0FBQkQwNDE0RkEwOUQ1MDA3NDU3QUUgLyogV2ViU29ja2V0Q2hhbm5lbENsaWVudC5oICovOyBz
ZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CkBAIC0zNjU4NCw2ICsz
NjU4NSw3IEBACiAJCQkJMDdGNUNGRjYyNTgyQTUyOTAwNjYyRUY1IC8qIFdlYk1BdWRpb1V0aWxp
dGllc0NvY29hLm1tIGluIFNvdXJjZXMgKi8sCiAJCQkJMDcwOUQ3OTIxQUU1NTU3RTAwNEU0MkY4
IC8qIFdlYk1lZGlhU2Vzc2lvbk1hbmFnZXJNYWMuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJMUNB
RjM0ODIwQTZDNDA1MjAwQUJFMDZFIC8qIFdlYlNjcmlwdE9iamVjdC5tbSBpbiBTb3VyY2VzICov
LAorCQkJCTk3QUFCQ0ZGMTRGQTA5RDUwMDc0NTdBRSAvKiBXZWJTb2NrZXQuY3BwIGluIFNvdXJj
ZXMgKi8sCiAJCQkJQ0VDREM5M0MyMUYyOTcyOTAwOTc2QkQxIC8qIFdlYlZpZGVvRnVsbHNjcmVl
bkNvbnRyb2xsZXJBVktpdC5tbSBpbiBTb3VyY2VzICovLAogCQkJCUUxRUU4QjgwMjQxMzE5MUYw
MEU3OTRENiAvKiBXZWJYUkJvdW5kZWRSZWZlcmVuY2VTcGFjZS5jcHAgaW4gU291cmNlcyAqLywK
IAkJCQlFMUVFOEI5MzI0MTMxOTUwMDBFNzk0RDYgLyogV2ViWFJGcmFtZS5jcHAgaW4gU291cmNl
cyAqLywK
</data>
<flag name="commit-queue"
          id="457168"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>434624</attachid>
            <date>2021-07-30 07:42:07 -0700</date>
            <delta_ts>2021-08-05 08:04:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-226557-20210730094206.patch</filename>
            <type>text/plain</type>
            <size>4623</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjYxNWQ2NjU0YzJlYTk0
YTE1N2MwM2M0ZDhlNjBlY2E0MzQ5M2Q1YS4uOTJhYTBjYjVlMDNiODUwNjc4ZDgwYzVjYTk2Y2Q5
ZDliN2ZjNWQwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA3LTMwICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIC1XYXJyYXkt
Ym91bmRzLCAtV3N0cmluZ29wLXRydW5jYXRpb24gd2FybmluZ3MgaW4gUGFja2VkLmgKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjU1NworICAgICAg
ICA8cmRhcjovL3Byb2JsZW0vNzkxMDM2NTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgU3VwcHJlc3NpbmcgdGhlIC1XYXJyYXktYm91bmRzIHdhcm5p
bmcgaW50cm9kdWNlcyB0aGUgLVdzdHJpbmdvcC10cnVuY2F0aW9uIHdhcm5pbmcsIHdoaWNoCisg
ICAgICAgIGNhbm5vdCBiZSBzdXBwcmVzc2VkIHdpdGggcHJhZ21hcy4gVGhlIG9ubHkgc29sdXRp
b24gSSBmb3VuZCBpcyAtV25vLXN0cmluZ29wLXRydW5jYXRpb24uIEkKKyAgICAgICAgY291bGQg
YXBwbHkgaXQgZ2xvYmFsbHksIGJ1dCB0aGlzIHdhcm5pbmcgZG9lcyBub3QgaGF2ZSBtYW55IGZh
bHNlIHBvc2l0aXZlcywgc28gSSB0aGluaworICAgICAgICBpdCdzIGJldHRlciB0byBzdXBwcmVz
cyB0aGUgd2FybmluZyBvbmx5IGZvciBXZWJTb2NrZXQuY3BwLiBVbmZvcnR1bmF0ZWx5IHdlIGhh
dmUgdG8gcmVtb3ZlCisgICAgICAgIGl0IGZyb20gdGhlIHVuaWZpZWQgYnVpbGQgaW4gb3JkZXIg
dG8gYWRkIGN1c3RvbSBmbGFncywgYnV0IGl0IHNlZW1zIHdvcnRoIGl0IHRvIGF2b2lkCisgICAg
ICAgIHN1cHByZXNzaW5nIHRoZSB3YXJuaW5nIGdsb2JhbGx5LgorCisgICAgICAgICogQ01ha2VM
aXN0cy50eHQ6CisgICAgICAgICogU291cmNlcy50eHQ6CisgICAgICAgICogV2ViQ29yZS54Y29k
ZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAyMDIxLTA3LTMwICBSb2IgQnVpcyAgPHJidWlzQGln
YWxpYS5jb20+CiAKICAgICAgICAgW0FzcGVjdFJhdGlvXSBGaXggcmVwbGFjZWQtZWxlbWVudC0w
MzQuaHRtbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3Vy
Y2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBjODg0ODAyYzJmNmQwZjE4MzhjNThlY2Ri
YjNlYTk4YTA3MGZhZDU4Li42ODliYjZjYzAzZjU0ZjBmMTlkZmNmMmY1NWExMjVkMzg0ODQ4NmRj
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMjE5OSwzICsyMTk5LDggQEAgaWYgKE1TVkMpCiAg
ICAgICAgIENPTVBJTEVfUERCX05BTUUgJHtXZWJDb3JlX09VVFBVVF9OQU1FfQogICAgICkKIGVu
ZGlmICgpCisKKyMgVGhpcyBHQ0Mgd2FybmluZyBjYW5ub3QgYmUgc3VwcHJlc3NlZCB3aXRoIGEg
cHJhZ21hLgoraWYgKENNQUtFX0NYWF9DT01QSUxFUl9JRCBNQVRDSEVTICJHTlUiKQorICAgIHNl
dF9zb3VyY2VfZmlsZXNfcHJvcGVydGllcyhNb2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0LmNw
cCBQUk9QRVJUSUVTIENPTVBJTEVfRkxBR1MgLVduby1zdHJpbmdvcC1vdmVycmVhZCkKK2VuZGlm
ICgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Tb3VyY2VzLnR4dCBiL1NvdXJjZS9XZWJD
b3JlL1NvdXJjZXMudHh0CmluZGV4IDU0NDQzZmI4OGE0ZGNhYmNiYjM2ZTUxZjVjMjc3ZTRmZmNj
ZjVhNjIuLmFjOGY3MDlkYjA2MDRkOTM5YjdjMjlkYTcxM2JhY2Q1MjdmMjQwMDEgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL1NvdXJj
ZXMudHh0CkBAIC0zMjMsNyArMzIzLDcgQEAgTW9kdWxlcy93ZWJkcml2ZXIvTmF2aWdhdG9yV2Vi
RHJpdmVyLmNwcAogTW9kdWxlcy93ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuY3BwCiBNb2R1bGVzL3dl
YnNvY2tldHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuY3BwCiBNb2R1bGVzL3dlYnNvY2tl
dHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxDbGllbnRXcmFwcGVyLmNwcAotTW9kdWxlcy93
ZWJzb2NrZXRzL1dlYlNvY2tldC5jcHAKK01vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXQuY3Bw
IEBuby11bmlmeQogTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwCiBNb2R1
bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbEluc3BlY3Rvci5jcHAKIE1vZHVsZXMvd2Vi
c29ja2V0cy9XZWJTb2NrZXREZWZsYXRlRnJhbWVyLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL1dlYkNvcmUv
V2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IGUwYmRiYjZmMGVmYzU1YTQ4
MzNhYTlkZTFiZTI1NzkwYTRmZGNiNGIuLjcxNjc5ZTMxNWFhYzBhYWM0YTlhYzBjZmVlZWJjNGJh
YzIwYzkwOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3By
b2plY3QucGJ4cHJvagorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9q
ZWN0LnBieHByb2oKQEAgLTMwNjMsNiArMzA2Myw3IEBACiAJCTk3QUFCRDEzMTRGQTA5RDUwMDc0
NTdBRSAvKiBDbG9zZUV2ZW50LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7
IGZpbGVSZWYgPSA5N0FBQkNGODE0RkEwOUQ1MDA3NDU3QUUgLyogQ2xvc2VFdmVudC5oICovOyB9
OwogCQk5N0FBQkQxNzE0RkEwOUQ1MDA3NDU3QUUgLyogVGhyZWFkYWJsZVdlYlNvY2tldENoYW5u
ZWwuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDk3QUFC
Q0ZDMTRGQTA5RDUwMDc0NTdBRSAvKiBUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbC5oICovOyBz
ZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CiAJCTk3QUFCRDE5MTRG
QTA5RDUwMDc0NTdBRSAvKiBUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbENsaWVudFdyYXBwZXIu
aCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDk3QUFCQ0ZF
MTRGQTA5RDUwMDc0NTdBRSAvKiBUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbENsaWVudFdyYXBw
ZXIuaCAqLzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQcml2YXRlLCApOyB9OyB9OworCQk5
N0FBQkQxQzc0RkEwOUQ1MDA3NDU3QUUgLyogV2ViU29ja2V0LmNwcCBpbiBTb3VyY2VzICovID0g
e2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDk3QUFCRDAwNDJGQTA5RDUwMDc0NTdBRSAv
KiBXZWJTb2NrZXQuY3BwICovOyB9OwogCQk5N0FBQkQxQjE0RkEwOUQ1MDA3NDU3QUUgLyogV2Vi
U29ja2V0LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5
N0FBQkQwMDE0RkEwOUQ1MDA3NDU3QUUgLyogV2ViU29ja2V0LmggKi87IH07CiAJCTk3QUFCRDFF
MTRGQTA5RDUwMDc0NTdBRSAvKiBXZWJTb2NrZXRDaGFubmVsLmggaW4gSGVhZGVycyAqLyA9IHtp
c2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5N0FBQkQwMzE0RkEwOUQ1MDA3NDU3QUUgLyog
V2ViU29ja2V0Q2hhbm5lbC5oICovOyBzZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUs
ICk7IH07IH07CiAJCTk3QUFCRDFGMTRGQTA5RDUwMDc0NTdBRSAvKiBXZWJTb2NrZXRDaGFubmVs
Q2xpZW50LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5
N0FBQkQwNDE0RkEwOUQ1MDA3NDU3QUUgLyogV2ViU29ja2V0Q2hhbm5lbENsaWVudC5oICovOyBz
ZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CkBAIC0zNjU4NCw2ICsz
NjU4NSw3IEBACiAJCQkJMDdGNUNGRjYyNTgyQTUyOTAwNjYyRUY1IC8qIFdlYk1BdWRpb1V0aWxp
dGllc0NvY29hLm1tIGluIFNvdXJjZXMgKi8sCiAJCQkJMDcwOUQ3OTIxQUU1NTU3RTAwNEU0MkY4
IC8qIFdlYk1lZGlhU2Vzc2lvbk1hbmFnZXJNYWMuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJMUNB
RjM0ODIwQTZDNDA1MjAwQUJFMDZFIC8qIFdlYlNjcmlwdE9iamVjdC5tbSBpbiBTb3VyY2VzICov
LAorCQkJCTk3QUFCRDFDNzRGQTA5RDUwMDc0NTdBRSAvKiBXZWJTb2NrZXQuY3BwIGluIFNvdXJj
ZXMgKi8sCiAJCQkJQ0VDREM5M0MyMUYyOTcyOTAwOTc2QkQxIC8qIFdlYlZpZGVvRnVsbHNjcmVl
bkNvbnRyb2xsZXJBVktpdC5tbSBpbiBTb3VyY2VzICovLAogCQkJCUUxRUU4QjgwMjQxMzE5MUYw
MEU3OTRENiAvKiBXZWJYUkJvdW5kZWRSZWZlcmVuY2VTcGFjZS5jcHAgaW4gU291cmNlcyAqLywK
IAkJCQlFMUVFOEI5MzI0MTMxOTUwMDBFNzk0RDYgLyogV2ViWFJGcmFtZS5jcHAgaW4gU291cmNl
cyAqLywK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>434985</attachid>
            <date>2021-08-05 08:04:21 -0700</date>
            <delta_ts>2021-11-11 11:20:34 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-226557-20210805100420.patch</filename>
            <type>text/plain</type>
            <size>1876</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDJkYzJjMDI4OTkyZGRh
NTM1ZDg5OGVlNWY4ZGUwY2UwMjYxNDU1MC4uMWMzZTJhOTkyMTFlNmNlNjZmM2QyYjdkY2FhNGYz
MGU0YjMzZGEyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA4LTA1ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIC1XYXJyYXkt
Ym91bmRzLCAtV3N0cmluZ29wLXRydW5jYXRpb24gd2FybmluZ3MgaW4gUGFja2VkLmgKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjU1NworICAgICAg
ICA8cmRhcjovL3Byb2JsZW0vNzkxMDM2NTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgU3VwcHJlc3NpbmcgdGhlIC1XYXJyYXktYm91bmRzIHdhcm5p
bmcgaW50cm9kdWNlcyB0aGUgLVdzdHJpbmdvcC10cnVuY2F0aW9uIHdhcm5pbmcsIHdoaWNoCisg
ICAgICAgIGNhbm5vdCBiZSBzdXBwcmVzc2VkIHdpdGggcHJhZ21hcy4gVGhlIG9ubHkgc29sdXRp
b24gSSBmb3VuZCBpcyAtV25vLXN0cmluZ29wLXRydW5jYXRpb24uIEkKKyAgICAgICAgY291bGQg
YXBwbHkgaXQgZ2xvYmFsbHksIGJ1dCB0aGlzIHdhcm5pbmcgZG9lcyBub3QgaGF2ZSBtYW55IGZh
bHNlIHBvc2l0aXZlcywgc28gSSB0aGluaworICAgICAgICBpdCdzIGJldHRlciB0byBzdXBwcmVz
cyB0aGUgd2FybmluZyBvbmx5IGZvciBXZWJTb2NrZXQuY3BwLiBVbmZvcnR1bmF0ZWx5IHdlIGhh
dmUgdG8gcmVtb3ZlCisgICAgICAgIGl0IGZyb20gdGhlIHVuaWZpZWQgYnVpbGQgaW4gb3JkZXIg
dG8gYWRkIGN1c3RvbSBmbGFncywgYnV0IGl0IHNlZW1zIHdvcnRoIGl0IHRvIGF2b2lkCisgICAg
ICAgIHN1cHByZXNzaW5nIHRoZSB3YXJuaW5nIGdsb2JhbGx5LgorCisgICAgICAgICogQ01ha2VM
aXN0cy50eHQ6CisKIDIwMjEtMDgtMDUgIEltYW5vbCBGZXJuYW5kZXogIDxpZmVybmFuZGV6QGln
YWxpYS5jb20+CiAKICAgICAgICAgRml4IFhSIHJlbGF0ZWQgY2xhbmcgd2FybmluZ3MgaW4gV1BF
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJD
b3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IGM4ODQ4MDJjMmY2ZDBmMTgzOGM1OGVjZGJiM2VhOThh
MDcwZmFkNTguLjg0OWE2MjRmMDA2OTAxN2MyM2M4ZTMzY2YyZWJmMGQ3OWIzMTg4M2IgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3Jl
L0NNYWtlTGlzdHMudHh0CkBAIC0yMTk5LDMgKzIxOTksMTAgQEAgaWYgKE1TVkMpCiAgICAgICAg
IENPTVBJTEVfUERCX05BTUUgJHtXZWJDb3JlX09VVFBVVF9OQU1FfQogICAgICkKIGVuZGlmICgp
CisKKyMgU3BlY2lhbCBjb21waWxlciBmbGFncyBtYXkgYmUgdXNlZCBmb3IgaW5kaXZpZHVhbCBm
aWxlcyBvbmx5IGlmIHRoZSBmaWxlIGlzIGV4Y2x1ZGVkIGZyb20gdW5pZmllZAorIyBidWlsZC4K
K2lmIChDTUFLRV9DWFhfQ09NUElMRVJfSUQgTUFUQ0hFUyAiR05VIikKKyAgICAjIFRoaXMgd2Fy
bmluZyBjYW5ub3QgYmUgc3VwcHJlc3NlZCB3aXRoIGEgcHJhZ21hLgorICAgIHNldF9zb3VyY2Vf
ZmlsZXNfcHJvcGVydGllcyhNb2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcCBQUk9QRVJU
SUVTIENPTVBJTEVfRkxBR1MgLVduby1zdHJpbmdvcC1vdmVycmVhZCkKK2VuZGlmICgpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>443980</attachid>
            <date>2021-11-11 11:20:38 -0800</date>
            <delta_ts>2021-11-11 13:09:49 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-226557-20211111132037.patch</filename>
            <type>text/plain</type>
            <size>7049</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDZjMGY5MzEwNGI5ODlk
MTIyMzdiM2IwZGEzNzBkYTQ1NTk2Y2M1Ni4uZWUyNmIwMzZkOGI0MDI1ZWU5NGNiMmUwYzlmMzc0
MmVhOGY5ZGQ5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTExLTExICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIC1XYXJyYXkt
Ym91bmRzLCAtV3N0cmluZ29wLXRydW5jYXRpb24sIC1Xc3RyaW5nb3Atb3ZlcnJlYWQgd2Fybmlu
Z3MgaW4gUGFja2VkLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIyNjU1NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzkxMDM2NTg+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgLVdzdHJpbmdv
cC1vdmVycmVhZCBpcyBub3cgc3VwcHJlc3NlZCBnbG9iYWxseSwgd2UgY2FuIGluY2x1ZGUgV2Vi
U29ja2V0LmNwcCBpbiB0aGUKKyAgICAgICAgdW5pZmllZCBidWlsZCBvbmNlIGFnYWluLgorCisg
ICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAgICogU291cmNlcy50eHQ6CisgICAgICAg
ICogV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAyMDIxLTExLTExICBBbnR0
aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBJbnRyb2R1Y2UgU2VsZWN0
b3JNYXRjaGluZ1N0YXRlIGFuZCBtb3ZlIFNlbGVjdG9yRmlsdGVyIHRoZXJlCmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlz
dHMudHh0CmluZGV4IGViZjQ5YWYzNDU4ZTNlODY3MDgxMTk1ZWRhNGI5YzAzODQ1MGRkZmEuLjU2
YTg5ODk2M2NkMzU5ZjQxNjVjYjBjM2U5MmNiYTI2ZWM5M2Y1YTQgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMu
dHh0CkBAIC0yNDQ3LDEwICsyNDQ3LDMgQEAgaWYgKE1TVkMpCiAgICAgICAgIENPTVBJTEVfUERC
X05BTUUgJHtXZWJDb3JlX09VVFBVVF9OQU1FfQogICAgICkKIGVuZGlmICgpCi0KLSMgU3BlY2lh
bCBjb21waWxlciBmbGFncyBtYXkgYmUgdXNlZCBmb3IgaW5kaXZpZHVhbCBmaWxlcyBvbmx5IGlm
IHRoZSBmaWxlIGlzIGV4Y2x1ZGVkIGZyb20gdW5pZmllZAotIyBidWlsZC4KLWlmIChDTUFLRV9D
WFhfQ09NUElMRVJfSUQgTUFUQ0hFUyAiR05VIikKLSAgICAjIFRoaXMgd2FybmluZyBjYW5ub3Qg
YmUgc3VwcHJlc3NlZCB3aXRoIGEgcHJhZ21hLgotICAgIHNldF9zb3VyY2VfZmlsZXNfcHJvcGVy
dGllcyhNb2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcCBQUk9QRVJUSUVTIENPTVBJTEVf
RkxBR1MgLVduby1zdHJpbmdvcC1vdmVycmVhZCkKLWVuZGlmICgpCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9Tb3VyY2VzLnR4dCBiL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXMudHh0CmluZGV4
IDhhMTE0YTEyMzhkNGY2ODE4ODQ2ZjIxYzJkYjBhYzAzMDNiMWViMjkuLjVhN2VhZDU2ZDkxNjhi
ZjljNDNjNzFmZWU4YWQyNTYzNzJiOTI0YzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1Nv
dXJjZXMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXMudHh0CkBAIC0zODMsNyArMzgz
LDcgQEAgTW9kdWxlcy93ZWJkcml2ZXIvTmF2aWdhdG9yV2ViRHJpdmVyLmNwcAogTW9kdWxlcy93
ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuY3BwCiBNb2R1bGVzL3dlYnNvY2tldHMvVGhyZWFkYWJsZVdl
YlNvY2tldENoYW5uZWwuY3BwCiBNb2R1bGVzL3dlYnNvY2tldHMvVGhyZWFkYWJsZVdlYlNvY2tl
dENoYW5uZWxDbGllbnRXcmFwcGVyLmNwcAotTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldC5j
cHAgQG5vLXVuaWZ5CitNb2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcAogTW9kdWxlcy93
ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwCiBNb2R1bGVzL3dlYnNvY2tldHMvV2ViU29j
a2V0Q2hhbm5lbEluc3BlY3Rvci5jcHAKIE1vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXREZWZs
YXRlRnJhbWVyLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS54Y29kZXBy
b2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJv
amVjdC5wYnhwcm9qCmluZGV4IDY5ZDNmZDljOGEyZmNhNjExNDk3ODg5MGY4MWJlN2NmN2RmMzU4
NGEuLmQwMjE1NjY4ZDBiNTZjYmU4NGRkMjllNzkyODM3NDg2MTEwZDU2ODAgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagorKysgYi9T
b3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKQEAgLTI5MDks
NyArMjkwOSw2IEBACiAJCTkzODQzMEI0MjQ3NURFNDAwMDNGOTYxNyAvKiBEaWN0YXRpb25Db250
ZXh0LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5Mzg0
MzBCMjI0NzVERTNGMDAzRjk2MTcgLyogRGljdGF0aW9uQ29udGV4dC5oICovOyBzZXR0aW5ncyA9
IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CiAJCTkzODQ5QzFGMjRCRTQwNEIwMDQ0
OEQ1QSAvKiBFbXB0eVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaCBpbiBIZWFkZXJzICovID0ge2lz
YSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDkzODQ5QzFFMjRCRTQwNEEwMDQ0OEQ1QSAvKiBF
bXB0eVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaCAqLzsgfTsKIAkJOTM4NDlDMjMyNEJFREQ4OTAw
NDQ4RDVBIC8qIEpTSURCU2VyaWFsaXphdGlvbkdsb2JhbE9iamVjdC5oIGluIEhlYWRlcnMgKi8g
PSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gOTM4NDlDMjEyNEJFREQ4ODAwNDQ4RDVB
IC8qIEpTSURCU2VyaWFsaXphdGlvbkdsb2JhbE9iamVjdC5oICovOyB9OwotCQk5MzhDRjI0MjI2
QkI3MjhDMDBDMDkyNDAgLyogV2ViU29ja2V0LmNwcCBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBC
WEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDk3QUFCQ0ZGMTRGQTA5RDUwMDc0NTdBRSAvKiBXZWJTb2Nr
ZXQuY3BwICovOyB9OwogCQk5MzhFNjVGMTA5RjA5ODQwMDA4QTQ4RUMgLyogSlNIVE1MRWxlbWVu
dFdyYXBwZXJGYWN0b3J5LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZp
bGVSZWYgPSA5MzhFNjVGMDA5RjA5ODQwMDA4QTQ4RUMgLyogSlNIVE1MRWxlbWVudFdyYXBwZXJG
YWN0b3J5LmggKi87IH07CiAJCTkzOEU2NjYyMDlGMDlCODcwMDhBNDhFQyAvKiBKU0hUTUxDYW52
YXNFbGVtZW50LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYg
PSA5MzhFNjY2MTA5RjA5Qjg3MDA4QTQ4RUMgLyogSlNIVE1MQ2FudmFzRWxlbWVudC5oICovOyB9
OwogCQk5MzkxQTk5MTE2Mjc0NkNCMDAyOTczMzAgLyogU2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWMu
aCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDkzOTFBOTkw
MTYyNzQ2Q0IwMDI5NzMzMCAvKiBTY3JvbGxpbmdDb29yZGluYXRvck1hYy5oICovOyBzZXR0aW5n
cyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CkBAIC0xODkyMiwxMSArMTg5MjEs
MTEgQEAKIAkJMUE1NjlDQzQwRDdFMkI2MDAwN0MzOTgzIC8qIGJyaWRnZSAqLyA9IHsKIAkJCWlz
YSA9IFBCWEdyb3VwOwogCQkJY2hpbGRyZW4gPSAoCisJCQkJNTlCNTk3NzExMTA4NjU1NjAwNzE1
OUU4IC8qIGpzYyAqLywKIAkJCQkxQTU2OUNFMjBEN0UyQjgyMDA3QzM5ODMgLyogb2JqYyAqLywK
IAkJCQk1OTlFNzU4RjExMDU1QTFGMDBEOTA0RkEgLyogQnJpZGdlLmggKi8sCiAJCQkJMUE3MUQ1
NzkwRjMzODE5MDAwRjlDRTRFIC8qIElkZW50aWZpZXJSZXAuY3BwICovLAogCQkJCTFBNzFENTdB
MEYzMzgxOTAwMEY5Q0U0RSAvKiBJZGVudGlmaWVyUmVwLmggKi8sCi0JCQkJNTlCNTk3NzExMTA4
NjU1NjAwNzE1OUU4IC8qIGpzYyAqLywKIAkJCQkxQTU2OUNFRjBEN0UyQjgyMDA3QzM5ODMgLyog
cnVudGltZV9hcnJheS5jcHAgKi8sCiAJCQkJMUE1NjlDRjAwRDdFMkI4MjAwN0MzOTgzIC8qIHJ1
bnRpbWVfYXJyYXkuaCAqLywKIAkJCQkxQTU2OUNGMTBEN0UyQjgyMDA3QzM5ODMgLyogcnVudGlt
ZV9tZXRob2QuY3BwICovLApAQCAtMzgxMTQsNyArMzgxMTMsNiBAQAogCQkJCTdDNDhBNkQwMTkx
QzlENjUwMDAyNjY3NCAvKiBXZWJLaXROYW1lc3BhY2UuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJ
MDdGNUNGRjYyNTgyQTUyOTAwNjYyRUY1IC8qIFdlYk1BdWRpb1V0aWxpdGllc0NvY29hLm1tIGlu
IFNvdXJjZXMgKi8sCiAJCQkJMUNBRjM0ODIwQTZDNDA1MjAwQUJFMDZFIC8qIFdlYlNjcmlwdE9i
amVjdC5tbSBpbiBTb3VyY2VzICovLAotCQkJCTkzOENGMjQyMjZCQjcyOEMwMEMwOTI0MCAvKiBX
ZWJTb2NrZXQuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJQ0VDREM5M0MyMUYyOTcyOTAwOTc2QkQx
IC8qIFdlYlZpZGVvRnVsbHNjcmVlbkNvbnRyb2xsZXJBVktpdC5tbSBpbiBTb3VyY2VzICovLAog
CQkJCUExNDgzMkMyMTg3RjY1QzcwMERBNjNBNiAvKiBXS1V0aWxpdGllcy5jIGluIFNvdXJjZXMg
Ki8sCiAJCQkJQTgzM0M3Q0MwQTJDRjA3NDAwRDU3NjY0IC8qIFhMaW5rTmFtZXMuY3BwIGluIFNv
dXJjZXMgKi8sCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJGbGFncy5j
bWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21waWxlckZsYWdzLmNtYWtlCmluZGV4IDc3ZWJi
ODAyZWJiMDM0NTBiNWU5NjYyOWE0N2I2ODE5YTY4NjcyYzYuLmQ0OWQ2ZTQzZDdlZWI2NjczYzYy
NGUwMGVhZGYzZWRmY2EwNjc0ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21w
aWxlckZsYWdzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21waWxlckZsYWdzLmNt
YWtlCkBAIC0xNDMsNiArMTQzLDEzIEBAIGlmIChDT01QSUxFUl9JU19HQ0NfT1JfQ0xBTkcpCiAg
ICAgICAgIFdFQktJVF9QUkVQRU5EX0dMT0JBTF9DWFhfRkxBR1MoLVduby1ub25udWxsKQogICAg
IGVuZGlmICgpCiAKKyAgICAjIFRoaXMgdHJpZ2dlcnMgd2FybmluZ3MgaW4gd3RmL1BhY2tlZC5o
LCBhIGhlYWRlciB0aGF0IGlzIGluY2x1ZGVkIGluIG1hbnkgcGxhY2VzLiBJdCBkb2VzIG5vdAor
ICAgICMgcmVzcGVjdCBpZ25vcmUgd2FybmluZyBwcmFnbWFzIGFuZCB3ZSBjYW5ub3QgZWFzaWx5
IHN1cHByZXNzIGl0IGZvciBhbGwgYWZmZWN0ZWQgZmlsZXMuCisgICAgIyBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NTU3CisgICAgaWYgKENNQUtFX0NYWF9DT01Q
SUxFUl9JRCBNQVRDSEVTICJHTlUiIEFORCAke0NNQUtFX0NYWF9DT01QSUxFUl9WRVJTSU9OfSBW
RVJTSU9OX0dSRUFURVJfRVFVQUwgIjExLjAiKQorICAgICAgICBXRUJLSVRfUFJFUEVORF9HTE9C
QUxfQ1hYX0ZMQUdTKC1Xbm8tc3RyaW5nb3Atb3ZlcnJlYWQpCisgICAgZW5kaWYgKCkKKwogICAg
ICMgLVdleHBhbnNpb24tdG8tZGVmaW5lZCBwcm9kdWNlcyBmYWxzZSBwb3NpdGl2ZXMgd2l0aCBH
Q0MgYnV0IG5vdCBDbGFuZwogICAgICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTE2NzY0MyNjMTMKICAgICBpZiAoQ01BS0VfQ1hYX0NPTVBJTEVSX0lEIE1BVENIRVMg
IkdOVSIpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYmUzZTVjMmJi
NzM0YzM3NmY4YWI2NTdlZmJkMDU5MjdmY2YwOWYyOC4uNDMwNTA5OWE0MDI1Njg2MDQzYzFiOGVh
ZDIzMDNmZThmYTdkZDkwZCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDIxIEBACisyMDIxLTExLTExICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnph
cm9AZ25vbWUub3JnPgorCisgICAgICAgIC1XYXJyYXktYm91bmRzLCAtV3N0cmluZ29wLXRydW5j
YXRpb24sIC1Xc3RyaW5nb3Atb3ZlcnJlYWQgd2FybmluZ3MgaW4gUGFja2VkLmgKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjU1NworICAgICAgICA8
cmRhcjovL3Byb2JsZW0vNzkxMDM2NTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgU3VwcHJlc3MgLVdzdHJpbmdvcC1vdmVycmVhZCBmb3IgYWxsIG9m
IFdlYktpdCB3aGVuIGJ1aWxkaW5nIHdpdGggR0NDIDExIG9yIG5ld2VyLiBUaGlzIGlzCisgICAg
ICAgIGFuIHVuZm9ydHVuYXRlIHdheSB0byBkZWFsIHdpdGggZmFsc2UgcG9zaXRpdmVzIHRoYXQg
d2Ugb3VnaHQgdG8gYmUgYWJsZSB0byBzaWxlbmNlIGluIGp1c3QKKyAgICAgICAgYSBmZXcgcGxh
Y2VzLCBidXQgd2hlbiB3YXJuaW5ncyBkbyBub3QgcmVzcGVjdCBwcmFnbWFzIHdlIGhhdmUgZmV3
IGFsdGVybmF0aXZlcywgYW5kIHRyeWluZworICAgICAgICB0byByZW1vdmUgZGVyaXZlZCBzb3Vy
Y2VzIGZyb20gdGhlIHVuaWZpZWQgYnVpbGQgaW4gb3JkZXIgdG8gYnVpbGQgdGhlbSB3aXRoIHNw
ZWNpYWwgZmxhZ3MKKyAgICAgICAgaXMganVzdCBub3Qgd29ydGggdGhlIGVmZm9ydC4KKworICAg
ICAgICBUaGlzIGlzIHBhcnQgb2YgYSBsYXJnZXIgdHJlbmQgb2Ygb3ZlcnNlbnNpdGl2ZSB3YXJu
aW5ncyBmcm9tIEdDQyAxMS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRDb21waWxl
ckZsYWdzLmNtYWtlOgorCiAyMDIxLTExLTEwICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBh
cHBsZS5jb20+CiAKICAgICAgICAgQ29kaW5nIHN0eWxlIGZvciBpbm5lciBuYW1lc3BhY2VzIGlz
IHNob3VsZCBiZSBzaW1wbGlmaWVkIHRvIG5vdCBpbmRlbnRlZAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>