226070 2021-05-21 00:04:10 -0700 [MSVC] The "/Zc:lambda" switch is recommended to use the new lambda processor. 2022-04-11 20:35:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC Windows 10 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209358 https://bugs.webkit.org/show_bug.cgi?id=209311 InRadar P2 Normal --- 1 1998zhangyi fujii annulen bburg bfulgham don.olmstead ews-watchlist fujii glenn gyuyoung.kim jbedard keith_miller mark.lam msaboff pvollan ross.kirsling ryuan.choi saam sergio tzagallo v-apriltan webkit-bug-importer oldest_to_newest 1762311 0 1998zhangyi 2021-05-21 00:04:10 -0700 Environment: VS 2019 + Windows Server 2016 Issue description: The MSVC team uses Webkit project as a test case to detect compiler regressions. Recently, two Webkit ports WinCairo and AppleWin triggered an old lambda processor issue on MSVC, which is an irreconcilable old lambda processor issue. Therefore, it is recommended to turn on "/Zc:lambda" switch to use new lambda processor to avoid this problem. Some opinions from MSVC developers: Note: the Webkit failure is an issue with the old lambda processor in which one or more lambdas (each of which contains one or more nested lambdas) are generated from a macro expansion. Trying to tell the lambdas apart is an exercise in futility (in the old, token based lambda processor the ‘identity’ for a lambda is the SFA of the initial ‘[‘) and code like this was one of the motivating reasons for starting on the lambda rejuvenation effort. Repro Steps: 1. git clone https://github.com/WebKit/webkit F:\gitP\WebKit\webkit 2. open a VS 2019 x64 command prompt as admin and browse to F:\gitP\WebKit\webkit 3. download latest WebKitAuxiliaryLibrary.zip from https://developer.apple.com/opensource/internet/WebKitAuxiliaryLibrary.zip and unzip to F:\gitP\WebKit\webkit\WebKitLibraries\win 4. download latest WebKitSupportLibrary.zip from https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html and unzip to F:\gitP\WebKit\webkit\WebKitLibraries\win 5. mkdir F:\gitP\WebKit\webkit\build_amd64_AppleWin 6. cd F:\gitP\WebKit\webkit\build_amd64_AppleWin 7. cmake -G "Visual Studio 16 2019" -A x64 -DCMAKE_SYSTEM_VERSION=10.0.18362.0 -DCMAKE_BUILD_TYPE=Release -DRUBY_LIBRARY=C:\tools\ruby26\lib -DPORT="AppleWin" .. 8. msbuild /p:Platform=x64 /p:Configuration=Release WebKit.sln /t:Rebuild Error Info: F:\gitP\WebKit\webkit\Source\JavaScriptCore\heap\Heap.cpp(2827): Assertion failed: iter->second.EncodedIndex() != encodedIndex, file d:\agent\_work\4\s\src\vctools\Compiler\CxxFE\sl\p1\c\lambdas.cpp, line 2464 [when compiling F:\gitP\WebKit\webkit\build_amd64_AppleWin\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-ee8a7a7a-3.cpp] c1xx!assertfe()+0x106 d:\agent\_work\4\s\src\vctools\Compiler\CxxFE\sl\p1\c\debug.c Line 333 c1xx!LambdaProcessor::Process()+0x8c3 d:\agent\_work\4\s\src\vctools\Compiler\CxxFE\sl\p1\c\lambdas.cpp Line 2462 c1xx!PrimaryParser::Parse()+0xd9ae d:\agent\_work\4\s\src\vctools\Compiler\CxxFE\sl\p1\cxx\grammar.y Line 11319 c1xx!`CallPrimaryParser'::`2'::<lambda_1>::operator()()+0x19 d:\agent\_work\4\s\src\vctools\Compiler\CxxFE\sl\p1\cxx\grammar.y Line 13808 c1xx!CallPrimaryParser()+0x14e d:\agent\_work\4\s\src\vctools\Compiler\CxxFE\sl\p1\cxx\grammar.y Line 13829 c1xx!main_compile()+0xfa2 d:\agent\_work\4\s\src\vctools\Compiler\CxxFE\sl\p1\c\main.c Line 3094 1762316 1 fujii 2021-05-21 00:30:15 -0700 /Zc:lambda seems an undocumented switch. Which MSVC version started to support it? IIRC, AppleWin is still using Visual Studio 2019 version 16.3 1762941 2 fujii 2021-05-23 13:11:02 -0700 See also: Bug 209311 – [WinCairo][MSVC] NetworkProcess.cpp(1896): fatal error C1001: Internal compiler error with Visual Studio 16.5.0 1763062 3 1998zhangyi 2021-05-24 01:38:55 -0700 Thanks for providing more information, Fujii. >>/Zc:lambda seems an undocumented switch. Which MSVC version started to support it? This does not seem to have official documents at present. I can find that the earliest VS version that contains the modification(Some people apparently don't like the continued use of 'experimental', so the team removed "/experimental:newLambdaProcessor" and added "/Zc:lambda" switch) is VS 16.4 Preview2, and the official version may be VS 16.5 and later. >>See also: Bug 209311 – [WinCairo][MSVC] NetworkProcess.cpp(1896): fatal error C1001: Internal compiler error with Visual Studio 16.5.0 Check the datails of dup bug https://bugs.webkit.org/show_bug.cgi?id=209358, the internal error occurred on VS 16.5.0, which should be caused by the above change. So now it may be necessary to add the new lambda processor back. >>IIRC, AppleWin is still using Visual Studio 2019 version 16.3 On my side, AppleWin and WinCairo are currently compiled successfully with "/Zc:lambda". I tested it on VS 16.9.1 and the latest version. 1763686 4 429692 fujii 2021-05-25 14:30:27 -0700 Created attachment 429692 Patch 1763716 5 don.olmstead 2021-05-25 15:54:52 -0700 Isn't VS 2022 releasing soon? Is the new lambda processor on by default for it? 1763793 6 fujii 2021-05-25 18:03:44 -0700 WinCairo EWS is reporting an compilation error for the patch. https://ews-build.webkit.org/#/builders/12/builds/53128 FAILED: Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-ee8a7a7a-3.cpp.obj C:\MSVS\VC\Tools\MSVC\14.28.29333\bin\Hostx64\x64\cl.exe /nologo /TP -DBUILDING_JavaScriptCore -DBUILDING_WITH_CMAKE=1 -DHAVE_CONFIG_H=1 -DJavaScriptCore_EXPORTS -DNOCRYPT -DNOMINMAX -DUNICODE -DWINVER=0x601 -DWTF_PLATFORM_WIN_CAIRO=1 -D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1 -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WIN32_WINNT=0x601 -D_WINDOWS -D_WINSOCKAPI_="" -IJavaScriptCore\Headers -I. -I..\..\Source\JavaScriptCore -I..\..\Source\JavaScriptCore\API -I..\..\Source\JavaScriptCore\assembler -I..\..\Source\JavaScriptCore\b3 -I..\..\Source\JavaScriptCore\b3\air -I..\..\Source\JavaScriptCore\bindings -I..\..\Source\JavaScriptCore\builtins -I..\..\Source\JavaScriptCore\bytecode -I..\..\Source\JavaScriptCore\bytecompiler -I..\..\Source\JavaScriptCore\dfg -I..\..\Source\JavaScriptCore\disassembler -I..\..\Source\JavaScriptCore\disassembler\ARM64 -I..\..\Source\JavaScriptCore\disassembler\udis86 -I..\..\Source\JavaScriptCore\domjit -I..\..\Source\JavaScriptCore\ftl -I..\..\Source\JavaScriptCore\heap -I..\..\Source\JavaScriptCore\debugger -I..\..\Source\JavaScriptCore\inspector -I..\..\Source\JavaScriptCore\inspector\agents -I..\..\Source\JavaScriptCore\inspector\augmentable -I..\..\Source\JavaScriptCore\inspector\remote -I..\..\Source\JavaScriptCore\interpreter -I..\..\Source\JavaScriptCore\jit -I..\..\Source\JavaScriptCore\llint -I..\..\Source\JavaScriptCore\parser -I..\..\Source\JavaScriptCore\profiler -I..\..\Source\JavaScriptCore\runtime -I..\..\Source\JavaScriptCore\tools -I..\..\Source\JavaScriptCore\wasm -I..\..\Source\JavaScriptCore\wasm\js -I..\..\Source\JavaScriptCore\yarr -IJavaScriptCore\DerivedSources -IJavaScriptCore\DerivedSources\inspector -IJavaScriptCore\DerivedSources\runtime -IJavaScriptCore\DerivedSources\yarr -I..\include\private -I..\..\Source\JavaScriptCore\inspector\remote\socket -IWTF\Headers -I..\..\WebKitLibraries\win\include /W4 /DWIN32 /D_WINDOWS /GR- /EHs- /EHc- /MD /O2 /Ob2 /DNDEBUG /wd4018 /wd4060 /wd4068 /wd4100 /wd4127 /wd4146 /wd4189 /wd4201 /wd4244 /wd4245 /wd4251 /wd4275 /wd4267 /wd4305 /wd4309 /wd4312 /wd4324 /wd4389 /wd4456 /wd4457 /wd4458 /wd4459 /wd4505 /wd4611 /wd4646 /wd4701 /wd4702 /wd4706 /wd4715 /wd4722 /wd4838 /wd4840 /wd4996 /wd5205 /Zi /GS /EHa- /EHc- /EHs- /fp:except- /analyze- /bigobj /utf-8 /validate-charset /Oy- /Zc:lambda -std:c++17 /showIncludes /FoSource\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\__\__\JavaScriptCore\DerivedSources\unified-sources\UnifiedSource-ee8a7a7a-3.cpp.obj /FdSource\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\ /FS -c JavaScriptCore\DerivedSources\unified-sources\UnifiedSource-ee8a7a7a-3.cpp C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\heap/Heap.cpp(2874): error C2065: 'Visitor': undeclared identifier C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\heap/Heap.cpp(2901): note: see reference to function template instantiation 'auto JSC::Heap::addCoreConstraints::<lambda_12>::()::<lambda_2>::operator ()<JSC::IsoCellSet>(_T1 &) const' being compiled with [ _T1=JSC::IsoCellSet ] C:\Buildbot\WinCairo-EWS\build\WebKitBuild\Release\WTF\Headers\wtf/Function.h(52): note: see reference to function template instantiation 'auto JSC::Heap::addCoreConstraints::<lambda_12>::operator ()<JSC::SlotVisitor>(_T1 &) const' being compiled with [ _T1=JSC::SlotVisitor ] C:\Buildbot\WinCairo-EWS\build\WebKitBuild\Release\WTF\Headers\wtf/Function.h(52): note: while compiling class template member function 'Out WTF::Detail::CallableWrapper<CallableType,Out,JSC::SlotVisitor &>::call(JSC::SlotVisitor &)' with [ Out=void, CallableType=JSC::Heap::addCoreConstraints::<lambda_12> ] C:\Buildbot\WinCairo-EWS\build\WebKitBuild\Release\WTF\Headers\wtf/StdLibExtras.h(505): note: see reference to class template instantiation 'WTF::Detail::CallableWrapper<CallableType,Out,JSC::SlotVisitor &>' being compiled with [ CallableType=JSC::Heap::addCoreConstraints::<lambda_12>, Out=void ] C:\Buildbot\WinCairo-EWS\build\WebKitBuild\Release\WTF\Headers\wtf/Function.h(74): note: see reference to function template instantiation 'std::unique_ptr<T,std::default_delete<T>> WTF::makeUnique<WTF::Detail::CallableWrapper<CallableType,Out,JSC::SlotVisitor &>,_Ty>(_Ty &&)' being compiled with [ T=WTF::Detail::CallableWrapper<JSC::Heap::addCoreConstraints::<lambda_12>,void,JSC::SlotVisitor &>, CallableType=JSC::Heap::addCoreConstraints::<lambda_12>, Out=void, _Ty=JSC::Heap::addCoreConstraints::<lambda_12> ] C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\heap/Heap.cpp(2901): note: see reference to function template instantiation 'WTF::Function<void (JSC::SlotVisitor &)>::Function<JSC::Heap::addCoreConstraints::<lambda_12>,void>(CallableType &&)' being compiled with [ CallableType=JSC::Heap::addCoreConstraints::<lambda_12> ] C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\heap/Heap.cpp(2872): note: see reference to function template instantiation 'WTF::Function<void (JSC::SlotVisitor &)>::Function<JSC::Heap::addCoreConstraints::<lambda_12>,void>(CallableType &&)' being compiled with [ CallableType=JSC::Heap::addCoreConstraints::<lambda_12> ] C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\heap/Heap.cpp(2874): error C2672: 'JSC::IsoCellSet::forEachMarkedCellInParallel': no matching overloaded function found C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\heap/Heap.cpp(2901): error C2974: 'JSC::IsoCellSet::forEachMarkedCellInParallel': invalid template argument for 'Visitor', type expected C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\heap\IsoCellSet.h(62): note: see declaration of 'JSC::IsoCellSet::forEachMarkedCellInParallel' C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\heap/Heap.cpp(2874): error C2672: 'JSC::Subspace::forEachMarkedCellInParallel': no matching overloaded function found C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\heap/Heap.cpp(2901): error C2974: 'JSC::Subspace::forEachMarkedCellInParallel': invalid template argument for 'Visitor', type expected C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\heap\Subspace.h(90): note: see declaration of 'JSC::Subspace::forEachMarkedCellInParallel' 1763802 7 fujii 2021-05-25 18:39:40 -0700 I don't see the error on my PC. Is this caused by specific MSVC version. I'm using MSVC 14.29 (Visual Studio 2019 Version 16.9). WinCairo EWS seems using MSVC 14.28 (Visual Studio 2019 Version 16.8). 1763852 8 1998zhangyi 2021-05-26 02:08:39 -0700 Hmm, for error C2065，I found relevant information, it is indeed a bug of MSVC, currently fixed in 16.9. You may need to upgrade VS. https://developercommunity.visualstudio.com/t/captured-variable-not-recognized-when-calling-temp/1137293 https://developercommunity.visualstudio.com/t/nested-c20-template-lambdas-two-issues-with-captur/1150322 I don’t know much about VS2022, there is a related blog https://devblogs.microsoft.com/visualstudio/visual-studio-2022/. 1763933 9 don.olmstead 2021-05-26 09:09:36 -0700 (In reply to QuellaZhang from comment #8) > Hmm, for error C2065，I found relevant information, it is indeed a bug of > MSVC, currently fixed in 16.9. You may need to upgrade VS. > > https://developercommunity.visualstudio.com/t/captured-variable-not- > recognized-when-calling-temp/1137293 > https://developercommunity.visualstudio.com/t/nested-c20-template-lambdas- > two-issues-with-captur/1150322 > > I don’t know much about VS2022, there is a related blog > https://devblogs.microsoft.com/visualstudio/visual-studio-2022/. Fujii's patch adds a compiler flag based on versioning I'm just curious if that flag will still be valid with 2022. If not then there'd need to be an upper bound. 1764627 10 1998zhangyi 2021-05-27 18:46:35 -0700 Hey Don, Confirmed with the developer: >>Isn't VS 2022 releasing soon? Is the new lambda processor on by default for it? Not: at the moment: it is the default if you compile with /std:c++latest or /permissive- -- it may become the default in VS2022 but we haven't made that decision yet. 1764700 11 webkit-bug-importer 2021-05-28 00:05:20 -0700 <rdar://problem/78607135> 1764850 12 don.olmstead 2021-05-28 11:37:40 -0700 (In reply to QuellaZhang from comment #10) > Hey Don, > > Confirmed with the developer: > > >>Isn't VS 2022 releasing soon? Is the new lambda processor on by default for it? > > Not: at the moment: it is the default if you compile with /std:c++latest or > /permissive- -- it may become the default in VS2022 but we haven't made that > decision yet. Thanks for letting us know! Fujii I think its probably better to start compiling with /permissive- rather than this. Thoughts? 1765245 13 fujii 2021-05-30 13:09:07 -0700 (In reply to Don Olmstead from comment #12) > (In reply to QuellaZhang from comment #10) > > Hey Don, > > > > Confirmed with the developer: > > > > >>Isn't VS 2022 releasing soon? Is the new lambda processor on by default for it? > > > > Not: at the moment: it is the default if you compile with /std:c++latest or > > /permissive- -- it may become the default in VS2022 but we haven't made that > > decision yet. > > Thanks for letting us know! > > Fujii I think its probably better to start compiling with /permissive- > rather than this. Thoughts? > the first public preview of Visual Studio 2022 will be released this summer. https://devblogs.microsoft.com/visualstudio/visual-studio-2022/ QuellaZhang, when do you want to solve the original problem (comment#0)? I think waiting for the official VS2022 release doesn't meat the QuellaZhang's schedule. 1765246 14 fujii 2021-05-30 13:12:32 -0700 meet, not 🐷. 1765378 15 1998zhangyi 2021-05-31 03:43:17 -0700 Hi Fujii, We added "/Zc:lambda" to command line as workaround to unblock us. Please follow your schedule to fix this issue. :) 1796222 16 fujii 2021-09-22 14:57:12 -0700 Bug 230599 can be solved by the /Zc:lambda switch. 1796640 17 439085 fujii 2021-09-23 13:24:06 -0700 Created attachment 439085 Patch 1796657 18 439085 ross.kirsling 2021-09-23 14:26:19 -0700 Comment on attachment 439085 Patch Seems fine to me. 1796664 19 439085 fujii 2021-09-23 14:35:16 -0700 Comment on attachment 439085 Patch Clearing flags on attachment: 439085 Committed r283007 (242072@main): <https://commits.webkit.org/242072@main> 1796665 20 fujii 2021-09-23 14:35:22 -0700 All reviewed patches have been landed. Closing bug. 1798186 21 fujii 2021-09-28 22:49:25 -0700 Reopening to attach new patch. 1798187 22 439568 fujii 2021-09-28 22:49:34 -0700 Created attachment 439568 Wrong Patch 1798188 23 ews-watchlist 2021-09-28 22:50:30 -0700 This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`) 1806518 24 fujii 2021-10-19 23:40:20 -0700 Hi QuellaZhang, After this change, we have another problem. Could you take a look? Bug 230877 – [Win] WebCore.dir\Debug\WebCore.lib : fatal error LNK1248: image size (1000309F0) exceeds maximum allowable size (FFFFFFFF) 1860537 25 v-apriltan 2022-04-11 20:15:37 -0700 Yes, the AppleWin port failed with one known bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1490389/ 1860541 26 fujii 2022-04-11 20:35:23 -0700 (In reply to April from comment #25) > Yes, the AppleWin port failed with one known bug: > https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1490389/ I can't see the page. > 401 - Uh-oh, you do not have access. If you have a problem, please create a new ticket. 429692 2021-05-25 14:30:27 -0700 2021-09-23 13:23:54 -0700 Patch bug-226070-20210526063025.patch text/plain 1249 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc01TVkMuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc01TVkMuY21ha2UKaW5kZXggYmFl NzA3ZmFlYjJhMjYzYTc3MzBhZTY2OTMxYTY0YmJhYTQyMzNkMy4uYzc3MmU4NzE2NWM3MjEwMTJj ZGYzZWEzZTY2Njc0NjVlZjE2NDU3OSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNN U1ZDLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zTVNWQy5jbWFrZQpAQCAtMjA1LDMg KzIwNSw4IEBAIGlmIChDT01QSUxFUl9JU19DTEFOR19DTCkKICAgICBzZXQoSEFWRV9JTlQxMjhf VCBPRkYpCiAgICAgbGlzdChSRU1PVkVfSVRFTSBfV0VCS0lUX0NPTkZJR19GSUxFX1ZBUklBQkxF UyBIQVZFX0lOVDEyOF9UKQogZW5kaWYgKCkKKworIyBFbmFibGUgdGhlIG5ldyBsYW1iZGEgcHJv Y2Vzc29yIGZvciBiZXR0ZXIgQysrIGNvbmZvcm1hbmNlCitpZiAoTk9UIENPTVBJTEVSX0lTX0NM QU5HX0NMIEFORCBNU1ZDX1ZFUlNJT04gR1JFQVRFUl9FUVVBTCAxOTI1KQorICAgIGFkZF9jb21w aWxlX29wdGlvbnMoL1pjOmxhbWJkYSkKK2VuZGlmICgpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cg Yi9DaGFuZ2VMb2cKaW5kZXggOThmMzA1YTVmNDA0YTExYjk4NDc4ZGY4YjQxZWU5N2MzYWNlNzE0 OC4uNTc2ZDZiZmIzM2ZhMzk1MjZkZDMzOWZlYjNjZmJhY2YyOWZlMTg0OSAxMDA2NDQKLS0tIGEv Q2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA1LTI1ICBG dWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtNU1ZD XSBUaGUgIi9aYzpsYW1iZGEiIHN3aXRjaCBpcyByZWNvbW1lbmRlZCB0byB1c2UgdGhlIG5ldyBs YW1iZGEgcHJvY2Vzc29yLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI2MDcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc01TVkMuY21ha2U6CisgICAgICAgIEFkZCAv WmM6bGFtYmRhIGZvciBWaXN1YWwgU3R1ZGlvIDE2LjUgb3IgbGF0ZXIuCisKIDIwMjEtMDUtMjUg IERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBbUGxheVN0 YXRpb25dIEltcGxlbWVudCBGaWxlU3lzdGVtIHdpdGhvdXQgc3RkOjpmaWxlc3lzdGVtCg== 439085 2021-09-23 13:24:06 -0700 2021-09-28 22:50:58 -0700 Patch bug-226070-20210924052404.patch text/plain 1517 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyOTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc01TVkMuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc01TVkMuY21ha2UKaW5kZXggYmFl NzA3ZmFlYjJhMjYzYTc3MzBhZTY2OTMxYTY0YmJhYTQyMzNkMy4uNWUxZGYxOTc2Mjk3MjY1MWMx NTgxYTQ3ZDdkMjE2Y2FjNjk4YjU3YiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNN U1ZDLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zTVNWQy5jbWFrZQpAQCAtMjA1LDMg KzIwNSw4IEBAIGlmIChDT01QSUxFUl9JU19DTEFOR19DTCkKICAgICBzZXQoSEFWRV9JTlQxMjhf VCBPRkYpCiAgICAgbGlzdChSRU1PVkVfSVRFTSBfV0VCS0lUX0NPTkZJR19GSUxFX1ZBUklBQkxF UyBIQVZFX0lOVDEyOF9UKQogZW5kaWYgKCkKKworIyBFbmFibGUgdGhlIG5ldyBsYW1iZGEgcHJv Y2Vzc29yIGZvciBiZXR0ZXIgQysrIGNvbmZvcm1hbmNlCitpZiAoTk9UIENPTVBJTEVSX0lTX0NM QU5HX0NMIEFORCBNU1ZDX1ZFUlNJT04gR1JFQVRFUl9FUVVBTCAxOTI4KQorICAgIGFkZF9jb21w aWxlX29wdGlvbnMoL1pjOmxhbWJkYSkKK2VuZGlmICgpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cg Yi9DaGFuZ2VMb2cKaW5kZXggY2I4NzUyM2I1MWNkMWE0MmMyODViZTg3YjAzODFjOWUzNjRlODBj NS4uNDA2ZGEyYzkwZDM1ZTI1ZDZmZmU3YzViYmRkODBjZjdhZjUwN2Y3NyAxMDA2NDQKLS0tIGEv Q2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA5LTIzICBG dWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtNU1ZD XSBUaGUgIi9aYzpsYW1iZGEiIHN3aXRjaCBpcyByZWNvbW1lbmRlZCB0byB1c2UgdGhlIG5ldyBs YW1iZGEgcHJvY2Vzc29yLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI2MDcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVmlzdWFsIFN0dWRpbyAxNi41IGFkZGVkIHRoZSAiL1pjOmxhbWJkYSIgc3dpdGNo IGZvciB0aGUgYmV0dGVyCisgICAgICAgIEMrKyBjb25mb3JtYW5jZSwgYnV0IGl0IGhhZCBhIGNv bXBpbGVyIGNyYXNoaW5nIGJ1Zy4gVmlzdWFsIFN0dWRpbworICAgICAgICAxNi45IGZpeGVkIHRo ZSBidWcuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc01TVkMuY21ha2U6IEFkZGVk IC9aYzpsYW1iZGEgZm9yIFZpc3VhbAorICAgICAgICBTdHVkaW8gMTYuOSBvciBsYXRlci4gSSB3 aWxsIHJlbW92ZSB0aGUgTVNWQ19WRVJTSU9OIGNoZWNrIGFmdGVyCisgICAgICAgIEFwcGxlV2lu IGJvdHMgd2lsbCB1cGdyYWRlIE1TVkMuCisKIDIwMjEtMDktMTcgIEFuZ2Vsb3MgT2lrb25vbW9w b3Vsb3MgIDxhbmdlbG9zQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5icmVhayBHQ0NfT0ZGTElO RUFTTV9TT1VSQ0VfTUFQIHdoZW4gTFRPIGlzIGluIHVzZQo= 439568 2021-09-28 22:49:34 -0700 2021-09-28 22:50:46 -0700 Wrong Patch bug-226070-20210929144933.patch text/plain 5621 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj NTBjNDlhMTU2Y2NmNTkyZDFlYjA4NmE3YmRjMmM2YWY0ZGZkMjhhLi4yMzBhNGM4YmUyZDM0YTVl YzdjNTVlMTFkNGFiMzE2MWU2ODM1YzBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMS0wOS0yOCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBQeXRob24gMyBmYWlscyB0byBydW4gcnVuLWJ1aWx0aW5zLWdl bmVyYXRvci10ZXN0cyA6IE1vZHVsZU5vdEZvdW5kRXJyb3I6IE5vIG1vZHVsZSBuYW1lZCAnYnVp bHRpbnNfbW9kZWwnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzA4NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBCYXNlRXhjZXB0aW9uLm1lc3NhZ2UgaGFzIGJlZW4gZGVwcmVjYXRlZCBhcyBvZiBQeXRo b24gMi42LiBVc2UKKyAgICAgICAgc3RyKGUpIGluc3RlYWQuCisKKyAgICAgICAgSW1wbGljaXQg cmVsYXRpdmUgaW1wb3J0cyBoYXZlIGJlZW4gZGVwcmVjYXRlZCBpbiBQeXRob24gMy4KKyAgICAg ICAgQmFzaWNhbGx5LCByZWxhdGl2ZSBpbXBvcnRzIHNob3VsZCBiZSB1c2VkLiBIb3dldmVyLCB0 aGUgc2NyaXB0cworICAgICAgICBpbiB3a2J1aWx0aW5zIGRpcmVjdG9yeSBhcmUgZmxhdHRlbmVk IHdoZW4gdGhleSBhcmUgY29waWVkIHRvCisgICAgICAgIFdlYktpdEJ1aWxkIGRpcmVjdG9yeS4g U28sIHJlbGF0aXZlIGltcG9ydHMgY2FuJ3QgYmUgdXNlZC4KKworICAgICAgICBTbywgYXBwZW5k IHdrYnVpbHRpbnMgZGlyZWN0b3J5IHRvIHN5cy5wYXRoIGFzIGEgd29ya2Fyb3VuZC4KKworICAg ICAgICAqIFNjcmlwdHMvZ2VuZXJhdGUtanMtYnVpbHRpbnMucHk6CisKIDIwMjEtMDktMjggIFNh YW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRG9lc0dDQ2hlY2sgZG9l cyBub3QgdXNlIGVub3VnaCBiaXRzIGZvciBub2RlSW5kZXgKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9TY3JpcHRzL2dlbmVyYXRlLWpzLWJ1aWx0aW5zLnB5IGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL1NjcmlwdHMvZ2VuZXJhdGUtanMtYnVpbHRpbnMucHkKaW5kZXggNTFjNmJl YWQzYjA3MmQwZGVjNGE3NzRhZTI4YTg4YjZkZWJiZWIyMy4uYmM2NzcxMmYzOGQyZTZlNDIwODMw ZjE2NjliOTQwOGRhNzFjMDdlOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL1Nj cmlwdHMvZ2VuZXJhdGUtanMtYnVpbHRpbnMucHkKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L1NjcmlwdHMvZ2VuZXJhdGUtanMtYnVpbHRpbnMucHkKQEAgLTMzLDYgKzMzLDggQEAgaW1wb3J0 IG9wdHBhcnNlCiBpbXBvcnQgb3MKIGltcG9ydCBzeXMKIAorc3lzLnBhdGguYXBwZW5kKG9zLnBh dGguam9pbihvcy5wYXRoLmRpcm5hbWUoX19maWxlX18pLCAnd2tidWlsdGlucycpKQorCiBsb2dn aW5nLmJhc2ljQ29uZmlnKGZvcm1hdD0nJShsZXZlbG5hbWUpczogJShtZXNzYWdlKXMnLCBsZXZl bD1sb2dnaW5nLkVSUk9SKQogbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoJ2dsb2JhbCcpCiAKQEAg LTE3OCw2ICsxODAsNiBAQCBpZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgogICAgICAgICBnZW5l cmF0ZV9iaW5kaW5nc19mb3JfYnVpbHRpbnNfZmlsZXMoYnVpbHRpbnNfZmlsZXM9aW5wdXRfZmls ZXBhdGhzLCAqKm9wdGlvbnMpCiAgICAgZXhjZXB0IFBhcnNlRXhjZXB0aW9uIGFzIGU6CiAgICAg ICAgIGlmIGFyZ19vcHRpb25zLnRlc3Q6Ci0gICAgICAgICAgICBsb2cuZXJyb3IoZS5tZXNzYWdl KQorICAgICAgICAgICAgbG9nLmVycm9yKHN0cihlKSkKICAgICAgICAgZWxzZToKICAgICAgICAg ICAgIHJhaXNlICAjIEZvcmNlIHRoZSBidWlsZCB0byBmYWlsLgpkaWZmIC0tZ2l0IGEvU291cmNl L2NtYWtlL09wdGlvbnNNU1ZDLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNNU1ZDLmNtYWtl CmluZGV4IDVlMWRmMTk3NjI5NzI2NTFjMTU4MWE0N2Q3ZDIxNmNhYzY5OGI1N2IuLjUzOGRhM2Zh YWJmYjJlYzgyY2NmNjkyOGUwNDE2ODdlMzkwNmM5NjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFr ZS9PcHRpb25zTVNWQy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc01TVkMuY21ha2UK QEAgLTIxMCwzICsyMTAsOCBAQCBlbmRpZiAoKQogaWYgKE5PVCBDT01QSUxFUl9JU19DTEFOR19D TCBBTkQgTVNWQ19WRVJTSU9OIEdSRUFURVJfRVFVQUwgMTkyOCkKICAgICBhZGRfY29tcGlsZV9v cHRpb25zKC9aYzpsYW1iZGEpCiBlbmRpZiAoKQorCisjIEVuYWJsZSB0aGUgbmV3IGxhbWJkYSBw cm9jZXNzb3IgZm9yIGJldHRlciBDKysgY29uZm9ybWFuY2UKK2lmIChOT1QgQ09NUElMRVJfSVNf Q0xBTkdfQ0wgQU5EIE1TVkNfVkVSU0lPTiBHUkVBVEVSX0VRVUFMIDE5MjgpCisgICAgYWRkX2Nv bXBpbGVfb3B0aW9ucygvWmM6bGFtYmRhKQorZW5kaWYgKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0No YW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMzQ0MTkzZmEwMGEyNDAyODg1NTVjMTFk NDQwYmVhNzA2ZWFkYWI3Li5iNzVkMjY4MTczNTc3M2NmOGRlOGI4NGM1NTE1NTRiNzI0NDhiMjE4 IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjMgQEAKKzIwMjEtMDktMjggIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlA c29ueS5jb20+CisKKyAgICAgICAgUHl0aG9uIDMgZmFpbHMgdG8gcnVuIHJ1bi1idWlsdGlucy1n ZW5lcmF0b3ItdGVzdHMgOiBNb2R1bGVOb3RGb3VuZEVycm9yOiBObyBtb2R1bGUgbmFtZWQgJ2J1 aWx0aW5zX21vZGVsJworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjMwODcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWZ0ZXIgcjI4MjQyNCAoQnVnIDIyOTg3OSkgc3dpdGNoZWQgdG8gcHl0aG9uMyBmb3Ig cnVubmluZworICAgICAgICBydW4tYnVpbHRpbnMtZ2VuZXJhdG9yLXRlc3RzIG9uIEJ1aWxkYm90 LCBvbmx5IFdpbkNhaXJvIGJ1aWxkYm90CisgICAgICAgIHdhcyBmYWlsaW5nIHJ1bi1idWlsdGlu cy1nZW5lcmF0b3ItdGVzdHMuCisKKyAgICAgICAgcnVuLWJ1aWx0aW5zLWdlbmVyYXRvci10ZXN0 cyB3YXMgaW52b2tpbmcgZ2VuZXJhdGUtanMtYnVpbHRpbnMucHkKKyAgICAgICAgZXhwbGljdGx5 IHdpdGggJ3B5dGhvbicuIFRoaXMgaXMgUHl0aG9uIDIgb24gb3RoZXIgYm90cy4KKworICAgICAg ICBVc2Ugc3lzLmV4ZWN1dGFibGUgaW5zdGVhZCBvZiAncHl0aG9uJyB0byBpbnZva2UKKyAgICAg ICAgZ2VuZXJhdGUtanMtYnVpbHRpbnMucHkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2NvZGVnZW4vbWFpbi5weToKKyAgICAgICAgKEJ1aWx0aW5zR2VuZXJhdG9yVGVzdHMuZ2VuZXJh dGVfZnJvbV9qc19idWlsdGlucyk6CisKIDIwMjEtMDktMjggIEJKIEJ1cmcgIDxiYnVyZ0BhcHBs ZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBBZGQgU1BJIHRvIHNlbGVjdCBhIHRhYiBjcmVhdGVk IGJ5IF9XS0luc3BlY3RvckV4dGVuc2lvbgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb2RlZ2VuL21haW4ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvZGVnZW4vbWFp bi5weQppbmRleCBkNmU3YjZiNmNjMWMxNmUzNGQxMWI1OTM2MTRlMDk3Njc4YTZiZmUwLi5iYTdm YjRmNjBjYTFhY2FlYTFmMTViOTFhMTllZDcyNjZmZjFiNzA0IDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvZGVnZW4vbWFpbi5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2NvZGVnZW4vbWFpbi5weQpAQCAtMjYsNiArMjYsNyBAQAogaW1wb3J0IG9zCiBpbXBvcnQg b3MucGF0aAogaW1wb3J0IHNodXRpbAoraW1wb3J0IHN5cwogaW1wb3J0IHRlbXBmaWxlCiBmcm9t IHdlYmtpdHB5LmNvbW1vbi5jaGVja291dC5zY20uZGV0ZWN0aW9uIGltcG9ydCBkZXRlY3Rfc2Nt X3N5c3RlbQogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmV4ZWN1dGl2ZSBpbXBvcnQgU2Ny aXB0RXJyb3IKQEAgLTM4LDcgKzM5LDcgQEAgY2xhc3MgQnVpbHRpbnNHZW5lcmF0b3JUZXN0czoK ICAgICAgICAgc2VsZi5leGVjdXRpdmUgPSBleGVjdXRpdmUKIAogICAgIGRlZiBnZW5lcmF0ZV9m cm9tX2pzX2J1aWx0aW5zKHNlbGYsIGJ1aWx0aW5zX2ZpbGVzLCBvdXRwdXRfZGlyZWN0b3J5LCBm cmFtZXdvcmtfbmFtZT0iIiwgY29tYmluZWRfb3V0cHV0cz1GYWxzZSwgZ2VuZXJhdGVfd3JhcHBl cnM9RmFsc2UpOgotICAgICAgICBjbWQgPSBbJ3B5dGhvbicsCisgICAgICAgIGNtZCA9IFtzeXMu ZXhlY3V0YWJsZSwKICAgICAgICAgICAgICAgICdKYXZhU2NyaXB0Q29yZS9TY3JpcHRzL2dlbmVy YXRlLWpzLWJ1aWx0aW5zLnB5JywKICAgICAgICAgICAgICAgICctLW91dHB1dC1kaXJlY3Rvcnkn LCBvdXRwdXRfZGlyZWN0b3J5LAogICAgICAgICAgICAgICAgJy0tZm9yY2UnLApkaWZmIC0tZ2l0 IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDg3YzcwMzliNTBiOTYyMGRkN2I0YTUzNTli NTFmYWI3ZDk4NTNmMWQuLjU5YjIyZjdlMzBmNDNjMDE3ODczNzk4MTUxZmQyNzIxOTYwNTQ5Nzcg MTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAor MjAyMS0wOS0yOCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KKwor ICAgICAgICBbTVNWQ10gVGhlICIvWmM6bGFtYmRhIiBzd2l0Y2ggaXMgcmVjb21tZW5kZWQgdG8g dXNlIHRoZSBuZXcgbGFtYmRhIHByb2Nlc3Nvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjA3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFZpc3VhbCBTdHVkaW8gMTYuNSBhZGRlZCB0aGUgIi9aYzps YW1iZGEiIHN3aXRjaCBmb3IgdGhlIGJldHRlcgorICAgICAgICBDKysgY29uZm9ybWFuY2UsIGJ1 dCBpdCBoYWQgYSBjb21waWxlciBjcmFzaGluZyBidWcuIFZpc3VhbCBTdHVkaW8KKyAgICAgICAg MTYuOSBmaXhlZCB0aGUgYnVnLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNNU1ZD LmNtYWtlOiBBZGRlZCAvWmM6bGFtYmRhIGZvciBWaXN1YWwKKyAgICAgICAgU3R1ZGlvIDE2Ljkg b3IgbGF0ZXIuIEkgd2lsbCByZW1vdmUgdGhlIE1TVkNfVkVSU0lPTiBjaGVjayBhZnRlcgorICAg ICAgICBBcHBsZVdpbiBib3RzIHdpbGwgdXBncmFkZSBNU1ZDLgorCiAyMDIxLTA5LTI4ICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtX UEVdIEJ1bXAgbGlic291cDMgdmVyc2lvbiB0byAzLjAuMAo=