<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>223850</bug_id>
          
          <creation_ts>2021-03-28 02:52:32 -0700</creation_ts>
          <short_desc>REGRESSION(r268176): [GStreamer] media/video-orientation-canvas.html fails</short_desc>
          <delta_ts>2021-04-02 01:56:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=95299</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=224064</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Philippe Normand">pnormand</reporter>
          <assigned_to name="Philippe Normand">pnormand</assigned_to>
          <cc>calvaris</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>gustavo</cc>
    
    <cc>jer.noble</cc>
    
    <cc>lmoura</cc>
    
    <cc>menard</cc>
    
    <cc>peng.liu6</cc>
    
    <cc>philipj</cc>
    
    <cc>sergio</cc>
    
    <cc>vjaquez</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1744599</commentid>
    <comment_count>0</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2021-03-28 02:52:32 -0700</bug_when>
    <thetext>--- /app/webkit/WebKitBuild/Release/layout-test-results/media/video-orientation-canvas-expected.txt
+++ /app/webkit/WebKitBuild/Release/layout-test-results/media/video-orientation-canvas-actual.txt
@@ -1,6 +1,6 @@

-EXPECTED (context.getImageData(88, 115, 1, 1).data == [208,0,0,255] with tolerance 5 OK
+EXPECTED (context.getImageData(88, 115, 1, 1).data == [208,0,0,255] with tolerance 5, OBSERVED &apos;[0,0,0,255]&apos; FAIL                                                                                                
 EXPECTED (context.getImageData(237, 88, 1, 1).data == [208,0,0,255] with tolerance 5 OK
-EXPECTED (context.getImageData(200, 237, 1, 1).data == [208,0,0,255] with tolerance 5 OK
+EXPECTED (context.getImageData(200, 237, 1, 1).data == [208,0,0,255] with tolerance 5, OBSERVED &apos;[0,0,0,255]&apos; FAIL                                                                                               
 END OF TEST</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1744609</commentid>
    <comment_count>1</comment_count>
      <attachid>424493</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2021-03-28 05:28:28 -0700</bug_when>
    <thetext>Created attachment 424493
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1745392</commentid>
    <comment_count>2</comment_count>
      <attachid>424493</attachid>
    <who name="Peng Liu">peng.liu6</who>
    <bug_when>2021-03-30 16:13:30 -0700</bug_when>
    <thetext>Comment on attachment 424493
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424493&amp;action=review

&gt; Source/WebCore/ChangeLog:9
&gt; +        handling of the image rotation tags is now performed only the pipeline is not able to do it

Nit. s/only/only when/g.

&gt; Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2775
&gt; +            m_shouldHandleOrientationTags = true;

Do we need to have a branch to set `m_shouldHandleOrientationTags` to false?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1745547</commentid>
    <comment_count>3</comment_count>
      <attachid>424493</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2021-03-31 01:15:38 -0700</bug_when>
    <thetext>Comment on attachment 424493
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424493&amp;action=review

&gt;&gt; Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2775
&gt;&gt; +            m_shouldHandleOrientationTags = true;
&gt; 
&gt; Do we need to have a branch to set `m_shouldHandleOrientationTags` to false?

No, the variable is initialized to false already and only one pipeline is created per MediaPlayerPrivate.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1746235</commentid>
    <comment_count>4</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2021-04-01 13:47:23 -0700</bug_when>
    <thetext>*** Bug 224064 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1746238</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2021-04-01 13:48:34 -0700</bug_when>
    <thetext>On r275376 I marked this test as failing, please remove the failed expectation once this lands.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1746240</commentid>
    <comment_count>6</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2021-04-01 13:51:46 -0700</bug_when>
    <thetext>BTW.. I think the regression was caused by r274076 and not by r268176 (as the title implies)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1746255</commentid>
    <comment_count>7</comment_count>
    <who name="Peng Liu">peng.liu6</who>
    <bug_when>2021-04-01 13:58:50 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #6)
&gt; BTW.. I think the regression was caused by r274076 and not by r268176 (as
&gt; the title implies)

Oh? But r274076 is a change to Cocoa ports only.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1746260</commentid>
    <comment_count>8</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2021-04-01 14:16:40 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #6)
&gt; BTW.. I think the regression was caused by r274076 and not by r268176 (as
&gt; the title implies)

I found r268176 with results.webkit.org, though I admit I haven&apos;t tried a local revert to verify it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1746261</commentid>
    <comment_count>9</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2021-04-01 14:17:48 -0700</bug_when>
    <thetext>(In reply to Peng Liu from comment #7)
&gt; (In reply to Carlos Alberto Lopez Perez from comment #6)
&gt; &gt; BTW.. I think the regression was caused by r274076 and not by r268176 (as
&gt; &gt; the title implies)
&gt; 
&gt; Oh? But r274076 is a change to Cocoa ports only.

Ups.. yes.

You&apos;re right.

I got confused because r274076 showed as the first revision making this test fail on the bot result history.
But that was just because r274076 removed this test as expected failure from LayoutTests/platform/wk2/TestExpectations

So, ignore my comment. Sorry for the noise</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1746263</commentid>
    <comment_count>10</comment_count>
      <attachid>424493</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2021-04-01 14:23:06 -0700</bug_when>
    <thetext>Comment on attachment 424493
Patch

Patch looks fine to me.
I have tested it works and fixes the test.
Please remove the expected failure from GTK TestExpectations file when landing it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1746422</commentid>
    <comment_count>11</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2021-04-02 01:55:45 -0700</bug_when>
    <thetext>Committed r275412 (236075@main): &lt;https://commits.webkit.org/236075@main&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1746423</commentid>
    <comment_count>12</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-04-02 01:56:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/76142996&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>424493</attachid>
            <date>2021-03-28 05:28:28 -0700</date>
            <delta_ts>2021-04-01 14:23:06 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-223850-20210328052826.patch</filename>
            <type>text/plain</type>
            <size>7328</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjkxODQ3MDkyZmVmMzFm
ZWYxZmZjNDY1ZmVjNmMzMTQyMmVhOGY1MS4uNDA1MWUwYWZjMWUwYTU2NjliNDFhNDQ0N2FhMjQx
MTdlNmM1YmQ0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTAzLTI4ICBQaGls
aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9O
KHIyNjgxNzYpOiBbR1N0cmVhbWVyXSBtZWRpYS92aWRlby1vcmllbnRhdGlvbi1jYW52YXMuaHRt
bCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MjIzODUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
VGhlIEdMIHBpcGVsaW5lIHVzZWQgYnkgdGhlIHBsYXllciBpcyBub3cgYWJsZSB0byBoYW5kbGUg
aW1hZ2Ugcm90YXRpb24gdGFncyBpdHNlbGYuIE1hbnVhbAorICAgICAgICBoYW5kbGluZyBvZiB0
aGUgaW1hZ2Ugcm90YXRpb24gdGFncyBpcyBub3cgcGVyZm9ybWVkIG9ubHkgdGhlIHBpcGVsaW5l
IGlzIG5vdCBhYmxlIHRvIGRvIGl0CisgICAgICAgIGJ5IGl0c2VsZi4KKworICAgICAgICAqIHBs
YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HTFZpZGVvU2lua0dTdHJlYW1lci5jcHA6CisgICAg
ICAgICh3ZWJLaXRHTFZpZGVvU2lua0NvbnN0cnVjdGVkKToKKyAgICAgICAgKiBwbGF0Zm9ybS9n
cmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6Y3JlYXRlR1NUUGxheUJp
bik6CisgICAgICAgIChXZWJDb3JlOjpnZXRWaWRlb09yaWVudGF0aW9uKToKKyAgICAgICAgKFdl
YkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6dXBkYXRlVmlkZW9TaXplQW5kT3Jp
ZW50YXRpb25Gcm9tQ2Fwcyk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy
L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oOgorCiAyMDIxLTAzLTI3ICBTaW1vbiBGcmFz
ZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IERpc3BsYXlSZWZy
ZXNoTW9uaXRvciB0byBiZSBtb3JlIGxvbmctbGl2ZWQgb2JqZWN0cwpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dMVmlkZW9TaW5rR1N0cmVh
bWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HTFZp
ZGVvU2lua0dTdHJlYW1lci5jcHAKaW5kZXggMTJjNjM5YmE4ZTE3YTdjYzc2MzQ3ZTRhMDcxYTU3
OTcxNDc3MDYwYy4uYTdjZDk3MzFmZTc0YmM5N2QwZjY3MTkzYjM3MmI4MjExMmY5ZDY2OCAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dMVmlk
ZW9TaW5rR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy9nc3RyZWFtZXIvR0xWaWRlb1NpbmtHU3RyZWFtZXIuY3BwCkBAIC04MSw5ICs4MSwxMyBAQCBz
dGF0aWMgdm9pZCB3ZWJLaXRHTFZpZGVvU2lua0NvbnN0cnVjdGVkKEdPYmplY3QqIG9iamVjdCkK
IAogICAgIEdzdEVsZW1lbnQqIHVwbG9hZCA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgiZ2x1
cGxvYWQiLCBudWxscHRyKTsKICAgICBHc3RFbGVtZW50KiBjb2xvcmNvbnZlcnQgPSBnc3RfZWxl
bWVudF9mYWN0b3J5X21ha2UoImdsY29sb3Jjb252ZXJ0IiwgbnVsbHB0cik7CisgICAgR3N0RWxl
bWVudCogdmlkZW9GbGlwID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJnbHZpZGVvZmxpcCIs
IG51bGxwdHIpOworICAgIGdzdF91dGlsX3NldF9vYmplY3RfYXJnKEdfT0JKRUNUKHZpZGVvRmxp
cCksICJtZXRob2QiLCAiYXV0b21hdGljIik7CisKICAgICBBU1NFUlQodXBsb2FkKTsKICAgICBB
U1NFUlQoY29sb3Jjb252ZXJ0KTsKLSAgICBnc3RfYmluX2FkZF9tYW55KEdTVF9CSU5fQ0FTVChz
aW5rKSwgdXBsb2FkLCBjb2xvcmNvbnZlcnQsIHNpbmstPnByaXYtPmFwcFNpbmsuZ2V0KCksIG51
bGxwdHIpOworICAgIEFTU0VSVCh2aWRlb0ZsaXApOworICAgIGdzdF9iaW5fYWRkX21hbnkoR1NU
X0JJTl9DQVNUKHNpbmspLCB1cGxvYWQsIGNvbG9yY29udmVydCwgdmlkZW9GbGlwLCBzaW5rLT5w
cml2LT5hcHBTaW5rLmdldCgpLCBudWxscHRyKTsKIAogICAgIC8vIFdvcmthcm91bmQgdW50aWwg
d2UgY2FuIGRlcGVuZCBvbiBHU3RyZWFtZXIgMS4xNi4yLgogICAgIC8vIGh0dHBzOi8vZ2l0bGFi
LmZyZWVkZXNrdG9wLm9yZy9nc3RyZWFtZXIvZ3N0LXBsdWdpbnMtYmFzZS9jb21taXQvOGQzMmRl
MDkwNTU0Y2YyOWZlMzU5ZjgzYWE0NjAwMGJhNjU4YTY5MwpAQCAtMTA5LDcgKzExMyw3IEBAIHN0
YXRpYyB2b2lkIHdlYktpdEdMVmlkZW9TaW5rQ29uc3RydWN0ZWQoR09iamVjdCogb2JqZWN0KQog
CiAgICAgaWYgKGlteFZpZGVvQ29udmVydEcyRCkKICAgICAgICAgZ3N0X2VsZW1lbnRfbGluayhp
bXhWaWRlb0NvbnZlcnRHMkQsIHVwbG9hZCk7Ci0gICAgZ3N0X2VsZW1lbnRfbGlua19tYW55KHVw
bG9hZCwgY29sb3Jjb252ZXJ0LCBzaW5rLT5wcml2LT5hcHBTaW5rLmdldCgpLCBudWxscHRyKTsK
KyAgICBnc3RfZWxlbWVudF9saW5rX21hbnkodXBsb2FkLCBjb2xvcmNvbnZlcnQsIHZpZGVvRmxp
cCwgc2luay0+cHJpdi0+YXBwU2luay5nZXQoKSwgbnVsbHB0cik7CiAKICAgICBHc3RFbGVtZW50
KiBzaW5rRWxlbWVudCA9CiAgICAgICAgIFsmXSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y
ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy
LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs
YXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDJjZGM5NDZkY2E4MmRmNTYyOTRkYTM1OTRi
ZDk2OTYyZDFkMjlmOTYuLmM2OTEyODQ2NWU4ZmRlMzA2MWNkYTVkNDQ5ODQ1ODg1Mzk1ZGMzZWEg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N
ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBA
IC0yNzY5LDEwICsyNzY5LDEwIEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpj
cmVhdGVHU1RQbGF5QmluKGNvbnN0IFVSTCYgdXJsLCBjb25zdCBTdHJpbmcmCiAgICAgICAgIC8v
IHRoZSBpbWFnZS1vcmllbnRhdGlvbiB0YWcuCiAgICAgICAgIEdzdEVsZW1lbnQqIHZpZGVvRmxp
cCA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgidmlkZW9mbGlwIiwgbnVsbHB0cik7CiAgICAg
ICAgIGlmICh2aWRlb0ZsaXApIHsKLSAgICAgICAgICAgIGdfb2JqZWN0X3NldCh2aWRlb0ZsaXAs
ICJtZXRob2QiLCA4LCBudWxscHRyKTsKKyAgICAgICAgICAgIGdzdF91dGlsX3NldF9vYmplY3Rf
YXJnKEdfT0JKRUNUKHZpZGVvRmxpcCksICJtZXRob2QiLCAiYXV0b21hdGljIik7CiAgICAgICAg
ICAgICBnX29iamVjdF9zZXQobV9waXBlbGluZS5nZXQoKSwgInZpZGVvLWZpbHRlciIsIHZpZGVv
RmxpcCwgbnVsbHB0cik7CiAgICAgICAgIH0gZWxzZQotICAgICAgICAgICAgR1NUX1dBUk5JTkco
IlRoZSB2aWRlb2ZsaXAgZWxlbWVudCBpcyBtaXNzaW5nLCB2aWRlbyByb3RhdGlvbiBzdXBwb3J0
IGlzIG5vdyBkaXNhYmxlZC4gUGxlYXNlIGNoZWNrIHlvdXIgZ3N0LXBsdWdpbnMtZ29vZCBpbnN0
YWxsYXRpb24uIik7CisgICAgICAgICAgICBtX3Nob3VsZEhhbmRsZU9yaWVudGF0aW9uVGFncyA9
IHRydWU7CiAgICAgfQogCiAgICAgR1JlZlB0cjxHc3RQYWQ+IHZpZGVvU2lua1BhZCA9IGFkb3B0
R1JlZihnc3RfZWxlbWVudF9nZXRfc3RhdGljX3BhZChtX3ZpZGVvU2luay5nZXQoKSwgInNpbmsi
KSk7CkBAIC0yOTQ2LDcgKzI5NDYsNyBAQCBzdGF0aWMgSW1hZ2VPcmllbnRhdGlvbiBnZXRWaWRl
b09yaWVudGF0aW9uKEdzdEVsZW1lbnQqIHNpbmspCiAgICAgR1JlZlB0cjxHc3RFdmVudD4gdGFn
c0V2ZW50ID0gYWRvcHRHUmVmKGdzdF9wYWRfZ2V0X3N0aWNreV9ldmVudChwYWQuZ2V0KCksIEdT
VF9FVkVOVF9UQUcsIDApKTsKICAgICBpZiAoIXRhZ3NFdmVudCkgewogICAgICAgICBHU1RfREVC
VUdfT0JKRUNUKHBhZC5nZXQoKSwgIk5vIHN0aWNreSB0YWcgZXZlbnQsIGFwcGx5aW5nIG5vIHJv
dGF0aW9uLiIpOwotICAgICAgICByZXR1cm4gSW1hZ2VPcmllbnRhdGlvbjo6T3JpZ2luVG9wTGVm
dDsKKyAgICAgICAgcmV0dXJuIEltYWdlT3JpZW50YXRpb246Ok5vbmU7CiAgICAgfQogCiAgICAg
R3N0VGFnTGlzdCogdGFnTGlzdDsKQEAgLTI5NTUsMTggKzI5NTUsMjcgQEAgc3RhdGljIEltYWdl
T3JpZW50YXRpb24gZ2V0VmlkZW9PcmllbnRhdGlvbihHc3RFbGVtZW50KiBzaW5rKQogICAgIEdV
bmlxdWVPdXRQdHI8Z2NoYXI+IHRhZzsKICAgICBpZiAoIWdzdF90YWdfbGlzdF9nZXRfc3RyaW5n
KHRhZ0xpc3QsIEdTVF9UQUdfSU1BR0VfT1JJRU5UQVRJT04sICZ0YWcub3V0UHRyKCkpKSB7CiAg
ICAgICAgIEdTVF9ERUJVR19PQkpFQ1QocGFkLmdldCgpLCAiTm8gaW1hZ2Vfb3JpZW50YXRpb24g
dGFnLCBhcHBseWluZyBubyByb3RhdGlvbi4iKTsKLSAgICAgICAgcmV0dXJuIEltYWdlT3JpZW50
YXRpb246Ok9yaWdpblRvcExlZnQ7CisgICAgICAgIHJldHVybiBJbWFnZU9yaWVudGF0aW9uOjpO
b25lOwogICAgIH0KIAogICAgIEdTVF9ERUJVR19PQkpFQ1QocGFkLmdldCgpLCAiRm91bmQgaW1h
Z2Vfb3JpZW50YXRpb24gdGFnOiAlcyIsIHRhZy5nZXQoKSk7Ci0gICAgaWYgKCFnX3N0cmNtcDAo
dGFnLmdldCgpLCAicm90YXRlLTkwIikpCi0gICAgICAgIHJldHVybiBJbWFnZU9yaWVudGF0aW9u
OjpPcmlnaW5SaWdodFRvcDsKKyAgICBpZiAoIWdfc3RyY21wMCh0YWcuZ2V0KCksICJmbGlwLXJv
dGF0ZS0wIikpCisgICAgICAgIHJldHVybiBJbWFnZU9yaWVudGF0aW9uOjpPcmlnaW5Ub3BSaWdo
dDsKICAgICBpZiAoIWdfc3RyY21wMCh0YWcuZ2V0KCksICJyb3RhdGUtMTgwIikpCiAgICAgICAg
IHJldHVybiBJbWFnZU9yaWVudGF0aW9uOjpPcmlnaW5Cb3R0b21SaWdodDsKKyAgICBpZiAoIWdf
c3RyY21wMCh0YWcuZ2V0KCksICJmbGlwLXJvdGF0ZS0xODAiKSkKKyAgICAgICAgcmV0dXJuIElt
YWdlT3JpZW50YXRpb246Ok9yaWdpbkJvdHRvbUxlZnQ7CisgICAgaWYgKCFnX3N0cmNtcDAodGFn
LmdldCgpLCAiZmxpcC1yb3RhdGUtMjcwIikpCisgICAgICAgIHJldHVybiBJbWFnZU9yaWVudGF0
aW9uOjpPcmlnaW5MZWZ0VG9wOworICAgIGlmICghZ19zdHJjbXAwKHRhZy5nZXQoKSwgInJvdGF0
ZS05MCIpKQorICAgICAgICByZXR1cm4gSW1hZ2VPcmllbnRhdGlvbjo6T3JpZ2luUmlnaHRUb3A7
CisgICAgaWYgKCFnX3N0cmNtcDAodGFnLmdldCgpLCAiZmxpcC1yb3RhdGUtOTAiKSkKKyAgICAg
ICAgcmV0dXJuIEltYWdlT3JpZW50YXRpb246Ok9yaWdpblJpZ2h0Qm90dG9tOwogICAgIGlmICgh
Z19zdHJjbXAwKHRhZy5nZXQoKSwgInJvdGF0ZS0yNzAiKSkKICAgICAgICAgcmV0dXJuIEltYWdl
T3JpZW50YXRpb246Ok9yaWdpbkxlZnRCb3R0b207CisKICAgICAvLyBEZWZhdWx0IHJvdGF0aW9u
LgotICAgIHJldHVybiBJbWFnZU9yaWVudGF0aW9uOjpPcmlnaW5Ub3BMZWZ0OworICAgIHJldHVy
biBJbWFnZU9yaWVudGF0aW9uOjpOb25lOwogfQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdT
dHJlYW1lcjo6dXBkYXRlVmlkZW9TaXplQW5kT3JpZW50YXRpb25Gcm9tQ2Fwcyhjb25zdCBHc3RD
YXBzKiBjYXBzKQpAQCAtMjk4Niw3ICsyOTk1LDggQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVH
U3RyZWFtZXI6OnVwZGF0ZVZpZGVvU2l6ZUFuZE9yaWVudGF0aW9uRnJvbUNhcHMoY29uc3QgR3MK
ICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIHNldFZpZGVvU291cmNlT3JpZW50YXRpb24o
Z2V0VmlkZW9PcmllbnRhdGlvbihtX3ZpZGVvU2luay5nZXQoKSkpOworICAgIGlmIChtX3Nob3Vs
ZEhhbmRsZU9yaWVudGF0aW9uVGFncykKKyAgICAgICAgc2V0VmlkZW9Tb3VyY2VPcmllbnRhdGlv
bihnZXRWaWRlb09yaWVudGF0aW9uKG1fdmlkZW9TaW5rLmdldCgpKSk7CiAKICNpZiBVU0UoVEVY
VFVSRV9NQVBQRVJfR0wpCiAgICAgLy8gV2hlbiB1c2luZyBhY2NlbGVyYXRlZCBjb21wb3NpdGlu
ZywgaWYgdGhlIHZpZGVvIGlzIHRhZ2dlZCBhcyByb3RhdGVkIDkwIG9yIDI3MCBkZWdyZWVzLCBz
d2FwIHdpZHRoIGFuZCBoZWlnaHQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmggYi9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRl
R1N0cmVhbWVyLmgKaW5kZXggM2VjNzRlNjExMDY5ZDViODA1YWMwMzNlZmRlMDFmNThhZjY1NWRj
MS4uNjM5YTg3YmE1MzI4Zjc3OTExODY4MWM0OTg5OTgxZDc4NjI5ZGZiNiAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp
dmF0ZUdTdHJlYW1lci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz
dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaApAQCAtNTMwLDYgKzUzMCw5IEBA
IHByaXZhdGU6CiAgICAgdWludDY0X3QgbV90b3RhbFZpZGVvRnJhbWVzIHsgMCB9OwogICAgIHVp
bnQ2NF90IG1fZHJvcHBlZFZpZGVvRnJhbWVzIHsgMCB9OwogCisgICAgLy8gVGhpcyBpcyBzZXQg
dG8gdHJ1ZSBpZiBubyB2aWRlb2ZsaXAgZWxlbWVudCBoYXMgYmVlbiBhZGRlZCB0byB0aGUgcGlw
ZWxpbmUuCisgICAgYm9vbCBtX3Nob3VsZEhhbmRsZU9yaWVudGF0aW9uVGFncyB7IGZhbHNlIH07
CisKIHByaXZhdGU6CiAjaWYgVVNFKFdQRV9WSURFT19QTEFORV9ESVNQTEFZX0RNQUJVRikKICAg
ICBHVW5pcXVlUHRyPHN0cnVjdCB3cGVfdmlkZW9fcGxhbmVfZGlzcGxheV9kbWFidWZfc291cmNl
PiBtX3dwZVZpZGVvUGxhbmVEaXNwbGF5RG1hQnVmOwo=
</data>
<flag name="review"
          id="444187"
          type_id="1"
          status="+"
          setter="clopez"
    />
          </attachment>
      

    </bug>

</bugzilla>