<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>223315</bug_id>
          
          <creation_ts>2021-03-16 23:33:59 -0700</creation_ts>
          <short_desc>webgl/1.0.x/conformance/glsl/bugs/character-set.html fails</short_desc>
          <delta_ts>2021-08-11 11:01:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>228951</dependson>
          <blocked>222812</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kimmo Kinnunen">kkinnunen</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>dino</cc>
    
    <cc>kbr</cc>
    
    <cc>kkinnunen</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1740403</commentid>
    <comment_count>0</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2021-03-16 23:33:59 -0700</bug_when>
    <thetext>webgl/1.0.4/conformance/glsl/bugs/character-set.html fails</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1740535</commentid>
    <comment_count>1</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2021-03-17 01:23:09 -0700</bug_when>
    <thetext>https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/bugs/character-set.html?webglVersion=1&amp;quiet=0&amp;quick=1

This test checks character set validation for glsl.

On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.


Canvas.getContext
PASS context exists

Checking shader character set validation and compilation
test fragment shader
FAIL getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string &apos;$&apos; in identifier until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;$&apos; in comment until compilation.
test fragment shader
FAIL getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string &apos;$&apos; in ifdef-out until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;$&apos; in ifdef-out #preproc until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;$&apos; in #preproc until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;$&apos; in comment after #define until compilation.
test fragment shader
FAIL getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string &apos;&quot;&apos; in identifier until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;&quot;&apos; in comment until compilation.
test fragment shader
FAIL getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string &apos;&quot;&apos; in ifdef-out until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;&quot;&apos; in ifdef-out #preproc until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;&quot;&apos; in #preproc until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;&quot;&apos; in comment after #define until compilation.
test fragment shader
FAIL getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string &apos;一些注释&apos; in identifier until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;一些注释&apos; in comment until compilation.
test fragment shader
FAIL getError expected: NO_ERROR. Was INVALID_VALUE : shaderSource allows Out-of-charset string &apos;一些注释&apos; in ifdef-out until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;一些注释&apos; in ifdef-out #preproc until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;一些注释&apos; in #preproc until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;一些注释&apos; in comment after #define until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in identifier until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in comment until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in ifdef-out until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in ifdef-out #preproc until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in #preproc until compilation.
test fragment shader
PASS getError was expected value: NO_ERROR : shaderSource allows Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in comment after #define until compilation.

test: Out-of-charset string &apos;$&apos; in identifier MUST NOT compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
PASS Out-of-charset string &apos;$&apos; in identifier MUST NOT compile.

test: Out-of-charset string &apos;$&apos; in comment MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;$&apos; in comment MUST compile.

test: Out-of-charset string &apos;$&apos; in ifdef-out MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
FAIL [unexpected fragment shader compile status] (expected: true) Out-of-charset string &apos;$&apos; in ifdef-out MUST compile.
test fragment shader info log

test: Out-of-charset string &apos;$&apos; in ifdef-out #preproc MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;$&apos; in ifdef-out #preproc MUST compile.

test: Out-of-charset string &apos;$&apos; in #preproc MUST NOT compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
PASS Out-of-charset string &apos;$&apos; in #preproc MUST NOT compile.

test: Out-of-charset string &apos;$&apos; in comment after #define MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;$&apos; in comment after #define MUST compile.

test: Out-of-charset string &apos;&quot;&apos; in identifier MUST NOT compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
PASS Out-of-charset string &apos;&quot;&apos; in identifier MUST NOT compile.

test: Out-of-charset string &apos;&quot;&apos; in comment MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;&quot;&apos; in comment MUST compile.

test: Out-of-charset string &apos;&quot;&apos; in ifdef-out MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
FAIL [unexpected fragment shader compile status] (expected: true) Out-of-charset string &apos;&quot;&apos; in ifdef-out MUST compile.
test fragment shader info log

test: Out-of-charset string &apos;&quot;&apos; in ifdef-out #preproc MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;&quot;&apos; in ifdef-out #preproc MUST compile.

test: Out-of-charset string &apos;&quot;&apos; in #preproc MUST NOT compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
PASS Out-of-charset string &apos;&quot;&apos; in #preproc MUST NOT compile.

test: Out-of-charset string &apos;&quot;&apos; in comment after #define MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;&quot;&apos; in comment after #define MUST compile.

test: Out-of-charset string &apos;一些注释&apos; in identifier MUST NOT compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
PASS Out-of-charset string &apos;一些注释&apos; in identifier MUST NOT compile.

test: Out-of-charset string &apos;一些注释&apos; in comment MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;一些注释&apos; in comment MUST compile.

test: Out-of-charset string &apos;一些注释&apos; in ifdef-out MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
FAIL [unexpected fragment shader compile status] (expected: true) Out-of-charset string &apos;一些注释&apos; in ifdef-out MUST compile.
test fragment shader info log

test: Out-of-charset string &apos;一些注释&apos; in ifdef-out #preproc MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;一些注释&apos; in ifdef-out #preproc MUST compile.

test: Out-of-charset string &apos;一些注释&apos; in #preproc MUST NOT compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
PASS Out-of-charset string &apos;一些注释&apos; in #preproc MUST NOT compile.

test: Out-of-charset string &apos;一些注释&apos; in comment after #define MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;一些注释&apos; in comment after #define MUST compile.

test: Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in identifier MUST NOT compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
PASS Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in identifier MUST NOT compile.

test: Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in comment MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in comment MUST compile.

test: Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in ifdef-out MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in ifdef-out MUST compile.

test: Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in ifdef-out #preproc MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in ifdef-out #preproc MUST compile.

test: Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in #preproc MUST NOT compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
PASS Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in #preproc MUST NOT compile.

test: Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in comment after #define MUST compile.
default vertex shader
default vertex shader translated for driver
test fragment shader
test fragment shader translated for driver
PASS Out-of-charset string &apos;#line 42 &quot;foo.glsl&quot;&apos; in comment after #define MUST compile.

PASS successfullyParsed is true

TEST COMPLETE
PASS successfullyParsed is true

TEST COMPLETE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1740549</commentid>
    <comment_count>2</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2021-03-17 01:36:53 -0700</bug_when>
    <thetext>*** Bug 223332 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1740598</commentid>
    <comment_count>3</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2021-03-17 01:45:53 -0700</bug_when>
    <thetext>At least macOS 11.3, iMacPro1,1, Radeon Pro Vega 56</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1743163</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-03-23 23:34:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/75772532&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1783559</commentid>
    <comment_count>5</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2021-08-11 11:01:54 -0700</bug_when>
    <thetext>Fixed by cherry-pick in bug 228951</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>