<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>223096</bug_id>
          
          <creation_ts>2021-03-11 15:43:33 -0800</creation_ts>
          <short_desc>[GPU Process] Encoding buffer for DisplayList items should be aligned to 8 bytes</short_desc>
          <delta_ts>2021-03-11 21:57:25 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Canvas</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>222835</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Said Abou-Hallawa">sabouhallawa</reporter>
          <assigned_to name="Said Abou-Hallawa">sabouhallawa</assigned_to>
          <cc>dino</cc>
    
    <cc>ggaren</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1738669</commentid>
    <comment_count>0</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-03-11 15:43:33 -0800</bug_when>
    <thetext>ItemBuffer::append() allocates a static buffer whose size = sizeof(DisplayList::Item) + uint64_t for the DisplayList::ItemType. But this static buffer is of type uint8_t. So this array should be aligned to the alignment of a single uint8_t which is 1.

The expectation is to have this buffer aligned to 8 bytes so all each member in the encoded DisplayList::Item can be aligned to its alignment requirement.

This was caught on Apple Silicon when trying to enable GPU rendering for 2D canvas for layout tests. See https://build.webkit.org/#/builders/103/builds/88. But the same assertion fires if the same page is just opened in mini browser while GPU rendering for 2D canvas is enabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738674</commentid>
    <comment_count>1</comment_count>
      <attachid>422983</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-03-11 15:49:31 -0800</bug_when>
    <thetext>Created attachment 422983
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738688</commentid>
    <comment_count>2</comment_count>
      <attachid>422983</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2021-03-11 16:01:41 -0800</bug_when>
    <thetext>Comment on attachment 422983
Patch

I think modern C++ has a nicer explicit feature to just say the alignment you want. alignas, maybe?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738695</commentid>
    <comment_count>3</comment_count>
      <attachid>422987</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-03-11 16:14:17 -0800</bug_when>
    <thetext>Created attachment 422987
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738723</commentid>
    <comment_count>4</comment_count>
      <attachid>422998</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-03-11 17:14:19 -0800</bug_when>
    <thetext>Created attachment 422998
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738729</commentid>
    <comment_count>5</comment_count>
      <attachid>423002</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-03-11 17:55:22 -0800</bug_when>
    <thetext>Created attachment 423002
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738735</commentid>
    <comment_count>6</comment_count>
      <attachid>423004</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-03-11 18:57:35 -0800</bug_when>
    <thetext>Created attachment 423004
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738748</commentid>
    <comment_count>7</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-03-11 20:19:05 -0800</bug_when>
    <thetext>commit-queue failed to commit attachment 423004 to WebKit repository. To retry, please set cq+ flag again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738762</commentid>
    <comment_count>8</comment_count>
      <attachid>423012</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-03-11 20:59:22 -0800</bug_when>
    <thetext>Created attachment 423012
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738776</commentid>
    <comment_count>9</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-03-11 21:56:59 -0800</bug_when>
    <thetext>Committed r274326: &lt;https://commits.webkit.org/r274326&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423012.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738777</commentid>
    <comment_count>10</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-03-11 21:57:25 -0800</bug_when>
    <thetext>&lt;rdar://problem/75348461&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>422983</attachid>
            <date>2021-03-11 15:49:31 -0800</date>
            <delta_ts>2021-03-11 16:14:15 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-223096-20210311154930.patch</filename>
            <type>text/plain</type>
            <size>2035</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ5NjUzODU2NGZjMDIz
NTUyOGVlNDFjNDk2MWEyYWZkOWI4ZDlhOC4uYjlmZmIwNDEwMDYyMjMyNmVjMTY5MWI2ZjRiYzQ0
ZjhlMDUzMjQxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTExICBTYWlk
IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g
RW5jb2RpbmcgYnVmZmVyIGZvciBEaXNwbGF5TGlzdCBpdGVtcyBzaG91bGQgYmUgYWxpZ25lZCB0
byA4IGJ5dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMjMwOTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBFbnN1cmUgdGhlIHN0YXRpYyBhcnJheSBpbiBJdGVtQnVmZmVyOjphcHBlbmQoKSBpcyBhbGln
bmVkIHRvIDggYnl0ZXMuIAorICAgICAgICBTbyBlYWNoIG1lbWJlciBpbiB0aGUgZW5jb2RlZCBE
aXNwbGF5TGlzdDo6SXRlbSBjYW4gYmUgYWxpZ25lZCB0byBpdHMKKyAgICAgICAgYWxpZ25tZW50
IHJlcXVpcmVtZW50CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMv
RGlzcGxheUxpc3RJdGVtQnVmZmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5TGlzdDo6
SXRlbUJ1ZmZlcjo6YXBwZW5kKToKKwogMjAyMS0wMy0wOSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBh
cHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBNYWtlIFdlYktpdCBBUEkgT2JqZWN0aXZlLUMg
b2JqZWN0cyBzYWZlIHRvIHJlbGVhc2Ugb24gbm9uLW1haW4gdGhyZWFkcwpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0
SXRlbUJ1ZmZlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxp
c3RzL0Rpc3BsYXlMaXN0SXRlbUJ1ZmZlci5oCmluZGV4IDg5Zjc0ZmZiNDA2ZTdlODZiYWJiOTRi
NzQ1NzdkYzZhODIyMTAxNTguLjZhNGUwNjRhOGUzMjNkYjczYWY0Mzg4NWE5NmMzZmVmMjFiZjVk
YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXls
aXN0cy9EaXNwbGF5TGlzdEl0ZW1CdWZmZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RJdGVtQnVmZmVyLmgKQEAgLTE1Miw3
ICsxNTIsOCBAQCBwdWJsaWM6CiAgICAgICAgIHN0YXRpY19hc3NlcnQoc3RkOjppc190cml2aWFs
bHlfZGVzdHJ1Y3RpYmxlPFQ+Ojp2YWx1ZSB8fCAhVDo6aXNJbmxpbmVJdGVtKTsKIAogICAgICAg
ICBpZiAoIVQ6OmlzSW5saW5lSXRlbSAmJiBtX3dyaXRpbmdDbGllbnQpIHsKLSAgICAgICAgICAg
IHN0YXRpYyB1aW50OF90IHRlbXBvcmFyeUl0ZW1CdWZmZXJbc2l6ZW9mKHVpbnQ2NF90KSArIHNp
emVvZihUKV07CisgICAgICAgICAgICBzdGF0aWMgdWludDY0X3QgYWxpZ25lZEl0ZW1CdWZmZXJb
KHNpemVvZih1aW50NjRfdCkgKyBzaXplb2YoVCkgKyBzaXplb2YodWludDY0X3QpIC0gMSkgLyBz
aXplb2YodWludDY0X3QpXTsKKyAgICAgICAgICAgIHN0YXRpYyB1aW50OF90KiB0ZW1wb3JhcnlJ
dGVtQnVmZmVyID0gcmVpbnRlcnByZXRfY2FzdDx1aW50OF90Kj4oYWxpZ25lZEl0ZW1CdWZmZXIp
OwogICAgICAgICAgICAgdGVtcG9yYXJ5SXRlbUJ1ZmZlclswXSA9IHN0YXRpY19jYXN0PHVpbnQ4
X3Q+KFQ6Oml0ZW1UeXBlKTsKICAgICAgICAgICAgIG5ldyAodGVtcG9yYXJ5SXRlbUJ1ZmZlciAr
IHNpemVvZih1aW50NjRfdCkpIFQoc3RkOjpmb3J3YXJkPEFyZ3M+KGFyZ3MpLi4uKTsKICAgICAg
ICAgICAgIGFwcGVuZCh7IHRlbXBvcmFyeUl0ZW1CdWZmZXIgfSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>422987</attachid>
            <date>2021-03-11 16:14:17 -0800</date>
            <delta_ts>2021-03-11 18:18:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-223096-20210311161416.patch</filename>
            <type>text/plain</type>
            <size>1922</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ5NjUzODU2NGZjMDIz
NTUyOGVlNDFjNDk2MWEyYWZkOWI4ZDlhOC4uYjlmZmIwNDEwMDYyMjMyNmVjMTY5MWI2ZjRiYzQ0
ZjhlMDUzMjQxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTExICBTYWlk
IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g
RW5jb2RpbmcgYnVmZmVyIGZvciBEaXNwbGF5TGlzdCBpdGVtcyBzaG91bGQgYmUgYWxpZ25lZCB0
byA4IGJ5dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMjMwOTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBFbnN1cmUgdGhlIHN0YXRpYyBhcnJheSBpbiBJdGVtQnVmZmVyOjphcHBlbmQoKSBpcyBhbGln
bmVkIHRvIDggYnl0ZXMuIAorICAgICAgICBTbyBlYWNoIG1lbWJlciBpbiB0aGUgZW5jb2RlZCBE
aXNwbGF5TGlzdDo6SXRlbSBjYW4gYmUgYWxpZ25lZCB0byBpdHMKKyAgICAgICAgYWxpZ25tZW50
IHJlcXVpcmVtZW50CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMv
RGlzcGxheUxpc3RJdGVtQnVmZmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5TGlzdDo6
SXRlbUJ1ZmZlcjo6YXBwZW5kKToKKwogMjAyMS0wMy0wOSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBh
cHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBNYWtlIFdlYktpdCBBUEkgT2JqZWN0aXZlLUMg
b2JqZWN0cyBzYWZlIHRvIHJlbGVhc2Ugb24gbm9uLW1haW4gdGhyZWFkcwpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0
SXRlbUJ1ZmZlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxp
c3RzL0Rpc3BsYXlMaXN0SXRlbUJ1ZmZlci5oCmluZGV4IDg5Zjc0ZmZiNDA2ZTdlODZiYWJiOTRi
NzQ1NzdkYzZhODIyMTAxNTguLjZlMjZhMzZiZDBhYWY3YmVjMGI1OGI3ODc5MTFlMGQxYzI2Mjdh
NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXls
aXN0cy9EaXNwbGF5TGlzdEl0ZW1CdWZmZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RJdGVtQnVmZmVyLmgKQEAgLTE1Miw3
ICsxNTIsNyBAQCBwdWJsaWM6CiAgICAgICAgIHN0YXRpY19hc3NlcnQoc3RkOjppc190cml2aWFs
bHlfZGVzdHJ1Y3RpYmxlPFQ+Ojp2YWx1ZSB8fCAhVDo6aXNJbmxpbmVJdGVtKTsKIAogICAgICAg
ICBpZiAoIVQ6OmlzSW5saW5lSXRlbSAmJiBtX3dyaXRpbmdDbGllbnQpIHsKLSAgICAgICAgICAg
IHN0YXRpYyB1aW50OF90IHRlbXBvcmFyeUl0ZW1CdWZmZXJbc2l6ZW9mKHVpbnQ2NF90KSArIHNp
emVvZihUKV07CisgICAgICAgICAgICBzdGF0aWMgdWludDhfdCB0ZW1wb3JhcnlJdGVtQnVmZmVy
W3NpemVvZih1aW50NjRfdCkgKyBzaXplb2YoVCldIF9fYXR0cmlidXRlX18oKGFsaWduZWQoOCkp
KTsKICAgICAgICAgICAgIHRlbXBvcmFyeUl0ZW1CdWZmZXJbMF0gPSBzdGF0aWNfY2FzdDx1aW50
OF90PihUOjppdGVtVHlwZSk7CiAgICAgICAgICAgICBuZXcgKHRlbXBvcmFyeUl0ZW1CdWZmZXIg
KyBzaXplb2YodWludDY0X3QpKSBUKHN0ZDo6Zm9yd2FyZDxBcmdzPihhcmdzKS4uLik7CiAgICAg
ICAgICAgICBhcHBlbmQoeyB0ZW1wb3JhcnlJdGVtQnVmZmVyIH0pOwo=
</data>
<flag name="review"
          id="442235"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
    <flag name="commit-queue"
          id="442251"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>422998</attachid>
            <date>2021-03-11 17:14:19 -0800</date>
            <delta_ts>2021-03-11 18:30:52 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-223096-20210311171418.patch</filename>
            <type>text/plain</type>
            <size>2107</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ5NjUzODU2NGZjMDIz
NTUyOGVlNDFjNDk2MWEyYWZkOWI4ZDlhOC4uYjlmZmIwNDEwMDYyMjMyNmVjMTY5MWI2ZjRiYzQ0
ZjhlMDUzMjQxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTExICBTYWlk
IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g
RW5jb2RpbmcgYnVmZmVyIGZvciBEaXNwbGF5TGlzdCBpdGVtcyBzaG91bGQgYmUgYWxpZ25lZCB0
byA4IGJ5dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMjMwOTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBFbnN1cmUgdGhlIHN0YXRpYyBhcnJheSBpbiBJdGVtQnVmZmVyOjphcHBlbmQoKSBpcyBhbGln
bmVkIHRvIDggYnl0ZXMuIAorICAgICAgICBTbyBlYWNoIG1lbWJlciBpbiB0aGUgZW5jb2RlZCBE
aXNwbGF5TGlzdDo6SXRlbSBjYW4gYmUgYWxpZ25lZCB0byBpdHMKKyAgICAgICAgYWxpZ25tZW50
IHJlcXVpcmVtZW50CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMv
RGlzcGxheUxpc3RJdGVtQnVmZmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5TGlzdDo6
SXRlbUJ1ZmZlcjo6YXBwZW5kKToKKwogMjAyMS0wMy0wOSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBh
cHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBNYWtlIFdlYktpdCBBUEkgT2JqZWN0aXZlLUMg
b2JqZWN0cyBzYWZlIHRvIHJlbGVhc2Ugb24gbm9uLW1haW4gdGhyZWFkcwpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0
SXRlbUJ1ZmZlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxp
c3RzL0Rpc3BsYXlMaXN0SXRlbUJ1ZmZlci5oCmluZGV4IDg5Zjc0ZmZiNDA2ZTdlODZiYWJiOTRi
NzQ1NzdkYzZhODIyMTAxNTguLmRlMGNhNTU3OTYzZDIwMGI4M2MzOWM4N2RmYWZkZTE1YWQyNjMz
YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXls
aXN0cy9EaXNwbGF5TGlzdEl0ZW1CdWZmZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RJdGVtQnVmZmVyLmgKQEAgLTE1Miw3
ICsxNTIsMTIgQEAgcHVibGljOgogICAgICAgICBzdGF0aWNfYXNzZXJ0KHN0ZDo6aXNfdHJpdmlh
bGx5X2Rlc3RydWN0aWJsZTxUPjo6dmFsdWUgfHwgIVQ6OmlzSW5saW5lSXRlbSk7CiAKICAgICAg
ICAgaWYgKCFUOjppc0lubGluZUl0ZW0gJiYgbV93cml0aW5nQ2xpZW50KSB7Ci0gICAgICAgICAg
ICBzdGF0aWMgdWludDhfdCB0ZW1wb3JhcnlJdGVtQnVmZmVyW3NpemVvZih1aW50NjRfdCkgKyBz
aXplb2YoVCldOworI2lmIENPTVBJTEVSKE1TVkMpCisgICAgICAgICAgICBfX2RlY2xzcGVjKGFs
aWduKDgpKSB1c2luZyBFbmNvZGluZ0J1ZmZlciA9IHVpbnQ4X3Rbc2l6ZW9mKHVpbnQ2NF90KSAr
IHNpemVvZihUKV07CisjZWxzZQorICAgICAgICAgICAgdXNpbmcgRW5jb2RpbmdCdWZmZXIgX19h
dHRyaWJ1dGVfXygoYWxpZ25lZCAoOCkpKSA9IHVpbnQ4X3Rbc2l6ZW9mKHVpbnQ2NF90KSArIHNp
emVvZihUKV07CisjZW5kaWYKKyAgICAgICAgICAgIHN0YXRpYyBFbmNvZGluZ0J1ZmZlciB0ZW1w
b3JhcnlJdGVtQnVmZmVyOwogICAgICAgICAgICAgdGVtcG9yYXJ5SXRlbUJ1ZmZlclswXSA9IHN0
YXRpY19jYXN0PHVpbnQ4X3Q+KFQ6Oml0ZW1UeXBlKTsKICAgICAgICAgICAgIG5ldyAodGVtcG9y
YXJ5SXRlbUJ1ZmZlciArIHNpemVvZih1aW50NjRfdCkpIFQoc3RkOjpmb3J3YXJkPEFyZ3M+KGFy
Z3MpLi4uKTsKICAgICAgICAgICAgIGFwcGVuZCh7IHRlbXBvcmFyeUl0ZW1CdWZmZXIgfSk7Cg==
</data>
<flag name="commit-queue"
          id="442252"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>423002</attachid>
            <date>2021-03-11 17:55:22 -0800</date>
            <delta_ts>2021-03-11 18:57:19 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-223096-20210311175522.patch</filename>
            <type>text/plain</type>
            <size>2107</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ5NjUzODU2NGZjMDIz
NTUyOGVlNDFjNDk2MWEyYWZkOWI4ZDlhOC4uYjlmZmIwNDEwMDYyMjMyNmVjMTY5MWI2ZjRiYzQ0
ZjhlMDUzMjQxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTExICBTYWlk
IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g
RW5jb2RpbmcgYnVmZmVyIGZvciBEaXNwbGF5TGlzdCBpdGVtcyBzaG91bGQgYmUgYWxpZ25lZCB0
byA4IGJ5dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMjMwOTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBFbnN1cmUgdGhlIHN0YXRpYyBhcnJheSBpbiBJdGVtQnVmZmVyOjphcHBlbmQoKSBpcyBhbGln
bmVkIHRvIDggYnl0ZXMuIAorICAgICAgICBTbyBlYWNoIG1lbWJlciBpbiB0aGUgZW5jb2RlZCBE
aXNwbGF5TGlzdDo6SXRlbSBjYW4gYmUgYWxpZ25lZCB0byBpdHMKKyAgICAgICAgYWxpZ25tZW50
IHJlcXVpcmVtZW50CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMv
RGlzcGxheUxpc3RJdGVtQnVmZmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5TGlzdDo6
SXRlbUJ1ZmZlcjo6YXBwZW5kKToKKwogMjAyMS0wMy0wOSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBh
cHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBNYWtlIFdlYktpdCBBUEkgT2JqZWN0aXZlLUMg
b2JqZWN0cyBzYWZlIHRvIHJlbGVhc2Ugb24gbm9uLW1haW4gdGhyZWFkcwpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0
SXRlbUJ1ZmZlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxp
c3RzL0Rpc3BsYXlMaXN0SXRlbUJ1ZmZlci5oCmluZGV4IDg5Zjc0ZmZiNDA2ZTdlODZiYWJiOTRi
NzQ1NzdkYzZhODIyMTAxNTguLmQ4NzU5MzJjMTc2ZjA3OTAzNmVmMGM0ZmJmNWQyZGE3MTMzMTVh
ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXls
aXN0cy9EaXNwbGF5TGlzdEl0ZW1CdWZmZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RJdGVtQnVmZmVyLmgKQEAgLTE1Miw3
ICsxNTIsMTIgQEAgcHVibGljOgogICAgICAgICBzdGF0aWNfYXNzZXJ0KHN0ZDo6aXNfdHJpdmlh
bGx5X2Rlc3RydWN0aWJsZTxUPjo6dmFsdWUgfHwgIVQ6OmlzSW5saW5lSXRlbSk7CiAKICAgICAg
ICAgaWYgKCFUOjppc0lubGluZUl0ZW0gJiYgbV93cml0aW5nQ2xpZW50KSB7Ci0gICAgICAgICAg
ICBzdGF0aWMgdWludDhfdCB0ZW1wb3JhcnlJdGVtQnVmZmVyW3NpemVvZih1aW50NjRfdCkgKyBz
aXplb2YoVCldOworI2lmIENPTVBJTEVSKE1TVkMpCisgICAgICAgICAgICBfX2RlY2xzcGVjKGFs
aWduKDgpKSB0eXBlZGVmIHVpbnQ4X3QgRW5jb2RpbmdCdWZmZXJbc2l6ZW9mKHVpbnQ2NF90KSAr
IHNpemVvZihUKV07CisjZWxzZQorICAgICAgICAgICAgdXNpbmcgRW5jb2RpbmdCdWZmZXIgX19h
dHRyaWJ1dGVfXygoYWxpZ25lZCAoOCkpKSA9IHVpbnQ4X3Rbc2l6ZW9mKHVpbnQ2NF90KSArIHNp
emVvZihUKV07CisjZW5kaWYKKyAgICAgICAgICAgIHN0YXRpYyBFbmNvZGluZ0J1ZmZlciB0ZW1w
b3JhcnlJdGVtQnVmZmVyOwogICAgICAgICAgICAgdGVtcG9yYXJ5SXRlbUJ1ZmZlclswXSA9IHN0
YXRpY19jYXN0PHVpbnQ4X3Q+KFQ6Oml0ZW1UeXBlKTsKICAgICAgICAgICAgIG5ldyAodGVtcG9y
YXJ5SXRlbUJ1ZmZlciArIHNpemVvZih1aW50NjRfdCkpIFQoc3RkOjpmb3J3YXJkPEFyZ3M+KGFy
Z3MpLi4uKTsKICAgICAgICAgICAgIGFwcGVuZCh7IHRlbXBvcmFyeUl0ZW1CdWZmZXIgfSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>423004</attachid>
            <date>2021-03-11 18:57:35 -0800</date>
            <delta_ts>2021-03-11 20:59:15 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-223096-20210311185734.patch</filename>
            <type>text/plain</type>
            <size>2105</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ5NjUzODU2NGZjMDIz
NTUyOGVlNDFjNDk2MWEyYWZkOWI4ZDlhOC4uZDNlMjUzYWI2Y2M3MzY4ZWZkMzViYzYyOTZkZmU1
YmY2OWRiZDg0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTExICBTYWlk
IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g
RW5jb2RpbmcgYnVmZmVyIGZvciBEaXNwbGF5TGlzdCBpdGVtcyBzaG91bGQgYmUgYWxpZ25lZCB0
byA4IGJ5dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMjMwOTYKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAg
RW5zdXJlIHRoZSBzdGF0aWMgYXJyYXkgaW4gSXRlbUJ1ZmZlcjo6YXBwZW5kKCkgaXMgYWxpZ25l
ZCB0byA4IGJ5dGVzLiAKKyAgICAgICAgU28gZWFjaCBtZW1iZXIgaW4gdGhlIGVuY29kZWQgRGlz
cGxheUxpc3Q6Okl0ZW0gY2FuIGJlIGFsaWduZWQgdG8gaXRzCisgICAgICAgIGFsaWdubWVudCBy
ZXF1aXJlbWVudAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rp
c3BsYXlMaXN0SXRlbUJ1ZmZlci5oOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheUxpc3Q6Okl0
ZW1CdWZmZXI6OmFwcGVuZCk6CisKIDIwMjEtMDMtMDkgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw
bGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gTWFrZSBXZWJLaXQgQVBJIE9iamVjdGl2ZS1DIG9i
amVjdHMgc2FmZSB0byByZWxlYXNlIG9uIG5vbi1tYWluIHRocmVhZHMKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0cy9EaXNwbGF5TGlzdEl0
ZW1CdWZmZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0
cy9EaXNwbGF5TGlzdEl0ZW1CdWZmZXIuaAppbmRleCA4OWY3NGZmYjQwNmU3ZTg2YmFiYjk0Yjc0
NTc3ZGM2YTgyMjEwMTU4Li5kODc1OTMyYzE3NmYwNzkwMzZlZjBjNGZiZjVkMmRhNzEzMzE1YWQ1
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlz
dHMvRGlzcGxheUxpc3RJdGVtQnVmZmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
Z3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0SXRlbUJ1ZmZlci5oCkBAIC0xNTIsNyAr
MTUyLDEyIEBAIHB1YmxpYzoKICAgICAgICAgc3RhdGljX2Fzc2VydChzdGQ6OmlzX3RyaXZpYWxs
eV9kZXN0cnVjdGlibGU8VD46OnZhbHVlIHx8ICFUOjppc0lubGluZUl0ZW0pOwogCiAgICAgICAg
IGlmICghVDo6aXNJbmxpbmVJdGVtICYmIG1fd3JpdGluZ0NsaWVudCkgewotICAgICAgICAgICAg
c3RhdGljIHVpbnQ4X3QgdGVtcG9yYXJ5SXRlbUJ1ZmZlcltzaXplb2YodWludDY0X3QpICsgc2l6
ZW9mKFQpXTsKKyNpZiBDT01QSUxFUihNU1ZDKQorICAgICAgICAgICAgX19kZWNsc3BlYyhhbGln
big4KSkgdHlwZWRlZiB1aW50OF90IEVuY29kaW5nQnVmZmVyW3NpemVvZih1aW50NjRfdCkgKyBz
aXplb2YoVCldOworI2Vsc2UKKyAgICAgICAgICAgIHVzaW5nIEVuY29kaW5nQnVmZmVyIF9fYXR0
cmlidXRlX18oKGFsaWduZWQgKDgpKSkgPSB1aW50OF90W3NpemVvZih1aW50NjRfdCkgKyBzaXpl
b2YoVCldOworI2VuZGlmCisgICAgICAgICAgICBzdGF0aWMgRW5jb2RpbmdCdWZmZXIgdGVtcG9y
YXJ5SXRlbUJ1ZmZlcjsKICAgICAgICAgICAgIHRlbXBvcmFyeUl0ZW1CdWZmZXJbMF0gPSBzdGF0
aWNfY2FzdDx1aW50OF90PihUOjppdGVtVHlwZSk7CiAgICAgICAgICAgICBuZXcgKHRlbXBvcmFy
eUl0ZW1CdWZmZXIgKyBzaXplb2YodWludDY0X3QpKSBUKHN0ZDo6Zm9yd2FyZDxBcmdzPihhcmdz
KS4uLik7CiAgICAgICAgICAgICBhcHBlbmQoeyB0ZW1wb3JhcnlJdGVtQnVmZmVyIH0pOwo=
</data>
<flag name="commit-queue"
          id="442261"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>423012</attachid>
            <date>2021-03-11 20:59:22 -0800</date>
            <delta_ts>2021-03-11 21:57:00 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-223096-20210311205921.patch</filename>
            <type>text/plain</type>
            <size>2057</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWFjODc0NmFlZmZmMTNm
OWRkOTVkYWRiMjA2ZWE5MDBmNGEzOGU4OS4uZDUyNzQyNDNiNzg1Y2Y5OWQ0ODYwMjk5ODhlYmMz
YThlMTBmNTNhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTExICBTYWlk
IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g
RW5jb2RpbmcgYnVmZmVyIGZvciBEaXNwbGF5TGlzdCBpdGVtcyBzaG91bGQgYmUgYWxpZ25lZCB0
byA4IGJ5dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMjMwOTYKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAg
RW5zdXJlIHRoZSBzdGF0aWMgYXJyYXkgaW4gSXRlbUJ1ZmZlcjo6YXBwZW5kKCkgaXMgYWxpZ25l
ZCB0byA4IGJ5dGVzLiAKKyAgICAgICAgU28gZWFjaCBtZW1iZXIgaW4gdGhlIGVuY29kZWQgRGlz
cGxheUxpc3Q6Okl0ZW0gY2FuIGJlIGFsaWduZWQgdG8gaXRzCisgICAgICAgIGFsaWdubWVudCBy
ZXF1aXJlbWVudAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rp
c3BsYXlMaXN0SXRlbUJ1ZmZlci5oOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheUxpc3Q6Okl0
ZW1CdWZmZXI6OmFwcGVuZCk6CisKIDIwMjEtMDMtMTEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw
cGxlLmNvbT4KIAogICAgICAgICBJbnRyb2R1Y2UgZW5zdXJlT25NYWluVGhyZWFkKCkKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0cy9EaXNw
bGF5TGlzdEl0ZW1CdWZmZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rp
c3BsYXlsaXN0cy9EaXNwbGF5TGlzdEl0ZW1CdWZmZXIuaAppbmRleCA4OWY3NGZmYjQwNmU3ZTg2
YmFiYjk0Yjc0NTc3ZGM2YTgyMjEwMTU4Li5kODc1OTMyYzE3NmYwNzkwMzZlZjBjNGZiZjVkMmRh
NzEzMzE1YWQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9k
aXNwbGF5bGlzdHMvRGlzcGxheUxpc3RJdGVtQnVmZmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0SXRlbUJ1ZmZlci5oCkBA
IC0xNTIsNyArMTUyLDEyIEBAIHB1YmxpYzoKICAgICAgICAgc3RhdGljX2Fzc2VydChzdGQ6Omlz
X3RyaXZpYWxseV9kZXN0cnVjdGlibGU8VD46OnZhbHVlIHx8ICFUOjppc0lubGluZUl0ZW0pOwog
CiAgICAgICAgIGlmICghVDo6aXNJbmxpbmVJdGVtICYmIG1fd3JpdGluZ0NsaWVudCkgewotICAg
ICAgICAgICAgc3RhdGljIHVpbnQ4X3QgdGVtcG9yYXJ5SXRlbUJ1ZmZlcltzaXplb2YodWludDY0
X3QpICsgc2l6ZW9mKFQpXTsKKyNpZiBDT01QSUxFUihNU1ZDKQorICAgICAgICAgICAgX19kZWNs
c3BlYyhhbGlnbig4KSkgdHlwZWRlZiB1aW50OF90IEVuY29kaW5nQnVmZmVyW3NpemVvZih1aW50
NjRfdCkgKyBzaXplb2YoVCldOworI2Vsc2UKKyAgICAgICAgICAgIHVzaW5nIEVuY29kaW5nQnVm
ZmVyIF9fYXR0cmlidXRlX18oKGFsaWduZWQgKDgpKSkgPSB1aW50OF90W3NpemVvZih1aW50NjRf
dCkgKyBzaXplb2YoVCldOworI2VuZGlmCisgICAgICAgICAgICBzdGF0aWMgRW5jb2RpbmdCdWZm
ZXIgdGVtcG9yYXJ5SXRlbUJ1ZmZlcjsKICAgICAgICAgICAgIHRlbXBvcmFyeUl0ZW1CdWZmZXJb
MF0gPSBzdGF0aWNfY2FzdDx1aW50OF90PihUOjppdGVtVHlwZSk7CiAgICAgICAgICAgICBuZXcg
KHRlbXBvcmFyeUl0ZW1CdWZmZXIgKyBzaXplb2YodWludDY0X3QpKSBUKHN0ZDo6Zm9yd2FyZDxB
cmdzPihhcmdzKS4uLik7CiAgICAgICAgICAgICBhcHBlbmQoeyB0ZW1wb3JhcnlJdGVtQnVmZmVy
IH0pOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>