22304 2008-11-16 22:47:43 -0800 [Transforms] Dictionary panel does not work correctly in transformed text 2009-01-09 13:36:38 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.5 ASSIGNED P2 Normal --- 15671 1 simon.fraser simon.fraser mitz oldest_to_newest 99003 0 simon.fraser 2008-11-16 22:47:43 -0800 The Dictionary panel (Command-Control-D) doesn't work correctly on text in a transformed element. It seems to refuse to open up. I'm guessing it's related to the relative positions of the cursor and the reported selection rects. 100961 1 25660 simon.fraser 2008-12-01 21:16:06 -0800 Created attachment 25660 Testcase 100962 2 simon.fraser 2008-12-01 21:19:02 -0800 The relevant call stack is #3 0x038bc680 in WebCore::RenderText::caretRect (this=0x1c90d00c, inlineBox=0x1c90a20c, caretOffset=25, extraWidthToEndOfLine=0xbfffdc1c) at /Volumes/Cassoulet/WebKit/WebKit.git/WebCore/rendering/RenderText.cpp:388 #4 0x035a4eef in WebCore::Frame::firstRectForRange (this=0x99fac0, range=0x1aff2480) at /Volumes/Cassoulet/WebKit/WebKit.git/WebCore/page/Frame.cpp:271 #5 0x001aff54 in -[WebFrame(WebInternal) _firstRectForDOMRange:] (self=0x99fb10, _cmd=0x26e514, range=0x1af9ecd0) at /Volumes/Cassoulet/WebKit/WebKit.git/WebKit/mac/WebView/WebFrame.mm:681 #6 0x001b1382 in -[WebFrame(WebInternal) _characterRangeAtPoint:] (self=0x99fb10, _cmd=0x25fe92, point={x = 179, y = 25}) at /Volumes/Cassoulet/WebKit/WebKit.git/WebKit/mac/WebView/WebFrame.mm:973 #7 0x001cbd87 in -[WebHTMLView(WebNSTextInputSupport) characterIndexForPoint:] (self=0x1aff5170, _cmd=0x94418798, thePoint={x = 179, y = 25}) at /Volumes/Cassoulet/WebKit/WebKit.git/WebKit/mac/WebView/WebHTMLView.mm:4963 #8 0x95772c6b in _NSTSMEventHandler () So this depends on the caretRect stuff. 101704 3 simon.fraser 2008-12-06 18:50:06 -0800 Note: the "start and end are on the same line" test in Frame::firstRectForRange() is wrong for transformed elements. But fixing this still doesn't make it work in all cases. 25660 2008-12-01 21:16:06 -0800 2008-12-01 21:16:06 -0800 Testcase dictionary-popup.html text/html 627 simon.fraser PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+Cgo8aHRtbCBs YW5nPSJlbiI+CjxoZWFkPgogIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KICA8dGl0bGU+VGVzdGluZyB0aGUgRGljdGlv YXJ5IFBvcC11cCBXaW5kb3c8L3RpdGxlPgogIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9 InNjcmVlbiI+CiAgICBkaXYgewogICAgICBtYXJnaW46IDQwcHg7CiAgICB9CiAgPC9zdHlsZT4K PC9oZWFkPgo8Ym9keT4KPHA+UG9pbnQgYXQgYSB3b3JkLCBwcmVzcyBDb21tYW5kLUNvbnRyb2wt RCB0byBnZXQgdGhlIERpY3Rpb25hcnkgd2luZG93PC9wPgo8ZGl2IHN0eWxlPSItd2Via2l0LXRy YW5zZm9ybTogdHJhbnNsYXRlKDIwcHgsIDIwcHgpOyI+CiAgVHJ5IGhlcmUKPC9kaXY+Cgo8ZGl2 IHN0eWxlPSItd2Via2l0LXRyYW5zZm9ybTogcm90YXRlKDIwZGVnKTsgLXdlYmtpdC10cmFuc2Zv cm0tb3JpZ2luOiB0b3AgbGVmdDsiPgogIFRyeSBoZXJlCjwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4K