222960 2021-03-08 23:53:01 -0800 [GPU Process] ImageBitmap should release its ImageBuffer in the main thread 2021-03-12 10:59:07 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 222835 1 sabouhallawa sabouhallawa cdumez changseok dino esprehn+autocc ews-watchlist gyuyoung.kim simon.fraser webkit-bug-importer oldest_to_newest 1737480 0 sabouhallawa 2021-03-08 23:53:01 -0800 The ImageBuffer of the ImageBitmap should be deleted on the main thread only since its deletion may require sending messages to the GPUP. 1737482 1 422668 sabouhallawa 2021-03-08 23:55:13 -0800 Created attachment 422668 Patch 1737638 2 422668 simon.fraser 2021-03-09 10:07:16 -0800 Comment on attachment 422668 Patch It this covered by tests? 1737657 3 422728 sabouhallawa 2021-03-09 10:45:44 -0800 Created attachment 422728 Patch 1737658 4 sabouhallawa 2021-03-09 10:46:12 -0800 (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 422668 [details] > Patch > > It this covered by tests? imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-in-worker-transfer.html 1737661 5 422728 cdumez 2021-03-09 10:46:57 -0800 Comment on attachment 422728 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422728&action=review > Source/WebCore/html/ImageBitmap.cpp:848 > + callOnMainThread([imageBuffer = WTFMove(imageBuffer)]() mutable { }); I doubt the mutable and () are needed. 1737662 6 simon.fraser 2021-03-09 10:49:11 -0800 (In reply to Said Abou-Hallawa from comment #4) > (In reply to Simon Fraser (smfr) from comment #2) > > Comment on attachment 422668 [details] > > Patch > > > > It this covered by tests? > > imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/ > createImageBitmap-in-worker-transfer.html Please note in the changeling. 1737673 7 422731 sabouhallawa 2021-03-09 11:08:43 -0800 Created attachment 422731 Patch 1737688 8 ews-feeder 2021-03-09 12:03:33 -0800 Committed r274164: <https://commits.webkit.org/r274164> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422731. 1737689 9 webkit-bug-importer 2021-03-09 12:04:39 -0800 <rdar://problem/75228853> 1738961 10 sabouhallawa 2021-03-12 10:59:07 -0800 *** Bug 222879 has been marked as a duplicate of this bug. *** 422668 2021-03-08 23:55:13 -0800 2021-03-09 10:07:16 -0800 Patch bug-222960-20210308235512.patch text/plain 1624 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzY3YTQyYzEzYWI2YWNl ZWRjMzAzZWZkZDk2OWEwMDJkNWIwMWZkZC4uNTAwMDc2NmQ3NTFiZjMzMDY4ZjRhNTFiMWM4YTgy YTc1MzA2MTY4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAzLTA4ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g SW1hZ2VCaXRtYXAgc2hvdWxkIHJlbGVhc2UgaXRzIEltYWdlQnVmZmVyIGluIHRoZSBtYWluIHRo cmVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIy OTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IEltYWdlQnVmZmVyIG9mIHRoZSBJbWFnZUJpdG1hcCBzaG91bGQgYmUgZGVsZXRlZCBvbiB0aGUg bWFpbiB0aHJlYWQKKyAgICAgICAgb25seSBzaW5jZSBpdHMgZGVsZXRpb24gbWF5IHJlcXVpcmUg c2VuZGluZyBtZXNzYWdlcyB0byB0aGUgR1BVUC4KKworICAgICAgICAqIGh0bWwvSW1hZ2VCaXRt YXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCaXRtYXA6On5JbWFnZUJpdG1hcCk6CisK IDIwMjEtMDMtMDggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTihyMjc0MDI1LXIyNzM4MTEpOiBDcmFzaCB1bmRlciBSZW5kZXJMYXll ckJhY2tpbmc6OnVwZGF0ZUdlb21ldHJ5KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSW1hZ2VCaXRtYXAuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZUJpdG1hcC5jcHAK aW5kZXggZTBlNTI4ZDRkMzQwM2JiYmNhMDUyZTMxYzM4MzRhNTU3MTVhZWM0YS4uMDQ1ZWFlZmYy YTg2NDBmN2IyYTAyODA2MDg1NDI2Y2QyNzY4MDJlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9JbWFnZUJpdG1hcC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZUJp dG1hcC5jcHAKQEAgLTg0MCw3ICs4NDAsMTMgQEAgSW1hZ2VCaXRtYXA6OkltYWdlQml0bWFwKE9w dGlvbmFsPEltYWdlQml0bWFwQmFja2luZz4mJiBiYWNraW5nU3RvcmUpCiAgICAgQVNTRVJUX0lN UExJRVMobV9iYWNraW5nU3RvcmUsIG1fYmFja2luZ1N0b3JlLT5idWZmZXIoKSk7CiB9CiAKLUlt YWdlQml0bWFwOjp+SW1hZ2VCaXRtYXAoKSA9IGRlZmF1bHQ7CitJbWFnZUJpdG1hcDo6fkltYWdl Qml0bWFwKCkKK3sKKyAgICBpZiAoaXNNYWluVGhyZWFkKCkpCisgICAgICAgIHJldHVybjsKKyAg ICBpZiAoYXV0byBpbWFnZUJ1ZmZlciA9IHRha2VJbWFnZUJ1ZmZlcigpKQorICAgICAgICBjYWxs T25NYWluVGhyZWFkKFtpbWFnZUJ1ZmZlciA9IFdURk1vdmUoaW1hZ2VCdWZmZXIpXSgpIG11dGFi bGUgeyB9KTsKK30KIAogT3B0aW9uYWw8SW1hZ2VCaXRtYXBCYWNraW5nPiBJbWFnZUJpdG1hcDo6 dGFrZUltYWdlQml0bWFwQmFja2luZygpCiB7Cg== 422728 2021-03-09 10:45:44 -0800 2021-03-09 11:09:16 -0800 Patch bug-222960-20210309104543.patch text/plain 1779 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzY3YTQyYzEzYWI2YWNl ZWRjMzAzZWZkZDk2OWEwMDJkNWIwMWZkZC4uYTYxOTY1YzE3NWFlYTMxYTRhM2QxMDJmYWE4Nzdk YjU3ODQ0ZDdhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAzLTA4ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g SW1hZ2VCaXRtYXAgc2hvdWxkIHJlbGVhc2UgaXRzIEltYWdlQnVmZmVyIGluIHRoZSBtYWluIHRo cmVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIy OTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgIFRoZSBJ bWFnZUJ1ZmZlciBvZiB0aGUgSW1hZ2VCaXRtYXAgc2hvdWxkIGJlIGRlbGV0ZWQgb24gdGhlIG1h aW4gdGhyZWFkCisgICAgICAgIG9ubHkgc2luY2UgaXRzIGRlbGV0aW9uIG1heSByZXF1aXJlIHNl bmRpbmcgbWVzc2FnZXMgdG8gdGhlIEdQVVAuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGlu ZyB0ZXN0OiAKKyAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRt bC9jYW52YXMvZWxlbWVudC9pbWFnZWJpdG1hcC9jcmVhdGVJbWFnZUJpdG1hcC1pbi13b3JrZXIt dHJhbnNmZXIuaHRtbAorCisgICAgICAgICogaHRtbC9JbWFnZUJpdG1hcC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpJbWFnZUJpdG1hcDo6fkltYWdlQml0bWFwKToKKwogMjAyMS0wMy0wOCAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O KHIyNzQwMjUtcjI3MzgxMSk6IENyYXNoIHVuZGVyIFJlbmRlckxheWVyQmFja2luZzo6dXBkYXRl R2VvbWV0cnkoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZUJpdG1hcC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlQml0bWFwLmNwcAppbmRleCBlMGU1MjhkNGQz NDAzYmJiY2EwNTJlMzFjMzgzNGE1NTcxNWFlYzRhLi4wNDVlYWVmZjJhODY0MGY3YjJhMDI4MDYw ODU0MjZjZDI3NjgwMmU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlQml0 bWFwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlQml0bWFwLmNwcApAQCAtODQw LDcgKzg0MCwxMyBAQCBJbWFnZUJpdG1hcDo6SW1hZ2VCaXRtYXAoT3B0aW9uYWw8SW1hZ2VCaXRt YXBCYWNraW5nPiYmIGJhY2tpbmdTdG9yZSkKICAgICBBU1NFUlRfSU1QTElFUyhtX2JhY2tpbmdT dG9yZSwgbV9iYWNraW5nU3RvcmUtPmJ1ZmZlcigpKTsKIH0KIAotSW1hZ2VCaXRtYXA6On5JbWFn ZUJpdG1hcCgpID0gZGVmYXVsdDsKK0ltYWdlQml0bWFwOjp+SW1hZ2VCaXRtYXAoKQoreworICAg IGlmIChpc01haW5UaHJlYWQoKSkKKyAgICAgICAgcmV0dXJuOworICAgIGlmIChhdXRvIGltYWdl QnVmZmVyID0gdGFrZUltYWdlQnVmZmVyKCkpCisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW2lt YWdlQnVmZmVyID0gV1RGTW92ZShpbWFnZUJ1ZmZlcildKCkgbXV0YWJsZSB7IH0pOworfQogCiBP cHRpb25hbDxJbWFnZUJpdG1hcEJhY2tpbmc+IEltYWdlQml0bWFwOjp0YWtlSW1hZ2VCaXRtYXBC YWNraW5nKCkKIHsK 422731 2021-03-09 11:08:43 -0800 2021-03-09 12:03:35 -0800 Patch bug-222960-20210309110842.patch text/plain 1769 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzY3YTQyYzEzYWI2YWNl ZWRjMzAzZWZkZDk2OWEwMDJkNWIwMWZkZC4uYTYxOTY1YzE3NWFlYTMxYTRhM2QxMDJmYWE4Nzdk YjU3ODQ0ZDdhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAzLTA4ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g SW1hZ2VCaXRtYXAgc2hvdWxkIHJlbGVhc2UgaXRzIEltYWdlQnVmZmVyIGluIHRoZSBtYWluIHRo cmVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIy OTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgIFRoZSBJ bWFnZUJ1ZmZlciBvZiB0aGUgSW1hZ2VCaXRtYXAgc2hvdWxkIGJlIGRlbGV0ZWQgb24gdGhlIG1h aW4gdGhyZWFkCisgICAgICAgIG9ubHkgc2luY2UgaXRzIGRlbGV0aW9uIG1heSByZXF1aXJlIHNl bmRpbmcgbWVzc2FnZXMgdG8gdGhlIEdQVVAuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGlu ZyB0ZXN0OiAKKyAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRt bC9jYW52YXMvZWxlbWVudC9pbWFnZWJpdG1hcC9jcmVhdGVJbWFnZUJpdG1hcC1pbi13b3JrZXIt dHJhbnNmZXIuaHRtbAorCisgICAgICAgICogaHRtbC9JbWFnZUJpdG1hcC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpJbWFnZUJpdG1hcDo6fkltYWdlQml0bWFwKToKKwogMjAyMS0wMy0wOCAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O KHIyNzQwMjUtcjI3MzgxMSk6IENyYXNoIHVuZGVyIFJlbmRlckxheWVyQmFja2luZzo6dXBkYXRl R2VvbWV0cnkoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZUJpdG1hcC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlQml0bWFwLmNwcAppbmRleCBlMGU1MjhkNGQz NDAzYmJiY2EwNTJlMzFjMzgzNGE1NTcxNWFlYzRhLi5lODBjNGYyNTI3YzNiYzFhODg3N2Q5Y2Uz MWY0NWIxOGUyMzI2N2FiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlQml0 bWFwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlQml0bWFwLmNwcApAQCAtODQw LDcgKzg0MCwxMyBAQCBJbWFnZUJpdG1hcDo6SW1hZ2VCaXRtYXAoT3B0aW9uYWw8SW1hZ2VCaXRt YXBCYWNraW5nPiYmIGJhY2tpbmdTdG9yZSkKICAgICBBU1NFUlRfSU1QTElFUyhtX2JhY2tpbmdT dG9yZSwgbV9iYWNraW5nU3RvcmUtPmJ1ZmZlcigpKTsKIH0KIAotSW1hZ2VCaXRtYXA6On5JbWFn ZUJpdG1hcCgpID0gZGVmYXVsdDsKK0ltYWdlQml0bWFwOjp+SW1hZ2VCaXRtYXAoKQoreworICAg IGlmIChpc01haW5UaHJlYWQoKSkKKyAgICAgICAgcmV0dXJuOworICAgIGlmIChhdXRvIGltYWdl QnVmZmVyID0gdGFrZUltYWdlQnVmZmVyKCkpCisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW2lt YWdlQnVmZmVyID0gV1RGTW92ZShpbWFnZUJ1ZmZlcildIHsgfSk7Cit9CiAKIE9wdGlvbmFsPElt YWdlQml0bWFwQmFja2luZz4gSW1hZ2VCaXRtYXA6OnRha2VJbWFnZUJpdG1hcEJhY2tpbmcoKQog ewo=