222909 2021-03-08 07:55:23 -0800 REGRESSION(r273197): Revert of r273084 broke building on Linux platforms 2021-03-08 08:04:39 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 222227 1 commit-queue commit-queue clord fred.wang mcatanzaro rwlbuis webkit-bug-importer oldest_to_newest 1737071 0 commit-queue 2021-03-08 07:55:23 -0800 https://trac.webkit.org/changeset/273197 broke the build: Revert of r273084 broke building on Linux platforms This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1737073 1 422565 commit-queue 2021-03-08 07:55:29 -0800 Created attachment 422565 REVERT of r273197 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1737077 2 ews-feeder 2021-03-08 08:01:50 -0800 Committed r274073: <https://commits.webkit.org/r274073> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422565. 1737078 3 webkit-bug-importer 2021-03-08 08:02:24 -0800 <rdar://problem/75170213> 1737080 4 mcatanzaro 2021-03-08 08:04:39 -0800 r273084 didn't break anything itself, but r274070 did. Sorry. 422565 2021-03-08 07:55:29 -0800 2021-03-08 08:01:51 -0800 REVERT of r273197 bug-222909-20210308155529.patch text/plain 2367 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTc1N2ZkMDY3ODMxMGMz NmQ2ZDFlODg1ZmJmMjhmYWMzMmU3ZDM2My4uOTAxMWVlNGVlZDAyZGUwMzVjYzU3MTMxNGRmMTA3 ZmU0ZGZlNGU2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAzLTA4ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByZXZlcnRpbmcgcjI3MzE5Ny4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIyMjkwOQorCisgICAgICAgIFJldmVydCBvZiByMjczMDg0IGJyb2tlIGJ1 aWxkaW5nIG9uIExpbnV4IHBsYXRmb3JtcworCisgICAgICAgIFJldmVydGVkIGNoYW5nZXNldDoK KworICAgICAgICAiUmVtb3ZlIHVudXNlZCBpc0dvb2dsZSBmdW5jdGlvbiIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjIyNworICAgICAgICBodHRw czovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjczMTk3CisKIDIwMjEtMDMtMDggIENvbW1p dCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJldmVydGluZyByMjczMDg0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v VXNlckFnZW50UXVpcmtzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VzZXJBZ2VudFF1 aXJrcy5jcHAKaW5kZXggZTVhYjhjZmRhYTBkMmM4MTRiNmRlYWViMDczOThlZDFjNWVjZGQ1NS4u Yjk4NmI1ZGI0ZDMzN2U5MTg1NTZlYWQ0ZGM4ZjM2NTI0NDA0ZDVhNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9Vc2VyQWdlbnRRdWlya3MuY3BwCkBAIC0zNSw2ICszNSwzMCBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAvLyBXaGVuIGVkaXRpbmcgdGhlIHF1aXJrcyBpbiB0aGlzIGZpbGUs IGJlIHN1cmUgdG8gdXBkYXRlCiAvLyBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUv VXNlckFnZW50UXVpcmtzLmNwcC4KIAorc3RhdGljIGJvb2wgaXNHb29nbGUoY29uc3QgVVJMJiB1 cmwpCit7CisgICAgU3RyaW5nIGRvbWFpbiA9IHVybC5ob3N0KCkudG9TdHJpbmcoKTsKKyAgICBT dHJpbmcgYmFzZURvbWFpbiA9IHRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4oZG9tYWluKTsK KworICAgIC8vIE91ciBHb29nbGUgVUEgaXMgKnZlcnkqIGNvbXBsaWNhdGVkIHRvIGdldCByaWdo dC4gUmVhZAorICAgIC8vIGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0MjA3NCBjYXJlZnVsbHkgYmVm b3JlIGNoYW5naW5nLiBUZXN0IHRoYXQgM0QKKyAgICAvLyB2aWV3IGlzIGF2YWlsYWJsZSBpbiBH b29nbGUgTWFwcy4gVGVzdCBHb29nbGUgQ2FsZW5kYXIuIFRlc3QgbG9nZ2luZyBvdXQKKyAgICAv LyBhbmQgbG9nZ2luZyBpbiB0byBhIEdvb2dsZSBhY2NvdW50LiBDaGFuZ2UgcGxhdGZvcm1WZXJz aW9uRm9yVUFTdHJpbmcoKQorICAgIC8vIHRvIHJldHVybiAiRnJlZUJTRCBhbWQ2NCIgYW5kIHRl c3QgZXZlcnl0aGluZyBhZ2Fpbi4KKyAgICBpZiAoYmFzZURvbWFpbi5zdGFydHNXaXRoKCJnb29n bGUuIikpCisgICAgICAgIHJldHVybiB0cnVlOworICAgIGlmIChiYXNlRG9tYWluID09ICJnc3Rh dGljLmNvbSIpCisgICAgICAgIHJldHVybiB0cnVlOworICAgIGlmIChiYXNlRG9tYWluID09ICJn b29nbGV1c2VyY29udGVudC5jb20iKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAvLyBnb29n bGVhcGlzLmNvbSBpcyBpbiB0aGUgcHVibGljIHN1ZmZpeCBsaXN0LCB3aGljaCBpcyBjb25mdXNp bmcuIEUuZy4KKyAgICAvLyBmb250cy5nb29nbGVhcGlzLmNvbSBpcyBhY3R1YWxseSBhIGJhc2Ug ZG9tYWluLgorICAgIGlmIChkb21haW4uZW5kc1dpdGgoIi5nb29nbGVhcGlzLmNvbSIpKQorICAg ICAgICByZXR1cm4gdHJ1ZTsKKworICAgIHJldHVybiBmYWxzZTsKK30KKwogLy8gQmUgY2FyZWZ1 bCB3aXRoIHRoaXMgcXVpcms6IGl0J3MgYW4gaW52aXRhdGlvbiBmb3Igc2l0ZXMgdG8gdXNlIEph dmFTY3JpcHQKIC8vIHRoYXQgd29ya3MgaW4gQ2hyb21lIHRoYXQgV2ViS2l0IGNhbm5vdCBoYW5k bGUuIFByZWZlciBvdGhlciBxdWlya3MgaW5zdGVhZC4KIHN0YXRpYyBib29sIHVybFJlcXVpcmVz Q2hyb21lQnJvd3Nlcihjb25zdCBVUkwmIHVybCkK