222880 2021-03-07 01:03:05 -0800 [GPU Process] inspector/canvas/memory.html fails when GPU rendering is enabled for 2D Canvas 2021-04-07 15:46:24 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224306 InRadar P2 Normal --- 222835 1 sabouhallawa sabouhallawa dino ews-watchlist hi jonlee simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1736909 0 sabouhallawa 2021-03-07 01:03:05 -0800 It looks related to the memoryCost() of the RemoteImageBuffer. 1736974 1 webkit-bug-importer 2021-03-07 19:27:03 -0800 <rdar://problem/75155302> 1738981 2 423072 sabouhallawa 2021-03-12 11:58:14 -0800 Created attachment 423072 Patch 1738984 3 423072 thorton 2021-03-12 12:13:54 -0800 Comment on attachment 423072 Patch How does it have a memory cost if it has no GPUP backend yet :) Why does asking for the memory cost make it have a cost? 1738985 4 thorton 2021-03-12 12:14:30 -0800 Also, do we /really/ need to round-trip processes to multiply some numbers :D 1738988 5 sabouhallawa 2021-03-12 12:32:39 -0800 (In reply to Tim Horton from comment #3) > Comment on attachment 423072 [details] > Patch > > How does it have a memory cost if it has no GPUP backend yet :) Why does > asking for the memory cost make it have a cost? Once the RemoteImageBufferProxy is created, the WebP process sends a messages to the GPUP asking it to create the corresponding RemoteImageBuffer. So the backend is created almost instantly when RemoteImageBufferProxy is created. Please see RemoteRenderingBackendProxy::createImageBuffer(). ensureBackendCreated() only makes the WebP wait the GPUP to reply back with the backend handle so it can map it to a shareable backend. 1738992 6 sabouhallawa 2021-03-12 12:41:28 -0800 (In reply to Tim Horton from comment #4) > Also, do we /really/ need to round-trip processes to multiply some numbers :D The IOSurface aligns its rows to 64 bytes. So the size is not necessarily = width x height x 4. For example an ImageBuffer whose logical size is 200 x 200 is not 160,000 bytes. But it is 166,400. And of course this is not the case with other backend types. 1738993 7 sabouhallawa 2021-03-12 12:43:32 -0800 (In reply to Said Abou-Hallawa from comment #6) > (In reply to Tim Horton from comment #4) > > Also, do we /really/ need to round-trip processes to multiply some numbers :D > > The IOSurface aligns its rows to 64 bytes. So the size is not necessarily = > width x height x 4. > > For example an ImageBuffer whose logical size is 200 x 200 is not 160,000 > bytes. But it is 166,400. And of course this is not the case with other > backend types. The bytesPerRow() for the example above is 832. So the size = 832 * 200 = 166,400 bytes 1739029 8 ews-feeder 2021-03-12 14:20:24 -0800 commit-queue failed to commit attachment 423072 to WebKit repository. To retry, please set cq+ flag again. 1739033 9 423082 sabouhallawa 2021-03-12 14:29:10 -0800 Created attachment 423082 Patch 1739048 10 ews-feeder 2021-03-12 15:44:02 -0800 commit-queue failed to commit attachment 423082 to WebKit repository. To retry, please set cq+ flag again. 1739054 11 sabouhallawa 2021-03-12 15:55:31 -0800 Committed r274373: <https://commits.webkit.org/r274373> 423072 2021-03-12 11:58:14 -0800 2021-03-12 14:20:25 -0800 Patch bug-222880-20210312115813.patch text/plain 2948 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYThiMTI5ZjI0YjI0NDkx M2E1NjA3NmU0NTg5NGMwNmMxMGE0NjA2Ny4uYjczMWMyZWMxMzAwZjMyYTJjYzg1MmU2YmUzZTRl OTUzNDIzOTlmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTAzLTEyICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g aW5zcGVjdG9yL2NhbnZhcy9tZW1vcnkuaHRtbCBmYWlscyB3aGVuIEdQVSByZW5kZXJpbmcgaXMg ZW5hYmxlZCBmb3IgMkQgQ2FudmFzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjI4ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdGVJbWFnZUJ1ZmZlclByb3h5IGhhcyB0byBlbnN1cmUgaXRzIGJh Y2tlbmQgaXMgY3JlYXRlZCBpbiB0aGUgR1BVUAorICAgICAgICBiZWZvcmUgcmVwb3J0aW5nIGl0 cyBtZW1vcnkgY29zdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0NvbmNyZXRlSW1h Z2VCdWZmZXIuaDoKKwogMjAyMS0wMy0xMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlZHVjZSBtYXhpbXVtIEhhc2hUYWJsZSBlbnRyeSBz aXplIHRvIDQwMCBieXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvQ29uY3JldGVJbWFnZUJ1ZmZlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvQ29uY3JldGVJbWFnZUJ1ZmZlci5oCmluZGV4IDM0OWI0NWFlOWQ4ZjRlNzA1MDY0NTBk ODlkZThjZDRmODA4OThjMDUuLjNhNTExNGI3MzIwYjdjOTBkOTIwNDk3NmNlNDAyZmYwMDhlZTU3 YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbmNyZXRl SW1hZ2VCdWZmZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db25j cmV0ZUltYWdlQnVmZmVyLmgKQEAgLTExMSwxMiArMTExLDE2IEBAIHByb3RlY3RlZDoKIAogICAg IHNpemVfdCBtZW1vcnlDb3N0KCkgY29uc3Qgb3ZlcnJpZGUKICAgICB7Ci0gICAgICAgIHJldHVy biBtX2JhY2tlbmQgPyBtX2JhY2tlbmQtPm1lbW9yeUNvc3QoKSA6IDA7CisgICAgICAgIGlmIChh dXRvKiBiYWNrZW5kID0gZW5zdXJlQmFja2VuZENyZWF0ZWQoKSkKKyAgICAgICAgICAgIHJldHVy biBtX2JhY2tlbmQtPm1lbW9yeUNvc3QoKTsKKyAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogCiAg ICAgc2l6ZV90IGV4dGVybmFsTWVtb3J5Q29zdCgpIGNvbnN0IG92ZXJyaWRlCiAgICAgewotICAg ICAgICByZXR1cm4gbV9iYWNrZW5kID8gbV9iYWNrZW5kLT5leHRlcm5hbE1lbW9yeUNvc3QoKSA6 IDA7CisgICAgICAgIGlmIChhdXRvKiBiYWNrZW5kID0gZW5zdXJlQmFja2VuZENyZWF0ZWQoKSkK KyAgICAgICAgICAgIHJldHVybiBtX2JhY2tlbmQtPmV4dGVybmFsTWVtb3J5Q29zdCgpOworICAg ICAgICByZXR1cm4gMDsKICAgICB9CiAKICAgICBSZWZQdHI8TmF0aXZlSW1hZ2U+IGNvcHlOYXRp dmVJbWFnZShCYWNraW5nU3RvcmVDb3B5IGNvcHlCZWhhdmlvciA9IENvcHlCYWNraW5nU3RvcmUp IGNvbnN0IG92ZXJyaWRlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2QzYWQ0MmVhYjVhMGRhMzVhMDg4NzE5ODQ4NGVkZWZh ZTRlZDcwMi4uYzgwZGZhOWZhZjE5OTQyZTIwNjk3MThkNjNkZjNhMmVhNzhiZjk0MSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDIxLTAzLTEyICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhaWRAYXBw bGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10gaW5zcGVjdG9yL2NhbnZhcy9tZW1vcnku aHRtbCBmYWlscyB3aGVuIEdQVSByZW5kZXJpbmcgaXMgZW5hYmxlZCBmb3IgMkQgQ2FudmFzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI4ODAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgR1BV UCByZW5kZXJpbmcgZm9yIDJEIGNhbnZhcyBmb3IgdGhpcyB0ZXN0LgorCisgICAgICAgICogaW5z cGVjdG9yL2NhbnZhcy9tZW1vcnkuaHRtbDoKKwogMjAyMS0wMy0xMiAgUm9iZXJ0IEplbm5lciAg PGplbm5lckBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY09TIHdrMl0gaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9tZWRpYS1zb3VyY2UvU291cmNlQnVmZmVyLWFib3J0LXVwZGF0aW5n Lmh0bWwgaXMgYSBmbGFrZXkgZmFpbHVyZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVj dG9yL2NhbnZhcy9tZW1vcnkuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52YXMvbWVt b3J5Lmh0bWwKaW5kZXggMGI5OGQyNzRiMmU2ZTQ3MjNjOTIwNzQ3ZDZiZGY1ZTg3YjMxMWIwNy4u NTA4Yjg3ZGYxZTJmYmQ3YzVkZGVlOGZlYTg1MTM4NzA5NmI3OWI2YyAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2NhbnZhcy9tZW1vcnkuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9p bnNwZWN0b3IvY2FudmFzL21lbW9yeS5odG1sCkBAIC0xLDQgKzEsMyBAQAotPCEtLSB3ZWJraXQt dGVzdC1ydW5uZXIgWyBVc2VHUFVQcm9jZXNzRm9yQ2FudmFzUmVuZGVyaW5nRW5hYmxlZD1mYWxz ZSBdIC0tPgogPCFET0NUWVBFIGh0bWw+CiA8aHRtbD4KIDxoZWFkPgo= 423082 2021-03-12 14:29:10 -0800 2021-03-12 15:46:28 -0800 Patch bug-222880-20210312142910.patch text/plain 2959 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTFhY2VjMzE1M2UxNjY1 YTczNGVkZTIyOWUyZjdhZTljOTIwYThjMy4uY2JjMDE5NmQ3MmJlOGQ0NGMwMDJjYmJmZjg0NGY1 Mzg4Y2Y3ZGExYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTAzLTEyICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g aW5zcGVjdG9yL2NhbnZhcy9tZW1vcnkuaHRtbCBmYWlscyB3aGVuIEdQVSByZW5kZXJpbmcgaXMg ZW5hYmxlZCBmb3IgMkQgQ2FudmFzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjI4ODAKKworICAgICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uLgor CisgICAgICAgIFJlbW90ZUltYWdlQnVmZmVyUHJveHkgaGFzIHRvIGVuc3VyZSBpdHMgYmFja2Vu ZCBpcyBjcmVhdGVkIGluIHRoZSBHUFVQCisgICAgICAgIGJlZm9yZSByZXBvcnRpbmcgaXRzIG1l bW9yeSBjb3N0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvQ29uY3JldGVJbWFnZUJ1 ZmZlci5oOgorCiAyMDIxLTAzLTEyICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtzZWxlY3RvcnNdIDpmb2N1cy12aXNpYmxlIG1hdGNoZXMgYm9k eSBhZnRlciBrZXlib2FyZCBldmVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvQ29uY3JldGVJbWFnZUJ1ZmZlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvQ29uY3JldGVJbWFnZUJ1ZmZlci5oCmluZGV4IDM0OWI0NWFlOWQ4ZjRlNzA1 MDY0NTBkODlkZThjZDRmODA4OThjMDUuLjNhNTExNGI3MzIwYjdjOTBkOTIwNDk3NmNlNDAyZmYw MDhlZTU3YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Nv bmNyZXRlSW1hZ2VCdWZmZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9Db25jcmV0ZUltYWdlQnVmZmVyLmgKQEAgLTExMSwxMiArMTExLDE2IEBAIHByb3RlY3RlZDoK IAogICAgIHNpemVfdCBtZW1vcnlDb3N0KCkgY29uc3Qgb3ZlcnJpZGUKICAgICB7Ci0gICAgICAg IHJldHVybiBtX2JhY2tlbmQgPyBtX2JhY2tlbmQtPm1lbW9yeUNvc3QoKSA6IDA7CisgICAgICAg IGlmIChhdXRvKiBiYWNrZW5kID0gZW5zdXJlQmFja2VuZENyZWF0ZWQoKSkKKyAgICAgICAgICAg IHJldHVybiBtX2JhY2tlbmQtPm1lbW9yeUNvc3QoKTsKKyAgICAgICAgcmV0dXJuIDA7CiAgICAg fQogCiAgICAgc2l6ZV90IGV4dGVybmFsTWVtb3J5Q29zdCgpIGNvbnN0IG92ZXJyaWRlCiAgICAg ewotICAgICAgICByZXR1cm4gbV9iYWNrZW5kID8gbV9iYWNrZW5kLT5leHRlcm5hbE1lbW9yeUNv c3QoKSA6IDA7CisgICAgICAgIGlmIChhdXRvKiBiYWNrZW5kID0gZW5zdXJlQmFja2VuZENyZWF0 ZWQoKSkKKyAgICAgICAgICAgIHJldHVybiBtX2JhY2tlbmQtPmV4dGVybmFsTWVtb3J5Q29zdCgp OworICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKICAgICBSZWZQdHI8TmF0aXZlSW1hZ2U+IGNv cHlOYXRpdmVJbWFnZShCYWNraW5nU3RvcmVDb3B5IGNvcHlCZWhhdmlvciA9IENvcHlCYWNraW5n U3RvcmUpIGNvbnN0IG92ZXJyaWRlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzBhNDVlYTFjN2Y2YTYyNTE3Nzk0ZGQwY2My MDJlNjU0NDhkOWVhOC4uOGZiZTAwYzhmMDVlZmJkYWY2ZmQ1NDkwMzVmZjJjMzU1OTIzMjAyMCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTAzLTEyICBTYWlkIEFib3UtSGFsbGF3YSAgPHNh aWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10gaW5zcGVjdG9yL2NhbnZhcy9t ZW1vcnkuaHRtbCBmYWlscyB3aGVuIEdQVSByZW5kZXJpbmcgaXMgZW5hYmxlZCBmb3IgMkQgQ2Fu dmFzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI4 ODAKKworICAgICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAgIEVuYWJsZSBH UFVQIHJlbmRlcmluZyBmb3IgMkQgY2FudmFzIGZvciB0aGlzIHRlc3QuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvY2FudmFzL21lbW9yeS5odG1sOgorCiAyMDIxLTAzLTEyICBSb2JlcnQgSmVubmVy ICA8amVubmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBbIE1hY09TIHdrMiBdIGluc3BlY3Rvci9k ZWJ1Z2dlci9icmVha3BvaW50cy9yZXNvbHZlZC1kdW1wLWFsbC1pbmxpbmUtc2NyaXB0LXBhdXNl LWxvY2F0aW9ucy5odG1sIGlzIGZsYWtleSB0aW1pbmcgb3V0CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvY2FudmFzL21lbW9yeS5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9y L2NhbnZhcy9tZW1vcnkuaHRtbAppbmRleCAwYjk4ZDI3NGIyZTZlNDcyM2M5MjA3NDdkNmJkZjVl ODdiMzExYjA3Li41MDhiODdkZjFlMmZiZDdjNWRkZWU4ZmVhODUxMzg3MDk2Yjc5YjZjIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL21lbW9yeS5odG1sCisrKyBiL0xh eW91dFRlc3RzL2luc3BlY3Rvci9jYW52YXMvbWVtb3J5Lmh0bWwKQEAgLTEsNCArMSwzIEBACi08 IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIFVzZUdQVVByb2Nlc3NGb3JDYW52YXNSZW5kZXJpbmdF bmFibGVkPWZhbHNlIF0gLS0+CiA8IURPQ1RZUEUgaHRtbD4KIDxodG1sPgogPGhlYWQ+Cg==