222846 2021-03-05 18:52:22 -0800 git-webkit should have an "info" command 2021-03-10 09:02:03 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215862 InRadar P2 Normal --- 1 rniwa jbedard aakash_jain bdakin dewei_zhu ggaren jbedard webkit-bug-importer oldest_to_newest 1736704 0 rniwa 2021-03-05 18:52:22 -0800 We need "git-webkit info" that behaves like "svn info" and show the last commit identifier. 1737090 1 webkit-bug-importer 2021-03-08 08:27:02 -0800 <rdar://problem/75171053> 1737091 2 jbedard 2021-03-08 08:30:11 -0800 Does `Tools/Scripts/git-webkit find HEAD` get you the information you want? My inclination is to make an "info" command that is essentially an alias to that. 1737432 3 rniwa 2021-03-08 19:08:14 -0800 (In reply to Jonathan Bedard from comment #2) > Does `Tools/Scripts/git-webkit find HEAD` get you the information you want? > My inclination is to make an "info" command that is essentially an alias to > that. Sure, that works for me but can we reorder so that the identifier appears at the end? It's sort of buried between author name, date, etc... right now. I want it to stand out and showing at the end will do. 1737694 4 422740 jbedard 2021-03-09 12:13:06 -0800 Created attachment 422740 Patch 1737695 5 jbedard 2021-03-09 12:14:22 -0800 I will do the re-order in a separate change, the original order was somewhat arbitrary anyways. 1737955 6 422740 rniwa 2021-03-09 22:46:51 -0800 Comment on attachment 422740 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422740&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:34 > +class Info(Command): > + name = 'info' > + help = 'Print information about the HEAD commit' This seems a bit backwards? Why not define info in terms of find instead? 1738059 7 jbedard 2021-03-10 07:45:06 -0800 (In reply to Ryosuke Niwa from comment #6) > Comment on attachment 422740 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=422740&action=review > > > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:34 > > +class Info(Command): > > + name = 'info' > > + help = 'Print information about the HEAD commit' > > This seems a bit backwards? Why not define info in terms of find instead? Was my thought originally too, but you don't have a great way to strip the ref argument when constructing the argparser, it makes more sense to add it. 1738060 8 ews-feeder 2021-03-10 07:49:06 -0800 Committed r274214: <https://commits.webkit.org/r274214> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422740. 422740 2021-03-09 12:13:06 -0800 2021-03-10 09:02:03 -0800 Patch bug-222846-20210309121305.patch text/plain 7051 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NDE2NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI0IEBACisyMDIxLTAzLTA5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBnaXQtd2Via2l0IHNob3VsZCBoYXZlIGFuICJpbmZvIiBjb21tYW5kCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI4NDYKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc1MTcxMDUzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkv c2V0dXAucHk6IEJ1bXAgdmVyc2lvbi4KKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJr aXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weTogRGl0dG8uCisgICAgICAgICogU2NyaXB0 cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvcHJvZ3JhbS9fX2luaXRfXy5weToK KyAgICAgICAgKG1haW4pOiBBZGQgSW5mbyBjb21tYW5kLgorICAgICAgICAqIFNjcmlwdHMvbGli cmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Byb2dyYW0vZmluZC5weToKKyAgICAgICAg KEluZm8pOgorICAgICAgICAoSW5mby5wYXJzZXIpOiBNb3ZlZCBmcm9tIEZpbmQucGFyc2VyLCBl eGNsdWRlIGFyZ3VtZW50LgorICAgICAgICAoSW5mby5tYWluKTogTW92ZWQgZnJvbSBGaW5kLm1h aW4sIGFkZCBhIGRlZmF1bHQgcmVmZXJlbmNlLgorICAgICAgICAoRmluZCk6CisgICAgICAgIChG aW5kLnBhcnNlcik6IEludm9rZSBJbmZvLnBhcnNlci4KKyAgICAgICAgKEZpbmQubWFpbik6IElu dm9rZSBJbmZvLm1haW4gd2l0aCB1c2VyJ3Mgc3BlY2lmaWVkIHJlZmVyZW5jZS4KKyAgICAgICAg KiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS90ZXN0L2ZpbmRfdW5p dHRlc3QucHk6CisKIDIwMjEtMDMtMDkgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgog CiAgICAgICAgIFVzZSAtLXZlcmlmeUdDPXRydWUgb24gc29tZSBKU0Mgc3RyZXNzIHRlc3QgY29u ZmlndXJhdGlvbnMuCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS9z ZXR1cC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21w eS9zZXR1cC5weQkocmV2aXNpb24gMjc0MTYyKQorKysgVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMv d2Via2l0c2NtcHkvc2V0dXAucHkJKHdvcmtpbmcgY29weSkKQEAgLTI5LDcgKzI5LDcgQEAgZGVm IHJlYWRtZSgpOgogCiBzZXR1cCgKICAgICBuYW1lPSd3ZWJraXRzY21weScsCi0gICAgdmVyc2lv bj0nMC4xMi41JywKKyAgICB2ZXJzaW9uPScwLjEzLjAnLAogICAgIGRlc2NyaXB0aW9uPSdMaWJy YXJ5IGRlc2lnbmVkIHRvIGludGVyYWN0IHdpdGggZ2l0IGFuZCBzdm4gcmVwb3NpdG9yaWVzLics CiAgICAgbG9uZ19kZXNjcmlwdGlvbj1yZWFkbWUoKSwKICAgICBjbGFzc2lmaWVycz1bCkluZGV4 OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRf Xy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93 ZWJraXRzY21weS9fX2luaXRfXy5weQkocmV2aXNpb24gMjc0MTYyKQorKysgVG9vbHMvU2NyaXB0 cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkJKHdvcmtpbmcg Y29weSkKQEAgLTQ2LDcgKzQ2LDcgQEAgZXhjZXB0IEltcG9ydEVycm9yOgogICAgICAgICAiUGxl YXNlIGluc3RhbGwgd2Via2l0Y29yZXB5IHdpdGggYHBpcCBpbnN0YWxsIHdlYmtpdGNvcmVweSAt LWV4dHJhLWluZGV4LXVybCA8cGFja2FnZSBpbmRleCBVUkw+YCIKICAgICApCiAKLXZlcnNpb24g PSBWZXJzaW9uKDAsIDEyLCA1KQordmVyc2lvbiA9IFZlcnNpb24oMCwgMTMsIDApCiAKIEF1dG9J bnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ2Zhc3RlbmVycycsIFZlcnNpb24oMCwgMTUsIDApKSkK IEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ21vbm90b25pYycsIFZlcnNpb24oMSwgNSkp KQpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkv cHJvZ3JhbS9fX2luaXRfXy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmll cy93ZWJraXRzY21weS93ZWJraXRzY21weS9wcm9ncmFtL19faW5pdF9fLnB5CShyZXZpc2lvbiAy NzQxNjIpCisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21w eS9wcm9ncmFtL19faW5pdF9fLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMSw3ICszMSw3IEBAIGZy b20gLmNhbm9uaWNhbGl6ZSBpbXBvcnQgQ2Fub25pY2FsaXplCiBmcm9tIC5jbGVhbiBpbXBvcnQg Q2xlYW4KIGZyb20gLmNvbW1hbmQgaW1wb3J0IENvbW1hbmQKIGZyb20gLmNoZWNrb3V0IGltcG9y dCBDaGVja291dAotZnJvbSAuZmluZCBpbXBvcnQgRmluZAorZnJvbSAuZmluZCBpbXBvcnQgRmlu ZCwgSW5mbwogZnJvbSAucHVsbCBpbXBvcnQgUHVsbAogZnJvbSAuc2V0dXBfZ2l0X3N2biBpbXBv cnQgU2V0dXBHaXRTdm4KIApAQCAtNTcsNyArNTcsNyBAQCBkZWYgbWFpbihhcmdzPU5vbmUsIHBh dGg9Tm9uZSwgbG9nZ2Vycz1OCiAKICAgICBzdWJwYXJzZXJzID0gcGFyc2VyLmFkZF9zdWJwYXJz ZXJzKGhlbHA9J3N1Yi1jb21tYW5kIGhlbHAnKQogCi0gICAgcHJvZ3JhbXMgPSBbRmluZCwgQ2hl Y2tvdXQsIENhbm9uaWNhbGl6ZSwgUHVsbCwgQ2xlYW5dCisgICAgcHJvZ3JhbXMgPSBbRmluZCwg SW5mbywgQ2hlY2tvdXQsIENhbm9uaWNhbGl6ZSwgUHVsbCwgQ2xlYW5dCiAgICAgaWYgc3VidmVy c2lvbjoKICAgICAgICAgcHJvZ3JhbXMuYXBwZW5kKFNldHVwR2l0U3ZuKQogCkluZGV4OiBUb29s cy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9wcm9ncmFtL2ZpbmQu cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Vi a2l0c2NtcHkvcHJvZ3JhbS9maW5kLnB5CShyZXZpc2lvbiAyNzQxNjIpCisrKyBUb29scy9TY3Jp cHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9wcm9ncmFtL2ZpbmQucHkJKHdv cmtpbmcgY29weSkKQEAgLTI5LDkgKzI5LDkgQEAgZnJvbSB3ZWJraXRjb3JlcHkgaW1wb3J0IGFy Z3VtZW50cwogZnJvbSB3ZWJraXRzY21weSBpbXBvcnQgQ29tbWl0LCBsb2NhbAogCiAKLWNsYXNz IEZpbmQoQ29tbWFuZCk6Ci0gICAgbmFtZSA9ICdmaW5kJwotICAgIGhlbHAgPSAnR2l2ZW4gYW4g aWRlbnRpZmllciwgcmV2aXNpb24gb3IgaGFzaCwgbm9ybWFsaXplIGFuZCBwcmludCB0aGUgY29t bWl0JworY2xhc3MgSW5mbyhDb21tYW5kKToKKyAgICBuYW1lID0gJ2luZm8nCisgICAgaGVscCA9 ICdQcmludCBpbmZvcm1hdGlvbiBhYm91dCB0aGUgSEVBRCBjb21taXQnCiAKICAgICBAY2xhc3Nt ZXRob2QKICAgICBkZWYgcGFyc2VyKGNscywgcGFyc2VyLCBsb2dnZXJzPU5vbmUpOgpAQCAtNTUs MTYgKzU1LDEwIEBAIGNsYXNzIEZpbmQoQ29tbWFuZCk6CiAgICAgICAgICAgICBkZWZhdWx0PVRy dWUsCiAgICAgICAgICkKIAotICAgICAgICBwYXJzZXIuYWRkX2FyZ3VtZW50KAotICAgICAgICAg ICAgJ2FyZ3VtZW50JywgbmFyZ3M9MSwKLSAgICAgICAgICAgIHR5cGU9c3RyLCBkZWZhdWx0PU5v bmUsCi0gICAgICAgICAgICBoZWxwPSdTdHJpbmcgcmVwcmVzZW50YXRpb24gb2YgYSBjb21taXQg b3IgYnJhbmNoIHRvIGJlIG5vcm1hbGl6ZWQnLAotICAgICAgICApCi0KICAgICBAY2xhc3NtZXRo b2QKLSAgICBkZWYgbWFpbihjbHMsIGFyZ3MsIHJlcG9zaXRvcnksICoqa3dhcmdzKToKKyAgICBk ZWYgbWFpbihjbHMsIGFyZ3MsIHJlcG9zaXRvcnksIHJlZmVyZW5jZT0nSEVBRCcsICoqa3dhcmdz KToKICAgICAgICAgdHJ5OgotICAgICAgICAgICAgY29tbWl0ID0gcmVwb3NpdG9yeS5maW5kKGFy Z3MuYXJndW1lbnRbMF0sIGluY2x1ZGVfbG9nPWFyZ3MuaW5jbHVkZV9sb2cpCisgICAgICAgICAg ICBjb21taXQgPSByZXBvc2l0b3J5LmZpbmQocmVmZXJlbmNlLCBpbmNsdWRlX2xvZz1hcmdzLmlu Y2x1ZGVfbG9nKQogICAgICAgICBleGNlcHQgKGxvY2FsLlNjbS5FeGNlcHRpb24sIFZhbHVlRXJy b3IpIGFzIGV4Y2VwdGlvbjoKICAgICAgICAgICAgICMgVmFsdWVFcnJvcnMgYW5kIFNjbSBleGNl cHRpb25zIHVzdWFsbHkgY29udGFpbiBlbm91Z2ggaW5mb3JtYXRpb24gdG8gYmUgZGlzcGxheWVk CiAgICAgICAgICAgICAjIHRvIHRoZSB1c2VyIGFzIGFuIGVycm9yCkBAIC0xMDMsMyArOTcsMjIg QEAgY2xhc3MgRmluZChDb21tYW5kKToKICAgICAgICAgICAgICAgICBwcmludCh1JyAgICB7fScu Zm9ybWF0KGxpbmUpKQogCiAgICAgICAgIHJldHVybiAwCisKKworY2xhc3MgRmluZChDb21tYW5k KToKKyAgICBuYW1lID0gJ2ZpbmQnCisgICAgaGVscCA9ICdHaXZlbiBhbiBpZGVudGlmaWVyLCBy ZXZpc2lvbiBvciBoYXNoLCBub3JtYWxpemUgYW5kIHByaW50IHRoZSBjb21taXQnCisKKyAgICBA Y2xhc3NtZXRob2QKKyAgICBkZWYgcGFyc2VyKGNscywgcGFyc2VyLCBsb2dnZXJzPU5vbmUpOgor ICAgICAgICBJbmZvLnBhcnNlcihwYXJzZXIsIGxvZ2dlcnM9bG9nZ2VycykKKworICAgICAgICBw YXJzZXIuYWRkX2FyZ3VtZW50KAorICAgICAgICAgICAgJ2FyZ3VtZW50JywgbmFyZ3M9MSwKKyAg ICAgICAgICAgIHR5cGU9c3RyLCBkZWZhdWx0PU5vbmUsCisgICAgICAgICAgICBoZWxwPSdTdHJp bmcgcmVwcmVzZW50YXRpb24gb2YgYSBjb21taXQgb3IgYnJhbmNoIHRvIGJlIG5vcm1hbGl6ZWQn LAorICAgICAgICApCisKKyAgICBAY2xhc3NtZXRob2QKKyAgICBkZWYgbWFpbihjbHMsIGFyZ3Ms IHJlcG9zaXRvcnksICoqa3dhcmdzKToKKyAgICAgICAgcmV0dXJuIEluZm8ubWFpbihhcmdzLCBy ZXBvc2l0b3J5PXJlcG9zaXRvcnksIHJlZmVyZW5jZT1hcmdzLmFyZ3VtZW50WzBdLCAqKmt3YXJn cykKSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5 L3Rlc3QvZmluZF91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJh cmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS90ZXN0L2ZpbmRfdW5pdHRlc3QucHkJKHJldmlz aW9uIDI3NDE2MikKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtp dHNjbXB5L3Rlc3QvZmluZF91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMjMzLDMgKzIz MywzMSBAQCBEYXRlOiB7fQogUmV2aXNpb246IDQKICcnJy5mb3JtYXQoZGF0ZXRpbWUuZnJvbXRp bWVzdGFtcCgxNjAxNjg2NzAwKS5zdHJmdGltZSgnJWEgJWIgJWQgJUg6JU06JVMgJVknKSksCiAg ICAgICAgICkKKworCitjbGFzcyBUZXN0SW5mbyh1bml0dGVzdC5UZXN0Q2FzZSk6CisgICAgcGF0 aCA9ICcvbW9jay9yZXBvc2l0b3J5JworCisgICAgZGVmIHRlc3RfYmFzaWNfZ2l0KHNlbGYpOgor ICAgICAgICB3aXRoIE91dHB1dENhcHR1cmUoKSBhcyBjYXB0dXJlZCwgbW9ja3MubG9jYWwuR2l0 KHNlbGYucGF0aCksIG1vY2tzLmxvY2FsLlN2bigpLCBNb2NrVGltZToKKyAgICAgICAgICAgIHNl bGYuYXNzZXJ0RXF1YWwoMCwgcHJvZ3JhbS5tYWluKAorICAgICAgICAgICAgICAgIGFyZ3M9KCdp bmZvJywgJy1xJyksCisgICAgICAgICAgICAgICAgcGF0aD1zZWxmLnBhdGgsCisgICAgICAgICAg ICApKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGNhcHR1cmVkLnN0ZG91dC5nZXR2YWx1ZSgp LCAnNUBtYWluIHwgZDhiY2UyNmZhNjVjIHwgUGF0Y2ggU2VyaWVzXG4nKQorCisgICAgZGVmIHRl c3RfYmFzaWNfZ2l0X3N2bihzZWxmKToKKyAgICAgICAgd2l0aCBPdXRwdXRDYXB0dXJlKCkgYXMg Y2FwdHVyZWQsIG1vY2tzLmxvY2FsLkdpdChzZWxmLnBhdGgsIGdpdF9zdm49VHJ1ZSksIG1vY2tz LmxvY2FsLlN2bigpLCBNb2NrVGltZToKKyAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoMCwg cHJvZ3JhbS5tYWluKAorICAgICAgICAgICAgICAgIGFyZ3M9KCdpbmZvJywgJy1xJyksCisgICAg ICAgICAgICAgICAgcGF0aD1zZWxmLnBhdGgsCisgICAgICAgICAgICApKQorICAgICAgICBzZWxm LmFzc2VydEVxdWFsKGNhcHR1cmVkLnN0ZG91dC5nZXR2YWx1ZSgpLCAnNUBtYWluIHwgZDhiY2Uy NmZhNjVjLCByOSB8IFBhdGNoIFNlcmllc1xuJykKKworICAgIGRlZiB0ZXN0X2Jhc2ljX3N2bihz ZWxmKToKKyAgICAgICAgd2l0aCBPdXRwdXRDYXB0dXJlKCkgYXMgY2FwdHVyZWQsIG1vY2tzLmxv Y2FsLkdpdCgpLCBtb2Nrcy5sb2NhbC5Tdm4oc2VsZi5wYXRoKSwgTW9ja1RpbWU6CisgICAgICAg ICAgICBzZWxmLmFzc2VydEVxdWFsKDAsIHByb2dyYW0ubWFpbigKKyAgICAgICAgICAgICAgICBh cmdzPSgnaW5mbycsICctcScpLAorICAgICAgICAgICAgICAgIHBhdGg9c2VsZi5wYXRoLAorICAg ICAgICAgICAgKSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChjYXB0dXJlZC5zdGRvdXQuZ2V0 dmFsdWUoKSwgJzRAdHJ1bmsgfCByNiB8IDZ0aCBjb21taXRcbicpCg==