222823 2021-03-05 13:52:32 -0800 REGRESSION: [iOS] http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode.html is failing 2021-03-08 09:27:20 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221784 InRadar P2 Normal --- 1 ryanhaddad cgambrell cgambrell darin jbedard webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1736524 0 ryanhaddad 2021-03-05 13:52:32 -0800 http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode.html is failing on iOS bots: --- /Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/layout-test-results/http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode-expected.txt +++ /Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/layout-test-results/http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode-actual.txt @@ -12,4 +12,8 @@ -------- Frame: '<!--frame1-->' -------- -http://127.0.0.1:8000/ +Not Found + +The requested URL was not found on this server. + +Apache/2.4.41 (Unix) PHP/7.3.11 LibreSSL/2.8.3 Server at 127.0.0.1 Port 80 https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fsecurity%2Fstrip-referrer-to-origin-for-third-party-redirects-in-private-mode.html 1736525 1 ryanhaddad 2021-03-05 13:53:13 -0800 I think this broke with the PHP -> Python conversion in https://trac.webkit.org/changeset/272981/webkit 1736526 2 ryanhaddad 2021-03-05 13:53:54 -0800 EWS missed this because the test is marked as a flaky timeout, so it was skipped. 1736556 3 jbedard 2021-03-05 14:35:26 -0800 I'll look into this Monday. Seems likely to do with 'allowCache'. 1736617 4 422446 cgambrell 2021-03-05 15:51:33 -0800 Created attachment 422446 Patch for EWS 1736618 5 422446 darin 2021-03-05 15:55:13 -0800 Comment on attachment 422446 Patch for EWS View in context: https://bugs.webkit.org/attachment.cgi?id=422446&action=review > LayoutTests/ChangeLog:9 > + * http/tests/resources/redirect.py: > + (addCacheControl): Normally we explain what we changed and why it fixes the bug. 1736628 6 422446 ryanhaddad 2021-03-05 16:09:26 -0800 Comment on attachment 422446 Patch for EWS Not yet ready for review. 1736636 7 422446 jbedard 2021-03-05 16:13:42 -0800 Comment on attachment 422446 Patch for EWS View in context: https://bugs.webkit.org/attachment.cgi?id=422446&action=review > LayoutTests/http/tests/resources/redirect.py:33 > sys.exit(0) This looks wrong. 1736671 8 422456 cgambrell 2021-03-05 17:14:35 -0800 Created attachment 422456 Patch 1736675 9 422456 cgambrell 2021-03-05 17:18:28 -0800 Comment on attachment 422456 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422456&action=review > LayoutTests/http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode.html:-30 > - openIframe("resources/redirect.py?redirectTo=http://localhost:8000/security/resources/echo-referrer.php", finishJSTest); "resources/redirect.py" was thought to be referencing LayoutTests/http/tests/resources/redirect.py when in actuality it was referencing LayoutTests/http/tests/security/resources/redirect.py which does not exist. Corrected back to "resources/redirect.php" 1736802 10 webkit-bug-importer 2021-03-06 08:10:52 -0800 <rdar://problem/75133450> 1737087 11 422571 cgambrell 2021-03-08 08:22:27 -0800 Created attachment 422571 Patch 1737118 12 ews-feeder 2021-03-08 09:27:18 -0800 Committed r274075: <https://commits.webkit.org/r274075> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422571. 422446 2021-03-05 15:51:33 -0800 2021-03-05 17:14:32 -0800 Patch for EWS bug-222823-20210305185131.patch text/plain 2600 cgambrell SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI3NDAxMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIxLTAzLTA1ICBDaHJpcyBHYW1icmVsbCAg PGNnYW1icmVsbEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW2lPU10gaHR0cC90 ZXN0cy9zZWN1cml0eS9zdHJpcC1yZWZlcnJlci10by1vcmlnaW4tZm9yLXRoaXJkLXBhcnR5LXJl ZGlyZWN0cy1pbi1wcml2YXRlLW1vZGUuaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI4MjMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvcmVzb3VyY2VzL3Jl ZGlyZWN0LnB5OgorICAgICAgICAoYWRkQ2FjaGVDb250cm9sKToKKwogMjAyMS0wMy0wNSAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgW1BheW1lbnQgUmVxdWVz dF0gaWYgYHJlcXVlc3RTaGlwcGluZzogZmFsc2VgIHRoZW4gd2Ugc2hvdWxkIG5vdCBzaG93IGFu eSBgUGF5bWVudFNoaXBwaW5nT3B0aW9uYCBpbiB0aGUgQXBwbGUgUGF5IHNoZWV0CkluZGV4OiBM YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3Jlc291cmNlcy9yZWRpcmVjdC5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3Jlc291cmNlcy9yZWRpcmVjdC5weQkocmV2aXNpb24g Mjc0MDA2KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9yZXNvdXJjZXMvcmVkaXJlY3QucHkJ KHdvcmtpbmcgY29weSkKQEAgLTEsMjggKzEsMjEgQEAKICMhL3Vzci9iaW4vZW52IHB5dGhvbjMK KwogaW1wb3J0IG9zCiBpbXBvcnQgc3lzCitmcm9tIHVybGxpYi5wYXJzZSBpbXBvcnQgcGFyc2Vf cXMKIAotZnJvbSB1cmxsaWIucGFyc2UgaW1wb3J0IHVucXVvdGUKLQotCi1kZWYgYWRkQ2FjaGVD b250cm9sKGFsbG93Q2FjaGU9VHJ1ZSk6CitkZWYgYWRkQ2FjaGVDb250cm9sKGFsbG93Q2FjaGUp OgogICAgIGlmIGFsbG93Q2FjaGU6Ci0gICAgICAgIHN5cy5zdGRvdXQud3JpdGUoJ0NhY2hlLUNv bnRyb2w6IHB1YmxpYywgbWF4LWFnZT04NjQwMFxyXG4nKQorICAgICAgICBzeXMuc3Rkb3V0Lndy aXRlKCdDYWNoZS1Db250cm9sOiBwdWJsaWMsIG1heC1hZ2U9ODY0MDBcclxuXHJcbicpCiAgICAg ZWxzZToKLSAgICAgICAgc3lzLnN0ZG91dC53cml0ZSgnQ2FjaGUtQ29udHJvbDogbm8tc3RvcmVc clxuJykKKyAgICAgICAgc3lzLnN0ZG91dC53cml0ZSgnQ2FjaGUtQ29udHJvbDogbm8tc3RvcmVc clxuXHJcbicpCiAKLXN5cy5zdGRvdXQud3JpdGUoJ0NvbnRlbnQtVHlwZTogdGV4dC9odG1sXHJc bicpCitxdWVyeSA9IHBhcnNlX3FzKG9zLmVudmlyb24uZ2V0KCdRVUVSWV9TVFJJTkcnLCAnJyks IGtlZXBfYmxhbmtfdmFsdWVzPVRydWUpCit1cmwgPSBxdWVyeS5nZXQoJ3VybCcsIFsnJ10pWzBd CityZWZyZXNoID0gcXVlcnkuZ2V0KCdyZWZyZXNoJywgWycnXSlbMF0KK2NvZGUgPSBpbnQocXVl cnkuZ2V0KCdjb2RlJywgWzMwMl0pWzBdKQogCi1xdWVyeSA9IHt9Ci1mb3IgcGFydCBpbiBvcy5l bnZpcm9uLmdldCgnUVVFUllfU1RSSU5HJywgJycpLnNwbGl0KCcmJyk6Ci0gICAgaWYgbm90IHBh cnQ6Ci0gICAgICAgIGNvbnRpbnVlCi0gICAgcXVlcnlbcGFydC5zcGxpdCgnPScpWzBdXSA9ICc9 Jy5qb2luKHBhcnQuc3BsaXQoJz0nKVsxOl0pCi0KLXVybCA9IHVucXVvdGUocXVlcnkuZ2V0KCd1 cmwnLCBOb25lKSkKLWFsbG93Q2FjaGUgPSBUcnVlIGlmIHF1ZXJ5LmdldCgnYWxsb3dDYWNoZScs IE5vbmUpIGlzIG5vdCBOb25lIGVsc2UgRmFsc2UKLXJlZnJlc2ggPSBxdWVyeS5nZXQoJ3JlZnJl c2gnLCBOb25lKQotY29kZSA9IHF1ZXJ5LmdldCgnY29kZScsICczMDInKQorYWxsb3dDYWNoZSA9 IFRydWUgaWYgcXVlcnkuZ2V0KCdhbGxvd0NhY2hlJywgW05vbmVdKVswXSBpcyBub3QgTm9uZSBl bHNlIEZhbHNlCiAKIGlmIHJlZnJlc2g6CiAgICAgc3lzLnN0ZG91dC53cml0ZSgKQEAgLTMwLDcg KzIzLDEzIEBAIGlmIHJlZnJlc2g6CiAgICAgICAgICdSZWZyZXNoOiB7fTsgdXJsPXt9XHJcbicu Zm9ybWF0KHJlZnJlc2gsIHVybCkKICAgICApCiAgICAgYWRkQ2FjaGVDb250cm9sKGFsbG93Q2Fj aGUpCi0gICAgc3lzLnN0ZG91dC53cml0ZSgnXHJcbicpCisgICAgc3lzLmV4aXQoMCkKKworc3lz LnN0ZG91dC53cml0ZSgKKyAgICAnc3RhdHVzOiB7fVxyXG4nCisgICAgJ0xvY2F0aW9uOiB7fVxy XG4nLmZvcm1hdChzdGF0dXMsIHVybCkKKykKK2FkZENhY2hlQ29udHJvbChhbGxvd0NhY2hlKSBz eXMuc3Rkb3V0LndyaXRlKCdcclxuJykKICAgICBzeXMuZXhpdCgwKQogCiBzeXMuc3Rkb3V0Lndy aXRlKCdzdGF0dXM6IHt9XHJcbicuZm9ybWF0KGNvZGUpKQo= 422456 2021-03-05 17:14:35 -0800 2021-03-08 08:22:24 -0800 Patch bug-222823-20210305201434.patch text/plain 1639 cgambrell SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI3NDAyMSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDIxLTAzLTA1ICBDaHJpcyBHYW1icmVsbCAg PGNnYW1icmVsbEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW2lPU10gaHR0cC90 ZXN0cy9zZWN1cml0eS9zdHJpcC1yZWZlcnJlci10by1vcmlnaW4tZm9yLXRoaXJkLXBhcnR5LXJl ZGlyZWN0cy1pbi1wcml2YXRlLW1vZGUuaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI4MjMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvc2VjdXJpdHkvc3Ry aXAtcmVmZXJyZXItdG8tb3JpZ2luLWZvci10aGlyZC1wYXJ0eS1yZWRpcmVjdHMtaW4tcHJpdmF0 ZS1tb2RlLmh0bWw6CisKIDIwMjEtMDMtMDUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CiAKICAgICAgICAgQWRkIGxlYWsgdGVzdHMgZm9yIFJhbmdlIGFuZCBTdGF0aWNSYW5nZQpJ bmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9zdHJpcC1yZWZlcnJlci10by1v cmlnaW4tZm9yLXRoaXJkLXBhcnR5LXJlZGlyZWN0cy1pbi1wcml2YXRlLW1vZGUuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3N0cmlwLXJlZmVycmVy LXRvLW9yaWdpbi1mb3ItdGhpcmQtcGFydHktcmVkaXJlY3RzLWluLXByaXZhdGUtbW9kZS5odG1s CShyZXZpc2lvbiAyNzQwMDYpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3N0 cmlwLXJlZmVycmVyLXRvLW9yaWdpbi1mb3ItdGhpcmQtcGFydHktcmVkaXJlY3RzLWluLXByaXZh dGUtbW9kZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw3ICsyNyw3IEBACiAgICAgICAgIHJl ZmVycmVyID0gZGF0YTsKICAgICAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJyZWZlcnJlciIs ICJodHRwOi8vMTI3LjAuMC4xOjgwMDAvc2VjdXJpdHkvc3RyaXAtcmVmZXJyZXItdG8tb3JpZ2lu LWZvci10aGlyZC1wYXJ0eS1yZWRpcmVjdHMtaW4tcHJpdmF0ZS1tb2RlLmh0bWwiKTsKIAotICAg ICAgICBvcGVuSWZyYW1lKCJyZXNvdXJjZXMvcmVkaXJlY3QucHk/cmVkaXJlY3RUbz1odHRwOi8v bG9jYWxob3N0OjgwMDAvc2VjdXJpdHkvcmVzb3VyY2VzL2VjaG8tcmVmZXJyZXIucGhwIiwgZmlu aXNoSlNUZXN0KTsKKyAgICAgICAgb3BlbklmcmFtZSgicmVzb3VyY2VzL3JlZGlyZWN0LnBocD9y ZWRpcmVjdFRvPWh0dHA6Ly9sb2NhbGhvc3Q6ODAwMC9zZWN1cml0eS9yZXNvdXJjZXMvZWNoby1y ZWZlcnJlci5waHAiLCBmaW5pc2hKU1Rlc3QpOwogCiAgICAgfSkuY2F0Y2goZnVuY3Rpb24oZXJy b3IpIHsKICAgICAgICAgY29uc29sZS5sb2coZXJyb3IubWVzc2FnZSk7Cg== 422571 2021-03-08 08:22:27 -0800 2021-03-08 09:27:19 -0800 Patch bug-222823-20210308112226.patch text/plain 1727 cgambrell SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI3NDA3MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIxLTAzLTA4ICBDaHJpcyBHYW1icmVsbCAg PGNnYW1icmVsbEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW2lPU10gaHR0cC90 ZXN0cy9zZWN1cml0eS9zdHJpcC1yZWZlcnJlci10by1vcmlnaW4tZm9yLXRoaXJkLXBhcnR5LXJl ZGlyZWN0cy1pbi1wcml2YXRlLW1vZGUuaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI4MjMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzc1MTMzNDUwPgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisg ICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS9zdHJpcC1yZWZlcnJlci10by1vcmlnaW4tZm9y LXRoaXJkLXBhcnR5LXJlZGlyZWN0cy1pbi1wcml2YXRlLW1vZGUuaHRtbDoKKwogMjAyMS0wMy0w NiAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KIAogICAgICAgICBbV2ViIEFu aW1hdGlvbnNdIFNvbWUgdGVzdHMgdW5kZXIgd2ViLWFuaW1hdGlvbnMvdGltaW5nLW1vZGVsL2Fu aW1hdGlvbnMgYXJlIEltYWdlT25seUZhaWx1cmUKSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVz dHMvc2VjdXJpdHkvc3RyaXAtcmVmZXJyZXItdG8tb3JpZ2luLWZvci10aGlyZC1wYXJ0eS1yZWRp cmVjdHMtaW4tcHJpdmF0ZS1tb2RlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9zZWN1cml0eS9zdHJpcC1yZWZlcnJlci10by1vcmlnaW4tZm9yLXRoaXJkLXBhcnR5 LXJlZGlyZWN0cy1pbi1wcml2YXRlLW1vZGUuaHRtbAkocmV2aXNpb24gMjc0MDA2KQorKysgTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9zdHJpcC1yZWZlcnJlci10by1vcmlnaW4tZm9y LXRoaXJkLXBhcnR5LXJlZGlyZWN0cy1pbi1wcml2YXRlLW1vZGUuaHRtbAkod29ya2luZyBjb3B5 KQpAQCAtMjcsNyArMjcsNyBAQAogICAgICAgICByZWZlcnJlciA9IGRhdGE7CiAgICAgICAgIHNo b3VsZEJlRXF1YWxUb1N0cmluZygicmVmZXJyZXIiLCAiaHR0cDovLzEyNy4wLjAuMTo4MDAwL3Nl Y3VyaXR5L3N0cmlwLXJlZmVycmVyLXRvLW9yaWdpbi1mb3ItdGhpcmQtcGFydHktcmVkaXJlY3Rz LWluLXByaXZhdGUtbW9kZS5odG1sIik7CiAKLSAgICAgICAgb3BlbklmcmFtZSgicmVzb3VyY2Vz L3JlZGlyZWN0LnB5P3JlZGlyZWN0VG89aHR0cDovL2xvY2FsaG9zdDo4MDAwL3NlY3VyaXR5L3Jl c291cmNlcy9lY2hvLXJlZmVycmVyLnBocCIsIGZpbmlzaEpTVGVzdCk7CisgICAgICAgIG9wZW5J ZnJhbWUoInJlc291cmNlcy9yZWRpcmVjdC5waHA/cmVkaXJlY3RUbz1odHRwOi8vbG9jYWxob3N0 OjgwMDAvc2VjdXJpdHkvcmVzb3VyY2VzL2VjaG8tcmVmZXJyZXIucGhwIiwgZmluaXNoSlNUZXN0 KTsKIAogICAgIH0pLmNhdGNoKGZ1bmN0aW9uKGVycm9yKSB7CiAgICAgICAgIGNvbnNvbGUubG9n KGVycm9yLm1lc3NhZ2UpOwo=