222746 2021-03-04 09:49:27 -0800 IDBTransaction is closed prematurely if a microtask is awaited after opening the transaction under some circumstances 2021-03-11 10:30:09 -0800 1 1 1 Unclassified WebKit WebCore Misc. Safari Technology Preview Mac (Intel) macOS 10.15 RESOLVED DUPLICATE 216769 https://bugs.webkit.org/show_bug.cgi?id=216769 InRadar P2 Normal --- 1 brunow webkit-unassigned ap beidson cdumez ggaren keith_miller rniwa sihui_liu webkit-bug-importer ysuzuki oldest_to_newest 1735879 0 422245 brunow 2021-03-04 09:49:27 -0800 Created attachment 422245 a small test case reproducing the problem I'm encountering an issue with IndexedDB which I can reproduce on several webkit based browsers (Safari on iOS 13.4, Safari TP 121 on macOS 10.15, and WebKitGTK 2.30.5 on Linux). The issue is that under some circumstances, an IDBTransaction can get closed if you wait a single microtask (e.g. await Promise.resolve()) to queue your first IDBRequest (as opposed to a macrotask, which is expected). In the web app where I encountered the issue, it happens easily if I have optional async code path after opening a transaction (async because they use indexeddb, no other macro tasks). I've attached a test case that reproduces the problem, where scheduling a macro task in between two transactions seems to trigger the bug. I have reduced it as much as possible, so every step is essential to reproduce the problem AFAIK. 1737146 1 cdumez 2021-03-08 10:09:11 -0800 The IDBTransaction constructor uses this: vm.whenIdle([protectedThis = makeRef(*this)]() { protectedThis->deactivate(); }); It seems our lambda is getting called prematurely here because the JS is using await on a setTimeout. 1737158 2 sihui_liu 2021-03-08 10:35:30 -0800 Seem the same as https://bugs.webkit.org/show_bug.cgi?id=216769 1737169 3 cdumez 2021-03-08 11:00:35 -0800 Interesting part of the repro case: ``` try { const db = await openDatabase(dbName, db => { db.createObjectStore("test", {keyPath: "key"}); }, 1); const readTxn = db.transaction(["test"], "readonly"); await reqAsPromise(readTxn.objectStore("test").get("somekey")); // schedule a macro task in between the two txns await new Promise(r => setTimeout(r, 0)); const writeTxn = db.transaction(["test"], "readwrite"); await Promise.resolve(); writeTxn.objectStore("test").add({key: "somekey", value: "foo"}); await txnAsPromise(writeTxn); } catch (err) { if (err.name === "TransactionInactiveError") { return true; // BUG } ``` So it looks like whenIdle called our lambda before the call to: writeTxn.objectStore("test").add() Calling our lambda deactivated the writeTxn, which is why we reject the promise with a TransactionInactiveError. 1738493 4 webkit-bug-importer 2021-03-11 09:50:15 -0800 <rdar://problem/75320436> 1738516 5 sihui_liu 2021-03-11 10:30:09 -0800 *** This bug has been marked as a duplicate of bug 216769 *** 422245 2021-03-04 09:49:27 -0800 2021-03-04 09:49:27 -0800 a small test case reproducing the problem idb-test-safari-close-txn.html text/html 2553 brunow PGh0bWw+CjxoZWFkPjxtZXRhIGNoYXJzZXQ9InV0Zi04Ij48L2hlYWQ+Cjxib2R5PgoJPHNjcmlw dCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgoKICAgICAgICBjb25zdCBsb2cgPSAoLi4ucGFyYW1z KSA9PiB7CiAgICAgICAgICAgIGRvY3VtZW50LndyaXRlKHBhcmFtcy5qb2luKCIgIikrIjxicj4i KTsKICAgICAgICB9OwoKICAgICAgICBmdW5jdGlvbiByZXFBc1Byb21pc2UocmVxKSB7CiAgICAg ICAgICAgIHJldHVybiBuZXcgUHJvbWlzZSgocmVzb2x2ZSwgcmVqZWN0KSA9PiB7CiAgICAgICAg ICAgICAgICByZXEub25zdWNjZXNzID0gKCkgPT4gcmVzb2x2ZShyZXEucmVzdWx0KTsKICAgICAg ICAgICAgICAgIHJlcS5vbmVycm9yID0gKGVycikgPT4gcmVqZWN0KGVycik7CiAgICAgICAgICAg IH0pOwogICAgICAgIH0KCiAgICAgICAgZnVuY3Rpb24gdHhuQXNQcm9taXNlKHR4bikgewogICAg ICAgICAgICByZXR1cm4gbmV3IFByb21pc2UoKHJlc29sdmUsIHJlamVjdCkgPT4gewogICAgICAg ICAgICAgICAgdHhuLmFkZEV2ZW50TGlzdGVuZXIoImNvbXBsZXRlIiwgcmVzb2x2ZSk7CiAgICAg ICAgICAgICAgICB0eG4uYWRkRXZlbnRMaXN0ZW5lcigiYWJvcnQiLCByZWplY3QpOwogICAgICAg ICAgICB9KTsKICAgICAgICB9CgogICAgICAgIGZ1bmN0aW9uIG9wZW5EYXRhYmFzZShuYW1lLCBj cmVhdGVPYmplY3RTdG9yZSwgdmVyc2lvbikgewogICAgICAgICAgICBjb25zdCByZXEgPSBpbmRl eGVkREIub3BlbihuYW1lLCB2ZXJzaW9uKTsKICAgICAgICAgICAgcmVxLm9udXBncmFkZW5lZWRl ZCA9IChldikgPT4gewogICAgICAgICAgICAgICAgY29uc3QgZGIgPSBldi50YXJnZXQucmVzdWx0 OwogICAgICAgICAgICAgICAgY29uc3QgdHhuID0gZXYudGFyZ2V0LnRyYW5zYWN0aW9uOwogICAg ICAgICAgICAgICAgY29uc3Qgb2xkVmVyc2lvbiA9IGV2Lm9sZFZlcnNpb247CiAgICAgICAgICAg ICAgICBjcmVhdGVPYmplY3RTdG9yZShkYiwgdHhuLCBvbGRWZXJzaW9uLCB2ZXJzaW9uKTsKICAg ICAgICAgICAgfTsgCiAgICAgICAgICAgIHJldHVybiByZXFBc1Byb21pc2UocmVxKTsKICAgICAg ICB9CgogICAgICAgIGFzeW5jIGZ1bmN0aW9uIGRldGVjdFdlYmtpdEVhcmx5Q2xvc2VUeG5CdWco KSB7CiAgICAgICAgICAgIGNvbnN0IGRiTmFtZSA9ICJ3ZWJraXRfdGVzdF9pbmFjdGl2ZV90eG5f IiArIE1hdGgucmFuZG9tKCkgKiBOdW1iZXIuTUFYX1NBRkVfSU5URUdFUjsKICAgICAgICAgICAg dHJ5IHsKICAgICAgICAgICAgICAgIGNvbnN0IGRiID0gYXdhaXQgb3BlbkRhdGFiYXNlKGRiTmFt ZSwgZGIgPT4gewogICAgICAgICAgICAgICAgICAgIGRiLmNyZWF0ZU9iamVjdFN0b3JlKCJ0ZXN0 Iiwge2tleVBhdGg6ICJrZXkifSk7CiAgICAgICAgICAgICAgICB9LCAxKTsKICAgICAgICAgICAg ICAgIGNvbnN0IHJlYWRUeG4gPSBkYi50cmFuc2FjdGlvbihbInRlc3QiXSwgInJlYWRvbmx5Iik7 CiAgICAgICAgICAgICAgICBhd2FpdCByZXFBc1Byb21pc2UocmVhZFR4bi5vYmplY3RTdG9yZSgi dGVzdCIpLmdldCgic29tZWtleSIpKTsKICAgICAgICAgICAgICAgIC8vIHNjaGVkdWxlIGEgbWFj cm8gdGFzayBpbiBiZXR3ZWVuIHRoZSB0d28gdHhucwogICAgICAgICAgICAgICAgYXdhaXQgbmV3 IFByb21pc2UociA9PiBzZXRUaW1lb3V0KHIsIDApKTsKICAgICAgICAgICAgICAgIGNvbnN0IHdy aXRlVHhuID0gZGIudHJhbnNhY3Rpb24oWyJ0ZXN0Il0sICJyZWFkd3JpdGUiKTsKICAgICAgICAg ICAgICAgIGF3YWl0IFByb21pc2UucmVzb2x2ZSgpOwogICAgICAgICAgICAgICAgd3JpdGVUeG4u b2JqZWN0U3RvcmUoInRlc3QiKS5hZGQoe2tleTogInNvbWVrZXkiLCB2YWx1ZTogImZvbyJ9KTsK ICAgICAgICAgICAgICAgIGF3YWl0IHR4bkFzUHJvbWlzZSh3cml0ZVR4bik7CiAgICAgICAgICAg IH0gY2F0Y2ggKGVycikgewogICAgICAgICAgICAgICAgaWYgKGVyci5uYW1lID09PSAiVHJhbnNh Y3Rpb25JbmFjdGl2ZUVycm9yIikgewogICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwog ICAgICAgICAgICAgICAgfQogICAgICAgICAgICB9IGZpbmFsbHkgewogICAgICAgICAgICAgICAg dHJ5IHsKICAgICAgICAgICAgICAgICAgICBpbmRleGVkREIuZGVsZXRlRGF0YWJhc2UoZGJOYW1l KTsKICAgICAgICAgICAgICAgIH0gY2F0Y2ggKGVycikge30KICAgICAgICAgICAgfQogICAgICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgfQoKICAgICAgICAoYXN5bmMgKCkgPT4gewogICAg ICAgICAgICBpZiAoYXdhaXQgZGV0ZWN0V2Via2l0RWFybHlDbG9zZVR4bkJ1ZygpKSB7CiAgICAg ICAgICAgICAgICBsb2coInRoZSB0ZXN0IGZhaWxlZCwgeW91ciBicm93c2VyIHNlZW1zIHRvIGhh dmUgdGhlIGJ1ZyIpOwogICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgbG9nKCJ0 aGUgdGVzdCBzdWNjZWVkZWQsIHlvdXIgYnJvd3NlciBzZWVtcyBmaW5lIik7CiAgICAgICAgICAg IH0KICAgICAgICB9KSgpOwoKCTwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K