222269 2021-02-22 07:05:03 -0800 [LFC][Integration] Respect hasLineIfEmpty 2021-02-22 10:47:23 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 220148 1 koivisto webkit-unassigned bfulgham changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1732118 0 koivisto 2021-02-22 07:05:03 -0800 In certain editing cases a block is computed to have height of a line even if it has no content. 1732119 1 421187 koivisto 2021-02-22 07:09:02 -0800 Created attachment 421187 patch 1732198 2 ews-feeder 2021-02-22 10:46:55 -0800 Committed r273262: <https://commits.webkit.org/r273262> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421187. 1732199 3 webkit-bug-importer 2021-02-22 10:47:23 -0800 <rdar://problem/74603281> 421187 2021-02-22 07:09:02 -0800 2021-02-22 10:46:57 -0800 patch lfc-has-line-if-empty.patch text/plain 1833 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3Njk4MGM0NGM5ZmIuLjZhODYwN2M3NmZmZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDIxLTAyLTIyICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNv bT4KKworICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gUmVzcGVjdCBoYXNMaW5lSWZFbXB0eQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMjY5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gY2VydGFp biBlZGl0aW5nIGNhc2VzIGEgYmxvY2sgaXMgY29tcHV0ZWQgdG8gaGF2ZSBoZWlnaHQgb2YgYSBs aW5lIGV2ZW4gaWYgaXQgaGFzIG5vIGNvbnRlbnQuCisKKyAgICAgICAgVGhpcyBmaXhlcyBlZGl0 aW5nL2V4ZWNDb21tYW5kL2V4dHJhY3RlZF9zdHlsZV9hc3NlcnQuaHRtbAorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJC bG9ja0Zsb3c6OmxheW91dE1vZGVybkxpbmVzKToKKwogMjAyMS0wMi0xOSAgSmlld2VuIFRhbiAg PGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFBDTTogUmVxdWVzdCBzZXJ2ZXIgcHVi bGljIGtleSB0byBnZW5lcmF0ZSBzZWNyZXQgdG9rZW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKaW5kZXggYTVlOGQxMjU3MmZiLi41OWIwMTdlY2FhOTAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC0z Njk4LDcgKzM2OTgsMTIgQEAgdm9pZCBSZW5kZXJCbG9ja0Zsb3c6OmxheW91dE1vZGVybkxpbmVz KGJvb2wgcmVsYXlvdXRDaGlsZHJlbiwgTGF5b3V0VW5pdCYgcmVwYWkKICAgICBpZiAodmlldygp LmZyYW1lVmlldygpLmxheW91dENvbnRleHQoKS5sYXlvdXRTdGF0ZSgpLT5pc1BhZ2luYXRlZCgp KQogICAgICAgICBsYXlvdXRGb3JtYXR0aW5nQ29udGV4dExpbmVMYXlvdXQuYWRqdXN0Rm9yUGFn aW5hdGlvbigpOwogCi0gICAgYXV0byBjb250ZW50SGVpZ2h0ID0gbGF5b3V0Rm9ybWF0dGluZ0Nv bnRleHRMaW5lTGF5b3V0LmNvbnRlbnRMb2dpY2FsSGVpZ2h0KCk7CisgICAgYXV0byBjb250ZW50 SGVpZ2h0ID0gWyZdIHsKKyAgICAgICAgaWYgKCFoYXNMaW5lcygpICYmIGhhc0xpbmVJZkVtcHR5 KCkpCisgICAgICAgICAgICByZXR1cm4gbGluZUhlaWdodCh0cnVlLCBpc0hvcml6b250YWxXcml0 aW5nTW9kZSgpID8gSG9yaXpvbnRhbExpbmUgOiBWZXJ0aWNhbExpbmUsIFBvc2l0aW9uT2ZJbnRl cmlvckxpbmVCb3hlcyk7CisgICAgICAgIAorICAgICAgICByZXR1cm4gbGF5b3V0Rm9ybWF0dGlu Z0NvbnRleHRMaW5lTGF5b3V0LmNvbnRlbnRMb2dpY2FsSGVpZ2h0KCk7CisgICAgfSgpOwogICAg IGF1dG8gY29udGVudEJveFRvcCA9IGJvcmRlckFuZFBhZGRpbmdCZWZvcmUoKTsKICAgICBhdXRv IGNvbnRlbnRCb3hCb3R0b20gPSBjb250ZW50Qm94VG9wICsgY29udGVudEhlaWdodDsKICAgICBh dXRvIGJvcmRlckJveEJvdHRvbSA9IGNvbnRlbnRCb3hCb3R0b20gKyBib3JkZXJBbmRQYWRkaW5n QWZ0ZXIoKTsK