222179 2021-02-19 10:01:59 -0800 Small improvements to r273073 2021-02-21 09:21:14 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 221407 1 mrobinson mrobinson changseok darin esprehn+autocc ews-watchlist glenn kondapallykalyan pdr webkit-bug-importer oldest_to_newest 1731403 0 mrobinson 2021-02-19 10:01:59 -0800 In https://bugs.webkit.org/show_bug.cgi?id=221407#c13, Darin pointed out a few improvements to r273073. This change tracks implementing those. 1731417 1 420987 mrobinson 2021-02-19 10:24:44 -0800 Created attachment 420987 Patch 1731948 2 420987 mrobinson 2021-02-21 08:32:39 -0800 Comment on attachment 420987 Patch It looks like the Windows failure here is unrelated to this change. 1731949 3 ews-feeder 2021-02-21 08:33:22 -0800 ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. 1731954 4 ews-feeder 2021-02-21 09:20:51 -0800 Committed r273219: <https://commits.webkit.org/r273219> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420987. 1731955 5 webkit-bug-importer 2021-02-21 09:21:14 -0800 <rdar://problem/74568983> 420987 2021-02-19 10:24:44 -0800 2021-02-21 09:20:52 -0800 Patch bug-222179-20210219192443.patch text/plain 2171 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzY5ODBjNDRjOWZiMDYw M2UwMmVmNzRmNDQ5NTk1NTQ2MmNmZTFmMC4uMDJhNmM5MDA0ZGQwNzQ4YmEwYmRhMDQxNmI2NGU3 MTA0ZWQyMzhkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTE5ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBTbWFsbCBpbXBy b3ZlbWVudHMgdG8gcjI3MzA3MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjIyMTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBiZWNhdXNlIHRoaXMgc2hvdWxkIG5vdCBjaGFuZ2Ug YmVoYXZpb3IuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6ZW5jbG9zaW5nU2Nyb2xsYWJsZUNvbnRhaW5lckZv clNuYXBwaW5nIGNvbnN0KTogUmVwbGFjZQorICAgICAgICBhIHdoaWxlIGxvb3Agd2l0aCBhIGZv ciBsb29wIGFuZCBwcmVmZXIgZG93bmNhc3Q8PiB0byBzdGF0aWNfY2FzdDw+LgorCiAyMDIxLTAy LTE5ICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CiAKICAgICAgICAgUENNOiBS ZXF1ZXN0IHNlcnZlciBwdWJsaWMga2V5IHRvIGdlbmVyYXRlIHNlY3JldCB0b2tlbgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAppbmRleCA1MjM2NjBlNjAyNTllYzU4 NTkxYzJmMTEyMmVmMTc5MjdlYmFhNDdlLi4wNTY1MjY3ZDhhN2QyMjQ4NGFjZTNjYTExMzMxNzRk NGM2NTc4Mzg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcApA QCAtNDU5LDE1ICs0NTksMTMgQEAgY29uc3QgUmVuZGVyQm94KiBSZW5kZXJPYmplY3Q6OmVuY2xv c2luZ1Njcm9sbGFibGVDb250YWluZXJGb3JTbmFwcGluZygpIGNvbnN0CiAgICAgLy8gdGhpcyBS ZW5kZXJPYmplY3QuIFRoZSBpbXBvcnRhbnQgdGhpbmcgaGVyZSBpcyB0aGF0IGBjb250YWluZXIo KWAgcmVzcGVjdHMKICAgICAvLyB0aGUgY29udGFpbmluZyBibG9jayBjaGFpbiBmb3IgcG9zaXRp b25lZCBlbGVtZW50cy4gVGhpcyBpcyBpbXBvcnRhbnQgYmVjYXVzZQogICAgIC8vIHNjcm9sbGFi bGUgb3ZlcmZsb3cgZG9lcyBub3QgZXN0YWJsaXNoIGEgbmV3IGNvbnRhaW5pbmcgYmxvY2sgZm9y IGNoaWxkcmVuLgotICAgIGF1dG8qIGNhbmRpZGF0ZSA9IGNvbnRhaW5lcigpOwotICAgIHdoaWxl IChjYW5kaWRhdGUpIHsKKyAgICBmb3IgKGF1dG8qIGNhbmRpZGF0ZSA9IGNvbnRhaW5lcigpOyBj YW5kaWRhdGU7IGNhbmRpZGF0ZSA9IGNhbmRpZGF0ZS0+Y29udGFpbmVyKCkpIHsKICAgICAgICAg Ly8gQ3VycmVudGx5IHRoZSBSZW5kZXJWaWV3IGNhbiBsb29rIGxpa2UgaXQgaGFzIHNjcm9sbGFi bGUgb3ZlcmZsb3csIGJ1dCB3ZSBuZXZlcgogICAgICAgICAvLyB3YW50IHRvIHJldHVybiB0aGlz IGFzIG91ciBjb250YWluZXIuIEluc3RlYWQgd2Ugc2hvdWxkIHVzZSB0aGUgcm9vdCBlbGVtZW50 LgogICAgICAgICBpZiAoY2FuZGlkYXRlLT5pc1JlbmRlclZpZXcoKSkKICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICBpZiAoY2FuZGlkYXRlLT5oYXNPdmVyZmxvd0NsaXAoKSkKLSAgICAgICAg ICAgIHJldHVybiBzdGF0aWNfY2FzdDxSZW5kZXJCb3gqPihjYW5kaWRhdGUpOwotICAgICAgICBj YW5kaWRhdGUgPSBjYW5kaWRhdGUtPmNvbnRhaW5lcigpOworICAgICAgICAgICAgcmV0dXJuIGRv d25jYXN0PFJlbmRlckJveD4oY2FuZGlkYXRlKTsKICAgICB9CiAKICAgICAvLyBJZiB3ZSByZWFj aCB0aGUgcm9vdCwgdGhlbiB0aGUgcm9vdCBlbGVtZW50IGlzIHRoZSBzY3JvbGxpbmcgY29udGFp bmVyLgo=