222039 2021-02-17 07:17:28 -0800 [GTK] Remove all Google user agent quirks except for Google Docs 2021-03-09 08:33:02 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Other RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=142074 https://bugs.webkit.org/show_bug.cgi?id=171941 https://bugs.webkit.org/show_bug.cgi?id=221845 https://bugs.webkit.org/show_bug.cgi?id=222978 P2 Normal --- 222905 1 mcatanzaro mcatanzaro bugs-noreply cgarcia commit-queue lantw44 mcatanzaro yoav oldest_to_newest 1730260 0 mcatanzaro 2021-02-17 07:17:28 -0800 In bug #171941 I replaced our previous Google user agent quirks with a Linux x86_64 quirk, to deal with Google discriminating against non-Linux and non-x86_64 users. It's weird for a website to discriminate against *non-Linux* users, but Google was really doing it on multiple domains. FreeBSD users were not happy. Another problem was Google discriminating when the operating system ("Ubuntu", "Fedora") was included in the user agent. The Linux x86_64 quirk was added to address both issues by ensuring Google domains receive the most standard/vanilla user agent we could possibly send. That was nearly four years ago. I've been testing every major Google domain (Maps, Calendar, Gmail, Docs, Drive, YouTube) with FreeBSD and Fedora user agents. I've even tested removing "X11" from the user agent, which was previously required by Google Calendar and Google Maps. Even that works properly nowadays. So it seems Google has seriously improved its robustness to our user agent header, and we no longer need the Linux x86_64 quirk. Thank you Google. (Additional testing welcome, of course. It's very possible that I have missed something.) The one major exception is Google Docs, which still shows unsupported browser warnings. That now uses a Chrome browser quirk since bug #221845, which will be needed until Google Docs stops discriminating against WebKit users. 1730270 1 mcatanzaro 2021-02-17 07:45:09 -0800 More things I've tested: replacing x86_64 with amd64 (used by FreeBSD) or aarch64 to ensure nondiscrimination against ARM users (some websites switch to mobile mode when they see ARM user agents). I've tried combining Fedora and FreeBSD into the same user agent. I've tried changing the operating system version to gibberish characters. At one point, I saw Google Maps fall back to a mobile interface, but I've tried several times to reproduce that with increasingly strange user agent strings and can't figure out how I managed that, so I think users will be fine. 1730274 2 420647 mcatanzaro 2021-02-17 07:51:37 -0800 Created attachment 420647 Patch 1730849 3 ews-feeder 2021-02-18 08:04:17 -0800 commit-queue failed to commit attachment 420647 to WebKit repository. To retry, please set cq+ flag again. 1730928 4 ews-feeder 2021-02-18 10:58:30 -0800 Committed r273084: <https://commits.webkit.org/r273084> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420647. 1737046 5 mcatanzaro 2021-03-08 06:29:59 -0800 OK I messed up. It works with this user agent: Mozilla/5.0 (X11; Fedora; Linux x86_64) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0 Safari/605.1.15 But drive.google.com and accounts.google.com both fail with this user agent: Mozilla/5.0 (X11; Fedora; Linux x86_64) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0 Safari/605.1.15 Epiphany/605.1.15 I stopped sending the Epiphany version recently hoping it would improve web compat. It seems that it did indeed. The cost is that now I have to remember to add it back in order to test quirks, and I failed to do so when testing this. So the Linux desktop platform quirk is still needed for drive.google.com and accounts.google.com to override the browser's usual identification. 1737052 6 commit-queue 2021-03-08 06:35:45 -0800 Re-opened since this is blocked by bug 222905 1737054 7 mcatanzaro 2021-03-08 06:36:32 -0800 WONTFIX for the time being. Should revisit in the future. 1737061 8 mcatanzaro 2021-03-08 06:47:52 -0800 (In reply to Michael Catanzaro from comment #5) > So the Linux desktop platform quirk is still needed for > drive.google.com and accounts.google.com to override the browser's usual > identification. We could probably replace it with a quirk that simply removes the browser's identification. Faking the Linux desktop platform really seems to no longer be needed. 1737579 9 mcatanzaro 2021-03-09 08:33:02 -0800 The adventure continues in bug #222978. 420647 2021-02-17 07:51:37 -0800 2021-02-18 10:58:32 -0800 Patch bug-222039-20210217095136.patch text/plain 6531 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyOTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE5OWE3YjA5NWFkZmE1 MmYwNDE0OGQ1OTY1OWE0MjE3MzM0ZjBlZC4uNmQ5OWRhNDE4MTY2ZjM3NzM0ZmVkNDEzMTRhNTRl NzYwMzgyNDM2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTAyLTE3ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIFJl bW92ZSBhbGwgR29vZ2xlIHVzZXIgYWdlbnQgcXVpcmtzIGV4Y2VwdCBmb3IgR29vZ2xlIERvY3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjAzOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBHb29n bGUgdXNlciBhZ2VudCBxdWlya3MgaGF2ZSBhIHZlcnkgbG9uZyBhbmQgY29tcGxleCBoaXN0b3J5 LCBkZXRhaWxlZCBhY3Jvc3Mgb3ZlciBhCisgICAgICAgIGRvemVuIGRpZmZlcmVudCBidWcgcmVw b3J0cy4gQnV0IEdvb2dsZSBzZWVtcyB0byBoYXZlIGltcHJvdmVkIGl0cyBwcmFjdGljZXMsIGFu ZCB0aGV5IGFyZQorICAgICAgICBubyBsb25nZXIgbmVlZGVkIGV4Y2VwdCBvbiBHb29nbGUgRG9j cywgYXQgbGVhc3QgZm9yIG5vdy4gVGhpcyBpcyBhIGhpc3RvcmljIG1vbWVudCEKKworICAgICAg ICAqIHBsYXRmb3JtL1VzZXJBZ2VudFF1aXJrcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpVc2Vy QWdlbnRRdWlya3M6OnF1aXJrc0ZvclVSTCk6CisgICAgICAgIChXZWJDb3JlOjpVc2VyQWdlbnRR dWlya3M6OnN0cmluZ0ZvclF1aXJrKToKKyAgICAgICAgKFdlYkNvcmU6OnVybFJlcXVpcmVzTGlu dXhEZXNrdG9wUGxhdGZvcm0pOiBEZWxldGVkLgorICAgICAgICAqIHBsYXRmb3JtL2dsaWIvVXNl ckFnZW50R0xpYi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpidWlsZFVzZXJBZ2VudFN0cmluZyk6 CisKIDIwMjEtMDItMTcgIEFuZHJlcyBHb256YWxleiAgPGFuZHJlc2dfMjJAYXBwbGUuY29tPgog CiAgICAgICAgIFN1cHBvcnQgYXJpYS1lcnJvcm1lc3NhZ2Ugb24gaU9TLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1VzZXJBZ2VudFF1aXJrcy5jcHAKaW5kZXggYjk4NmI1ZGI0ZDMzN2U5MTg1 NTZlYWQ0ZGM4ZjM2NTI0NDA0ZDVhNi4uMDM5ZjdjMTRlMTkzOTU3M2IwYjMwYTY0OWQyNTc5ZjM1 MDYwNGFkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50UXVp cmtzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Vc2VyQWdlbnRRdWlya3MuY3Bw CkBAIC0xNDcsMTEgKzE0Nyw2IEBAIHN0YXRpYyBib29sIHVybFJlcXVpcmVzTWFjaW50b3NoUGxh dGZvcm0oY29uc3QgVVJMJiB1cmwpCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi1zdGF0aWMgYm9v bCB1cmxSZXF1aXJlc0xpbnV4RGVza3RvcFBsYXRmb3JtKGNvbnN0IFVSTCYgdXJsKQotewotICAg IHJldHVybiBpc0dvb2dsZSh1cmwpICYmIGNoYXNzaXNUeXBlKCkgIT0gV1RGOjpDaGFzc2lzVHlw ZTo6TW9iaWxlOwotfQotCiBVc2VyQWdlbnRRdWlya3MgVXNlckFnZW50UXVpcmtzOjpxdWlya3NG b3JVUkwoY29uc3QgVVJMJiB1cmwpCiB7CiAgICAgQVNTRVJUKCF1cmwuaXNOdWxsKCkpOwpAQCAt MTY1LDggKzE2MCw2IEBAIFVzZXJBZ2VudFF1aXJrcyBVc2VyQWdlbnRRdWlya3M6OnF1aXJrc0Zv clVSTChjb25zdCBVUkwmIHVybCkKIAogICAgIGlmICh1cmxSZXF1aXJlc01hY2ludG9zaFBsYXRm b3JtKHVybCkpCiAgICAgICAgIHF1aXJrcy5hZGQoVXNlckFnZW50UXVpcmtzOjpOZWVkc01hY2lu dG9zaFBsYXRmb3JtKTsKLSAgICBlbHNlIGlmICh1cmxSZXF1aXJlc0xpbnV4RGVza3RvcFBsYXRm b3JtKHVybCkpCi0gICAgICAgIHF1aXJrcy5hZGQoVXNlckFnZW50UXVpcmtzOjpOZWVkc0xpbnV4 RGVza3RvcFBsYXRmb3JtKTsKIAogICAgIHJldHVybiBxdWlya3M7CiB9CkBAIC0xODEsOCArMTc0 LDYgQEAgU3RyaW5nIFVzZXJBZ2VudFF1aXJrczo6c3RyaW5nRm9yUXVpcmsoVXNlckFnZW50UXVp cmsgcXVpcmspCiAgICAgICAgIHJldHVybiAiOyBydjo4Ny4wKSBHZWNrby8yMDEwMDEwMSBGaXJl Zm94Lzg3LjAiX3M7CiAgICAgY2FzZSBOZWVkc01hY2ludG9zaFBsYXRmb3JtOgogICAgICAgICBy ZXR1cm4gIk1hY2ludG9zaDsgSW50ZWwgTWFjIE9TIFggMTBfMTUiX3M7Ci0gICAgY2FzZSBOZWVk c0xpbnV4RGVza3RvcFBsYXRmb3JtOgotICAgICAgICByZXR1cm4gIlgxMTsgTGludXggeDg2XzY0 Il9zOwogICAgIGNhc2UgTnVtVXNlckFnZW50UXVpcmtzOgogICAgIGRlZmF1bHQ6CiAgICAgICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ2xpYi9Vc2VyQWdlbnRHTGliLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dsaWIv VXNlckFnZW50R0xpYi5jcHAKaW5kZXggNDQ0Mzk2MzhmNDkwN2Y2NWFkMzEzOTU3ZjVjZDZlMDQ4 NmNlNjgyNy4uNTNjMTgwM2NhMTMxNTQyMzNlMmEzYzhmOGFlMWYwMzNlZGFiNDc1MSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2xpYi9Vc2VyQWdlbnRHTGliLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL1VzZXJBZ2VudEdMaWIuY3BwCkBAIC04OSw4 ICs4OSw2IEBAIHN0YXRpYyBTdHJpbmcgYnVpbGRVc2VyQWdlbnRTdHJpbmcoY29uc3QgVXNlckFn ZW50UXVpcmtzJiBxdWlya3MpCiAKICAgICBpZiAocXVpcmtzLmNvbnRhaW5zKFVzZXJBZ2VudFF1 aXJrczo6TmVlZHNNYWNpbnRvc2hQbGF0Zm9ybSkpCiAgICAgICAgIHVhU3RyaW5nLmFwcGVuZChV c2VyQWdlbnRRdWlya3M6OnN0cmluZ0ZvclF1aXJrKFVzZXJBZ2VudFF1aXJrczo6TmVlZHNNYWNp bnRvc2hQbGF0Zm9ybSkpOwotICAgIGVsc2UgaWYgKHF1aXJrcy5jb250YWlucyhVc2VyQWdlbnRR dWlya3M6Ok5lZWRzTGludXhEZXNrdG9wUGxhdGZvcm0pKQotICAgICAgICB1YVN0cmluZy5hcHBl bmQoVXNlckFnZW50UXVpcmtzOjpzdHJpbmdGb3JRdWlyayhVc2VyQWdlbnRRdWlya3M6Ok5lZWRz TGludXhEZXNrdG9wUGxhdGZvcm0pKTsKICAgICBlbHNlIHsKICAgICAgICAgdWFTdHJpbmcuYXBw ZW5kKHBsYXRmb3JtRm9yVUFTdHJpbmcoKSk7CiAgICAgICAgIHVhU3RyaW5nLmFwcGVuZExpdGVy YWwoIjsgIik7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cK aW5kZXggYjViZDFkNWU0MjljNmVhOTM3ZjY5MTRlMzlhZWE3YzcxN2I5OGNlNC4uY2M4YTY4N2Nh ZTZiMmVkNmFiNzJmNjMyODc3MzU0YTgwNWEyOTM4OSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdl TG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTAyLTE3ICBN aWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtd IFJlbW92ZSBhbGwgR29vZ2xlIHVzZXIgYWdlbnQgcXVpcmtzIGV4Y2VwdCBmb3IgR29vZ2xlIERv Y3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjAz OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHA6CisgICAgICAgIChU ZXN0V2ViS2l0QVBJOjpURVNUKToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OmFzc2VydFVzZXJB Z2VudEZvclVSTEhhc0xpbnV4UGxhdGZvcm1RdWlyayk6IERlbGV0ZWQuCisKIDIwMjEtMDItMTcg IERpZWdvIFBpbm8gR2FyY2lhICA8ZHBpbm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbRmxhdHBh ayBTREtdIFNjcmlwdCAnd2Via2l0LWZsYXRwYWstcnVuLW5pZ2h0bHknIGV4cGVjdHMgZGlmZmVy ZW50IGZvcm1hdCBmb3IgYSBidWlsdCBwcm9kdWN0IG5hbWUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9Vc2VyQWdlbnRRdWlya3MuY3BwIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHAKaW5kZXggMzc2YmI1 YjYwMjVkODdhZDA3NzU0OGM0YTI3MTM1MWM2YjkyNzNmZi4uNmJlYjE3NGE2YWNmNjcyNzVmZDBj MjMzYzFiMmFjOTZmNWMwODcwNSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHAKQEAgLTU0LDE3ICs1NCw2IEBAIHN0YXRp YyB2b2lkIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc0ZpcmVmb3hCcm93c2VyUXVpcmsoY29uc3Qg Y2hhciogdXJsKQogICAgIEVYUEVDVF9GQUxTRSh1YVN0cmluZy5jb250YWlucygiVmVyc2lvbiIp KTsKIH0KIAotc3RhdGljIHZvaWQgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzTGludXhQbGF0Zm9y bVF1aXJrKGNvbnN0IGNoYXIqIHVybCkKLXsKLSAgICBTdHJpbmcgdWFTdHJpbmcgPSBzdGFuZGFy ZFVzZXJBZ2VudEZvclVSTChVUkwoeyB9LCB1cmwpKTsKLQotICAgIEVYUEVDVF9UUlVFKHVhU3Ry aW5nLmNvbnRhaW5zKCJMaW51eCIpKTsKLSAgICBFWFBFQ1RfRkFMU0UodWFTdHJpbmcuY29udGFp bnMoIk1hY2ludG9zaCIpKTsKLSAgICBFWFBFQ1RfRkFMU0UodWFTdHJpbmcuY29udGFpbnMoIk1h YyBPUyBYIikpOwotICAgIEVYUEVDVF9GQUxTRSh1YVN0cmluZy5jb250YWlucygiQ2hyb21lIikp OwotICAgIEVYUEVDVF9GQUxTRSh1YVN0cmluZy5jb250YWlucygiRnJlZUJTRCIpKTsKLX0KLQog c3RhdGljIHZvaWQgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzTWFjUGxhdGZvcm1RdWlyayhjb25z dCBjaGFyKiB1cmwpCiB7CiAgICAgU3RyaW5nIHVhU3RyaW5nID0gc3RhbmRhcmRVc2VyQWdlbnRG b3JVUkwoVVJMKHsgfSwgdXJsKSk7CkBAIC04MiwxMiArNzEsNiBAQCBURVNUKFVzZXJBZ2VudFRl c3QsIFF1aXJrcykKICAgICBTdHJpbmcgdWFTdHJpbmcgPSBzdGFuZGFyZFVzZXJBZ2VudEZvclVS TChVUkwoeyB9LCAiaHR0cDovL3d3dy53ZWJraXQub3JnLyIpKTsKICAgICBFWFBFQ1RfVFJVRSh1 YVN0cmluZy5pc051bGwoKSk7CiAKLSNpZiAhT1MoTElOVVgpIHx8ICFDUFUoWDg2XzY0KQotICAg IC8vIEdvb2dsZSBxdWlyayBzaG91bGQgbm90IGFmZmVjdCBzaXRlcyB3aXRoIHNpbWlsYXIgZG9t YWlucy4KLSAgICB1YVN0cmluZyA9IHN0YW5kYXJkVXNlckFnZW50Rm9yVVJMKFVSTCh7IH0sICJo dHRwOi8vd3d3Lmdvb2dsZWJsb2cuY29tLyIpKTsKLSAgICBFWFBFQ1RfRkFMU0UodWFTdHJpbmcu Y29udGFpbnMoIkxpbnV4IHg4Nl82NCIpKTsKLSNlbmRpZgotCiAgICAgYXNzZXJ0VXNlckFnZW50 Rm9yVVJMSGFzQ2hyb21lQnJvd3NlclF1aXJrKCJodHRwOi8vdHlwZWtpdC5jb20vIik7CiAgICAg YXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzQ2hyb21lQnJvd3NlclF1aXJrKCJodHRwOi8vdHlwZWtp dC5uZXQvIik7CiAgICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzQ2hyb21lQnJvd3NlclF1aXJr KCJodHRwOi8vYXV0aC5tYXlvaHIuY29tLyIpOwpAQCAtMTAwLDEyICs4Myw2IEBAIFRFU1QoVXNl ckFnZW50VGVzdCwgUXVpcmtzKQogICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc0ZpcmVmb3hC cm93c2VyUXVpcmsoImh0dHA6Ly93d3cubmV0ZmxpeC5jb20vIik7CiAjZW5kaWYKIAotICAgIGFz c2VydFVzZXJBZ2VudEZvclVSTEhhc0xpbnV4UGxhdGZvcm1RdWlyaygiaHR0cDovL3d3dy5nb29n bGUuY29tLyIpOwotICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc0xpbnV4UGxhdGZvcm1RdWly aygiaHR0cDovL3d3dy5nb29nbGUuZXMvIik7Ci0gICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFz TGludXhQbGF0Zm9ybVF1aXJrKCJodHRwOi8vY2FsZW5kYXIuZ29vZ2xlLmNvbS8iKTsKLSAgICBh c3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNMaW51eFBsYXRmb3JtUXVpcmsoImh0dHA6Ly9wbHVzLmdv b2dsZS5jb20vIik7Ci0gICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzTGludXhQbGF0Zm9ybVF1 aXJrKCJodHRwOi8vZm9udHMuZ29vZ2xlYXBpcy5jb20vIik7Ci0KICAgICBhc3NlcnRVc2VyQWdl bnRGb3JVUkxIYXNNYWNQbGF0Zm9ybVF1aXJrKCJodHRwOi8vd3d3LnlhaG9vLmNvbS8iKTsKICAg ICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNNYWNQbGF0Zm9ybVF1aXJrKCJodHRwOi8vZmluYW5j ZS55YWhvby5jb20vIik7CiAgICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzTWFjUGxhdGZvcm1R dWlyaygiaHR0cDovL2ludGwudGFvYmFvLmNvbS8iKTsK