221634 2021-02-09 14:55:43 -0800 REGRESSION: (r272458): [BigSur Debug] ASSERTION FAILED: m_haveAddedMediaUsageManagerSession in WebCore::MediaElementSession::updateMediaUsageIfChanged() 2021-02-09 19:31:06 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 amir_mark eric.carlson cdumez changseok eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim jer.noble philipj rniwa sergio tetsuharu.ohzeki webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1727280 0 amir_mark 2021-02-09 14:55:43 -0800 imported/w3c/web-platform-tests/shadow-dom/declarative/declarative-shadow-dom-attachment.tentative.html Is consistently crashing on BigSur Debug Wk1 and Wk2. History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fshadow-dom%2Fdeclarative%2Fdeclarative-shadow-dom-attachment.tentative.html Crash Log: ASSERTION FAILED: m_haveAddedMediaUsageManagerSession ./html/MediaElementSession.cpp(1172) : virtual void WebCore::MediaElementSession::updateMediaUsageIfChanged() 1 0x10c3fdc69 WTFCrash 2 0x12d2a0d0b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x1309d3119 WebCore::MediaElementSession::updateMediaUsageIfChanged() 4 0x12ecde360 auto WebCore::MediaSessionManagerCocoa::scheduleSessionStatusUpdate()::$_8::operator()()::'lambda'(auto&)::operator()<WebCore::PlatformMediaSession>(auto&) const 5 0x12ecde313 WTF::Detail::CallableWrapper<WebCore::MediaSessionManagerCocoa::scheduleSessionStatusUpdate()::$_8::operator()()::'lambda'(auto&), void, WebCore::PlatformMediaSession&>::call(WebCore::PlatformMediaSession&) 6 0x13152697a WTF::Function<void (WebCore::PlatformMediaSession&)>::operator()(WebCore::PlatformMediaSession&) const 7 0x1315240aa WebCore::PlatformMediaSessionManager::forEachSession(WTF::Function<void (WebCore::PlatformMediaSession&)> const&) 8 0x12ecddfbb WebCore::MediaSessionManagerCocoa::scheduleSessionStatusUpdate()::$_8::operator()() 9 0x12ecddf0e WTF::Detail::CallableWrapper<WebCore::MediaSessionManagerCocoa::scheduleSessionStatusUpdate()::$_8, void>::call() 10 0x12d2b60a2 WTF::Function<void ()>::operator()() const 11 0x12d66c7b5 WebCore::GenericTaskQueue<WebCore::Timer>::enqueueTask(WTF::Function<void ()>&&)::'lambda'()::operator()() const 12 0x12d66c5ee WTF::Detail::CallableWrapper<WebCore::GenericTaskQueue<WebCore::Timer>::enqueueTask(WTF::Function<void ()>&&)::'lambda'(), void>::call() 13 0x12d2b60a2 WTF::Function<void ()>::operator()() const 14 0x131488d6f WebCore::TaskDispatcher<WebCore::Timer>::dispatchOneTask() 15 0x131488a45 WebCore::TaskDispatcher<WebCore::Timer>::sharedTimerFired() 16 0x1314903e1 WebCore::TaskDispatcher<WebCore::Timer>::sharedTimer()::$_2::operator()() const 17 0x13149039e WTF::Detail::CallableWrapper<WebCore::TaskDispatcher<WebCore::Timer>::sharedTimer()::$_2, void>::call() 18 0x12d2b60a2 WTF::Function<void ()>::operator()() const 19 0x12d2f907e WebCore::Timer::fired() 20 0x1314e67e4 WebCore::ThreadTimers::sharedTimerFiredInternal() 21 0x1314f3211 WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0::operator()() const 22 0x1314f31be WTF::Detail::CallableWrapper<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0, void>::call() 23 0x12d2b60a2 WTF::Function<void ()>::operator()() const 24 0x1314a3eeb WebCore::MainThreadSharedTimer::fired() 25 0x131566886 WebCore::timerFired(__CFRunLoopTimer*, void*) 26 0x7fff2047390d __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 27 0x7fff204733e8 __CFRunLoopDoTimer 28 0x7fff20472f42 __CFRunLoopDoTimers 29 0x7fff2045957f __CFRunLoopRun 30 0x7fff204586ce CFRunLoopRunSpecific 31 0x10b15ac7a runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) Able to reproduce issue using command: run-webkit-tests imported/w3c/web-platform-tests/shadow-dom/declarative/declarative-shadow-dom-attachment.tentative.html --debug --iterations 1000 -f 1727281 1 webkit-bug-importer 2021-02-09 14:56:08 -0800 <rdar://problem/74161017> 1727338 2 419785 eric.carlson 2021-02-09 16:54:10 -0800 Created attachment 419785 Patch 1727348 3 419785 rniwa 2021-02-09 17:16:06 -0800 Comment on attachment 419785 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419785&action=review > Source/WebCore/html/MediaElementSession.cpp:-131 > - addedMediaUsageManagerSessionIfNecessary(); LOL. 1727397 4 ews-feeder 2021-02-09 19:31:02 -0800 Committed r272633: <https://commits.webkit.org/r272633> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419785. 419785 2021-02-09 16:54:10 -0800 2021-02-09 19:31:04 -0800 Patch bug-221634-20210209165409.patch text/plain 3380 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzc4NjI2YjVlMDY5N2E5 NGZlYjRmNTlmZTk1YzQ2OTI5NzE2NmNmMi4uODhjNTExMzcwNjI0MzgzYTQ5NjIzZTM5YzYxMTUx ZjkyYWI1YTMxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTAyLTA5ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046 IChyMjcyNDU4KTogW0JpZ1N1ciBEZWJ1Z10gQVNTRVJUSU9OIEZBSUxFRDogbV9oYXZlQWRkZWRN ZWRpYVVzYWdlTWFuYWdlclNlc3Npb24gaW4gV2ViQ29yZTo6TWVkaWFFbGVtZW50U2Vzc2lvbjo6 dXBkYXRlTWVkaWFVc2FnZUlmQ2hhbmdlZCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE2MzQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc0MTYx MDE3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgdGhpcyBmaXhlcyBhbiBhc3NlcnRpb24gaW4gYW4gZXhpc3RpbmcgdGVzdC4K KworICAgICAgICAqIGh0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpNZWRpYUVsZW1lbnRTZXNzaW9uOjpNZWRpYUVsZW1lbnRTZXNzaW9uKToKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhRWxlbWVudFNlc3Npb246OmFkZE1lZGlhVXNhZ2VNYW5hZ2VyU2Vzc2lv bklmTmVjZXNzYXJ5KToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhRWxlbWVudFNlc3Npb246Omlu QWN0aXZlRG9jdW1lbnRDaGFuZ2VkKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhRWxlbWVudFNl c3Npb246OnVwZGF0ZU1lZGlhVXNhZ2VJZkNoYW5nZWQpOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFFbGVtZW50U2Vzc2lvbjo6YWRkZWRNZWRpYVVzYWdlTWFuYWdlclNlc3Npb25JZk5lY2Vzc2Fy eSk6IERlbGV0ZWQuCisgICAgICAgICogaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmg6CisKIDIw MjEtMDItMDkgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFtD b2NvYV0gcmVuYW1lIGBFTkdJTkVFUklOR19CVUlMRGAgdG8gYEVOQUJMRV9ERVZFTE9QRVJfTU9E RWAgdG8gbWF0Y2ggb3RoZXIgcGxhdGZvcm1zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVs ZW1lbnRTZXNzaW9uLmNwcAppbmRleCBkMWMwMzczODhlMWM3NDNhODdiMDhjOTI5MGJkMzkzOGVh Mzg2NzIzLi44Mzk2ZmY2ZjQ2MzI4MjhlNjAzOWE1ZDNmNDlkNjgzYjExOTE3YjI1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAKQEAgLTEyOCw3ICsxMjgs NiBAQCBNZWRpYUVsZW1lbnRTZXNzaW9uOjpNZWRpYUVsZW1lbnRTZXNzaW9uKEhUTUxNZWRpYUVs ZW1lbnQmIGVsZW1lbnQpCiAgICAgLCBtX2xvZ0lkZW50aWZpZXIoZWxlbWVudC5sb2dJZGVudGlm aWVyKCkpCiAjZW5kaWYKIHsKLSAgICBhZGRlZE1lZGlhVXNhZ2VNYW5hZ2VyU2Vzc2lvbklmTmVj ZXNzYXJ5KCk7CiB9CiAKIE1lZGlhRWxlbWVudFNlc3Npb246On5NZWRpYUVsZW1lbnRTZXNzaW9u KCkKQEAgLTE0MCw3ICsxMzksNyBAQCBNZWRpYUVsZW1lbnRTZXNzaW9uOjp+TWVkaWFFbGVtZW50 U2Vzc2lvbigpCiAjZW5kaWYKIH0KIAotdm9pZCBNZWRpYUVsZW1lbnRTZXNzaW9uOjphZGRlZE1l ZGlhVXNhZ2VNYW5hZ2VyU2Vzc2lvbklmTmVjZXNzYXJ5KCkKK3ZvaWQgTWVkaWFFbGVtZW50U2Vz c2lvbjo6YWRkTWVkaWFVc2FnZU1hbmFnZXJTZXNzaW9uSWZOZWNlc3NhcnkoKQogewogI2lmIEVO QUJMRShNRURJQV9VU0FHRSkKICAgICBpZiAobV9oYXZlQWRkZWRNZWRpYVVzYWdlTWFuYWdlclNl c3Npb24pCkBAIC0yMjEsNyArMjIwLDYgQEAgdm9pZCBNZWRpYUVsZW1lbnRTZXNzaW9uOjppbkFj dGl2ZURvY3VtZW50Q2hhbmdlZCgpCiB7CiAgICAgbV9lbGVtZW50SXNIaWRkZW5CZWNhdXNlSXRX YXNSZW1vdmVkRnJvbURPTSA9ICFtX2VsZW1lbnQuaW5BY3RpdmVEb2N1bWVudCgpOwogICAgIHNj aGVkdWxlQ2xpZW50RGF0YUJ1ZmZlcmluZ0NoZWNrKCk7Ci0gICAgYWRkZWRNZWRpYVVzYWdlTWFu YWdlclNlc3Npb25JZk5lY2Vzc2FyeSgpOwogfQogCiB2b2lkIE1lZGlhRWxlbWVudFNlc3Npb246 OnNjaGVkdWxlQ2xpZW50RGF0YUJ1ZmZlcmluZ0NoZWNrKCkKQEAgLTExNjksNyArMTE2Nyw3IEBA IHZvaWQgTWVkaWFFbGVtZW50U2Vzc2lvbjo6dXBkYXRlTWVkaWFVc2FnZUlmQ2hhbmdlZCgpCiAg ICAgbV9tZWRpYVVzYWdlSW5mbyA9IFdURk1vdmUodXNhZ2UpOwogCiAjaWYgRU5BQkxFKE1FRElB X1VTQUdFKQotICAgIEFTU0VSVChtX2hhdmVBZGRlZE1lZGlhVXNhZ2VNYW5hZ2VyU2Vzc2lvbik7 CisgICAgYWRkTWVkaWFVc2FnZU1hbmFnZXJTZXNzaW9uSWZOZWNlc3NhcnkoKTsKICAgICBwYWdl LT5jaHJvbWUoKS5jbGllbnQoKS51cGRhdGVNZWRpYVVzYWdlTWFuYWdlclNlc3Npb25TdGF0ZSht ZWRpYVNlc3Npb25JZGVudGlmaWVyKCksICptX21lZGlhVXNhZ2VJbmZvKTsKICNlbmRpZgogfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmggYi9T b3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uaAppbmRleCBkNzFlNGRiYjRm MDNjNDM2ZWYzNGVjOTRjZWU0NzAyYWVhMmEwMWJkLi4wNzU3OTBiNTRkYWJiODVkMTljYzg5M2Vi MDFlOTUyNTk2ZTYwMjJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxl bWVudFNlc3Npb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Np b24uaApAQCAtMTk5LDcgKzE5OSw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBjbGllbnREYXRhQnVm ZmVyaW5nVGltZXJGaXJlZCgpOwogICAgIHZvaWQgdXBkYXRlQ2xpZW50RGF0YUJ1ZmZlcmluZygp OwogCi0gICAgdm9pZCBhZGRlZE1lZGlhVXNhZ2VNYW5hZ2VyU2Vzc2lvbklmTmVjZXNzYXJ5KCk7 CisgICAgdm9pZCBhZGRNZWRpYVVzYWdlTWFuYWdlclNlc3Npb25JZk5lY2Vzc2FyeSgpOwogCiAg ICAgSFRNTE1lZGlhRWxlbWVudCYgbV9lbGVtZW50OwogICAgIEJlaGF2aW9yUmVzdHJpY3Rpb25z IG1fcmVzdHJpY3Rpb25zOwo=