221551 2021-02-08 07:05:04 -0800 Fix WebXRWebGLLayer m_isCompositionDisabled checks 2021-04-19 03:28:46 -0700 1 1 1 Unclassified WebKit WebXR WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 208988 1 ifernandez ifernandez svillar webkit-bug-importer oldest_to_newest 1726626 0 ifernandez 2021-02-08 07:05:04 -0800 m_isCompositionDisabled checks are reversed 1726629 1 419589 ifernandez 2021-02-08 07:09:29 -0800 Created attachment 419589 Patch 1726635 2 419589 svillar 2021-02-08 07:25:02 -0800 Comment on attachment 419589 Patch :) double negations. Good catch! 1726647 3 ews-feeder 2021-02-08 08:14:40 -0800 Committed r272491: <https://commits.webkit.org/r272491> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419589. 1727790 4 webkit-bug-importer 2021-02-10 14:33:33 -0800 <rdar://problem/74206649> 419589 2021-02-08 07:09:29 -0800 2021-02-08 08:14:40 -0800 Patch bug-221551-20210208160928.patch text/plain 2324 ifernandez U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTJhMDdmN2EyNWM5MjRh YWMzZGU0YjBjMjczNjliYzAzMGNlZDVlOC4uZWVkNGQwYWVmYjJkMjY3YTgzMTNiYmQxYjM0MWE2 YWQxNGE1OTJiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTA4ICBJbWFu b2wgRmVybmFuZGV6ICA8aWZlcm5hbmRlekBpZ2FsaWEuY29tPgorCisgICAgICAgIEZpeCBXZWJY UldlYkdMTGF5ZXIgbV9pc0NvbXBvc2l0aW9uRGlzYWJsZWQgY2hlY2tzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE1NTEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggcmV2ZXJzZWQgbV9pc0NvbXBv c2l0aW9uRGlzYWJsZWQgY2hlY2tzLgorCisgICAgICAgICogTW9kdWxlcy93ZWJ4ci9XZWJYUldl YkdMTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViWFJXZWJHTExheWVyOjpjcmVhdGUp OgorICAgICAgICAoV2ViQ29yZTo6V2ViWFJXZWJHTExheWVyOjpXZWJYUldlYkdMTGF5ZXIpOgor CiAyMDIxLTAyLTA4ICBGcsOpZMOpcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgogCiAgICAg ICAgIFBlcmZvcm0gbGF5b3V0IGJlZm9yZSBydW5uaW5nIEVkaXRvcjo6ZmluZFN0cmluZwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9XZWJYUldlYkdMTGF5ZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9XZWJYUldlYkdMTGF5ZXIuY3BwCmluZGV4 IDg2ZGQxMWIwMDE0M2JmODBlYTgxYWUyYWRkOGRlODRkYzAyZDAzM2YuLjY0ZjUyNTkxYjdjMjZl ZGRkMjAzN2U0MjFlZmNlNmQ5MTgxN2E5ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvd2VieHIvV2ViWFJXZWJHTExheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3dlYnhyL1dlYlhSV2ViR0xMYXllci5jcHAKQEAgLTc0LDcgKzc0LDcgQEAgRXhjZXB0aW9u T3I8UmVmPFdlYlhSV2ViR0xMYXllcj4+IFdlYlhSV2ViR0xMYXllcjo6Y3JlYXRlKFJlZjxXZWJY UlNlc3Npb24+JiYgc2UKICAgICAgICAgICAgIC8vIDkuIChzZWUgY29uc3RydWN0b3IgZXhjZXB0 IGZvciB0aGUgcmVzb3VyY2VzIGluaXRpYWxpemF0aW9uIHN0ZXAgd2hpY2ggaXMgaGFuZGxlZCBp biB0aGUgaWYgYmxvY2sgYmVsb3cpCiAgICAgICAgICAgICBhdXRvIGxheWVyID0gYWRvcHRSZWYo Km5ldyBXZWJYUldlYkdMTGF5ZXIoV1RGTW92ZShzZXNzaW9uKSwgV1RGTW92ZShjb250ZXh0KSwg aW5pdCkpOwogCi0gICAgICAgICAgICBpZiAobGF5ZXItPm1faXNDb21wb3NpdGlvbkRpc2FibGVk KSB7CisgICAgICAgICAgICBpZiAoIWxheWVyLT5tX2lzQ29tcG9zaXRpb25EaXNhYmxlZCkgewog ICAgICAgICAgICAgICAgIC8vIDkuNC4gQWxsb2NhdGUgYW5kIGluaXRpYWxpemUgcmVzb3VyY2Vz IGNvbXBhdGlibGUgd2l0aCBzZXNzaW9u4oCZcyBYUiBkZXZpY2UsIGluY2x1ZGluZyBHUFUgYWNj ZXNzaWJsZSBtZW1vcnkgYnVmZmVycywKICAgICAgICAgICAgICAgICAvLyAgICAgIGFzIHJlcXVp cmVkIHRvIHN1cHBvcnQgdGhlIGNvbXBvc2l0aW5nIG9mIGxheWVyLgogICAgICAgICAgICAgICAg IC8vIDkuNS4gSWYgbGF5ZXLigJlzIHJlc291cmNlcyB3ZXJlIHVuYWJsZSB0byBiZSBjcmVhdGVk IGZvciBhbnkgcmVhc29uLCB0aHJvdyBhbiBPcGVyYXRpb25FcnJvciBhbmQgYWJvcnQgdGhlc2Ug c3RlcHMuCkBAIC0xMDksNyArMTA5LDcgQEAgV2ViWFJXZWJHTExheWVyOjpXZWJYUldlYkdMTGF5 ZXIoUmVmPFdlYlhSU2Vzc2lvbj4mJiBzZXNzaW9uLCBXZWJYUlJlbmRlcmluZ0NvbnQKICAgICBt X2lzQ29tcG9zaXRpb25EaXNhYmxlZCA9IG1fc2Vzc2lvbi0+bW9kZSgpID09IFhSU2Vzc2lvbk1v ZGU6OklubGluZTsKIAogICAgIC8vIDkuIElmIGxheWVy4oCZcyBjb21wb3NpdGlvbiBkaXNhYmxl ZCBib29sZWFuIGlzIGZhbHNlOgotICAgIGlmIChtX2lzQ29tcG9zaXRpb25EaXNhYmxlZCkgewor ICAgIGlmICghbV9pc0NvbXBvc2l0aW9uRGlzYWJsZWQpIHsKICAgICAgICAgLy8gIDEuIEluaXRp YWxpemUgbGF5ZXLigJlzIGFudGlhbGlhcyB0byBsYXllckluaXTigJlzIGFudGlhbGlhcyB2YWx1 ZS4KICAgICAgICAgbV9hbnRpYWxpYXMgPSBpbml0LmFudGlhbGlhczsKIAo=