22111 2008-11-06 12:15:44 -0800 [Transforms] Event handling in <video> controls is broken if the video is transformed 2008-11-19 18:44:45 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 15670 1 simon.fraser simon.fraser oldest_to_newest 97857 0 simon.fraser 2008-11-06 12:15:44 -0800 Video control seem to have event handling issues when the video is transformed, or has a transformed parent. Bug 22109 fixes the slider issues, but there are others (e.g. you can click the play button, and it responds, but the video does not play). 97860 1 24952 simon.fraser 2008-11-06 12:19:25 -0800 Created attachment 24952 Testcase 97861 2 24953 simon.fraser 2008-11-06 12:20:53 -0800 Created attachment 24953 Fixed testcase 99411 3 25299 simon.fraser 2008-11-19 18:31:13 -0800 Created attachment 25299 Patch, testcase, changelog 99416 4 25299 koivisto 2008-11-19 18:40:18 -0800 Comment on attachment 25299 Patch, testcase, changelog r=me That FIXME in MediaPlayer could be more enlightening. 99417 5 simon.fraser 2008-11-19 18:44:45 -0800 Fixed the comment, and committed: Committed r38612 M WebCore/ChangeLog M WebCore/platform/graphics/MediaPlayer.h M WebCore/rendering/RenderMedia.cpp A LayoutTests/media/video-controls-transformed-expected.txt A LayoutTests/media/video-controls-transformed.html M LayoutTests/ChangeLog r38612 = 154846681526fcb9b0fb6b824768fa0c30f14020 (trunk) 24952 2008-11-06 12:19:25 -0800 2008-11-06 12:20:53 -0800 Testcase transformed-video-controls.html text/html 338 simon.fraser PHZpZGVvIGNvbnRyb2xzIHN0eWxlPSItd2Via2l0LXRyYW5zZm9ybTogcm90YXRlKC00NWRlZyk7 IC13ZWJraXQtdHJhbnNmb3JtLW9yaWdpbjogdG9wIHJpZ2h0OyI+PC92aWRlbz4KPCEtLSA8dmlk ZW8gY29udHJvbHM+PC92aWRlbz4gLS0+CjxwPlRlc3QgJ2NvbnRyb2xzJyBhdHRyaWJ1dGU8cD4K PHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48L3NjcmlwdD4KPHNjcmlwdD4KdmlkZW8uc3JjID0g J2h0dHA6Ly9tb3ZpZXMuYXBwbGUuY29tL21vdmllcy9mb3hfc2VhcmNobGlnaHQvc2x1bWRvZ21p bGxpb25haXJlL3NsdW1kb2dtaWxsaW9uYWlyZV9oLjMyMC5tb3YnOwo8L3NjcmlwdD4KCgo= 24953 2008-11-06 12:20:53 -0800 2008-11-06 12:20:53 -0800 Fixed testcase transformed-video-controls.html text/html 386 simon.fraser PGh0bWw+Cjxib2R5Pgo8dmlkZW8gaWQ9InZpZGVvIiBjb250cm9scyBzdHlsZT0iLXdlYmtpdC10 cmFuc2Zvcm06IHJvdGF0ZSgtNDVkZWcpOyAtd2Via2l0LXRyYW5zZm9ybS1vcmlnaW46IHRvcCBy aWdodDsiPjwvdmlkZW8+CjwhLS0gPHZpZGVvIGNvbnRyb2xzPjwvdmlkZW8+IC0tPgo8cD5UZXN0 ICdjb250cm9scycgYXR0cmlidXRlPHA+CjxzY3JpcHQ+CnZhciB2aWRlbyA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCd2aWRlbycpOwp2aWRlby5zcmMgPSAnaHR0cDovL21vdmllcy5hcHBsZS5j b20vbW92aWVzL2ZveF9zZWFyY2hsaWdodC9zbHVtZG9nbWlsbGlvbmFpcmUvc2x1bWRvZ21pbGxp b25haXJlX2guMzIwLm1vdic7Cjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4= 25299 2008-11-19 18:31:13 -0800 2008-11-19 18:40:18 -0800 Patch, testcase, changelog 22111_patch.txt text/plain 6169 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwMDgwNzIyLi5mMmY0ZTM1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTEt MTkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyMTExCisgICAgICAgIAorICAgICAgICBUZXN0Y2FzZSBmb3Ig aGl0IHRlc3RpbmcgaW4gdmlkZW8gY29udHJvbHMgb24gdHJhbnNmb3JtZWQgdmlkZW8uCisKKyAg ICAgICAgKiBtZWRpYS92aWRlby1jb250cm9scy10cmFuc2Zvcm1lZC1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIG1lZGlhL3ZpZGVvLWNvbnRyb2xzLXRyYW5zZm9ybWVkLmh0bWw6IEFk ZGVkLgorCiAyMDA4LTExLTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xzLXRyYW5zZm9ybWVkLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xzLXRyYW5zZm9ybWVkLWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5lYTBlNzk0Ci0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY29udHJvbHMtdHJhbnNmb3JtZWQtZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEsOSBAQAorVGVzdCBjb250cm9scyBvbiB0cmFuc2Zvcm1lZCB2aWRlby4K KworVGhpcyB0ZXN0IG9ubHkgcnVucyBpbiBEUlQhCisKK1RFU1QodmlkZW8uY29udHJvbHMpIE9L CitFVkVOVChsb2FkKQorVEVTVCghdmlkZW8ucGF1c2VkKSBPSworRU5EIE9GIFRFU1QKKwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY29udHJvbHMtdHJhbnNmb3JtZWQuaHRt bCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xzLXRyYW5zZm9ybWVkLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uY2I3OWI0NwotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xzLXRyYW5zZm9ybWVkLmh0bWwKQEAg LTAsMCArMSwzMCBAQAorPGh0bWw+Cis8aGVhZD4KKyAgPHRpdGxlPlRlc3QgY29udHJvbHMgb24g dHJhbnNmb3JtZWQgdmlkZW88L3RpdGxlPgorICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1lZGlh PSJzY3JlZW4iPgorICAgIHZpZGVvIHsKKyAgICAgIG1hcmdpbjogNTBweDsKKyAgICAgIC13ZWJr aXQtdHJhbnNmb3JtOiByb3RhdGUoMjBkZWcpOworICAgIH0KKyAgPC9zdHlsZT4KKzwvaGVhZD4K Kzxib2R5PgorICA8dmlkZW8gY29udHJvbHM+PC92aWRlbz4KKzxwPlRlc3QgY29udHJvbHMgb24g dHJhbnNmb3JtZWQgdmlkZW8uPC9wPgorPHA+VGhpcyB0ZXN0IG9ubHkgcnVucyBpbiBEUlQhPC9w PgorPHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48L3NjcmlwdD4KKzxzY3JpcHQ+Cit0ZXN0KCJ2 aWRlby5jb250cm9scyIpOword2FpdEZvckV2ZW50KCdsb2FkJywgZnVuY3Rpb24gKCkgeworICBp ZiAod2luZG93LmV2ZW50U2VuZGVyKSB7CisgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDU0 LDI0MCk7IC8vIG92ZXIgcGxheSBidXR0b24KKyAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7 CisgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKyAgfQorICB0ZXN0KCIhdmlkZW8ucGF1c2Vk Iik7CisgIGVuZFRlc3QoKTsKK30gKTsKK3ZpZGVvLnNyYyA9ICdjb250ZW50L3Rlc3QubXA0JzsK Kzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNzEyYjJmLi5mMjdkNjlmIDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIz IEBACiAyMDA4LTExLTE5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgog CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTExCisgICAgICAgIAor ICAgICAgICBGaXggaGl0IHRlc3RpbmcgaW4gY29udHJvbHMgb24gdHJhbnNmb3JtZWQgdmlkZW8g ZWxlbWVudHMKKyAgICAgICAgYnkgcmVwbGFjaW5nIGFic29sdXRlQm91bmRpbmdCb3hSZWN0KCku Y29udGFpbnMoKSB3aXRoCisgICAgICAgIGNvZGUgdGhhdCBtYXBzIHRoZSBwb2ludCBpbnRvIGxv Y2FsIGNvb3JkcywgdGFraW5nCisgICAgICAgIHRyYW5zZm9ybXMgaW50byBhY2NvdW50LgorCisg ICAgICAgIFRlc3Q6IG1lZGlhL3ZpZGVvLWNvbnRyb2xzLXRyYW5zZm9ybWVkLmh0bWwKKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmg6CisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlck1lZGlhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJlbmRlcmVyQ29udGFpbnNQ b2ludCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJNZWRpYTo6Zm9yd2FyZEV2ZW50KToKKwor MjAwOC0xMS0xOSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAg ICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlcgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM0OApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9NZWRpYVBsYXllci5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRp YVBsYXllci5oCmluZGV4IDFiZWFiOTUuLjdiOGI3MGMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL01lZGlhUGxheWVyLmgKQEAgLTY3LDYgKzY3LDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0 RnJhbWVWaWV3KEZyYW1lVmlldyogZnJhbWVWaWV3KSB7IG1fZnJhbWVWaWV3ID0gZnJhbWVWaWV3 OyB9CiAgICAgYm9vbCBpbk1lZGlhRG9jdW1lbnQoKTsKICAgICAKKyAgICAvLyBGSVhNRTogdGhp cyBpcyBub25zZW5zaWNhbCBpZiB0aGUgdmlkZW8gaXMgdHJhbnNmb3JtZWQKICAgICBJbnRSZWN0 IHJlY3QoKSBjb25zdCB7IHJldHVybiBtX3JlY3Q7IH0KICAgICB2b2lkIHNldFJlY3QoY29uc3Qg SW50UmVjdCYgcik7CiAgICAgCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJN ZWRpYS5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZWRpYS5jcHAKaW5kZXggNDk1M2Ez NS4uZTExZWExZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWVkaWEuY3Bw CisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lZGlhLmNwcApAQCAtMzU1LDIzICszNTUs MzYgQEAgdm9pZCBSZW5kZXJNZWRpYTo6b3BhY2l0eUFuaW1hdGlvblRpbWVyRmlyZWQoVGltZXI8 UmVuZGVyTWVkaWE+KikKICAgICBmbG9hdCBvcGFjaXR5ID0gbmFycm93UHJlY2lzaW9uVG9GbG9h dChtX29wYWNpdHlBbmltYXRpb25Gcm9tICsgKG1fb3BhY2l0eUFuaW1hdGlvblRvIC0gbV9vcGFj aXR5QW5pbWF0aW9uRnJvbSkgKiB0aW1lIC8gY09wYWNpdHlBbmltYXRpb25EdXJhdGlvbik7CiAg ICAgY2hhbmdlT3BhY2l0eShtX3BhbmVsLmdldCgpLCBvcGFjaXR5KTsKIH0KLSAgICAKKworc3Rh dGljIGJvb2wgcmVuZGVyZXJDb250YWluc1BvaW50KGNvbnN0IFJlbmRlck9iamVjdCogciwgY29u c3QgSW50UG9pbnQmIGFic1BvaW50KQoreworICAgIGlmICghcikKKyAgICAgICAgcmV0dXJuIGZh bHNlOworICAgIEZsb2F0UG9pbnQgbG9jYWxQb2ludCA9IHItPmFic29sdXRlVG9Mb2NhbChhYnNQ b2ludCwgZmFsc2UsIHRydWUpOyAgLy8gcmVzcGVjdCB0cmFuc2Zvcm1zCisgICAgcmV0dXJuIHIt PmJvcmRlckJveCgpLmNvbnRhaW5zKHJvdW5kZWRJbnRQb2ludChsb2NhbFBvaW50KSk7Cit9CisK IHZvaWQgUmVuZGVyTWVkaWE6OmZvcndhcmRFdmVudChFdmVudCogZXZlbnQpCiB7CiAgICAgaWYg KGV2ZW50LT5pc01vdXNlRXZlbnQoKSAmJiBtX2NvbnRyb2xzU2hhZG93Um9vdCkgewogICAgICAg ICBNb3VzZUV2ZW50KiBtb3VzZUV2ZW50ID0gc3RhdGljX2Nhc3Q8TW91c2VFdmVudCo+KGV2ZW50 KTsKICAgICAgICAgSW50UG9pbnQgcG9pbnQobW91c2VFdmVudC0+cGFnZVgoKSwgbW91c2VFdmVu dC0+cGFnZVkoKSk7Ci0gICAgICAgIGlmIChtX211dGVCdXR0b24gJiYgbV9tdXRlQnV0dG9uLT5y ZW5kZXJlcigpICYmIG1fbXV0ZUJ1dHRvbi0+cmVuZGVyZXIoKS0+YWJzb2x1dGVCb3VuZGluZ0Jv eFJlY3QoKS5jb250YWlucyhwb2ludCkpCisgICAgICAgIGlmIChtX211dGVCdXR0b24gJiYgcmVu ZGVyZXJDb250YWluc1BvaW50KG1fbXV0ZUJ1dHRvbi0+cmVuZGVyZXIoKSwgcG9pbnQpKQogICAg ICAgICAgICAgbV9tdXRlQnV0dG9uLT5kZWZhdWx0RXZlbnRIYW5kbGVyKGV2ZW50KTsKLSAgICAg ICAgaWYgKG1fcGxheUJ1dHRvbiAmJiBtX3BsYXlCdXR0b24tPnJlbmRlcmVyKCkgJiYgbV9wbGF5 QnV0dG9uLT5yZW5kZXJlcigpLT5hYnNvbHV0ZUJvdW5kaW5nQm94UmVjdCgpLmNvbnRhaW5zKHBv aW50KSkKKworICAgICAgICBpZiAobV9wbGF5QnV0dG9uICYmIHJlbmRlcmVyQ29udGFpbnNQb2lu dChtX3BsYXlCdXR0b24tPnJlbmRlcmVyKCksIHBvaW50KSkKICAgICAgICAgICAgIG1fcGxheUJ1 dHRvbi0+ZGVmYXVsdEV2ZW50SGFuZGxlcihldmVudCk7Ci0gICAgICAgIGlmIChtX3NlZWtCYWNr QnV0dG9uICYmIG1fc2Vla0JhY2tCdXR0b24tPnJlbmRlcmVyKCkgJiYgbV9zZWVrQmFja0J1dHRv bi0+cmVuZGVyZXIoKS0+YWJzb2x1dGVCb3VuZGluZ0JveFJlY3QoKS5jb250YWlucyhwb2ludCkp CisKKyAgICAgICAgaWYgKG1fc2Vla0JhY2tCdXR0b24gJiYgcmVuZGVyZXJDb250YWluc1BvaW50 KG1fc2Vla0JhY2tCdXR0b24tPnJlbmRlcmVyKCksIHBvaW50KSkKICAgICAgICAgICAgIG1fc2Vl a0JhY2tCdXR0b24tPmRlZmF1bHRFdmVudEhhbmRsZXIoZXZlbnQpOwotICAgICAgICBpZiAobV9z ZWVrRm9yd2FyZEJ1dHRvbiAmJiBtX3NlZWtGb3J3YXJkQnV0dG9uLT5yZW5kZXJlcigpICYmIG1f c2Vla0ZvcndhcmRCdXR0b24tPnJlbmRlcmVyKCktPmFic29sdXRlQm91bmRpbmdCb3hSZWN0KCku Y29udGFpbnMocG9pbnQpKQorCisgICAgICAgIGlmIChtX3NlZWtGb3J3YXJkQnV0dG9uICYmIHJl bmRlcmVyQ29udGFpbnNQb2ludChtX3NlZWtGb3J3YXJkQnV0dG9uLT5yZW5kZXJlcigpLCBwb2lu dCkpCiAgICAgICAgICAgICBtX3NlZWtGb3J3YXJkQnV0dG9uLT5kZWZhdWx0RXZlbnRIYW5kbGVy KGV2ZW50KTsKLSAgICAgICAgaWYgKG1fdGltZWxpbmUgJiYgbV90aW1lbGluZS0+cmVuZGVyZXIo KSAmJiBtX3RpbWVsaW5lLT5yZW5kZXJlcigpLT5hYnNvbHV0ZUJvdW5kaW5nQm94UmVjdCgpLmNv bnRhaW5zKHBvaW50KSkKKworICAgICAgICBpZiAobV90aW1lbGluZSAmJiByZW5kZXJlckNvbnRh aW5zUG9pbnQobV90aW1lbGluZS0+cmVuZGVyZXIoKSwgcG9pbnQpKQogICAgICAgICAgICAgbV90 aW1lbGluZS0+ZGVmYXVsdEV2ZW50SGFuZGxlcihldmVudCk7Ci0gICAgICAgIGlmIChtX2Z1bGxz Y3JlZW5CdXR0b24gJiYgbV9mdWxsc2NyZWVuQnV0dG9uLT5yZW5kZXJlcigpICYmIG1fZnVsbHNj cmVlbkJ1dHRvbi0+cmVuZGVyZXIoKS0+YWJzb2x1dGVCb3VuZGluZ0JveFJlY3QoKS5jb250YWlu cyhwb2ludCkpCisKKyAgICAgICAgaWYgKG1fZnVsbHNjcmVlbkJ1dHRvbiAmJiByZW5kZXJlckNv bnRhaW5zUG9pbnQobV9mdWxsc2NyZWVuQnV0dG9uLT5yZW5kZXJlcigpLCBwb2ludCkpCiAgICAg ICAgICAgICBtX2Z1bGxzY3JlZW5CdXR0b24tPmRlZmF1bHRFdmVudEhhbmRsZXIoZXZlbnQpOwog ICAgICAgICAKICAgICAgICAgaWYgKGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLm1vdXNl b3ZlckV2ZW50KSB7Cg==