221029 2021-01-27 01:52:23 -0800 REGRESSION(r271634): keyring still failing to retrieve secrets 2021-10-07 18:55:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220736 https://bugs.webkit.org/show_bug.cgi?id=231381 InRadar P2 Normal --- 1 pnormand pnormand mcatanzaro svillar webkit-bug-importer oldest_to_newest 1722871 0 pnormand 2021-01-27 01:52:23 -0800 Bug 220736 is still happening. Downgrading keyring to 7.3.1 makes it work again. This module is now optional in the github scm module, I'm not sure why the version was bumped in the first place, anyway. 1722872 1 418516 pnormand 2021-01-27 01:55:29 -0800 Created attachment 418516 Patch 1722958 2 418516 mcatanzaro 2021-01-27 06:54:41 -0800 Comment on attachment 418516 Patch I agree this is the version of the patch that should land. But could you please also test if the newest version, 22.0.1, works? We can't actually upgrade to that now, because it doesn't support python2, but if it doesn't work then we need to investigate further and figure out what has gone wrong. P.S. The keyring package was upgraded for no reason, see https://bugs.webkit.org/show_bug.cgi?id=220736#c12. So downgrading should be fine. But it will be upgraded again eventually.... 1722961 3 pnormand 2021-01-27 07:01:52 -0800 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 418516 [details] > Patch > > I agree this is the version of the patch that should land. > > But could you please also test if the newest version, 22.0.1, works? We > can't actually upgrade to that now, because it doesn't support python2, but > if it doesn't work then we need to investigate further and figure out what > has gone wrong. > This could be done as part of the migration of webkitpy to python3. IDK if there's a tracking bug for that though. > P.S. The keyring package was upgraded for no reason, see > https://bugs.webkit.org/show_bug.cgi?id=220736#c12. So downgrading should be > fine. But it will be upgraded again eventually.... Thanks for confirming! 1722966 4 mcatanzaro 2021-01-27 07:21:23 -0800 (In reply to Philippe Normand from comment #3) > This could be done as part of the migration of webkitpy to python3. IDK if > there's a tracking bug for that though. webkitpy already fully supports both python2 and python3, and both are tested on the EWS. The tracking bug for that was bug #184986. I was going to say: "If your runtime is based on freedesktop-sdk, it is probably already using python3, because python2 was removed in 19.08 and that was a pretty long time ago." But I see you are manually building python2 on top of freedesktop-sdk 20.08. So... if /usr/bin/python is still pointing to python2, that might indeed explain the behavior difference. Is there some strong reason that is still needed? It looks like all the python2 elements under Tools/buildstream/elements are only needed by sdk-platform.bst and that suggests they can probably just be dropped... assuming we don't notice any explosions when removed. Nothing in WebKit should still require python2. 1722967 5 mcatanzaro 2021-01-27 07:22:16 -0800 (afaik webkitpy maintains python2 support only for Apple internal reasons. All our scripts and dependencies should already be fully-compatible with python3. In theory.) 1722971 6 pnormand 2021-01-27 07:30:04 -0800 I added Python2 in the SDK indeed, and then moved on with other things :) I suppose it could be removed now indeed. 1722975 7 mcatanzaro 2021-01-27 07:33:38 -0800 Well maybe not, looks like bug #203701 might need fixed. (I guess it's been a very long time since I last attempted to run layout tests....) 1722981 8 pnormand 2021-01-27 07:38:02 -0800 Committed r271952: <https://trac.webkit.org/changeset/271952> 1722983 9 webkit-bug-importer 2021-01-27 07:39:12 -0800 <rdar://problem/73661761> 418516 2021-01-27 01:55:29 -0800 2021-01-27 02:24:29 -0800 Patch bug-221029-20210127015527.patch text/plain 2614 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxOTM4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2FkMmE3MmIxYjU5OGM1M2UxNThiZTNlNWY5Nzg2ODZh YWQzZWNlZC4uZDgzZWE3ODVjZDRmY2NkZDkwMjI2MjRhZGQzNjM2YjdkNDM5OTM3OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIxLTAxLTI3ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBSRUdSRVNTSU9OKHIyNzE2MzQpOiBrZXlyaW5nIHN0aWxsIGZhaWxpbmcgdG8g cmV0cmlldmUgc2VjcmV0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjIxMDI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS9zZXR1cC5weTogUmVkdWNl IHZlcnNpb24gbnVtYmVyIGR1cGxpY2F0aW9uIGJ5IHJldXNpbmcgdGhlCisgICAgICAgIFZlcnNp b24gb2JqZWN0IGRlY2xhcmVkIGluIHRoZSBwYWNrYWdlLgorICAgICAgICAqIFNjcmlwdHMvbGli cmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5OiBCdW1wIHZlcnNpb24g YW5kIGRvd25ncmFkZSB0bworICAgICAgICB1c2FibGUga2V5cmluZyB2ZXJzaW9uIChpbiBMaW51 eCBhdCBsZWFzdCkuCisKIDIwMjEtMDEtMjcgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPiBhbmQgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbRmxhdHBhayBTREtdIEZsYXRwYWsgMS4xMCBlbnZpcm9ubWVudCB2YXJpYWJsZSBpc3N1ZXMK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3NldHVwLnB5 IGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvc2V0dXAucHkKaW5kZXggNzRj YTFlOTBmYjc1NTE2OWI1ODM4M2MzY2VlOTFiYTNmMDdhMDFkMS4uOGRlNjEwMzk1YzhjODlmNzcw MzQ2NTRhM2Q4Mzc1MWFjZmIxZjE0MyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy9saWJyYXJp ZXMvd2Via2l0c2NtcHkvc2V0dXAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Vi a2l0c2NtcHkvc2V0dXAucHkKQEAgLTIxLDcgKzIxLDcgQEAKICMgU09GVFdBUkUsIEVWRU4gSUYg QURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKIGZyb20gc2V0dXB0 b29scyBpbXBvcnQgc2V0dXAKLQorZnJvbSB3ZWJraXRzY21weSBpbXBvcnQgdmVyc2lvbgogCiBk ZWYgcmVhZG1lKCk6CiAgICAgd2l0aCBvcGVuKCdSRUFETUUubWQnKSBhcyBmOgpAQCAtMzAsNyAr MzAsNyBAQCBkZWYgcmVhZG1lKCk6CiAKIHNldHVwKAogICAgIG5hbWU9J3dlYmtpdHNjbXB5JywK LSAgICB2ZXJzaW9uPScwLjkuNScsCisgICAgdmVyc2lvbj1yZXByKHZlcnNpb24pLAogICAgIGRl c2NyaXB0aW9uPSdMaWJyYXJ5IGRlc2lnbmVkIHRvIGludGVyYWN0IHdpdGggZ2l0IGFuZCBzdm4g cmVwb3NpdG9yaWVzLicsCiAgICAgbG9uZ19kZXNjcmlwdGlvbj1yZWFkbWUoKSwKICAgICBjbGFz c2lmaWVycz1bCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21w eS93ZWJraXRzY21weS9fX2luaXRfXy5weSBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtp dHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5CmluZGV4IDk3YzZhZDEzOTU1OWI3YmJkYTMz ZGY4Mjk5YzJjOWQ2MzliMTU3ZTYuLmIyNjFiMjg3ZTY2MWU2YWYxYTVkMzU2MzdmYjIzNDc1MjI4 NTU2ZmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dl YmtpdHNjbXB5L19faW5pdF9fLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtp dHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5CkBAIC00NiwxMSArNDYsMTEgQEAgZXhjZXB0 IEltcG9ydEVycm9yOgogICAgICAgICAiUGxlYXNlIGluc3RhbGwgd2Via2l0Y29yZXB5IHdpdGgg YHBpcCBpbnN0YWxsIHdlYmtpdGNvcmVweSAtLWV4dHJhLWluZGV4LXVybCA8cGFja2FnZSBpbmRl eCBVUkw+YCIKICAgICApCiAKLXZlcnNpb24gPSBWZXJzaW9uKDAsIDksIDUpCit2ZXJzaW9uID0g VmVyc2lvbigwLCA5LCA2KQogCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdlbnRyeXBv aW50cycsIFZlcnNpb24oMCwgMywgMCkpKQogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgn ZmFzdGVuZXJzJywgVmVyc2lvbigwLCAxNSwgMCkpKQotQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFj a2FnZSgna2V5cmluZycsIFZlcnNpb24oMTEsIDEsIDApKSkKK0F1dG9JbnN0YWxsLnJlZ2lzdGVy KFBhY2thZ2UoJ2tleXJpbmcnLCBWZXJzaW9uKDcsIDMsIDEpKSkKIEF1dG9JbnN0YWxsLnJlZ2lz dGVyKFBhY2thZ2UoJ21vbm90b25pYycsIFZlcnNpb24oMSwgNSkpKQogQXV0b0luc3RhbGwucmVn aXN0ZXIoUGFja2FnZSgneG1sdG9kaWN0JywgVmVyc2lvbigwLCAxMSwgMCkpKQogCg==