220938 2021-01-25 11:40:45 -0800 [GLIB] API tests fail to report harness failures 2021-01-27 08:58:29 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220922 https://bugs.webkit.org/show_bug.cgi?id=220366 https://bugs.webkit.org/show_bug.cgi?id=220863 InRadar P2 Normal --- 1 lmoura lmoura bugs-noreply cgarcia mcatanzaro webkit-bug-importer oldest_to_newest 1722168 0 lmoura 2021-01-25 11:40:45 -0800 The glib API test runner fails to report crashes in the test harness (e.g. the `beforeAll()` family of functions). This hid the issues setting up WebKitTestServer, related to bug220366 and bug220922 (reverted the original Soup commits). Patch almost ready. 1722385 1 418366 lmoura 2021-01-25 20:18:57 -0800 Created attachment 418366 Patch 1722416 2 418366 cgarcia 2021-01-26 00:42:13 -0800 Comment on attachment 418366 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418366&action=review Good catch, thanks! > Tools/glib/glib_test_runner.py:272 > + if (not self._results) and p.returncode != 0: Do we need the parentheses here? > Tools/glib/glib_test_runner.py:278 > + elif p.returncode != 0 and not need_restart: # Try to read errors from afterAll Don't use else after a return 1722545 3 418430 lmoura 2021-01-26 09:17:37 -0800 Created attachment 418430 Patch for landing. 1722702 4 ews-feeder 2021-01-26 13:33:38 -0800 Committed r271902: <https://trac.webkit.org/changeset/271902> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418430. 1722703 5 webkit-bug-importer 2021-01-26 13:34:13 -0800 <rdar://problem/73630623> 418366 2021-01-25 20:18:57 -0800 2021-01-26 09:17:32 -0800 Patch bug-220938-20210126011856.patch text/plain 2317 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxODcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2YxN2Y5YjVkYjg4Zjg0MDJiYmQwZDQ0OGQ2MWFmZjFm ZmUzYmFlZi4uMGJlYzZiZDAyN2MxZTU1ZTk4MTU3MmM3MmRlZmE2MjZkMDhmYTlmNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIxLTAxLTI1ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtHTElCXSBBUEkgdGVzdHMgZmFpbCB0byByZXBvcnQgaGFybmVzcyBmYWlsdXJlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwOTM4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIEdMaWJUZXN0 UnVubmVyIGNsYXNzIHBhcnNlcyB0aGUgc3Rkb3V0IG9mIHRoZSBjaGlsZCB0ZXN0IHByb2dyYW0g dG8KKyAgICAgICAgZGV0ZWN0IGZhaWx1cmVzIGFuZCBjcmFzaGVzIHVzaW5nIEdMaWIncyBnX3Rl c3RfKiBwcm90b2NvbCwgYnV0IHRoZQorICAgICAgICBzZXR1cCBhbmQgdGVhcmRvd24gb2YgZWFj aCBzdWl0ZS9wcm9ncmFtIGlzIGRvbmUgbWFudWFsbHkgaW4gdGhlCisgICAgICAgIGJlZm9yZUFs bC9hZnRlckFsbCBmdW5jdGlvbnMuIFRoZWlyIG91dHB1dC9zdGF0dXMgbmVlZCB0byBiZSBjaGVj a2VkCisgICAgICAgIHNlcGFyYXRlbHkgYnkgdGhlIHJ1bm5lciBzY3JpcHRzLgorCisgICAgICAg IFRoaXMgY29tbWl0IGNoZWNrcyBpZiBhIGZhaWx1cmUgaGFwcGVucyBiZWZvcmUgYW55IHRlc3Qg aXMgcnVuIChhCisgICAgICAgIGJlZm9yZUFsbCBmYWlsdXJlKSBhbmQgaWYgdGhlcmUgaXMgc3Rp bGwgcGVuZGluZyBzdGRlcnIgb3V0cHV0IG5vdAorICAgICAgICBwcm9jZXNzZWQgYnkgZ190ZXN0 X3J1biAoYW4gYWZ0ZXJBbGwgZmFpbHVyZSkuCisKKyAgICAgICAgKiBnbGliL2dsaWJfdGVzdF9y dW5uZXIucHk6CisgICAgICAgIChHTGliVGVzdFJ1bm5lci5ydW4pOgorCiAyMDIxLTAxLTI1ICBX ZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIEFTU0VSVCBO T1QgUkVBQ0hFRCBpbiBXZWJDb3JlOjpEaXNwbGF5TGlzdDo6aXNEcmF3aW5nSXRlbQpkaWZmIC0t Z2l0IGEvVG9vbHMvZ2xpYi9nbGliX3Rlc3RfcnVubmVyLnB5IGIvVG9vbHMvZ2xpYi9nbGliX3Rl c3RfcnVubmVyLnB5CmluZGV4IGM4MjY4OTc2YzlkZDE3ZGI2MDEyMjk4MGRiYTU5ZjA3MjBjZDNk MTcuLjYzNmYxMDdjNzJlZWQ0ZTk1NTVhZTgxZTFhNGRiNDAzYjBkNTg5ZTcgMTAwNjQ0Ci0tLSBh L1Rvb2xzL2dsaWIvZ2xpYl90ZXN0X3J1bm5lci5weQorKysgYi9Ub29scy9nbGliL2dsaWJfdGVz dF9ydW5uZXIucHkKQEAgLTI2OCw2ICsyNjgsMjAgQEAgY2xhc3MgR0xpYlRlc3RSdW5uZXIob2Jq ZWN0KToKICAgICAgICAgICAgIHNlbGYuX3N1YnRlc3RfZW5kKDI1NikKICAgICAgICAgICAgIG5l ZWRfcmVzdGFydCA9IFRydWUKIAorICAgICAgICAjIENoZWNrIGZvciBlcnJvcnMgYmVmb3JlIGFu eSB0ZXN0IGlzIHJ1bgorICAgICAgICBpZiAobm90IHNlbGYuX3Jlc3VsdHMpIGFuZCBwLnJldHVy bmNvZGUgIT0gMDoKKyAgICAgICAgICAgIGVycm9ycyA9IHNlbGYuX3JlYWRfZnJvbV9zdGRlcnIo c2VsZi5fc3RkZXJyX2ZkKQorICAgICAgICAgICAgc3lzLnN0ZG91dC53cml0ZSgnVGVzdCBwcm9n cmFtIHNldHVwIGZhaWxlZC5cbicpCisgICAgICAgICAgICBzZWxmLl9zdWJ0ZXN0X3N0ZGVycihl cnJvcnMpCisgICAgICAgICAgICBzZWxmLl9yZXN1bHRzWydiZWZvcmVBbGwnXSA9ICdDUkFTSCcK KyAgICAgICAgICAgIHJldHVybiBzZWxmLl9yZXN1bHRzCisgICAgICAgIGVsaWYgcC5yZXR1cm5j b2RlICE9IDAgYW5kIG5vdCBuZWVkX3Jlc3RhcnQ6ICAjIFRyeSB0byByZWFkIGVycm9ycyBmcm9t IGFmdGVyQWxsCisgICAgICAgICAgICBlcnJvcnMgPSBzZWxmLl9yZWFkX2Zyb21fc3RkZXJyKHNl bGYuX3N0ZGVycl9mZCkKKyAgICAgICAgICAgIHN5cy5zdGRvdXQud3JpdGUoJ1Rlc3QgcHJvZ3Jh bSBzaHV0ZG93biBmYWlsZWQuJykKKyAgICAgICAgICAgIHNlbGYuX3N1YnRlc3Rfc3RkZXJyKGVy cm9ycykKKyAgICAgICAgICAgIHNlbGYuX3Jlc3VsdHNbJ2FmdGVyQWxsJ10gPSAnQ1JBU0gnCisg ICAgICAgICAgICByZXR1cm4gc2VsZi5fcmVzdWx0cworCiAgICAgICAgIHNlbGYuX3N0ZGVycl9m ZCA9IE5vbmUKIAogICAgICAgICBpZiBuZWVkX3Jlc3RhcnQ6Cg== 418430 2021-01-26 09:17:37 -0800 2021-01-26 13:33:39 -0800 Patch for landing. bug-220938-20210126141735.patch text/plain 2351 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxODgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA4M2Q1MWFhMWNhMjcwOGVlYjM1YmIwN2VkMjQ5NTBi MGRlNWRmZC4uMTc1MzViYjlhZTUyYTg2MmQ3ZTYwZWE3Mjg5ZjFlMTAxNTdhM2E0NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIxLTAxLTI2ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtHTElCXSBBUEkgdGVzdHMgZmFpbCB0byByZXBvcnQgaGFybmVzcyBmYWlsdXJlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwOTM4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgQ2FybG9zIEdhcmNpYSBDYW1wb3MuCisKKyAgICAgICAgVGhlIEdM aWJUZXN0UnVubmVyIGNsYXNzIHBhcnNlcyB0aGUgc3Rkb3V0IG9mIHRoZSBjaGlsZCB0ZXN0IHBy b2dyYW0gdG8KKyAgICAgICAgZGV0ZWN0IGZhaWx1cmVzIGFuZCBjcmFzaGVzIHVzaW5nIEdMaWIn cyBnX3Rlc3RfKiBwcm90b2NvbCwgYnV0IHRoZQorICAgICAgICBzZXR1cCBhbmQgdGVhcmRvd24g b2YgZWFjaCBzdWl0ZS9wcm9ncmFtIGlzIGRvbmUgbWFudWFsbHkgaW4gdGhlCisgICAgICAgIGJl Zm9yZUFsbC9hZnRlckFsbCBmdW5jdGlvbnMuIFRoZWlyIG91dHB1dC9zdGF0dXMgbmVlZCB0byBi ZSBjaGVja2VkCisgICAgICAgIHNlcGFyYXRlbHkgYnkgdGhlIHJ1bm5lciBzY3JpcHRzLgorCisg ICAgICAgIFRoaXMgY29tbWl0IGNoZWNrcyBpZiBhIGZhaWx1cmUgaGFwcGVucyBiZWZvcmUgYW55 IHRlc3QgaXMgcnVuIChhCisgICAgICAgIGJlZm9yZUFsbCBmYWlsdXJlKSBhbmQgaWYgdGhlcmUg aXMgc3RpbGwgcGVuZGluZyBzdGRlcnIgb3V0cHV0IG5vdAorICAgICAgICBwcm9jZXNzZWQgYnkg Z190ZXN0X3J1biAoYW4gYWZ0ZXJBbGwgZmFpbHVyZSkuCisKKyAgICAgICAgKiBnbGliL2dsaWJf dGVzdF9ydW5uZXIucHk6CisgICAgICAgIChHTGliVGVzdFJ1bm5lci5ydW4pOgorCiAyMDIxLTAx LTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbU09VUF0gU3RvcCB1c2luZyBTb3VwUmVxdWVzdCBBUEkgdG8gbG9hZCBmaWxlcyBpbiBwcmVw YXJhdGlvbiBmb3IgbGlic291cDMKZGlmZiAtLWdpdCBhL1Rvb2xzL2dsaWIvZ2xpYl90ZXN0X3J1 bm5lci5weSBiL1Rvb2xzL2dsaWIvZ2xpYl90ZXN0X3J1bm5lci5weQppbmRleCBjODI2ODk3NmM5 ZGQxN2RiNjAxMjI5ODBkYmE1OWYwNzIwY2QzZDE3Li4zZDJkMDdmOTk4ZTEyOGQ1NjVjNDA4YzY0 YTM0OTI2OTkyNDQ1NmY1IDEwMDY0NAotLS0gYS9Ub29scy9nbGliL2dsaWJfdGVzdF9ydW5uZXIu cHkKKysrIGIvVG9vbHMvZ2xpYi9nbGliX3Rlc3RfcnVubmVyLnB5CkBAIC0yNjgsNiArMjY4LDIy IEBAIGNsYXNzIEdMaWJUZXN0UnVubmVyKG9iamVjdCk6CiAgICAgICAgICAgICBzZWxmLl9zdWJ0 ZXN0X2VuZCgyNTYpCiAgICAgICAgICAgICBuZWVkX3Jlc3RhcnQgPSBUcnVlCiAKKyAgICAgICAg IyBDaGVjayBmb3IgZXJyb3JzIGJlZm9yZSBhbnkgdGVzdCBpcyBydW4KKyAgICAgICAgaWYgbm90 IHNlbGYuX3Jlc3VsdHMgYW5kIHAucmV0dXJuY29kZSAhPSAwOgorICAgICAgICAgICAgZXJyb3Jz ID0gc2VsZi5fcmVhZF9mcm9tX3N0ZGVycihzZWxmLl9zdGRlcnJfZmQpCisgICAgICAgICAgICBz eXMuc3Rkb3V0LndyaXRlKCdUZXN0IHByb2dyYW0gc2V0dXAgZmFpbGVkLlxuJykKKyAgICAgICAg ICAgIHNlbGYuX3N1YnRlc3Rfc3RkZXJyKGVycm9ycykKKyAgICAgICAgICAgIHNlbGYuX3Jlc3Vs dHNbJ2JlZm9yZUFsbCddID0gJ0NSQVNIJworICAgICAgICAgICAgcmV0dXJuIHNlbGYuX3Jlc3Vs dHMKKworICAgICAgICAjIFRyeSB0byByZWFkIGVycm9ycyBmcm9tIGFmdGVyQWxsCisgICAgICAg IGlmIHAucmV0dXJuY29kZSAhPSAwIGFuZCBub3QgbmVlZF9yZXN0YXJ0OgorICAgICAgICAgICAg ZXJyb3JzID0gc2VsZi5fcmVhZF9mcm9tX3N0ZGVycihzZWxmLl9zdGRlcnJfZmQpCisgICAgICAg ICAgICBzeXMuc3Rkb3V0LndyaXRlKCdUZXN0IHByb2dyYW0gc2h1dGRvd24gZmFpbGVkLicpCisg ICAgICAgICAgICBzZWxmLl9zdWJ0ZXN0X3N0ZGVycihlcnJvcnMpCisgICAgICAgICAgICBzZWxm Ll9yZXN1bHRzWydhZnRlckFsbCddID0gJ0NSQVNIJworICAgICAgICAgICAgcmV0dXJuIHNlbGYu X3Jlc3VsdHMKKwogICAgICAgICBzZWxmLl9zdGRlcnJfZmQgPSBOb25lCiAKICAgICAgICAgaWYg bmVlZF9yZXN0YXJ0Ogo=