220922 2021-01-25 07:06:42 -0800 REGRESSION(r270074): Broke all GLib unit tests using a SoupServer 2021-01-25 11:41:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220366 https://bugs.webkit.org/show_bug.cgi?id=220938 InRadar P2 Normal --- 219257 219160 1 commit-queue commit-queue cgarcia fred.wang lmoura mcatanzaro webkit-bug-importer oldest_to_newest 1722057 0 commit-queue 2021-01-25 07:06:42 -0800 https://trac.webkit.org/changeset/270074 broke the build: Broke all GLib unit tests using a SoupServer This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1722060 1 418288 commit-queue 2021-01-25 07:06:51 -0800 Created attachment 418288 REVERT of r270074 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1722063 2 ews-feeder 2021-01-25 07:08:57 -0800 Committed r271794: <https://trac.webkit.org/changeset/271794> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418288. 1722064 3 webkit-bug-importer 2021-01-25 07:09:34 -0800 <rdar://problem/73570236> 1722111 4 lmoura 2021-01-25 10:04:48 -0800 A bunch of GTK/WPE API failures after this revert. I'm gardening them under this bug for now. Unexpected failures (10) /WebKit2Gtk/TestWebKitSettings /webkit/WebKitSettings/webkit-settings /webkit/WebKitSettings/javascript-markup /WebKit2Gtk/TestAuthentication /webkit/Authentication/authentication-empty-realm /webkit/Authentication/authentication-no-credential /webkit/Authentication/authentication-failure /webkit/Authentication/authentication-success /WebKit2Gtk/TestSSL /webkit/WebKitWebView/load-failed-with-tls-errors /WebKit2Gtk/TestBackForwardList /webkit/BackForwardList/navigation /WebKit2Gtk/TestWebKitWebView /webkit/WebKitWebView/title-change /WebKit2Gtk/TestLoaderClient /webkit/WebKitWebView/title Unexpected timeouts (1) /WebKit2Gtk/TestWebKitFaviconDatabase /webkit/WebKitFaviconDatabase/get-favicon 1722132 5 mcatanzaro 2021-01-25 10:52:37 -0800 Something is seriously wrong here. Carlos and I are both convinced that all these tests should have been guaranteed to fail *without* the revert, because there was no way the WebKitTestServer could have started. And yet the tests were passing. Now that the change is reverted to get back to the original known-good state, and the tests have all started to fail. There must be something more going on that we don't understand. 1722142 6 lmoura 2021-01-25 11:02:02 -0800 (In reply to Michael Catanzaro from comment #5) > Something is seriously wrong here. Carlos and I are both convinced that all > these tests should have been guaranteed to fail *without* the revert, > because there was no way the WebKitTestServer could have started. And yet > the tests were passing. Now that the change is reverted to get back to the > original known-good state, and the tests have all started to fail. > > There must be something more going on that we don't understand. Yeah. The tests weren't being run at all, it seems. Test log from the revision *before* the revert: https://build.webkit.org/builders/GTK-Linux-64-bit-Release-Tests/builds/17973/steps/API-tests/logs/stdio Test log from the revert: https://build.webkit.org/builders/GTK-Linux-64-bit-Release-Tests/builds/17974/steps/API-tests/logs/stdio There are many tests (the failing ones among them) not appearing in the run before the revert. And indeed, trying to run the title-change one, for example, before the revert, shows only the "1 of 1 passed" message without actually running it. It looks like an issue with the glib test runner failing to report some kinds of failures/crashes. And due to this, there's a chance these tests weren't actually being tested all this time. 1722149 7 lmoura 2021-01-25 11:06:15 -0800 Gardened in r271803 418288 2021-01-25 07:06:51 -0800 2021-01-25 07:08:57 -0800 REVERT of r270074 bug-220922-20210125150651.patch text/plain 5997 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjgxYWY1ZDNiNWFiMWIyODMwNTI1MjlhMDYxZDYxNTZh OTg5YTY0NS4uNWQ0YzNlZDIxYjg5MDliYjVlM2RiMjY4MTRiZGYxMmMyMzNlYzNkZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDIxLTAxLTI1ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K KworICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI3MDA3NCBhbmQgcjI3MDE3MC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDkyMgorCisg ICAgICAgIEJyb2tlIGFsbCBHTGliIHVuaXQgdGVzdHMgdXNpbmcgYSBTb3VwU2VydmVyCisKKyAg ICAgICAgUmV2ZXJ0ZWQgY2hhbmdlc2V0czoKKworICAgICAgICAiW0dUS10gTWlncmF0ZSBXZWJL aXRUZXN0U2VydmVyIHRvIGxpYnNvdXAgMi40OCBBUEkiCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkxNjAKKyAgICAgICAgaHR0cHM6Ly90cmFjLndl YmtpdC5vcmcvY2hhbmdlc2V0LzI3MDA3NAorCisgICAgICAgICJbR1RLXSBBbGxvdyBXZWJLaXRU ZXN0U2VydmVyIHRvIHJ1biBub24tbG9vcGJhY2sgYWRkcmVzc2VzCisgICAgICAgIGZvciBBUEkg dGVzdHMiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTkyNTcKKyAgICAgICAgaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzI3MDE3MAor CiAyMDIxLTAxLTI1ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAg ICAgICAgRHVtcFJlbmRlclRyZWUgYmVoYXZlcyBkaWZmZXJlbnRseSB0byBXZWJLaXRUZXN0UnVu bmVyIHdydCBpbnRlZ3JhdGVkL2Rpc2NyZXRlIEdQVSBiZWhhdmlvcgpkaWZmIC0tZ2l0IGEvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RTU0wuY3BwIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RTU0wuY3BwCmluZGV4IGY2MDBmZDdhY2M5 NWQ0MzcxYzQwYTM0MmE4NzAxMWNlNzczMTQxNjIuLjg5MmQzNDI4MDZiZjZlMWI5N2QyMjNjNWNj NWE1N2VlMDQyMjYyM2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0R0xpYi9UZXN0U1NMLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dEdMaWIvVGVzdFNTTC5jcHAKQEAgLTU1NCwxMiArNTU0LDEwIEBAIHN0YXRpYyB2b2lkIGh0dHBT ZXJ2ZXJDYWxsYmFjayhTb3VwU2VydmVyKiBzZXJ2ZXIsIFNvdXBNZXNzYWdlKiBtZXNzYWdlLCBj b25zdCBjCiAKIHZvaWQgYmVmb3JlQWxsKCkKIHsKLSAgICAvLyBGSVhNRShodHRwczovL3dlYmtp dC5vcmcvYi8yMTkxOTgpOiBUaGlzIHNob3VsZCByZWFsbHkgYmUgYSBub24tbG9jYWxob3N0IGRv bWFpbiBidXQKLSAgICAvLyByZWx5aW5nIG9uIGEgbm9uLWxvb3BiYWNrIElQIGFkZHJlc3MgaXMg ZW5vdWdoIHVudGlsIGJ1ZyAxNzE5MzQgaXMgZml4ZWQuCi0gICAga0h0dHBzU2VydmVyID0gbmV3 IFdlYktpdFRlc3RTZXJ2ZXIoV2ViS2l0VGVzdFNlcnZlcjo6U2VydmVySFRUUFMgfCBXZWJLaXRU ZXN0U2VydmVyOjpTZXJ2ZXJOb25Mb29wYmFjayk7CisgICAga0h0dHBzU2VydmVyID0gbmV3IFdl YktpdFRlc3RTZXJ2ZXIoV2ViS2l0VGVzdFNlcnZlcjo6U2VydmVySFRUUFMpOwogICAgIGtIdHRw c1NlcnZlci0+cnVuKGh0dHBzU2VydmVyQ2FsbGJhY2spOwogCi0gICAga0h0dHBTZXJ2ZXIgPSBu ZXcgV2ViS2l0VGVzdFNlcnZlcigpOworICAgIGtIdHRwU2VydmVyID0gbmV3IFdlYktpdFRlc3RT ZXJ2ZXIoV2ViS2l0VGVzdFNlcnZlcjo6U2VydmVySFRUUCk7CiAgICAga0h0dHBTZXJ2ZXItPnJ1 bihodHRwU2VydmVyQ2FsbGJhY2spOwogCiAgICAgU1NMVGVzdDo6YWRkKCJXZWJLaXRXZWJWaWV3 IiwgInNzbCIsIHRlc3RTU0wpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9nbGli L1dlYktpdEdMaWIvV2ViS2l0VGVzdFNlcnZlci5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL2ds aWIvV2ViS2l0R0xpYi9XZWJLaXRUZXN0U2VydmVyLmNwcAppbmRleCAyYTA3MjBmYzNmZGRiZmRk MjZkYzkwNmE1YTFmZjIyODE2MzMyZDIyLi5kMmU0OTVjYWQyYTNlZWJkZGVjYWIxMDBhOWJhMWQ1 YThkOWZkOGVhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL2dsaWIvV2ViS2l0R0xp Yi9XZWJLaXRUZXN0U2VydmVyLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL2dsaWIvV2Vi S2l0R0xpYi9XZWJLaXRUZXN0U2VydmVyLmNwcApAQCAtMjQsNDQgKzI0LDMwIEBACiAjaW5jbHVk ZSA8d3RmL1RocmVhZGluZy5oPgogI2luY2x1ZGUgPHd0Zi9nbGliL0dVbmlxdWVQdHIuaD4KIAot V2ViS2l0VGVzdFNlcnZlcjo6V2ViS2l0VGVzdFNlcnZlcihTZXJ2ZXJPcHRpb25zQml0U2V0IG9w dGlvbnMpCitXZWJLaXRUZXN0U2VydmVyOjpXZWJLaXRUZXN0U2VydmVyKFNlcnZlck9wdGlvbnMg b3B0aW9ucykKIHsKLSAgICBpZiAob3B0aW9uc1tTZXJ2ZXJSdW5JblRocmVhZF0pIHsKKyAgICBp ZiAob3B0aW9ucyAmIFNlcnZlclJ1bkluVGhyZWFkKSB7CiAgICAgICAgIFdURjo6aW5pdGlhbGl6 ZSgpOwogICAgICAgICBtX3F1ZXVlID0gV29ya1F1ZXVlOjpjcmVhdGUoIldlYktpdFRlc3RTZXJ2 ZXIiKTsKICAgICB9CiAKICAgICBHVW5pcXVlUHRyPGNoYXI+IHNzbENlcnRpZmljYXRlRmlsZTsK ICAgICBHVW5pcXVlUHRyPGNoYXI+IHNzbEtleUZpbGU7Ci0gICAgaWYgKG9wdGlvbnNbU2VydmVy SFRUUFNdKSB7CisgICAgaWYgKG9wdGlvbnMgJiBTZXJ2ZXJIVFRQUykgewogICAgICAgICBDU3Ry aW5nIHJlc291cmNlc0RpciA9IFRlc3Q6OmdldFJlc291cmNlc0RpcigpOwogICAgICAgICBzc2xD ZXJ0aWZpY2F0ZUZpbGUucmVzZXQoZ19idWlsZF9maWxlbmFtZShyZXNvdXJjZXNEaXIuZGF0YSgp LCAidGVzdC1jZXJ0LnBlbSIsIE5VTEwpKTsKICAgICAgICAgc3NsS2V5RmlsZS5yZXNldChnX2J1 aWxkX2ZpbGVuYW1lKHJlc291cmNlc0Rpci5kYXRhKCksICJ0ZXN0LWtleS5wZW0iLCBOVUxMKSk7 CiAgICAgfQogCi0gICAgbV9zb3VwU2VydmVyID0gYWRvcHRHUmVmKHNvdXBfc2VydmVyX25ldygK KyAgICBHUmVmUHRyPFNvdXBBZGRyZXNzPiBhZGRyZXNzID0gYWRvcHRHUmVmKHNvdXBfYWRkcmVz c19uZXcoIjEyNy4wLjAuMSIsIFNPVVBfQUREUkVTU19BTllfUE9SVCkpOworICAgIHNvdXBfYWRk cmVzc19yZXNvbHZlX3N5bmMoYWRkcmVzcy5nZXQoKSwgMCk7CisKKyAgICBtX3NvdXBTZXJ2ZXIg PSBhZG9wdEdSZWYoc291cF9zZXJ2ZXJfbmV3KFNPVVBfU0VSVkVSX0lOVEVSRkFDRSwgYWRkcmVz cy5nZXQoKSwKICAgICAgICAgU09VUF9TRVJWRVJfQVNZTkNfQ09OVEVYVCwgbV9xdWV1ZSA/IG1f cXVldWUtPnJ1bkxvb3AoKS5tYWluQ29udGV4dCgpIDogbnVsbHB0ciwKICAgICAgICAgU09VUF9T RVJWRVJfU1NMX0NFUlRfRklMRSwgc3NsQ2VydGlmaWNhdGVGaWxlLmdldCgpLAogICAgICAgICBT T1VQX1NFUlZFUl9TU0xfS0VZX0ZJTEUsIHNzbEtleUZpbGUuZ2V0KCksIG51bGxwdHIpKTsKLQot ICAgIEdVbmlxdWVPdXRQdHI8R0Vycm9yPiBlcnJvcjsKLSAgICBTb3VwU2VydmVyTGlzdGVuT3B0 aW9ucyBzZXJ2ZXJPcHRpb25zID0gc3RhdGljX2Nhc3Q8U291cFNlcnZlckxpc3Rlbk9wdGlvbnM+ KG9wdGlvbnNbU2VydmVySFRUUFNdID8gU09VUF9TRVJWRVJfTElTVEVOX0lQVjRfT05MWSA6IFNP VVBfU0VSVkVSX0xJU1RFTl9JUFY0X09OTFkgfCBTT1VQX1NFUlZFUl9MSVNURU5fSFRUUFMpOwot ICAgIGJvb2wgc2VydmVyU3RhcnRlZCA9IGZhbHNlOwotICAgIGlmIChvcHRpb25zW1NlcnZlck5v bkxvb3BiYWNrXSkgewotICAgICAgICBHUmVmUHRyPFNvdXBBZGRyZXNzPiBhZGRyZXNzID0gYWRv cHRHUmVmKHNvdXBfYWRkcmVzc19uZXcoImxvY2FsaG9zdCIsIFNPVVBfQUREUkVTU19BTllfUE9S VCkpOwotICAgICAgICBzb3VwX2FkZHJlc3NfcmVzb2x2ZV9zeW5jKGFkZHJlc3MuZ2V0KCksIG51 bGxwdHIpOwotICAgICAgICBzZXJ2ZXJTdGFydGVkID0gc291cF9zZXJ2ZXJfbGlzdGVuKG1fc291 cFNlcnZlci5nZXQoKSwgc291cF9hZGRyZXNzX2dldF9nc29ja2FkZHIoYWRkcmVzcy5nZXQoKSks IHNlcnZlck9wdGlvbnMsICZlcnJvci5vdXRQdHIoKSk7Ci0gICAgfSBlbHNlCi0gICAgICAgIHNl cnZlclN0YXJ0ZWQgPSBzb3VwX3NlcnZlcl9saXN0ZW5fbG9jYWwobV9zb3VwU2VydmVyLmdldCgp LCBTT1VQX0FERFJFU1NfQU5ZX1BPUlQsIHNlcnZlck9wdGlvbnMsICZlcnJvci5vdXRQdHIoKSk7 Ci0gICAgaWYgKCFzZXJ2ZXJTdGFydGVkKSB7Ci0gICAgICAgIFdURkxvZ0Fsd2F5cygiRmFpbGVk IHRvIHN0YXJ0IEhUVFAgc2VydmVyOiAlcyIsIGVycm9yLT5tZXNzYWdlKTsKLSAgICAgICAgQ1JB U0goKTsKLSAgICB9Ci0KLSAgICBHU0xpc3QqIHVyaXMgPSBzb3VwX3NlcnZlcl9nZXRfdXJpcyht X3NvdXBTZXJ2ZXIuZ2V0KCkpOwotICAgIEFTU0VSVCh1cmlzKTsKLSAgICBtX2Jhc2VVUkkgPSBz dGF0aWNfY2FzdDxTb3VwVVJJKj4oZ19vYmplY3RfcmVmKHVyaXMtPmRhdGEpKTsKLSAgICBnX3Ns aXN0X2ZyZWVfZnVsbCh1cmlzLCBnX29iamVjdF91bnJlZik7CisgICAgbV9iYXNlVVJJID0gb3B0 aW9ucyAmIFNlcnZlckhUVFBTID8gc291cF91cmlfbmV3KCJodHRwczovLzEyNy4wLjAuMS8iKSA6 IHNvdXBfdXJpX25ldygiaHR0cDovLzEyNy4wLjAuMS8iKTsKKyAgICBzb3VwX3VyaV9zZXRfcG9y dChtX2Jhc2VVUkksIHNvdXBfc2VydmVyX2dldF9wb3J0KG1fc291cFNlcnZlci5nZXQoKSkpOwog fQogCiBXZWJLaXRUZXN0U2VydmVyOjp+V2ViS2l0VGVzdFNlcnZlcigpCmRpZmYgLS1naXQgYS9U b29scy9UZXN0V2ViS2l0QVBJL2dsaWIvV2ViS2l0R0xpYi9XZWJLaXRUZXN0U2VydmVyLmggYi9U b29scy9UZXN0V2ViS2l0QVBJL2dsaWIvV2ViS2l0R0xpYi9XZWJLaXRUZXN0U2VydmVyLmgKaW5k ZXggZGEyNWVhZGE4MzZhNGZkNGY0ZjE4MmYxODEwZWZlOWQwMmUwYTE0My4uMjgxNDUyN2YxOWI5 NTRmODJhZWI4N2JjMGU0YzhkYzBiOWE3ZjViNiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktp dEFQSS9nbGliL1dlYktpdEdMaWIvV2ViS2l0VGVzdFNlcnZlci5oCisrKyBiL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvZ2xpYi9XZWJLaXRHTGliL1dlYktpdFRlc3RTZXJ2ZXIuaApAQCAtMTksNyArMTks NiBAQAogCiAjcHJhZ21hIG9uY2UKIAotI2luY2x1ZGUgPGJpdHNldD4KICNpbmNsdWRlIDxsaWJz b3VwL3NvdXAuaD4KICNpbmNsdWRlIDx3dGYvV29ya1F1ZXVlLmg+CiAjaW5jbHVkZSA8d3RmL2ds aWIvR1JlZlB0ci5oPgpAQCAtMzAsMTMgKzI5LDEyIEBAIGNsYXNzIFdlYktpdFRlc3RTZXJ2ZXIg ewogcHVibGljOgogCiAgICAgZW51bSBTZXJ2ZXJPcHRpb25zIHsKLSAgICAgICAgU2VydmVySFRU UFMgPSAwLAotICAgICAgICBTZXJ2ZXJSdW5JblRocmVhZCA9IDEsCi0gICAgICAgIFNlcnZlck5v bkxvb3BiYWNrID0gMiwKKyAgICAgICAgU2VydmVySFRUUCA9IDAsCisgICAgICAgIFNlcnZlckhU VFBTID0gMSA8PCAxLAorICAgICAgICBTZXJ2ZXJSdW5JblRocmVhZCA9IDEgPDwgMiwKICAgICB9 OwotICAgIHVzaW5nIFNlcnZlck9wdGlvbnNCaXRTZXQgPSBzdGQ6OmJpdHNldDwzPjsKIAotICAg IFdlYktpdFRlc3RTZXJ2ZXIoU2VydmVyT3B0aW9uc0JpdFNldCA9IDApOworICAgIFdlYktpdFRl c3RTZXJ2ZXIoU2VydmVyT3B0aW9ucyA9IFNlcnZlckhUVFApOwogICAgIHZpcnR1YWwgfldlYktp dFRlc3RTZXJ2ZXIoKTsKIAogICAgIFNvdXBVUkkqIGJhc2VVUkkoKSBjb25zdCB7IHJldHVybiBt X2Jhc2VVUkk7IH0K