220863 2021-01-22 08:59:28 -0800 [GTK] run-gtk-tests: Crashing and non-existent tests should not count as a pass 2021-01-27 09:17:59 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220938 InRadar P2 Normal --- 1 aboya aboya bugs-noreply mcatanzaro webkit-bug-importer oldest_to_newest 1721594 0 aboya 2021-01-22 08:59:28 -0800 The current implementation doesn't account for test binaries that have not emitted any subtests. This is the case when a test binary doesn't exist or it crashes. Also, in the latter case, the stderr of the crashed processes was not being outputted to the user, masking a crashing test binary as a passing test. This patch fixes both issues: It adds several warning prints when binaries can't be run or fail to add any subtest, emitting the stderr generated by the failing or crashing binary. 1721595 1 418152 aboya 2021-01-22 09:00:22 -0800 Created attachment 418152 Patch 1722512 2 418421 aboya 2021-01-26 08:01:32 -0800 Created attachment 418421 Patch 1722514 3 aboya 2021-01-26 08:06:02 -0800 Uploaded an updated version that marks these tests as CRASH. I expect the EWS to fail on the test suites that are currently crashing. 1722928 4 aboya 2021-01-27 06:03:14 -0800 (In reply to Alicia Boya García from comment #3) > Uploaded an updated version that marks these tests as CRASH. I expect the > EWS to fail on the test suites that are currently crashing. Well, EWS didn't fail because the crashes have been fixed in the meantime. Now the previously crashing test suites are reporting subtests again. TEST: /app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestCookieManager... /webkit/WebKitCookieManager/accept-policy: PASS TEST: /app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestBackForwardList... /webkit/BackForwardList/navigation: PASS TEST: /app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestLoaderClient... /webkit/WebKitWebView/loading-status: PASS ... and so on. 1722943 5 418538 aboya 2021-01-27 06:27:04 -0800 Created attachment 418538 Patch 1722946 6 aboya 2021-01-27 06:27:38 -0800 Reuploaded removing the ChangeLog line about changing expectations since it's no longer necessary. 1722955 7 mcatanzaro 2021-01-27 06:49:42 -0800 Remember to CC bugs-noreply@webkitgtk.org if you're not using the GTK or WPE component, so it doesn't get missed! 1722956 8 418538 mcatanzaro 2021-01-27 06:50:29 -0800 Comment on attachment 418538 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418538&action=review > Tools/glib/api_test_runner.py:308 > + # No subtests where emitted, either the test binary didn't exist, or we don't know how to run it, or it crashed. were 1723003 9 418550 aboya 2021-01-27 08:46:57 -0800 Created attachment 418550 Patch 1723010 10 ews-feeder 2021-01-27 09:14:20 -0800 Committed r271955: <https://trac.webkit.org/changeset/271955> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418550. 1723012 11 webkit-bug-importer 2021-01-27 09:17:59 -0800 <rdar://problem/73664773> 418152 2021-01-22 09:00:22 -0800 2021-01-26 08:01:29 -0800 Patch bug-220863-20210122180025.patch text/plain 3434 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMzU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWY1NGJhZWQwODg0MjNmNjllODAxNmY3NmEyMzEyOTBm NjNjYmE4Mi4uZGYzZThjMTJjODMyYTM5ZTNjOWQ5ODJkNGRhNjllMjg1ZDgwYTk5OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4 IEBACisyMDIxLTAxLTIyICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBydW4tZ3RrLXRlc3RzOiBDcmFzaGluZyBhbmQgbm9uLWV4aXN0ZW50 IHRlc3RzIHNob3VsZCBub3QgY291bnQgYXMgYSBwYXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA4NjMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBkb2Vz bid0IGFjY291bnQgZm9yIHRlc3QgYmluYXJpZXMgdGhhdCBoYXZlCisgICAgICAgIG5vdCBlbWl0 dGVkIGFueSBzdWJ0ZXN0cy4gVGhpcyBpcyB0aGUgY2FzZSB3aGVuIGEgdGVzdCBiaW5hcnkgZG9l c24ndAorICAgICAgICBleGlzdCBvciBpdCBjcmFzaGVzLgorCisgICAgICAgIEFsc28sIGluIHRo ZSBsYXR0ZXIgY2FzZSwgdGhlIHN0ZGVyciBvZiB0aGUgY3Jhc2hlZCBwcm9jZXNzZXMgd2FzIG5v dAorICAgICAgICBiZWluZyBvdXRwdXR0ZWQgdG8gdGhlIHVzZXIsIG1hc2tpbmcgYSBjcmFzaGlu ZyB0ZXN0IGJpbmFyeSBhcyBhCisgICAgICAgIHBhc3NpbmcgdGVzdC4KKworICAgICAgICBUaGlz IHBhdGNoIGZpeGVzIGJvdGggaXNzdWVzOiBJdCBhZGRzIHNldmVyYWwgd2FybmluZyBwcmludHMg d2hlbgorICAgICAgICBiaW5hcmllcyBjYW4ndCBiZSBydW4gb3IgZmFpbCB0byBhZGQgYW55IHN1 YnRlc3QsIGVtaXR0aW5nIHRoZSBzdGRlcnIKKyAgICAgICAgZ2VuZXJhdGVkIGJ5IHRoZSBmYWls aW5nIG9yIGNyYXNoaW5nIGJpbmFyeS4KKworICAgICAgICAqIGdsaWIvYXBpX3Rlc3RfcnVubmVy LnB5OgorICAgICAgICAoVGVzdFJ1bm5lci5fcnVuX3Rlc3QpOgorICAgICAgICAoVGVzdFJ1bm5l ci5ydW5fdGVzdHMpOgorICAgICAgICAqIGdsaWIvZ2xpYl90ZXN0X3J1bm5lci5weToKKyAgICAg ICAgKEdMaWJUZXN0UnVubmVyLnJ1bik6CisKIDIwMjEtMDEtMjIgIEFsaWNpYSBCb3lhIEdhcmPD rWEgIDxhYm95YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIHJ1bi1ndGstdGVzdHM6IFVz ZSBzeXMuZXhpdCgxKSBpbnN0ZWFkIG9mIHJldHVybiAxCmRpZmYgLS1naXQgYS9Ub29scy9nbGli L2FwaV90ZXN0X3J1bm5lci5weSBiL1Rvb2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5CmluZGV4 IGE1OTRkZmE4NzZmNTFhZjAxNjYxYmM2MWM2YzE5MzNmZjQwMWI4MGQuLjc1OTdhY2I5N2QyMDNi ZTFhOWE5M2Y2ZTk4MDlhNjVkMTJhMThiYjAgMTAwNzU1Ci0tLSBhL1Rvb2xzL2dsaWIvYXBpX3Rl c3RfcnVubmVyLnB5CisrKyBiL1Rvb2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5CkBAIC0yNzYs NiArMjc2LDcgQEAgY2xhc3MgVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICBpZiBzZWxmLmlz X3F0X3Rlc3QodGVzdF9wcm9ncmFtKToKICAgICAgICAgICAgIHJldHVybiBzZWxmLl9ydW5fdGVz dF9xdCh0ZXN0X3Byb2dyYW0pCiAKKyAgICAgICAgc3lzLnN0ZGVyci53cml0ZSgiV0FSTklORzog JXMgZG9lc24ndCBzZWVtIHRvIGJlIGEgc3VwcG9ydGVkIHRlc3QgcHJvZ3JhbS5cbiIgJSB0ZXN0 X3Byb2dyYW0pCiAgICAgICAgIHJldHVybiB7fQogCiAgICAgZGVmIHJ1bl90ZXN0cyhzZWxmKToK QEAgLTMwMiw2ICszMDMsMTEgQEAgY2xhc3MgVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICAg ICAgICAgIHNraXBwZWRfc3VidGVzdHMgPSBzZWxmLl90ZXN0X2Nhc2VzX3RvX3NraXAodGVzdCkK ICAgICAgICAgICAgICAgICBudW1iZXJfb2ZfdG90YWxfdGVzdHMgKz0gbGVuKHNraXBwZWRfc3Vi dGVzdHMpCiAgICAgICAgICAgICAgICAgcmVzdWx0cyA9IHNlbGYuX3J1bl90ZXN0KHRlc3QsIHN1 YnRlc3RzLCBza2lwcGVkX3N1YnRlc3RzKQorICAgICAgICAgICAgICAgIGlmIGxlbihyZXN1bHRz KSA9PSAwOgorICAgICAgICAgICAgICAgICAgICAjIENvdWxkbid0IHJ1biB0aGUgdGVzdCwgZG9u J3QgY291bnQgaXQgYXMgZXhlY3V0ZWQuCisgICAgICAgICAgICAgICAgICAgIHN5cy5zdGRlcnIu d3JpdGUoIkVSUk9SOiAlcyBmYWlsZWQgdG8gcnVuLCBhcyBpdCBkaWRuJ3QgZW1pdCBhbnkgc3Vi dGVzdHMuXG4iICUgdGVzdCkKKyAgICAgICAgICAgICAgICAgICAgbnVtYmVyX29mX2V4ZWN1dGVk X3Rlc3RzIC09IDEKKyAgICAgICAgICAgICAgICAgICAgY29udGludWUKICAgICAgICAgICAgICAg ICBudW1iZXJfb2ZfZXhlY3V0ZWRfc3VidGVzdHNfZm9yX3Rlc3QgPSBsZW4ocmVzdWx0cykKICAg ICAgICAgICAgICAgICBpZiBudW1iZXJfb2ZfZXhlY3V0ZWRfc3VidGVzdHNfZm9yX3Rlc3QgPiAx OgogICAgICAgICAgICAgICAgICAgICBudW1iZXJfb2ZfZXhlY3V0ZWRfdGVzdHMgKz0gbnVtYmVy X29mX2V4ZWN1dGVkX3N1YnRlc3RzX2Zvcl90ZXN0CmRpZmYgLS1naXQgYS9Ub29scy9nbGliL2ds aWJfdGVzdF9ydW5uZXIucHkgYi9Ub29scy9nbGliL2dsaWJfdGVzdF9ydW5uZXIucHkKaW5kZXgg YzgyNjg5NzZjOWRkMTdkYjYwMTIyOTgwZGJhNTlmMDcyMGNkM2QxNy4uYjkzYmM5N2UxNTdiYWU2 OTIxZGYwZmRhMTMzMTA4ZTEwNGQwNTBmYSAxMDA2NDQKLS0tIGEvVG9vbHMvZ2xpYi9nbGliX3Rl c3RfcnVubmVyLnB5CisrKyBiL1Rvb2xzL2dsaWIvZ2xpYl90ZXN0X3J1bm5lci5weQpAQCAtMjY4 LDYgKzI2OCwxMiBAQCBjbGFzcyBHTGliVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICAgICAg c2VsZi5fc3VidGVzdF9lbmQoMjU2KQogICAgICAgICAgICAgbmVlZF9yZXN0YXJ0ID0gVHJ1ZQog CisgICAgICAgIGlmIGxlbihzZWxmLl9yZXN1bHRzKSA9PSAwOgorICAgICAgICAgICAgIyBOb3Jt YWxseSBzdGRlcnIgaXMgY2hlY2tlZCBhZnRlciBhIHN1YnRlc3QgaGFzIGJlZW4gcGFyc2VkLiBJ ZiBubyBzdWJ0ZXN0cyBoYXZlIGJlZW4gcGFyc2VkCisgICAgICAgICAgICAjIGNoYW5jZXMgYXJl IHNvbWV0aGluZyB3ZW50IHdyb25nIHdpdGggdGhlIHRlc3QgZXhlY3V0YWJsZSBpdHNlbGYgYW5k IHdlIHNob3VsZCBwcmludCBzdGRlcnIKKyAgICAgICAgICAgICMgdG8gdGhlIHVzZXIuCisgICAg ICAgICAgICBzeXMuc3RkZXJyLndyaXRlKHNlbGYuX3JlYWRfZnJvbV9zdGRlcnIoc2VsZi5fc3Rk ZXJyX2ZkKSkKKwogICAgICAgICBzZWxmLl9zdGRlcnJfZmQgPSBOb25lCiAKICAgICAgICAgaWYg bmVlZF9yZXN0YXJ0Ogo= 418421 2021-01-26 08:01:32 -0800 2021-01-27 06:27:01 -0800 Patch bug-220863-20210126170131.patch text/plain 3687 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMzU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWY1NGJhZWQwODg0MjNmNjllODAxNmY3NmEyMzEyOTBm NjNjYmE4Mi4uYzU1ZDBhZGQ2NDhkOGExZWM0MDBhMjg2Mjc1ZTEwMGMyNDJiZTAzZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMx IEBACisyMDIxLTAxLTIyICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBydW4tZ3RrLXRlc3RzOiBDcmFzaGluZyBhbmQgbm9uLWV4aXN0ZW50 IHRlc3RzIHNob3VsZCBub3QgY291bnQgYXMgYSBwYXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA4NjMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBkb2Vz bid0IGFjY291bnQgZm9yIHRlc3QgYmluYXJpZXMgdGhhdCBoYXZlCisgICAgICAgIG5vdCBlbWl0 dGVkIGFueSBzdWJ0ZXN0cy4gVGhpcyBpcyB0aGUgY2FzZSB3aGVuIGEgdGVzdCBiaW5hcnkgZG9l c24ndAorICAgICAgICBleGlzdCBvciBpdCBjcmFzaGVzLgorCisgICAgICAgIEFsc28sIGluIHRo ZSBsYXR0ZXIgY2FzZSwgdGhlIHN0ZGVyciBvZiB0aGUgY3Jhc2hlZCBwcm9jZXNzZXMgd2FzIG5v dAorICAgICAgICBiZWluZyBvdXRwdXR0ZWQgdG8gdGhlIHVzZXIsIG1hc2tpbmcgYSBjcmFzaGlu ZyB0ZXN0IGJpbmFyeSBhcyBhCisgICAgICAgIHBhc3NpbmcgdGVzdC4KKworICAgICAgICBUaGlz IHBhdGNoIGZpeGVzIGJvdGggaXNzdWVzOiBJdCBhZGRzIHNldmVyYWwgd2FybmluZyBwcmludHMg d2hlbgorICAgICAgICBiaW5hcmllcyBjYW4ndCBiZSBydW4gb3IgZmFpbCB0byBhZGQgYW55IHN1 YnRlc3QsIGVtaXR0aW5nIHRoZSBzdGRlcnIKKyAgICAgICAgZ2VuZXJhdGVkIGJ5IHRoZSBmYWls aW5nIG9yIGNyYXNoaW5nIGJpbmFyeS4KKworICAgICAgICBJdCBhbHNvIG1hcmtzIHRoZW0gYXMg Y3Jhc2hlZCB0ZXN0cyBpbiB0aGUgQ0ksIHNvIHRoYXQgdGhleSBkb24ndCBwYXNzCisgICAgICAg IHVubm90aWNlZC4KKworICAgICAgICAqIGdsaWIvYXBpX3Rlc3RfcnVubmVyLnB5OgorICAgICAg ICAoVGVzdFJ1bm5lci5fcnVuX3Rlc3QpOgorICAgICAgICAoVGVzdFJ1bm5lci5ydW5fdGVzdHMp OgorICAgICAgICAqIGdsaWIvZ2xpYl90ZXN0X3J1bm5lci5weToKKyAgICAgICAgKEdMaWJUZXN0 UnVubmVyLnJ1bik6CisKIDIwMjEtMDEtMjIgIEFsaWNpYSBCb3lhIEdhcmPDrWEgIDxhYm95YUBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIHJ1bi1ndGstdGVzdHM6IFVzZSBzeXMuZXhpdCgx KSBpbnN0ZWFkIG9mIHJldHVybiAxCmRpZmYgLS1naXQgYS9Ub29scy9nbGliL2FwaV90ZXN0X3J1 bm5lci5weSBiL1Rvb2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5CmluZGV4IDk0Y2JhNTdjMmEy ZmNkYzcxODNiY2MxNjQ1YTgxZmE5ODIwMjgzZjIuLmM1ZWMxMmZhZGFjM2Y4ZWJhMDE1YjRlOTQw MGMzM2Q4N2ZkNDM3NTMgMTAwNzU1Ci0tLSBhL1Rvb2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5 CisrKyBiL1Rvb2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5CkBAIC0yNzcsNiArMjc3LDcgQEAg Y2xhc3MgVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICBpZiBzZWxmLmlzX3F0X3Rlc3QodGVz dF9wcm9ncmFtKToKICAgICAgICAgICAgIHJldHVybiBzZWxmLl9ydW5fdGVzdF9xdCh0ZXN0X3By b2dyYW0pCiAKKyAgICAgICAgc3lzLnN0ZGVyci53cml0ZSgiV0FSTklORzogJXMgZG9lc24ndCBz ZWVtIHRvIGJlIGEgc3VwcG9ydGVkIHRlc3QgcHJvZ3JhbS5cbiIgJSB0ZXN0X3Byb2dyYW0pCiAg ICAgICAgIHJldHVybiB7fQogCiAgICAgZGVmIHJ1bl90ZXN0cyhzZWxmKToKQEAgLTMwMyw2ICsz MDQsMTEgQEAgY2xhc3MgVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICAgICAgICAgIHNraXBw ZWRfc3VidGVzdHMgPSBzZWxmLl90ZXN0X2Nhc2VzX3RvX3NraXAodGVzdCkKICAgICAgICAgICAg ICAgICBudW1iZXJfb2ZfdG90YWxfdGVzdHMgKz0gbGVuKHNraXBwZWRfc3VidGVzdHMgaWYgbm90 IHN1YnRlc3RzIGVsc2Ugc2V0KHNraXBwZWRfc3VidGVzdHMpLmludGVyc2VjdGlvbihzdWJ0ZXN0 cykpCiAgICAgICAgICAgICAgICAgcmVzdWx0cyA9IHNlbGYuX3J1bl90ZXN0KHRlc3QsIHN1YnRl c3RzLCBza2lwcGVkX3N1YnRlc3RzKQorICAgICAgICAgICAgICAgIGlmIGxlbihyZXN1bHRzKSA9 PSAwOgorICAgICAgICAgICAgICAgICAgICAjIE5vIHN1YnRlc3RzIHdoZXJlIGVtaXR0ZWQsIGVp dGhlciB0aGUgdGVzdCBiaW5hcnkgZGlkbid0IGV4aXN0LCBvciB3ZSBkb24ndCBrbm93IGhvdyB0 byBydW4gaXQsIG9yIGl0IGNyYXNoZWQuCisgICAgICAgICAgICAgICAgICAgIHN5cy5zdGRlcnIu d3JpdGUoIkVSUk9SOiAlcyBmYWlsZWQgdG8gcnVuLCBhcyBpdCBkaWRuJ3QgZW1pdCBhbnkgc3Vi dGVzdHMuXG4iICUgdGVzdCkKKyAgICAgICAgICAgICAgICAgICAgY3Jhc2hlZF90ZXN0c1t0ZXN0 XSA9IFsiKHByb2JsZW0gaW4gdGVzdCBleGVjdXRhYmxlKSJdCisgICAgICAgICAgICAgICAgICAg IGNvbnRpbnVlCiAgICAgICAgICAgICAgICAgbnVtYmVyX29mX2V4ZWN1dGVkX3N1YnRlc3RzX2Zv cl90ZXN0ID0gbGVuKHJlc3VsdHMpCiAgICAgICAgICAgICAgICAgaWYgbnVtYmVyX29mX2V4ZWN1 dGVkX3N1YnRlc3RzX2Zvcl90ZXN0ID4gMToKICAgICAgICAgICAgICAgICAgICAgbnVtYmVyX29m X2V4ZWN1dGVkX3Rlc3RzICs9IG51bWJlcl9vZl9leGVjdXRlZF9zdWJ0ZXN0c19mb3JfdGVzdApk aWZmIC0tZ2l0IGEvVG9vbHMvZ2xpYi9nbGliX3Rlc3RfcnVubmVyLnB5IGIvVG9vbHMvZ2xpYi9n bGliX3Rlc3RfcnVubmVyLnB5CmluZGV4IGM4MjY4OTc2YzlkZDE3ZGI2MDEyMjk4MGRiYTU5ZjA3 MjBjZDNkMTcuLmI5M2JjOTdlMTU3YmFlNjkyMWRmMGZkYTEzMzEwOGUxMDRkMDUwZmEgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL2dsaWIvZ2xpYl90ZXN0X3J1bm5lci5weQorKysgYi9Ub29scy9nbGliL2ds aWJfdGVzdF9ydW5uZXIucHkKQEAgLTI2OCw2ICsyNjgsMTIgQEAgY2xhc3MgR0xpYlRlc3RSdW5u ZXIob2JqZWN0KToKICAgICAgICAgICAgIHNlbGYuX3N1YnRlc3RfZW5kKDI1NikKICAgICAgICAg ICAgIG5lZWRfcmVzdGFydCA9IFRydWUKIAorICAgICAgICBpZiBsZW4oc2VsZi5fcmVzdWx0cykg PT0gMDoKKyAgICAgICAgICAgICMgTm9ybWFsbHkgc3RkZXJyIGlzIGNoZWNrZWQgYWZ0ZXIgYSBz dWJ0ZXN0IGhhcyBiZWVuIHBhcnNlZC4gSWYgbm8gc3VidGVzdHMgaGF2ZSBiZWVuIHBhcnNlZAor ICAgICAgICAgICAgIyBjaGFuY2VzIGFyZSBzb21ldGhpbmcgd2VudCB3cm9uZyB3aXRoIHRoZSB0 ZXN0IGV4ZWN1dGFibGUgaXRzZWxmIGFuZCB3ZSBzaG91bGQgcHJpbnQgc3RkZXJyCisgICAgICAg ICAgICAjIHRvIHRoZSB1c2VyLgorICAgICAgICAgICAgc3lzLnN0ZGVyci53cml0ZShzZWxmLl9y ZWFkX2Zyb21fc3RkZXJyKHNlbGYuX3N0ZGVycl9mZCkpCisKICAgICAgICAgc2VsZi5fc3RkZXJy X2ZkID0gTm9uZQogCiAgICAgICAgIGlmIG5lZWRfcmVzdGFydDoK 418538 2021-01-27 06:27:04 -0800 2021-01-27 08:46:53 -0800 Patch bug-220863-20210127152703.patch text/plain 3585 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMzU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWY1NGJhZWQwODg0MjNmNjllODAxNmY3NmEyMzEyOTBm NjNjYmE4Mi4uZGYzZThjMTJjODMyYTM5ZTNjOWQ5ODJkNGRhNjllMjg1ZDgwYTk5OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4 IEBACisyMDIxLTAxLTIyICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBydW4tZ3RrLXRlc3RzOiBDcmFzaGluZyBhbmQgbm9uLWV4aXN0ZW50 IHRlc3RzIHNob3VsZCBub3QgY291bnQgYXMgYSBwYXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA4NjMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBkb2Vz bid0IGFjY291bnQgZm9yIHRlc3QgYmluYXJpZXMgdGhhdCBoYXZlCisgICAgICAgIG5vdCBlbWl0 dGVkIGFueSBzdWJ0ZXN0cy4gVGhpcyBpcyB0aGUgY2FzZSB3aGVuIGEgdGVzdCBiaW5hcnkgZG9l c24ndAorICAgICAgICBleGlzdCBvciBpdCBjcmFzaGVzLgorCisgICAgICAgIEFsc28sIGluIHRo ZSBsYXR0ZXIgY2FzZSwgdGhlIHN0ZGVyciBvZiB0aGUgY3Jhc2hlZCBwcm9jZXNzZXMgd2FzIG5v dAorICAgICAgICBiZWluZyBvdXRwdXR0ZWQgdG8gdGhlIHVzZXIsIG1hc2tpbmcgYSBjcmFzaGlu ZyB0ZXN0IGJpbmFyeSBhcyBhCisgICAgICAgIHBhc3NpbmcgdGVzdC4KKworICAgICAgICBUaGlz IHBhdGNoIGZpeGVzIGJvdGggaXNzdWVzOiBJdCBhZGRzIHNldmVyYWwgd2FybmluZyBwcmludHMg d2hlbgorICAgICAgICBiaW5hcmllcyBjYW4ndCBiZSBydW4gb3IgZmFpbCB0byBhZGQgYW55IHN1 YnRlc3QsIGVtaXR0aW5nIHRoZSBzdGRlcnIKKyAgICAgICAgZ2VuZXJhdGVkIGJ5IHRoZSBmYWls aW5nIG9yIGNyYXNoaW5nIGJpbmFyeS4KKworICAgICAgICAqIGdsaWIvYXBpX3Rlc3RfcnVubmVy LnB5OgorICAgICAgICAoVGVzdFJ1bm5lci5fcnVuX3Rlc3QpOgorICAgICAgICAoVGVzdFJ1bm5l ci5ydW5fdGVzdHMpOgorICAgICAgICAqIGdsaWIvZ2xpYl90ZXN0X3J1bm5lci5weToKKyAgICAg ICAgKEdMaWJUZXN0UnVubmVyLnJ1bik6CisKIDIwMjEtMDEtMjIgIEFsaWNpYSBCb3lhIEdhcmPD rWEgIDxhYm95YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIHJ1bi1ndGstdGVzdHM6IFVz ZSBzeXMuZXhpdCgxKSBpbnN0ZWFkIG9mIHJldHVybiAxCmRpZmYgLS1naXQgYS9Ub29scy9nbGli L2FwaV90ZXN0X3J1bm5lci5weSBiL1Rvb2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5CmluZGV4 IDk0Y2JhNTdjMmEyZmNkYzcxODNiY2MxNjQ1YTgxZmE5ODIwMjgzZjIuLmM1ZWMxMmZhZGFjM2Y4 ZWJhMDE1YjRlOTQwMGMzM2Q4N2ZkNDM3NTMgMTAwNzU1Ci0tLSBhL1Rvb2xzL2dsaWIvYXBpX3Rl c3RfcnVubmVyLnB5CisrKyBiL1Rvb2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5CkBAIC0yNzcs NiArMjc3LDcgQEAgY2xhc3MgVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICBpZiBzZWxmLmlz X3F0X3Rlc3QodGVzdF9wcm9ncmFtKToKICAgICAgICAgICAgIHJldHVybiBzZWxmLl9ydW5fdGVz dF9xdCh0ZXN0X3Byb2dyYW0pCiAKKyAgICAgICAgc3lzLnN0ZGVyci53cml0ZSgiV0FSTklORzog JXMgZG9lc24ndCBzZWVtIHRvIGJlIGEgc3VwcG9ydGVkIHRlc3QgcHJvZ3JhbS5cbiIgJSB0ZXN0 X3Byb2dyYW0pCiAgICAgICAgIHJldHVybiB7fQogCiAgICAgZGVmIHJ1bl90ZXN0cyhzZWxmKToK QEAgLTMwMyw2ICszMDQsMTEgQEAgY2xhc3MgVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICAg ICAgICAgIHNraXBwZWRfc3VidGVzdHMgPSBzZWxmLl90ZXN0X2Nhc2VzX3RvX3NraXAodGVzdCkK ICAgICAgICAgICAgICAgICBudW1iZXJfb2ZfdG90YWxfdGVzdHMgKz0gbGVuKHNraXBwZWRfc3Vi dGVzdHMgaWYgbm90IHN1YnRlc3RzIGVsc2Ugc2V0KHNraXBwZWRfc3VidGVzdHMpLmludGVyc2Vj dGlvbihzdWJ0ZXN0cykpCiAgICAgICAgICAgICAgICAgcmVzdWx0cyA9IHNlbGYuX3J1bl90ZXN0 KHRlc3QsIHN1YnRlc3RzLCBza2lwcGVkX3N1YnRlc3RzKQorICAgICAgICAgICAgICAgIGlmIGxl bihyZXN1bHRzKSA9PSAwOgorICAgICAgICAgICAgICAgICAgICAjIE5vIHN1YnRlc3RzIHdoZXJl IGVtaXR0ZWQsIGVpdGhlciB0aGUgdGVzdCBiaW5hcnkgZGlkbid0IGV4aXN0LCBvciB3ZSBkb24n dCBrbm93IGhvdyB0byBydW4gaXQsIG9yIGl0IGNyYXNoZWQuCisgICAgICAgICAgICAgICAgICAg IHN5cy5zdGRlcnIud3JpdGUoIkVSUk9SOiAlcyBmYWlsZWQgdG8gcnVuLCBhcyBpdCBkaWRuJ3Qg ZW1pdCBhbnkgc3VidGVzdHMuXG4iICUgdGVzdCkKKyAgICAgICAgICAgICAgICAgICAgY3Jhc2hl ZF90ZXN0c1t0ZXN0XSA9IFsiKHByb2JsZW0gaW4gdGVzdCBleGVjdXRhYmxlKSJdCisgICAgICAg ICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAgICAgICAgICAgICAgbnVtYmVyX29mX2V4ZWN1dGVk X3N1YnRlc3RzX2Zvcl90ZXN0ID0gbGVuKHJlc3VsdHMpCiAgICAgICAgICAgICAgICAgaWYgbnVt YmVyX29mX2V4ZWN1dGVkX3N1YnRlc3RzX2Zvcl90ZXN0ID4gMToKICAgICAgICAgICAgICAgICAg ICAgbnVtYmVyX29mX2V4ZWN1dGVkX3Rlc3RzICs9IG51bWJlcl9vZl9leGVjdXRlZF9zdWJ0ZXN0 c19mb3JfdGVzdApkaWZmIC0tZ2l0IGEvVG9vbHMvZ2xpYi9nbGliX3Rlc3RfcnVubmVyLnB5IGIv VG9vbHMvZ2xpYi9nbGliX3Rlc3RfcnVubmVyLnB5CmluZGV4IGM4MjY4OTc2YzlkZDE3ZGI2MDEy Mjk4MGRiYTU5ZjA3MjBjZDNkMTcuLmI5M2JjOTdlMTU3YmFlNjkyMWRmMGZkYTEzMzEwOGUxMDRk MDUwZmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2dsaWIvZ2xpYl90ZXN0X3J1bm5lci5weQorKysgYi9U b29scy9nbGliL2dsaWJfdGVzdF9ydW5uZXIucHkKQEAgLTI2OCw2ICsyNjgsMTIgQEAgY2xhc3Mg R0xpYlRlc3RSdW5uZXIob2JqZWN0KToKICAgICAgICAgICAgIHNlbGYuX3N1YnRlc3RfZW5kKDI1 NikKICAgICAgICAgICAgIG5lZWRfcmVzdGFydCA9IFRydWUKIAorICAgICAgICBpZiBsZW4oc2Vs Zi5fcmVzdWx0cykgPT0gMDoKKyAgICAgICAgICAgICMgTm9ybWFsbHkgc3RkZXJyIGlzIGNoZWNr ZWQgYWZ0ZXIgYSBzdWJ0ZXN0IGhhcyBiZWVuIHBhcnNlZC4gSWYgbm8gc3VidGVzdHMgaGF2ZSBi ZWVuIHBhcnNlZAorICAgICAgICAgICAgIyBjaGFuY2VzIGFyZSBzb21ldGhpbmcgd2VudCB3cm9u ZyB3aXRoIHRoZSB0ZXN0IGV4ZWN1dGFibGUgaXRzZWxmIGFuZCB3ZSBzaG91bGQgcHJpbnQgc3Rk ZXJyCisgICAgICAgICAgICAjIHRvIHRoZSB1c2VyLgorICAgICAgICAgICAgc3lzLnN0ZGVyci53 cml0ZShzZWxmLl9yZWFkX2Zyb21fc3RkZXJyKHNlbGYuX3N0ZGVycl9mZCkpCisKICAgICAgICAg c2VsZi5fc3RkZXJyX2ZkID0gTm9uZQogCiAgICAgICAgIGlmIG5lZWRfcmVzdGFydDoK 418550 2021-01-27 08:46:57 -0800 2021-01-27 09:14:21 -0800 Patch bug-220863-20210127174655.patch text/plain 3587 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMzU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWY1NGJhZWQwODg0MjNmNjllODAxNmY3NmEyMzEyOTBm NjNjYmE4Mi4uZTBlM2E5MTQxMWI3YTFhYmE4YzM4ZDE0M2MyNGQwMjhlMDM0YjdlMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4 IEBACisyMDIxLTAxLTIyICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBydW4tZ3RrLXRlc3RzOiBDcmFzaGluZyBhbmQgbm9uLWV4aXN0ZW50 IHRlc3RzIHNob3VsZCBub3QgY291bnQgYXMgYSBwYXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA4NjMKKworICAgICAgICBSZXZpZXdlZCBieSBN aWNoYWVsIENhdGFuemFyby4KKworICAgICAgICBUaGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBk b2Vzbid0IGFjY291bnQgZm9yIHRlc3QgYmluYXJpZXMgdGhhdCBoYXZlCisgICAgICAgIG5vdCBl bWl0dGVkIGFueSBzdWJ0ZXN0cy4gVGhpcyBpcyB0aGUgY2FzZSB3aGVuIGEgdGVzdCBiaW5hcnkg ZG9lc24ndAorICAgICAgICBleGlzdCBvciBpdCBjcmFzaGVzLgorCisgICAgICAgIEFsc28sIGlu IHRoZSBsYXR0ZXIgY2FzZSwgdGhlIHN0ZGVyciBvZiB0aGUgY3Jhc2hlZCBwcm9jZXNzZXMgd2Fz IG5vdAorICAgICAgICBiZWluZyBvdXRwdXR0ZWQgdG8gdGhlIHVzZXIsIG1hc2tpbmcgYSBjcmFz aGluZyB0ZXN0IGJpbmFyeSBhcyBhCisgICAgICAgIHBhc3NpbmcgdGVzdC4KKworICAgICAgICBU aGlzIHBhdGNoIGZpeGVzIGJvdGggaXNzdWVzOiBJdCBhZGRzIHNldmVyYWwgd2FybmluZyBwcmlu dHMgd2hlbgorICAgICAgICBiaW5hcmllcyBjYW4ndCBiZSBydW4gb3IgZmFpbCB0byBhZGQgYW55 IHN1YnRlc3QsIGVtaXR0aW5nIHRoZSBzdGRlcnIKKyAgICAgICAgZ2VuZXJhdGVkIGJ5IHRoZSBm YWlsaW5nIG9yIGNyYXNoaW5nIGJpbmFyeS4KKworICAgICAgICAqIGdsaWIvYXBpX3Rlc3RfcnVu bmVyLnB5OgorICAgICAgICAoVGVzdFJ1bm5lci5fcnVuX3Rlc3QpOgorICAgICAgICAoVGVzdFJ1 bm5lci5ydW5fdGVzdHMpOgorICAgICAgICAqIGdsaWIvZ2xpYl90ZXN0X3J1bm5lci5weToKKyAg ICAgICAgKEdMaWJUZXN0UnVubmVyLnJ1bik6CisKIDIwMjEtMDEtMjIgIEFsaWNpYSBCb3lhIEdh cmPDrWEgIDxhYm95YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIHJ1bi1ndGstdGVzdHM6 IFVzZSBzeXMuZXhpdCgxKSBpbnN0ZWFkIG9mIHJldHVybiAxCmRpZmYgLS1naXQgYS9Ub29scy9n bGliL2FwaV90ZXN0X3J1bm5lci5weSBiL1Rvb2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5Cmlu ZGV4IDk0Y2JhNTdjMmEyZmNkYzcxODNiY2MxNjQ1YTgxZmE5ODIwMjgzZjIuLjQ5M2JlYWQ1MjYw NjQxNGQxZDdmMDE0NzNkMDFjZTEwZTQ1MDg5MTggMTAwNzU1Ci0tLSBhL1Rvb2xzL2dsaWIvYXBp X3Rlc3RfcnVubmVyLnB5CisrKyBiL1Rvb2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5CkBAIC0y NzcsNiArMjc3LDcgQEAgY2xhc3MgVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICBpZiBzZWxm LmlzX3F0X3Rlc3QodGVzdF9wcm9ncmFtKToKICAgICAgICAgICAgIHJldHVybiBzZWxmLl9ydW5f dGVzdF9xdCh0ZXN0X3Byb2dyYW0pCiAKKyAgICAgICAgc3lzLnN0ZGVyci53cml0ZSgiV0FSTklO RzogJXMgZG9lc24ndCBzZWVtIHRvIGJlIGEgc3VwcG9ydGVkIHRlc3QgcHJvZ3JhbS5cbiIgJSB0 ZXN0X3Byb2dyYW0pCiAgICAgICAgIHJldHVybiB7fQogCiAgICAgZGVmIHJ1bl90ZXN0cyhzZWxm KToKQEAgLTMwMyw2ICszMDQsMTEgQEAgY2xhc3MgVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAg ICAgICAgICAgIHNraXBwZWRfc3VidGVzdHMgPSBzZWxmLl90ZXN0X2Nhc2VzX3RvX3NraXAodGVz dCkKICAgICAgICAgICAgICAgICBudW1iZXJfb2ZfdG90YWxfdGVzdHMgKz0gbGVuKHNraXBwZWRf c3VidGVzdHMgaWYgbm90IHN1YnRlc3RzIGVsc2Ugc2V0KHNraXBwZWRfc3VidGVzdHMpLmludGVy c2VjdGlvbihzdWJ0ZXN0cykpCiAgICAgICAgICAgICAgICAgcmVzdWx0cyA9IHNlbGYuX3J1bl90 ZXN0KHRlc3QsIHN1YnRlc3RzLCBza2lwcGVkX3N1YnRlc3RzKQorICAgICAgICAgICAgICAgIGlm IGxlbihyZXN1bHRzKSA9PSAwOgorICAgICAgICAgICAgICAgICAgICAjIE5vIHN1YnRlc3RzIHdl cmUgZW1pdHRlZCwgZWl0aGVyIHRoZSB0ZXN0IGJpbmFyeSBkaWRuJ3QgZXhpc3QsIG9yIHdlIGRv bid0IGtub3cgaG93IHRvIHJ1biBpdCwgb3IgaXQgY3Jhc2hlZC4KKyAgICAgICAgICAgICAgICAg ICAgc3lzLnN0ZGVyci53cml0ZSgiRVJST1I6ICVzIGZhaWxlZCB0byBydW4sIGFzIGl0IGRpZG4n dCBlbWl0IGFueSBzdWJ0ZXN0cy5cbiIgJSB0ZXN0KQorICAgICAgICAgICAgICAgICAgICBjcmFz aGVkX3Rlc3RzW3Rlc3RdID0gWyIocHJvYmxlbSBpbiB0ZXN0IGV4ZWN1dGFibGUpIl0KKyAgICAg ICAgICAgICAgICAgICAgY29udGludWUKICAgICAgICAgICAgICAgICBudW1iZXJfb2ZfZXhlY3V0 ZWRfc3VidGVzdHNfZm9yX3Rlc3QgPSBsZW4ocmVzdWx0cykKICAgICAgICAgICAgICAgICBpZiBu dW1iZXJfb2ZfZXhlY3V0ZWRfc3VidGVzdHNfZm9yX3Rlc3QgPiAxOgogICAgICAgICAgICAgICAg ICAgICBudW1iZXJfb2ZfZXhlY3V0ZWRfdGVzdHMgKz0gbnVtYmVyX29mX2V4ZWN1dGVkX3N1YnRl c3RzX2Zvcl90ZXN0CmRpZmYgLS1naXQgYS9Ub29scy9nbGliL2dsaWJfdGVzdF9ydW5uZXIucHkg Yi9Ub29scy9nbGliL2dsaWJfdGVzdF9ydW5uZXIucHkKaW5kZXggYzgyNjg5NzZjOWRkMTdkYjYw MTIyOTgwZGJhNTlmMDcyMGNkM2QxNy4uYjkzYmM5N2UxNTdiYWU2OTIxZGYwZmRhMTMzMTA4ZTEw NGQwNTBmYSAxMDA2NDQKLS0tIGEvVG9vbHMvZ2xpYi9nbGliX3Rlc3RfcnVubmVyLnB5CisrKyBi L1Rvb2xzL2dsaWIvZ2xpYl90ZXN0X3J1bm5lci5weQpAQCAtMjY4LDYgKzI2OCwxMiBAQCBjbGFz cyBHTGliVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICAgICAgc2VsZi5fc3VidGVzdF9lbmQo MjU2KQogICAgICAgICAgICAgbmVlZF9yZXN0YXJ0ID0gVHJ1ZQogCisgICAgICAgIGlmIGxlbihz ZWxmLl9yZXN1bHRzKSA9PSAwOgorICAgICAgICAgICAgIyBOb3JtYWxseSBzdGRlcnIgaXMgY2hl Y2tlZCBhZnRlciBhIHN1YnRlc3QgaGFzIGJlZW4gcGFyc2VkLiBJZiBubyBzdWJ0ZXN0cyBoYXZl IGJlZW4gcGFyc2VkCisgICAgICAgICAgICAjIGNoYW5jZXMgYXJlIHNvbWV0aGluZyB3ZW50IHdy b25nIHdpdGggdGhlIHRlc3QgZXhlY3V0YWJsZSBpdHNlbGYgYW5kIHdlIHNob3VsZCBwcmludCBz dGRlcnIKKyAgICAgICAgICAgICMgdG8gdGhlIHVzZXIuCisgICAgICAgICAgICBzeXMuc3RkZXJy LndyaXRlKHNlbGYuX3JlYWRfZnJvbV9zdGRlcnIoc2VsZi5fc3RkZXJyX2ZkKSkKKwogICAgICAg ICBzZWxmLl9zdGRlcnJfZmQgPSBOb25lCiAKICAgICAgICAgaWYgbmVlZF9yZXN0YXJ0Ogo=